Skip to content

Commit

Permalink
ddtrace/tracer: rename version tag for more clarity
Browse files Browse the repository at this point in the history
  • Loading branch information
hannahkm committed Dec 12, 2024
1 parent 6f3cfa1 commit 530a452
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion ddtrace/tracer/tracer.go
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ func newTracer(opts ...StartOption) *tracer {
if v == "" {
v = "unknown"
}
t.statsd.Incr("datadog.tracer.instrumentations", []string{fmt.Sprintf("instrumentation:%s", name), fmt.Sprintf("version:%s", v)}, 1)
t.statsd.Incr("datadog.tracer.instrumentations", []string{fmt.Sprintf("instrumentation:%s", name), fmt.Sprintf("instrumentation_version:%s", v)}, 1)
}

t.wg.Add(1)
Expand Down
2 changes: 1 addition & 1 deletion ddtrace/tracer/tracer_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ func TestTracerStart(t *testing.T) {
calls := tg.IncrCalls()
for _, c := range calls {
if c.GetName() == "datadog.tracer.instrumentations" {
assert.EqualValues(c.GetTags(), []string{"instrumentation:chi", "version:unknown"})
assert.EqualValues(c.GetTags(), []string{"instrumentation:chi", "instrumentation_version:unknown"})
return
}
}
Expand Down

0 comments on commit 530a452

Please sign in to comment.