Don't add nil stacktraces to spans

DataDog · May 27, 2024 · 7c9f1fb · 7c9f1fb
1 parent 20078e1
commit 7c9f1fb
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/internal/appsec/emitter/httpsec/http.go b/internal/appsec/emitter/httpsec/http.go
@@ -78,15 +78,15 @@ func WrapHandler(handler http.Handler, span ddtrace.Span, pathParams map[string]
 
 		var bypassHandler http.Handler
 		var blocking bool
-		var stackTrace stacktrace.Event
+		var stackTrace *stacktrace.Event
 		args := MakeHandlerOperationArgs(r, clientIP, pathParams)
 		ctx, op := StartOperation(r.Context(), args, func(op *types.Operation) {
 			dyngo.OnData(op, func(a *sharedsec.HTTPAction) {
 				blocking = true
 				bypassHandler = a.Handler
 			})
 			dyngo.OnData(op, func(a *sharedsec.StackTraceAction) {
-				stackTrace = a.Event
+				stackTrace = &a.Event
 			})
 		})
 		r = r.WithContext(ctx)
@@ -104,7 +104,9 @@ func WrapHandler(handler http.Handler, span ddtrace.Span, pathParams map[string]
 			}
 
 			// Add stacktraces to the span, if any
-			stacktrace.AddToSpan(span, &stackTrace)
+			if stackTrace != nil {
+				stacktrace.AddToSpan(span, stackTrace)
+			}
 
 			if bypassHandler != nil {
 				bypassHandler.ServeHTTP(w, r)