-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2 experimentation] ddtrace/tracer: have tracer.Start return an error #2231
[V2 experimentation] ddtrace/tracer: have tracer.Start return an error #2231
Conversation
BenchmarksBenchmark execution time: 2023-10-27 13:35:44 Comparing candidate commit 7bfb9c2 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 0 unstable metrics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I would advise to check all the places with returned errors to make sure they look presentable, that is returning that error actually brings value to the customer, as opposed to confusing them
Moving all V2 prs to point against v2-dev |
Co-authored-by: Diana Shevchenko <[email protected]>
What does this PR do?
Added err type in
tacer.Start()
return valueProposal: #540
Motivation
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!