Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2 experimentation] ddtrace/tracer: have tracer.Start return an error #2231

Conversation

JianyiGao
Copy link
Contributor

What does this PR do?

Added err type in tacer.Start() return value
Proposal: #540

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@pr-commenter
Copy link

pr-commenter bot commented Sep 25, 2023

Benchmarks

Benchmark execution time: 2023-10-27 13:35:44

Comparing candidate commit 7bfb9c2 in PR branch jennie.gao/tracer-start-error with baseline commit e2429fc in branch jennie.gao/v2-experimentation-main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 0 unstable metrics.

@JianyiGao JianyiGao added the v2.0 label Sep 25, 2023
@JianyiGao JianyiGao changed the title ddtrace/tracer: have tracer.Start return an error [V2 experimentation] ddtrace/tracer: have tracer.Start return an error Sep 25, 2023
Copy link
Contributor

@dianashevchenko dianashevchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would advise to check all the places with returned errors to make sure they look presentable, that is returning that error actually brings value to the customer, as opposed to confusing them

ddtrace/tracer/tracer.go Outdated Show resolved Hide resolved
ddtrace/tracer/option.go Outdated Show resolved Hide resolved
@JianyiGao JianyiGao marked this pull request as ready for review October 27, 2023 14:05
@JianyiGao JianyiGao requested a review from a team October 27, 2023 14:05
@JianyiGao JianyiGao requested a review from a team as a code owner October 27, 2023 14:05
@JianyiGao
Copy link
Contributor Author

Moving all V2 prs to point against v2-dev

@JianyiGao JianyiGao closed this Oct 30, 2023
@JianyiGao JianyiGao closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants