general: replace gopkg.in/DataDog/dd-trace-go.v1 with github.com/DataDog/dd-trace-go/v2 #2300
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
darccio
force-pushed
the
dario.castane/AIT-3705/remove-gopkgin
branch
from
66e426e to
fe165bd
Compare
BenchmarksBenchmark execution time: 2023-10-30 12:09:35 Comparing candidate commit 30541af in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics. |
darccio
force-pushed
the
dario.castane/AIT-3705/remove-gopkgin
branch
from
2d0f8d4 to
6fe30bf
Compare
darccio
force-pushed
the
dario.castane/AIT-3705/remove-gopkgin
branch
from
91549ac to
37dad66
Compare
| @@ -151,6 +151,7 @@ jobs: | |||
| - run: docker run --platform=linux/arm64 -v $PWD:$PWD -w $PWD -eCGO_ENABLED=${{ matrix.cgo_enabled }} -eDD_APPSEC_ENABLED=${{ matrix.appsec_enabled }} -eDD_APPSEC_WAF_TIMEOUT=$DD_APPSEC_WAF_TIMEOUT golang go test -v -tags appsec $TO_TEST | |||
|
|
|||
| smoke-tests: | |||
| uses: DataDog/appsec-go-test-app/.github/workflows/smoke-tests.yml@main | |||
| # TODO(darccio): change to main branch on v2 release | |||
| uses: DataDog/appsec-go-test-app/.github/workflows/[email protected]/AIT-3705/dd-trace-go.v2 | |||
There was a problem hiding this comment.
This branch will be open until v2 release.
| @@ -93,7 +93,8 @@ jobs: | |||
| uses: actions/checkout@v3 | |||
| with: | |||
| repository: 'DataDog/system-tests' | |||
| ref: ${{ inputs.ref }} | |||
| # TODO(darccio): remove ref on v2 release | |||
| ref: 5af583da64c7458daf3fdf5e5538b90cdc4d9154 | |||
There was a problem hiding this comment.
This branch will be open until v2 release.
MIGRATING.md
Outdated
There was a problem hiding this comment.
This migration guide will be reviewed before the v2 release. It will be replaced with a new version for migrating from 1.x to 2.x.
README.md
Outdated
There was a problem hiding this comment.
More changes will be done in this README during the next weeks.
Is this (from the PR description) accurate? It seems like the import path is actually changed to: |
You are right, it was a typo in the PR's description. |
What does this PR do?
This PR changes the canonical import URL, setting it as
github.com/DataDog/dd-trace-go/v2.This is the first step towards the new v2 major version.
It's a big PR but it contains the result of search-and-replace operations for the old import URL. We considered to do smaller PRs for contribs, but it was simpler to do the changes at once, specially to test the CI too.
Tests are green ✅ , although it involved creating specific branches in system-tests and appsec-go-test-app. These branches will remain unmerged until the v2 release.
Documentation files (README.md, contrrib/README.md and MIGRATING.md) will be updated in following PRs.
Motivation
gopkg.inisn't needed anymore, and it's not well maintained.Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!