Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.sh: add support for running on Apple Silicon #2313

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

darccio
Copy link
Member

@darccio darccio commented Oct 30, 2023

What does this PR do?

Adds support for Apple Silicon by setting the appropriate environment variable to force Docker images' platform to be x86 64 (amd64).

Motivation

Easily run integration tests locally.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.

For Datadog employees:

  • If this PR touches code that handles credentials of any kind, such as Datadog API keys, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@darccio darccio requested a review from a team as a code owner October 30, 2023 14:44
@darccio darccio enabled auto-merge (squash) October 30, 2023 14:50
@darccio darccio merged commit 95faefd into main Oct 30, 2023
50 checks passed
@darccio darccio deleted the dario.castane/AIT-8784/fix-testsh-x86 branch October 30, 2023 14:50
@darccio
Copy link
Member Author

darccio commented Oct 30, 2023

Thanks @ahmed-mez! 🥷

@darccio darccio restored the dario.castane/AIT-8784/fix-testsh-x86 branch November 16, 2023 16:19
@darccio darccio deleted the dario.castane/AIT-8784/fix-testsh-x86 branch November 16, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants