Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appsec/grpc: fix rpc message blocking #2723

Merged
merged 6 commits into from
Jun 4, 2024

Conversation

Julio-Guerra
Copy link
Contributor

@Julio-Guerra Julio-Guerra commented Jun 3, 2024

What does this PR do?

  • Fix gRPC message blocking
  • Increase the test coverage of gRPC blocking so that this path is now properly tested. Only IP-, user- and metadata-blocking was tested.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

JIRA: APPSEC-53472

@Julio-Guerra Julio-Guerra requested a review from a team as a code owner June 3, 2024 07:47
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jun 3, 2024
@Julio-Guerra Julio-Guerra marked this pull request as draft June 3, 2024 07:47
@Julio-Guerra Julio-Guerra changed the title grpc/appsec: fix rpc message blocking appsec/grpc: fix rpc message blocking Jun 3, 2024
@Julio-Guerra Julio-Guerra added appsec and removed apm:ecosystem contrib/* related feature requests or bugs labels Jun 3, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jun 3, 2024

Benchmarks

Benchmark execution time: 2024-06-04 12:29:34

Comparing candidate commit fc5c6eb in PR branch julio.guerra/fix-grpc-blocking with baseline commit 6126fb6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 1 unstable metrics.

@Julio-Guerra Julio-Guerra marked this pull request as ready for review June 4, 2024 07:52
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jun 4, 2024
contrib/google.golang.org/grpc/appsec.go Outdated Show resolved Hide resolved
contrib/google.golang.org/grpc/appsec.go Outdated Show resolved Hide resolved
contrib/google.golang.org/grpc/appsec.go Outdated Show resolved Hide resolved
contrib/google.golang.org/grpc/appsec.go Outdated Show resolved Hide resolved
internal/appsec/listener/grpcsec/grpc.go Outdated Show resolved Hide resolved
internal/appsec/listener/grpcsec/grpc.go Outdated Show resolved Hide resolved
internal/appsec/listener/grpcsec/grpc.go Outdated Show resolved Hide resolved
@Julio-Guerra Julio-Guerra merged commit d8acf16 into main Jun 4, 2024
200 checks passed
@Julio-Guerra Julio-Guerra deleted the julio.guerra/fix-grpc-blocking branch June 4, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs appsec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants