tracer: allow x-datadog headers to pass as header tags#2744
Merged
Conversation
…, and condense related tests
BenchmarksBenchmark execution time: 2024-07-11 14:28:57 Comparing candidate commit 9c358af in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 1 unstable metrics. scenario:BenchmarkHttpServeTrace-24
|
rarguelloF
approved these changes
Jul 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows x-datadog headers to be set as tags on http integrations with the header_tags feature
Motivation
Previously, the Go tracer would drop any headers prefixed with "x-datadog". Now that header_tags need to be explicitly included, there is no reason to drop x-datadog headers if they've been specified.
Allowing these headers as tags also assists with troubleshooting trace context propagation issues, see: Document
Reviewer's Checklist
Unsure? Have a question? Request a review!