Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/appsec: refactor simple WAF run operations #2776

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

eliottness
Copy link
Contributor

What does this PR do?

This PR does a simple refactor of internal/appsec/listener packages. Including the following:

  • Make a new MakeWAFRunListener func that simplify adding new simple addresses to call the WAF
  • Stop trying to register Derivatives at each WAF run.
  • Register RASP SQLi in gRPC

Motivation

Doing less copy-pastes

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness eliottness force-pushed the eliott.bouhana/APPSEC-54003 branch 3 times, most recently from d70bb88 to 387bfc2 Compare July 8, 2024 15:44
@eliottness eliottness marked this pull request as ready for review July 8, 2024 15:44
@eliottness eliottness requested a review from a team as a code owner July 8, 2024 15:44
internal/appsec/listener/httpsec/http.go Show resolved Hide resolved
internal/appsec/listener/sqlsec/sql.go Outdated Show resolved Hide resolved
internal/appsec/listener/sharedsec/shared.go Outdated Show resolved Hide resolved
@eliottness eliottness requested a review from a team as a code owner July 10, 2024 09:06
@eliottness eliottness force-pushed the eliott.bouhana/APPSEC-54003 branch from 068d797 to 6e1344c Compare July 10, 2024 09:06
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness eliottness enabled auto-merge (squash) July 10, 2024 09:08
@eliottness eliottness merged commit 457de24 into main Jul 10, 2024
165 of 166 checks passed
@eliottness eliottness deleted the eliott.bouhana/APPSEC-54003 branch July 10, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants