Skip to content

[godfathering] contrib/dimfeld/httptreemux.v5: failing tests for path variable replacement#2938

Merged
darccio merged 2 commits intomainfrom
dario.castane/godfathering-pr-2881
Oct 22, 2024
Merged

[godfathering] contrib/dimfeld/httptreemux.v5: failing tests for path variable replacement#2938
darccio merged 2 commits intomainfrom
dario.castane/godfathering-pr-2881

Conversation

@darccio
Copy link
Copy Markdown
Member

@darccio darccio commented Oct 22, 2024

What does this PR do?

Replicates and closes #2881 #2812

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio darccio requested review from a team as code owners October 22, 2024 08:09
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 22, 2024
@darccio darccio merged commit e104e1e into main Oct 22, 2024
@darccio darccio deleted the dario.castane/godfathering-pr-2881 branch October 22, 2024 08:28
darccio added a commit that referenced this pull request Oct 23, 2024
… variable replacement (#2938)

Co-authored-by: Max Thomson <git@mnt.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants