Skip to content

[SVLS-5560] Inject DD trace context into AWS Step Functions input#2942

Merged
darccio merged 12 commits intomainfrom
dylan/sfn-trace-ctx
Oct 29, 2024
Merged

[SVLS-5560] Inject DD trace context into AWS Step Functions input#2942
darccio merged 12 commits intomainfrom
dylan/sfn-trace-ctx

Conversation

@DylanLovesCoffee
Copy link
Copy Markdown
Contributor

What does this PR do?

Adds an instrumentation for AWS SDK Step Functions. This enables tracing for when a Lambda function invokes a Step Function. Trace context is injected into the Step Function's StartExecution/StartSyncExecution.Input object.

The Logs to Traces Reducer will read the trace context from the Step Function logs and create a Step Function span.

Screenshot 2024-10-22 at 4 02 24 PM

Motivation

We want to increase support for step function tracing as a whole. This PR supports tracing a step function that has been called downstream of a Lambda function.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 22, 2024
@DylanLovesCoffee DylanLovesCoffee marked this pull request as ready for review October 22, 2024 20:40
@DylanLovesCoffee DylanLovesCoffee requested review from a team as code owners October 22, 2024 20:40
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Oct 22, 2024

Benchmarks

Benchmark execution time: 2024-10-22 21:24:22

Comparing candidate commit acab365 in PR branch dylan/sfn-trace-ctx with baseline commit 2edf445 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@darccio darccio merged commit 50d338a into main Oct 29, 2024
@darccio darccio deleted the dylan/sfn-trace-ctx branch October 29, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants