-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddtrace/tracer: report number of instrumentations used as health metric #3021
base: main
Are you sure you want to change the base?
Conversation
BenchmarksBenchmark execution time: 2024-12-17 21:50:35 Comparing candidate commit 0327e10 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 0 unstable metrics. scenario:BenchmarkSetTagStringer-24
|
Datadog ReportBranch report: ✅ 0 Failed, 5113 Passed, 70 Skipped, 2m 27s Total Time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 comments.
- I thought the tag name we agreed upon was
integration
, notinstrumentation
😆 . Whatever it is, it should be consistent between your PR and mine. That way, users can more effectively correlate their data. - I wonder if iterating over all integrations (
for name, conf := range c.integrations
) will introduce a performance cost that is.. not worth it. We can get this information from startup logs (Limitations: We need to solicit these logs from the customer and they can be disabled [rare]) and we can get this information from telemetry (Limitations: .... Metabase is not the easiest to use...). I'm not even sure that a "metric" is the right data type to support this information. Curious what other team members, e.g. @darccio or @rodfalcon think about this.
@mtoffl01 Ah, you're right. All these I-words look the same 😵 . Let me adapt that. Regarding your second point, I was hoping that, by putting the for loop into
Yeah... is this even a health metric? 🤔 |
What does this PR do?
Creates and reports a new health metric,
datadog.tracer.instrumentations
, that counts the number of contribs the user is implementing.The metric will contain the tags
instrumentation
andversion
. Theinstrumentation
tag contains the name of the contrib that the user has implemented, for examplechi
orhttp
. Theversion
tag will contain the version of the contrib package that the user has imported into their code.Motivation
This information is currently in the startup logs, but we want to also give this to our support teams without the extra step of requesting this info from the customer.
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!