-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename reportHealthMetrics function #3040
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 5117 Passed, 70 Skipped, 2m 54.54s Total Time |
BenchmarksBenchmark execution time: 2024-12-23 16:29:52 Comparing candidate commit c7a40e5 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics. |
ddtrace/tracer/metrics.go
Outdated
@@ -85,7 +85,9 @@ func (t *tracer) reportRuntimeMetrics(interval time.Duration) { | |||
} | |||
} | |||
|
|||
func (t *tracer) reportHealthMetrics(interval time.Duration) { | |||
// reportHealthMetricsAtInterval reports health metrics at the specified interval to reduce noise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smallest nit in the world: since we are clarifying that not all health metrics are contained in this function, should we also be clear about that in this comment? Something along the lines of:
// reportHealthMetricsAtInterval reports health metrics at the specified interval to reduce noise. | |
// reportHealthMetricsAtInterval reports certain/noisy health metrics at the specified interval to reduce noise. |
I'm not sure what word will best describe these metrics, but dealer's choice 👍🏼
What does this PR do?
Renames the reportHealthMetrics function to reportHealthMetricsAtInterval
Motivation
Health metrics are reported across the repo; the name reportHealthMetrics can be confusing and incorrectly imply that the only health metrics we report are done inside of this function.
Reviewer's Checklist
v2-dev
branch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!