Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contrib/IBM/sarama.v1: support for consumer groups #3041

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rarguelloF
Copy link
Contributor

@rarguelloF rarguelloF commented Dec 17, 2024

What does this PR do?

Adds support for instrumenting consumer groups for IBM/sarama through wrapping sarama.ConsumerGroupHandler.

Closes #2133, closes #552, closes #1928

Motivation

Support tracing consumer groups.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Dec 17, 2024
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Dec 17, 2024

Datadog Report

Branch report: rarguelloF/AIDM-461/support-sarama-consumer-group
Commit report: cd684ee
Test service: dd-trace-go

✅ 0 Failed, 5113 Passed, 70 Skipped, 2m 32.51s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Dec 17, 2024

Benchmarks

Benchmark execution time: 2024-12-19 12:58:24

Comparing candidate commit c2088e0 in PR branch rarguelloF/AIDM-461/support-sarama-consumer-group with baseline commit d15e61a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

@rarguelloF rarguelloF marked this pull request as ready for review December 19, 2024 10:43
@rarguelloF rarguelloF requested review from a team as code owners December 19, 2024 10:43
Copy link
Member

@darccio darccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rarguelloF Remember to port this to v2-dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
2 participants