SpanBuilder.withTag(name, "") should behave like span.setTag(name, ""…

…) and map empty strings to null, ie. remove the tag (#5155)
DataDog · May 5, 2023 · 7b56c83 · 7b56c83
1 parent 858f631
commit 7b56c83
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java b/dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java
@@ -1272,7 +1272,7 @@ public CoreSpanBuilder withTag(final String tag, final Number number) {
 
     @Override
     public CoreSpanBuilder withTag(final String tag, final String string) {
-      return withTag(tag, (Object) string);
+      return withTag(tag, (Object) (string == null || string.isEmpty() ? null : string));
     }
 
     @Override