Skip to content

Commit

Permalink
Fix service version sanitize tags (#7293)
Browse files Browse the repository at this point in the history
* Sanitize service env and version in SymbolSink

We're matching RC tags with these tags, so they have to be sanitized the
same way.

https://github.com/DataDog/dd-trace-java/blob/65d7de13ac6a58d949af75fef4e9531bcaed5aab/remote-config/src/main/java/datadog/remoteconfig/PollerRequestFactory.java#L54-L57

* Remove duplicate tests
  • Loading branch information
ojung committed Jul 9, 2024
1 parent 3de43de commit 8629967
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ public SymbolSink(Config config) {

SymbolSink(Config config, BatchUploader symbolUploader) {
this.serviceName = TagsHelper.sanitize(config.getServiceName());
this.env = config.getEnv();
this.version = config.getVersion();
this.env = TagsHelper.sanitize(config.getEnv());
this.version = TagsHelper.sanitize(config.getVersion());
this.symbolUploader = symbolUploader;
byte[] eventContent =
String.format(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,9 @@ public void testIncludeSomeExcludeSome() {
strings = {
"java.FooBar",
"org.junit.Test",
"org.junit.jupiter.api.Test",
"akka.Actor",
"cats.Functor",
"org.junit.jupiter.api.Test",
"org.junit.jupiter.api.Test",
"org.datadog.jmxfetch.FooBar"
})
public void testExcludeDefaults(String input) {
Expand Down

0 comments on commit 8629967

Please sign in to comment.