fix(core): Fix terminated context addition in span builder

DataDog · Nov 6, 2023 · a015c11 · a015c11
1 parent 62d051c
commit a015c11
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java b/dd-trace-core/src/main/java/datadog/trace/core/CoreTracer.java
@@ -1191,13 +1191,7 @@ public CoreSpanBuilder ignoreActiveSpan() {
     }
 
     private DDSpan buildSpan() {
-      if (parent instanceof TagContext) {
-        List<AgentSpanLink> terminatedContextLinks =
-            ((TagContext) parent).getTerminatedContextLinks();
-        if (!terminatedContextLinks.isEmpty()) {
-          links.addAll(terminatedContextLinks);
-        }
-      }
+      addTerminatedContextAsLinks();
       DDSpan span = DDSpan.create(instrumentationName, timestampMicro, buildSpanContext(), links);
       if (span.isLocalRootSpan()) {
         EndpointTracker tracker = tracer.onRootSpanStarted(span);
@@ -1206,6 +1200,19 @@ private DDSpan buildSpan() {
       return span;
     }
 
+    private void addTerminatedContextAsLinks() {
+      if (this.parent instanceof TagContext) {
+        List<AgentSpanLink> terminatedContextLinks =
+            ((TagContext) this.parent).getTerminatedContextLinks();
+        if (!terminatedContextLinks.isEmpty()) {
+          if (this.links == null) {
+            this.links = new ArrayList<>();
+          }
+          this.links.addAll(terminatedContextLinks);
+        }
+      }
+    }
+
     @Override
     public AgentSpan start() {
       return buildSpan();