Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin coroutines instrumentation #4405

Merged
merged 38 commits into from
Jan 27, 2023
Merged

Kotlin coroutines instrumentation #4405

merged 38 commits into from
Jan 27, 2023

Commits on Dec 8, 2022

  1. Configure kotlin-coroutines module to be compilable 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    45d2c12 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. Add a test case for kotlin coroutines tracing with suspension 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    df6d722 View commit details
    Browse the repository at this point in the history

  2. Add a naive Kotlin coroutines instrumentation 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    c7b4468 View commit details
    Browse the repository at this point in the history

  3. Rewrite using ManagedScope abstraction for scope stack management 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    a3512c8 View commit details
    Browse the repository at this point in the history

  4. Configure muzzle 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    9553d24 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into feature/kotlin-coro… 

    …utines-instrumentation
    @monosoul
    monosoul committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    b001da9 View commit details
    Browse the repository at this point in the history

  6. Fix a typo 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    d0cbeac View commit details
    Browse the repository at this point in the history

  7. ManagedScope -> ScopeState; delegateManagedScope -> newScopeState 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    079ab2c View commit details
    Browse the repository at this point in the history

  8. Improve createKotlinDirs task declaration to make sure it always works 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    e719abc View commit details
    Browse the repository at this point in the history

  9. Add unit tests for ContinuableScopeState 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    66072b6 View commit details
    Browse the repository at this point in the history

  10. Exclude CustomScopeState 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    1a342eb View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. Merge remote-tracking branch 'origin/master' into feature/kotlin-coro… 

    …utines-instrumentation
    @monosoul
    monosoul committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    6aca8d1 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Merge remote-tracking branch 'origin/master' into feature/kotlin-coro… 

    …utines-instrumentation
    @monosoul
    monosoul committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    ec1ff19 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into feature/kotlin-coro… 

    …utines-instrumentation

Signed-off-by: monosoul <[email protected]>

# Conflicts:
#	dd-trace-core/src/main/java/datadog/trace/core/scopemanager/ContinuableScopeManager.java
    @monosoul
    monosoul committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    3a9b4f1 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2022

  1. Add a test case for lazily started coroutines 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    d5438db View commit details
    Browse the repository at this point in the history

  2. Add a test case for starting coroutines without a parent trace 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    497bdca View commit details
    Browse the repository at this point in the history

  3. Adjust the implementation to make the tests pass 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    708c0be View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Refactor CoroutineContextHelper a bit and add a comment 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    f285a1e View commit details
    Browse the repository at this point in the history

  2. Remove unused method 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    be78939 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Fix Gradle task failures caused by kotlin coroutines module 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    d36e597 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into feature/kotlin-coro… 

    …utines-instrumentation
    @monosoul
    monosoul committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    1358d10 View commit details
    Browse the repository at this point in the history

  3. Disable strict trace writes for the coroutines test 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    296d400 View commit details
    Browse the repository at this point in the history

  4. Fix wrong dispatcher used in parameterized tests 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    92cc4e6 View commit details
    Browse the repository at this point in the history

  5. Refactor KotlinCoroutineTests 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    1284f08 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. Merge remote-tracking branch 'upstream/master' into feature/kotlin-co… 

    …routines-instrumentation
    @monosoul
    monosoul committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    bca00e1 View commit details
    Browse the repository at this point in the history

  2. Introduce ContinuationHandler to better manage continuations 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    7073b6e View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into feature/kotlin-co… 

    …routines-instrumentation
    @monosoul
    monosoul committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    a3e901b View commit details
    Browse the repository at this point in the history

  4. Add final modifiers where it makes sense 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    f193145 View commit details
    Browse the repository at this point in the history

  5. Remove redundant annotation 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    8f00d51 View commit details
    Browse the repository at this point in the history

  6. Add coroutine names for easier troubleshooting 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    a2ead1c View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. Ensure invokeOnCompletion is invoked with the right scope stack 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    9eaf18c View commit details
    Browse the repository at this point in the history

  2. scopeState -> coroutineScopeState 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    7c19f01 View commit details
    Browse the repository at this point in the history

  3. currentThreadState -> currentThreadScopeState 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    971839d View commit details
    Browse the repository at this point in the history

  4. fix formatting 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    01cff05 View commit details
    Browse the repository at this point in the history

  5. Extract ContinuationHandler into its own file 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    f5ba3d0 View commit details
    Browse the repository at this point in the history

  6. Extract closeScopeAndCancelContinuation method 

    Signed-off-by: monosoul <[email protected]>
    @monosoul
    monosoul committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    fcb59ae View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Handle lazily/eagerly started coroutines differently (#3)

    @monosoul
    monosoul committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    2f062e6 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into feature/kotlin-coro… 

    …utines-instrumentation
    @monosoul
    monosoul committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    3923d69 View commit details
    Browse the repository at this point in the history