Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automatic demo application deploy on release #5134

Merged
merged 1 commit into from
May 2, 2023

Conversation

shurivich
Copy link
Contributor

@shurivich shurivich commented May 1, 2023

What Does This Do

Currently, the demo applications deployment to the backend is not triggered when a new version is released.
This is because the deployment is only triggered for the default branch, and the new version is committed to the release branch.
The current PR fix this issue by adding a trigger from the release branch to ensure that the deployment is also triggered when a new version is released.

@shurivich shurivich self-assigned this May 1, 2023
@pr-commenter
Copy link

pr-commenter bot commented May 1, 2023

Benchmarks

Parameters

Baseline Candidate
commit 1.13.0-SNAPSHOT~c5389db4ee 1.13.0-SNAPSHOT~21aff0b8b9
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start same
scenario:Startup-base-BytebuddyAgent same
scenario:Startup-base-GlobalTracer same
scenario:Startup-base-AppSec same
scenario:Startup-base-Remote Config same
scenario:Startup-base-Telemetry same
scenario:Startup-iast-Agent same
scenario:Startup-iast-Agent.start same
scenario:Startup-iast-BytebuddyAgent same
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST same
scenario:Startup-iast-Remote Config same
scenario:Startup-iast-Telemetry same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start same
scenario:Startup-waf-BytebuddyAgent same
scenario:Startup-waf-GlobalTracer same
scenario:Startup-waf-AppSec same
scenario:Startup-waf-Remote Config same
scenario:Startup-waf-Telemetry same

@shurivich shurivich changed the title Fix deploy on release Fix automatic demo application deploy on release May 1, 2023
@shurivich shurivich marked this pull request as ready for review May 1, 2023 11:24
@shurivich shurivich requested a review from a team as a code owner May 1, 2023 11:24
Copy link
Contributor

@ojung ojung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@shurivich shurivich merged commit 89c2bd4 into master May 2, 2023
@shurivich shurivich deleted the shurivich/deploy_on_release branch May 2, 2023 11:25
@github-actions github-actions bot added this to the 1.13.0 milestone May 2, 2023
@richardstartin richardstartin added the tag: no release notes Changes to exclude from release notes label May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: no release notes Changes to exclude from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants