Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hashcode and equals for Span Decoration Probes #5136

Merged
merged 1 commit into from
May 2, 2023
Merged

Fix hashcode and equals for Span Decoration Probes #5136

merged 1 commit into from
May 2, 2023

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented May 2, 2023

Add toString for Span decoration probe objects to pretty print in debug logs

What Does This Do

Motivation

Additional Notes

@jpbempel
Fix hashcode and equals for Span Decoration Probes
e70fcc1 
Add toString for Span decoration probe objects to pretty print in
debug logs
@jpbempel jpbempel added tag: no release notes Changes to exclude from release notes comp: debugger Dynamic Instrumentation labels May 2, 2023
@jpbempel jpbempel requested a review from a team as a code owner May 2, 2023 09:36
@jpbempel jpbempel requested review from ojung and removed request for a team May 2, 2023 09:36
@pr-commenter
Copy link

pr-commenter bot commented May 2, 2023

Benchmarks

Parameters

Baseline Candidate
commit 1.13.0-SNAPSHOT~6dd932c714 1.13.0-SNAPSHOT~e70fcc13e1
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start same
scenario:Startup-base-BytebuddyAgent same
scenario:Startup-base-GlobalTracer same
scenario:Startup-base-AppSec same
scenario:Startup-base-Remote Config same
scenario:Startup-base-Telemetry same
scenario:Startup-iast-Agent same
scenario:Startup-iast-Agent.start same
scenario:Startup-iast-BytebuddyAgent same
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST same
scenario:Startup-iast-Remote Config same
scenario:Startup-iast-Telemetry same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start same
scenario:Startup-waf-BytebuddyAgent same
scenario:Startup-waf-GlobalTracer same
scenario:Startup-waf-AppSec same
scenario:Startup-waf-Remote Config same
scenario:Startup-waf-Telemetry same

ojung
ojung approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@ojung ojung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jpbempel jpbempel merged commit 0c04e9f into master May 2, 2023
@jpbempel jpbempel deleted the jpbempel/fix-span-decoration-hash-eq branch May 2, 2023 11:51
@github-actions github-actions bot added this to the 1.13.0 milestone May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojung ojung ojung approved these changes

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpbempel @ojung