Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use strictly for testng dependency #5144

Merged
merged 1 commit into from
May 3, 2023

Conversation

bantonsson
Copy link
Contributor

What Does This Do

Changes back a strictly directive to a force clause

Motivation

When running dependencies on the testng project gradle reports a FAILURE and IntelliJ IDEA will report an ERROR when importing the project.

Additional Notes

@bantonsson bantonsson added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels May 3, 2023
@bantonsson bantonsson requested a review from a team as a code owner May 3, 2023 11:25
@bantonsson bantonsson self-assigned this May 3, 2023
@pr-commenter
Copy link

pr-commenter bot commented May 3, 2023

Benchmarks

Parameters

Baseline Candidate
commit 1.14.0-SNAPSHOT~5e079a8865 1.14.0-SNAPSHOT~c4528f0de0
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start same
scenario:Startup-base-BytebuddyAgent unsure
[-4.241ms; -0.126ms] or [-0.720%; -0.021%]
scenario:Startup-base-GlobalTracer same
scenario:Startup-base-AppSec same
scenario:Startup-base-Remote Config same
scenario:Startup-base-Telemetry same
scenario:Startup-iast-Agent same
scenario:Startup-iast-Agent.start same
scenario:Startup-iast-BytebuddyAgent same
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST unsure
[+0.009ms; +0.488ms] or [+0.077%; +4.347%]
scenario:Startup-iast-Remote Config same
scenario:Startup-iast-Telemetry same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start same
scenario:Startup-waf-BytebuddyAgent same
scenario:Startup-waf-GlobalTracer same
scenario:Startup-waf-AppSec same
scenario:Startup-waf-Remote Config same
scenario:Startup-waf-Telemetry same

@bantonsson bantonsson merged commit c118f59 into master May 3, 2023
@bantonsson bantonsson deleted the ban/dont-use-strictly-for-testng branch May 3, 2023 12:32
@github-actions github-actions bot added this to the 1.14.0 milestone May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants