Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic configuration of tagged headers #5154

Merged
merged 1 commit into from
May 9, 2023

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented May 4, 2023

No description provided.

@mcculls mcculls added the comp: core Tracer core label May 4, 2023
@pr-commenter
Copy link

pr-commenter bot commented May 4, 2023

Benchmarks

Parameters

Baseline Candidate
commit 1.14.0-SNAPSHOT~e41c7fc3bb 1.14.0-SNAPSHOT~460ac37355
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 21 cases.

scenario Δ mean execution_time
scenario:Startup-iast-Remote Config worse
[+9.246µs; +36.030µs] or [+1.536%; +5.988%]
See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start unsure
[+0.536ms; +7.394ms] or [+0.056%; +0.779%]
scenario:Startup-base-BytebuddyAgent same
scenario:Startup-base-GlobalTracer unsure
[+0.512ms; +2.551ms] or [+0.232%; +1.156%]
scenario:Startup-base-AppSec same
scenario:Startup-base-Remote Config same
scenario:Startup-base-Telemetry same
scenario:Startup-iast-Agent same
scenario:Startup-iast-Agent.start same
scenario:Startup-iast-BytebuddyAgent same
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST same
scenario:Startup-iast-Telemetry same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start same
scenario:Startup-waf-BytebuddyAgent same
scenario:Startup-waf-GlobalTracer same
scenario:Startup-waf-AppSec same
scenario:Startup-waf-Remote Config same
scenario:Startup-waf-Telemetry same

@mcculls mcculls marked this pull request as ready for review May 4, 2023 13:29
@mcculls mcculls requested a review from a team as a code owner May 4, 2023 13:29
Copy link
Contributor

@bantonsson bantonsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice cleanup, but I'm missing dynamic updates of the reverse baggage mapping in the injectors.

@mcculls
Copy link
Contributor Author

mcculls commented May 9, 2023

Hi @bantonsson - I left out the inject side in this PR because it's not actually required for the first release of dynamic config. Baggage mapping isn't one of the items which will be exposed as editable, but it was easier to include it in TraceConfig than have the extractor code contain both old and new concepts. In other words we're not currently expecting baggage mapping to change over the life of the tracer, even though this PR unlocks that ability for the extract side.

I'll create a separate PR for the inject side for consistency, but I'd prefer not to have that block this PR.

@mcculls mcculls changed the title Support dynamic configuration of tagged headers and baggage mapping Support dynamic configuration of tagged headers May 9, 2023
@mcculls mcculls merged commit 2f9bea6 into master May 9, 2023
@mcculls mcculls deleted the mcculls/dynamic-header-tagging branch May 9, 2023 13:11
@github-actions github-actions bot added this to the 1.14.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: core Tracer core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants