Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test targets in jetty other than 'test' #5158

Merged
merged 1 commit into from
May 8, 2023

Conversation

cataphract
Copy link
Contributor

@cataphract cataphract commented May 5, 2023

Two problems:

  • The addTestSuiteForDir calls were for adding only targets that don't run the *ForkedTests.
  • When adding ForkedTest targets, the gradle "configurations"' name are based upon the sourceSet name. DefaultJvmTestSuite uses as the sourceSet name the name of the task. Consequently, if we add a target called latestDepForkedTest, the created configurations are named latestDepForkedTestImplementation and so on, whereas the current dependencies {} blocks are only adding dependencies on latestDepTestImplementation. Fix this by making the ForkedTest configurations extend from the non-Forked ones (e.g. latestDepForkedTestImplementation extends from latestDepTestImplementation; latestDepTestImplementation is created if it doesn't exist).

@cataphract cataphract requested a review from a team as a code owner May 5, 2023 10:25
@cataphract cataphract requested a review from bantonsson May 5, 2023 10:25
@pr-commenter
Copy link

pr-commenter bot commented May 5, 2023

Benchmarks

Parameters

Baseline Candidate
commit 1.14.0-SNAPSHOT~41ae2f7dec 1.14.0-SNAPSHOT~d9d8c0bce0
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start same
scenario:Startup-base-BytebuddyAgent same
scenario:Startup-base-GlobalTracer same
scenario:Startup-base-AppSec same
scenario:Startup-base-Remote Config same
scenario:Startup-base-Telemetry same
scenario:Startup-iast-Agent same
scenario:Startup-iast-Agent.start same
scenario:Startup-iast-BytebuddyAgent same
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST same
scenario:Startup-iast-Remote Config same
scenario:Startup-iast-Telemetry same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start same
scenario:Startup-waf-BytebuddyAgent same
scenario:Startup-waf-GlobalTracer same
scenario:Startup-waf-AppSec same
scenario:Startup-waf-Remote Config same
scenario:Startup-waf-Telemetry same

@cataphract cataphract merged commit bc3fe15 into master May 8, 2023
@cataphract cataphract deleted the glopes/test-suites-configs branch May 8, 2023 11:10
@github-actions github-actions bot added this to the 1.14.0 milestone May 8, 2023
@smola smola added comp: testing Testing tag: no release notes Changes to exclude from release notes labels May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: testing Testing tag: no release notes Changes to exclude from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants