Catch exceptions throws from instrumented code #5159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. See unchanged results
|
ojung
reviewed
May 5, 2023
| } | ||
| forwarder.count(name, delta, tags); | ||
| } catch (Exception ex) { | ||
| LOGGER.debug("Error in count method: ", ex); |
There was a problem hiding this comment.
Can we use a rate limited logger here?
There was a problem hiding this comment.
hmm not easy as we are in bootstrap module, let me see if I can pull something
There was a problem hiding this comment.
Just thinking about this because a user could put a probe in a very hot code path, which is totally valid with metrics. If we log on every invocation it might be very spammy.
There was a problem hiding this comment.
yeah but we are in debug here, and rate limited logger already makes the difference on DEBUG or not for rate limiting.
smola
approved these changes
May 8, 2023
smola
approved these changes
May 8, 2023
smola
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Avoid modifying behavior of user code when instrumenting code
Additional Notes