Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove propagation from IAST metrics #5161

Merged
merged 1 commit into from
May 9, 2023
Merged

Remove propagation from IAST metrics #5161

merged 1 commit into from
May 9, 2023

Conversation

manuel-alvarez-alvarez
Copy link
Contributor

What Does This Do

Remove propagation_type from IAST metrics as it provides no value right now and it's not supported

Motivation

Additional Notes

@manuel-alvarez-alvarez manuel-alvarez-alvarez added comp: asm iast Application Security Management (IAST) tag: no release notes Changes to exclude from release notes labels May 8, 2023
@manuel-alvarez-alvarez manuel-alvarez-alvarez marked this pull request as ready for review May 8, 2023 17:23
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team May 8, 2023 17:23
@manuel-alvarez-alvarez manuel-alvarez-alvarez requested a review from a team as a code owner May 8, 2023 17:23
@pr-commenter
Copy link

pr-commenter bot commented May 8, 2023

Benchmarks

Parameters

Baseline Candidate
commit 1.14.0-SNAPSHOT~663150c3e9 1.14.0-SNAPSHOT~ef34eddff9
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start same
scenario:Startup-base-BytebuddyAgent same
scenario:Startup-base-GlobalTracer same
scenario:Startup-base-AppSec same
scenario:Startup-base-Remote Config same
scenario:Startup-base-Telemetry same
scenario:Startup-iast-Agent same
scenario:Startup-iast-Agent.start same
scenario:Startup-iast-BytebuddyAgent same
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST unsure
[+0.015ms; +0.175ms] or [+0.136%; +1.560%]
scenario:Startup-iast-Remote Config same
scenario:Startup-iast-Telemetry same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start same
scenario:Startup-waf-BytebuddyAgent same
scenario:Startup-waf-GlobalTracer same
scenario:Startup-waf-AppSec same
scenario:Startup-waf-Remote Config same
scenario:Startup-waf-Telemetry same

@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 79ef64c into master May 9, 2023
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/iast-remove-propagation-type branch May 9, 2023 09:04
@github-actions github-actions bot added this to the 1.14.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST) tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manuel-alvarez-alvarez @smola