Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SpringBootOpenLibertySnapshotTest #5270

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

smola
Copy link
Member

@smola smola commented May 26, 2023

What Does This Do

Motivation

We moved to trace protocol v0.5, but the mock agent used for this suite does not support it.

Additional Notes

See #5174

We moved to trace protocol v0.5, but the mock agent used for this suite
does not support it.
@smola smola added comp: testing Testing tag: no release notes Changes to exclude from release notes labels May 26, 2023
@smola smola requested a review from a team as a code owner May 26, 2023 06:19
@pr-commenter
Copy link

pr-commenter bot commented May 26, 2023

Benchmarks

Parameters

Baseline Candidate
commit 1.15.0-SNAPSHOT~0b64a64a02 1.15.0-SNAPSHOT~36ba4ada2e
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start same
scenario:Startup-base-BytebuddyAgent same
scenario:Startup-base-GlobalTracer same
scenario:Startup-base-AppSec same
scenario:Startup-base-Remote Config same
scenario:Startup-base-Telemetry same
scenario:Startup-iast-Agent same
scenario:Startup-iast-Agent.start same
scenario:Startup-iast-BytebuddyAgent same
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST unsure
[+0.012ms; +0.146ms] or [+0.102%; +1.212%]
scenario:Startup-iast-Remote Config unsure
[+0.177µs; +17.646µs] or [+0.028%; +2.831%]
scenario:Startup-iast-Telemetry same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start unsure
[-0.007s; -0.001s] or [-0.662%; -0.061%]
scenario:Startup-waf-BytebuddyAgent unsure
[-3.913ms; -0.169ms] or [-0.657%; -0.028%]
scenario:Startup-waf-GlobalTracer same
scenario:Startup-waf-AppSec unsure
[-1.628ms; -0.066ms] or [-0.889%; -0.036%]
scenario:Startup-waf-Remote Config same
scenario:Startup-waf-Telemetry same

@smola smola merged commit ebdc616 into master May 26, 2023
@smola smola deleted the smola/fix-openliberty-test branch May 26, 2023 07:18
@github-actions github-actions bot added this to the 1.15.0 milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: testing Testing tag: no release notes Changes to exclude from release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants