Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid opening jar files before checking in pom is available #5271

Merged
merged 1 commit into from
May 26, 2023

Conversation

anderruiz
Copy link
Contributor

What Does This Do

Before the PR all jar files were opened to calculate the jar file SHA1 signature, even before checking if maven information was available (and in that case the signature was avoided)

@anderruiz anderruiz requested a review from a team as a code owner May 26, 2023 09:58
@pr-commenter
Copy link

pr-commenter bot commented May 26, 2023

Benchmarks

Parameters

Baseline Candidate
commit 1.15.0-SNAPSHOT~ebdc616cd3 1.15.0-SNAPSHOT~ed36dcf5ca
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 21 cases.

scenario Δ mean execution_time
scenario:Startup-waf-Remote Config worse
[+7.394µs; +231.674µs] or [+1.042%; +32.633%]
See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start same
scenario:Startup-base-BytebuddyAgent same
scenario:Startup-base-GlobalTracer same
scenario:Startup-base-AppSec same
scenario:Startup-base-Remote Config same
scenario:Startup-base-Telemetry same
scenario:Startup-iast-Agent same
scenario:Startup-iast-Agent.start same
scenario:Startup-iast-BytebuddyAgent same
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST same
scenario:Startup-iast-Remote Config same
scenario:Startup-iast-Telemetry same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start same
scenario:Startup-waf-BytebuddyAgent same
scenario:Startup-waf-GlobalTracer same
scenario:Startup-waf-AppSec same
scenario:Startup-waf-Telemetry unsure
[-0.395ms; -0.051ms] or [-6.639%; -0.854%]

@smola smola requested a review from a team May 26, 2023 12:25
@smola smola added the comp: telemetry Telemetry label May 26, 2023
@smola smola merged commit 33c9f18 into master May 26, 2023
@smola smola deleted the ander.ruiz/avoid_opening_all_jars branch May 26, 2023 13:06
@github-actions github-actions bot added this to the 1.15.0 milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants