Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add peer service for eligible aws sdk services #5283

Merged
merged 1 commit into from
May 30, 2023
Merged

add peer service for eligible aws sdk services #5283

merged 1 commit into from
May 30, 2023

Conversation

amarziali
Copy link
Collaborator

What Does This Do

Adds peer.service for aws sdk managed services

Motivation

Additional Notes

@pr-commenter
Copy link

pr-commenter bot commented May 30, 2023

Benchmarks

Parameters

Baseline Candidate
commit 1.15.0-SNAPSHOT~d8f3e0223c 1.15.0-SNAPSHOT~92e28d9f22
config baseline candidate
See matching parameters
Baseline Candidate
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

See unchanged results
scenario Δ mean execution_time
scenario:Startup-base-Agent same
scenario:Startup-base-Agent.start same
scenario:Startup-base-BytebuddyAgent same
scenario:Startup-base-GlobalTracer same
scenario:Startup-base-AppSec same
scenario:Startup-base-Remote Config same
scenario:Startup-base-Telemetry same
scenario:Startup-iast-Agent same
scenario:Startup-iast-Agent.start same
scenario:Startup-iast-BytebuddyAgent same
scenario:Startup-iast-GlobalTracer same
scenario:Startup-iast-AppSec same
scenario:Startup-iast-IAST same
scenario:Startup-iast-Remote Config same
scenario:Startup-iast-Telemetry same
scenario:Startup-waf-Agent same
scenario:Startup-waf-Agent.start unsure
[+0.001s; +0.006s] or [+0.108%; +0.576%]
scenario:Startup-waf-BytebuddyAgent unsure
[+0.474ms; +3.981ms] or [+0.079%; +0.666%]
scenario:Startup-waf-GlobalTracer unsure
[+0.496ms; +2.083ms] or [+0.222%; +0.934%]
scenario:Startup-waf-AppSec same
scenario:Startup-waf-Remote Config same
scenario:Startup-waf-Telemetry same

@amarziali amarziali marked this pull request as ready for review May 30, 2023 10:06
@amarziali amarziali requested a review from a team as a code owner May 30, 2023 10:06
@amarziali amarziali enabled auto-merge May 30, 2023 12:48
ygree
ygree approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@ygree ygree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarziali amarziali merged commit eeb83b8 into master May 30, 2023
@amarziali amarziali deleted the andrea.marziali/peer.service-aws branch May 30, 2023 16:26
@github-actions github-actions bot added this to the 1.15.0 milestone May 30, 2023
@amarziali amarziali added the tag: no release notes Changes to exclude from release notes label May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygree ygree ygree approved these changes

Assignees
No one assigned
Labels
tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amarziali @ygree