Fix TestNG integration for TESTS parallel mode #5305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
comp: ci visibility
smola
approved these changes
Jun 1, 2023
smola
approved these changes
Jun 1, 2023
nikita-tkachenko-datadog
changed the base branch from
release/v1.5.x
to
release/v1.15.x
BenchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. |
nikita-tkachenko-datadog
deleted the
nikita-tkachenko/testng-fix-release-v1.5.x
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fixes Test NG integration for cases when parallel execution mode is set to tests and when XML configuration is used.
Motivation
There are clients who use CI Visibility with Test NG in tests parallel mode and with explicit XML configuration.
Additional Notes
When Test NG is configured explicitly using XML (rather than when Maven/Gradle plugins create an implicit XmlSuite instance), some of the assumptions made previously do not hold: it is possible to have multiple ITestClass instances for the same Java class and multiple ITestMethod instances for the same test case method.