Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of lambdas as CLOSURE scope type #6105

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Add support of lambdas as CLOSURE scope type #6105

merged 1 commit into from
Oct 30, 2023

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented Oct 26, 2023 •
edited by jira bot
Loading

What Does This Do

Motivation

Additional Notes

Jira ticket: DEBUG-1892

@jpbempel jpbempel requested a review from a team as a code owner October 26, 2023 13:42
@jpbempel jpbempel requested review from shatzi and removed request for a team October 26, 2023 13:42
@jpbempel jpbempel added the comp: debugger Dynamic Instrumentation label Oct 26, 2023
ojung
ojung approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@ojung ojung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks 👍

...gent-debugger/src/test/java/com/datadog/debugger/symbol/SymbolExtractionTransformerTest.java Show resolved Hide resolved
@pr-commenter
Copy link

pr-commenter bot commented Oct 26, 2023

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.22.0-SNAPSHOT~848d3775b0 1.22.0-SNAPSHOT~25ff89fa9d
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 cases.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.22.0-SNAPSHOT~25ff89fa9d, baseline=1.22.0-SNAPSHOT~848d3775b0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1024324
Total [baseline] (8.72 s) : 0, 8719995
Agent [candidate] (1.021 s) : 0, 1021281
Total [candidate] (8.71 s) : 0, 8709908
section iast
Agent [baseline] (1.143 s) : 0, 1143191
Total [baseline] (9.203 s) : 0, 9203010
Agent [candidate] (1.154 s) : 0, 1153579
Total [candidate] (9.281 s) : 0, 9280555
section iast_TELEMETRY_OFF
Agent [baseline] (1.14 s) : 0, 1139718
Total [baseline] (9.212 s) : 0, 9211734
Agent [candidate] (1.136 s) : 0, 1136169
Total [candidate] (9.184 s) : 0, 9184302
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.024 s -
Agent iast 1.143 s 118.867 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.14 s 115.394 ms (11.3%)
Total tracing 8.72 s -
Total iast 9.203 s 483.016 ms (5.5%)
Total iast_TELEMETRY_OFF 9.212 s 491.739 ms (5.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.021 s -
Agent iast 1.154 s 132.298 ms (13.0%)
Agent iast_TELEMETRY_OFF 1.136 s 114.888 ms (11.2%)
Total tracing 8.71 s -
Total iast 9.281 s 570.646 ms (6.6%)
Total iast_TELEMETRY_OFF 9.184 s 474.394 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.22.0-SNAPSHOT~25ff89fa9d, baseline=1.22.0-SNAPSHOT~848d3775b0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (639.789 ms) : 0, 639789
BytebuddyAgent [candidate] (637.983 ms) : 0, 637983
GlobalTracer [baseline] (293.756 ms) : 0, 293756
GlobalTracer [candidate] (292.972 ms) : 0, 292972
AppSec [baseline] (49.459 ms) : 0, 49459
AppSec [candidate] (49.167 ms) : 0, 49167
Remote Config [baseline] (682.219 µs) : 0, 682
Remote Config [candidate] (675.027 µs) : 0, 675
Telemetry [baseline] (6.036 ms) : 0, 6036
Telemetry [candidate] (6.059 ms) : 0, 6059
section iast
BytebuddyAgent [baseline] (765.644 ms) : 0, 765644
BytebuddyAgent [candidate] (771.922 ms) : 0, 771922
GlobalTracer [baseline] (270.718 ms) : 0, 270718
GlobalTracer [candidate] (273.863 ms) : 0, 273863
AppSec [baseline] (47.655 ms) : 0, 47655
AppSec [candidate] (46.327 ms) : 0, 46327
IAST [baseline] (16.661 ms) : 0, 16661
IAST [candidate] (17.213 ms) : 0, 17213
Remote Config [baseline] (595.594 µs) : 0, 596
Remote Config [candidate] (585.819 µs) : 0, 586
Telemetry [baseline] (7.602 ms) : 0, 7602
Telemetry [candidate] (9.017 ms) : 0, 9017
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (761.094 ms) : 0, 761094
BytebuddyAgent [candidate] (758.897 ms) : 0, 758897
GlobalTracer [baseline] (272.455 ms) : 0, 272455
GlobalTracer [candidate] (271.786 ms) : 0, 271786
AppSec [baseline] (46.486 ms) : 0, 46486
AppSec [candidate] (46.177 ms) : 0, 46177
IAST [baseline] (15.613 ms) : 0, 15613
IAST [candidate] (18.178 ms) : 0, 18178
Remote Config [baseline] (647.336 µs) : 0, 647
Remote Config [candidate] (648.325 µs) : 0, 648
Telemetry [baseline] (9.025 ms) : 0, 9025
Telemetry [candidate] (6.131 ms) : 0, 6131
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.22.0-SNAPSHOT~25ff89fa9d, baseline=1.22.0-SNAPSHOT~848d3775b0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018641
Total [baseline] (9.27 s) : 0, 9270349
Agent [candidate] (1.02 s) : 0, 1019775
Total [candidate] (9.217 s) : 0, 9216878
section appsec
Agent [baseline] (1.109 s) : 0, 1108990
Total [baseline] (9.308 s) : 0, 9308259
Agent [candidate] (1.121 s) : 0, 1121105
Total [candidate] (9.349 s) : 0, 9348562
section iast
Agent [baseline] (1.142 s) : 0, 1141632
Total [baseline] (9.459 s) : 0, 9458857
Agent [candidate] (1.18 s) : 0, 1179620
Total [candidate] (9.489 s) : 0, 9488819
section profiling
Agent [baseline] (1.19 s) : 0, 1190424
Total [baseline] (9.428 s) : 0, 9428336
Agent [candidate] (1.193 s) : 0, 1193000
Total [candidate] (9.456 s) : 0, 9455876
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.019 s -
Agent appsec 1.109 s 90.349 ms (8.9%)
Agent iast 1.142 s 122.991 ms (12.1%)
Agent profiling 1.19 s 171.783 ms (16.9%)
Total tracing 9.27 s -
Total appsec 9.308 s 37.91 ms (0.4%)
Total iast 9.459 s 188.508 ms (2.0%)
Total profiling 9.428 s 157.987 ms (1.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.02 s -
Agent appsec 1.121 s 101.33 ms (9.9%)
Agent iast 1.18 s 159.845 ms (15.7%)
Agent profiling 1.193 s 173.225 ms (17.0%)
Total tracing 9.217 s -
Total appsec 9.349 s 131.684 ms (1.4%)
Total iast 9.489 s 271.941 ms (3.0%)
Total profiling 9.456 s 238.998 ms (2.6%) 
gantt
    title petclinic - break down per module: candidate=1.22.0-SNAPSHOT~25ff89fa9d, baseline=1.22.0-SNAPSHOT~848d3775b0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (636.864 ms) : 0, 636864
BytebuddyAgent [candidate] (636.968 ms) : 0, 636968
GlobalTracer [baseline] (291.805 ms) : 0, 291805
GlobalTracer [candidate] (292.458 ms) : 0, 292458
AppSec [baseline] (48.91 ms) : 0, 48910
AppSec [candidate] (49.199 ms) : 0, 49199
Remote Config [baseline] (688.008 µs) : 0, 688
Remote Config [candidate] (680.301 µs) : 0, 680
Telemetry [baseline] (6.015 ms) : 0, 6015
Telemetry [candidate] (6.133 ms) : 0, 6133
section appsec
BytebuddyAgent [baseline] (637.961 ms) : 0, 637961
BytebuddyAgent [candidate] (645.939 ms) : 0, 645939
GlobalTracer [baseline] (292.374 ms) : 0, 292374
GlobalTracer [candidate] (295.415 ms) : 0, 295415
AppSec [baseline] (137.944 ms) : 0, 137944
AppSec [candidate] (138.585 ms) : 0, 138585
Remote Config [baseline] (641.249 µs) : 0, 641
Remote Config [candidate] (653.523 µs) : 0, 654
Telemetry [baseline] (5.696 ms) : 0, 5696
Telemetry [candidate] (5.77 ms) : 0, 5770
section iast
BytebuddyAgent [baseline] (765.116 ms) : 0, 765116
BytebuddyAgent [candidate] (790.647 ms) : 0, 790647
GlobalTracer [baseline] (271.034 ms) : 0, 271034
GlobalTracer [candidate] (279.531 ms) : 0, 279531
AppSec [baseline] (46.467 ms) : 0, 46467
AppSec [candidate] (49.436 ms) : 0, 49436
Remote Config [baseline] (583.069 µs) : 0, 583
Remote Config [candidate] (605.565 µs) : 0, 606
Telemetry [baseline] (6.131 ms) : 0, 6131
Telemetry [candidate] (7.677 ms) : 0, 7677
IAST [baseline] (17.906 ms) : 0, 17906
IAST [candidate] (16.342 ms) : 0, 16342
section profiling
BytebuddyAgent [baseline] (646.682 ms) : 0, 646682
BytebuddyAgent [candidate] (648.723 ms) : 0, 648723
GlobalTracer [baseline] (354.515 ms) : 0, 354515
GlobalTracer [candidate] (355.105 ms) : 0, 355105
AppSec [baseline] (49.296 ms) : 0, 49296
AppSec [candidate] (48.904 ms) : 0, 48904
Remote Config [baseline] (645.465 µs) : 0, 645
Remote Config [candidate] (637.182 µs) : 0, 637
Telemetry [baseline] (6.026 ms) : 0, 6026
Telemetry [candidate] (5.991 ms) : 0, 5991
ProfilingAgent [baseline] (80.045 ms) : 0, 80045
ProfilingAgent [candidate] (80.343 ms) : 0, 80343
Profiling [baseline] (80.069 ms) : 0, 80069
Profiling [candidate] (80.367 ms) : 0, 80367
Loading

Load

Parameters

Baseline Candidate
commit 1.22.0-SNAPSHOT~848d3775b0 1.22.0-SNAPSHOT~25ff89fa9d
config baseline candidate
end_time 2023-10-26T14:05:17 2023-10-26T14:21:32
start_time 2023-10-26T14:05:04 2023-10-26T14:21:19
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.22.0-SNAPSHOT~25ff89fa9d, baseline=1.22.0-SNAPSHOT~848d3775b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (358.562 µs) : 339, 378
.   : milestone, 359,
iast (457.91 µs) : 437, 479
.   : milestone, 458,
iast_FULL (524.182 µs) : 503, 545
.   : milestone, 524,
iast_INACTIVE (429.547 µs) : 409, 451
.   : milestone, 430,
iast_TELEMETRY_OFF (458.315 µs) : 437, 480
.   : milestone, 458,
tracing (437.267 µs) : 416, 459
.   : milestone, 437,
section candidate
no_agent (359.129 µs) : 338, 380
.   : milestone, 359,
iast (462.519 µs) : 442, 483
.   : milestone, 463,
iast_FULL (521.937 µs) : 501, 543
.   : milestone, 522,
iast_INACTIVE (429.509 µs) : 408, 451
.   : milestone, 430,
iast_TELEMETRY_OFF (451.742 µs) : 431, 473
.   : milestone, 452,
tracing (438.759 µs) : 417, 460
.   : milestone, 439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 358.562 µs [338.699 µs, 378.425 µs] -
iast 457.91 µs [437.279 µs, 478.54 µs] 99.348 µs (27.7%)
iast_FULL 524.182 µs [503.332 µs, 545.032 µs] 165.62 µs (46.2%)
iast_INACTIVE 429.547 µs [408.544 µs, 450.55 µs] 70.985 µs (19.8%)
iast_TELEMETRY_OFF 458.315 µs [436.983 µs, 479.648 µs] 99.753 µs (27.8%)
tracing 437.267 µs [415.844 µs, 458.69 µs] 78.705 µs (22.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 359.129 µs [338.21 µs, 380.048 µs] -
iast 462.519 µs [441.603 µs, 483.435 µs] 103.39 µs (28.8%)
iast_FULL 521.937 µs [501.368 µs, 542.506 µs] 162.808 µs (45.3%)
iast_INACTIVE 429.509 µs [408.382 µs, 450.636 µs] 70.38 µs (19.6%)
iast_TELEMETRY_OFF 451.742 µs [430.828 µs, 472.657 µs] 92.613 µs (25.8%)
tracing 438.759 µs [417.081 µs, 460.438 µs] 79.63 µs (22.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.22.0-SNAPSHOT~25ff89fa9d, baseline=1.22.0-SNAPSHOT~848d3775b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.331 ms) : 1312, 1350
.   : milestone, 1331,
appsec (1.696 ms) : 1672, 1721
.   : milestone, 1696,
iast (1.442 ms) : 1418, 1466
.   : milestone, 1442,
profiling (1.462 ms) : 1438, 1486
.   : milestone, 1462,
tracing (1.458 ms) : 1434, 1482
.   : milestone, 1458,
section candidate
no_agent (1.325 ms) : 1307, 1344
.   : milestone, 1325,
appsec (1.669 ms) : 1644, 1694
.   : milestone, 1669,
iast (1.452 ms) : 1428, 1477
.   : milestone, 1452,
profiling (1.512 ms) : 1486, 1537
.   : milestone, 1512,
tracing (1.439 ms) : 1414, 1463
.   : milestone, 1439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.331 ms [1.312 ms, 1.35 ms] -
appsec 1.696 ms [1.672 ms, 1.721 ms] 365.433 µs (27.5%)
iast 1.442 ms [1.418 ms, 1.466 ms] 110.867 µs (8.3%)
profiling 1.462 ms [1.438 ms, 1.486 ms] 130.981 µs (9.8%)
tracing 1.458 ms [1.434 ms, 1.482 ms] 126.854 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.325 ms [1.307 ms, 1.344 ms] -
appsec 1.669 ms [1.644 ms, 1.694 ms] 343.667 µs (25.9%)
iast 1.452 ms [1.428 ms, 1.477 ms] 126.94 µs (9.6%)
profiling 1.512 ms [1.486 ms, 1.537 ms] 186.153 µs (14.0%)
tracing 1.439 ms [1.414 ms, 1.463 ms] 113.269 µs (8.5%)

@jpbempel jpbempel merged commit 34c6955 into master Oct 30, 2023
71 checks passed
@jpbempel jpbempel deleted the jpbempel/symbol-closure-scope branch October 30, 2023 15:01
@github-actions github-actions bot added this to the 1.23.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ojung ojung ojung approved these changes

@shatzi shatzi Awaiting requested review from shatzi shatzi is a code owner automatically assigned from DataDog/debugger-java

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @ojung