Upgrade to ddprof 0.82.0 #6109

richardstartin · 2023-10-27T13:48:41Z

What Does This Do

Fixes for ELF parsing of dynamic libraries
Fix for live heap table resizing

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

pr-commenter · 2023-10-27T14:32:07Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
commit	1.23.0-SNAPSHOT~c2cfdeaf5e	1.23.0-SNAPSHOT~9b936ceddd
config	baseline	candidate

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 cases.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.23.0-SNAPSHOT~9b936ceddd, baseline=1.23.0-SNAPSHOT~c2cfdeaf5e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.028 s) : 0, 1027520
Total [baseline] (9.339 s) : 0, 9339287
Agent [candidate] (1.029 s) : 0, 1029306
Total [candidate] (9.34 s) : 0, 9339868
section appsec
Agent [baseline] (1.118 s) : 0, 1118003
Total [baseline] (9.428 s) : 0, 9427547
Agent [candidate] (1.117 s) : 0, 1116893
Total [candidate] (9.403 s) : 0, 9403216
section iast
Agent [baseline] (1.169 s) : 0, 1168934
Total [baseline] (9.598 s) : 0, 9598492
Agent [candidate] (1.156 s) : 0, 1155675
Total [candidate] (9.548 s) : 0, 9547903
section profiling
Agent [baseline] (1.202 s) : 0, 1202045
Total [baseline] (9.562 s) : 0, 9562141
Agent [candidate] (1.202 s) : 0, 1202389
Total [candidate] (9.524 s) : 0, 9524388

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.028 s	-
Agent	appsec	1.118 s	90.484 ms (8.8%)
Agent	iast	1.169 s	141.414 ms (13.8%)
Agent	profiling	1.202 s	174.525 ms (17.0%)
Total	tracing	9.339 s	-
Total	appsec	9.428 s	88.261 ms (0.9%)
Total	iast	9.598 s	259.205 ms (2.8%)
Total	profiling	9.562 s	222.854 ms (2.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.029 s	-
Agent	appsec	1.117 s	87.588 ms (8.5%)
Agent	iast	1.156 s	126.369 ms (12.3%)
Agent	profiling	1.202 s	173.084 ms (16.8%)
Total	tracing	9.34 s	-
Total	appsec	9.403 s	63.348 ms (0.7%)
Total	iast	9.548 s	208.035 ms (2.2%)
Total	profiling	9.524 s	184.52 ms (2.0%)

gantt
    title petclinic - break down per module: candidate=1.23.0-SNAPSHOT~9b936ceddd, baseline=1.23.0-SNAPSHOT~c2cfdeaf5e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (642.636 ms) : 0, 642636
BytebuddyAgent [candidate] (643.484 ms) : 0, 643484
GlobalTracer [baseline] (294.509 ms) : 0, 294509
GlobalTracer [candidate] (295.201 ms) : 0, 295201
AppSec [baseline] (48.996 ms) : 0, 48996
AppSec [candidate] (49.224 ms) : 0, 49224
Remote Config [baseline] (687.443 µs) : 0, 687
Remote Config [candidate] (691.77 µs) : 0, 692
Telemetry [baseline] (6.162 ms) : 0, 6162
Telemetry [candidate] (6.161 ms) : 0, 6161
section appsec
BytebuddyAgent [baseline] (644.214 ms) : 0, 644214
BytebuddyAgent [candidate] (643.701 ms) : 0, 643701
GlobalTracer [baseline] (294.31 ms) : 0, 294310
GlobalTracer [candidate] (293.701 ms) : 0, 293701
AppSec [baseline] (138.66 ms) : 0, 138660
AppSec [candidate] (138.602 ms) : 0, 138602
Remote Config [baseline] (642.945 µs) : 0, 643
Remote Config [candidate] (641.876 µs) : 0, 642
Telemetry [baseline] (5.721 ms) : 0, 5721
Telemetry [candidate] (5.726 ms) : 0, 5726
section iast
BytebuddyAgent [baseline] (784.749 ms) : 0, 784749
BytebuddyAgent [candidate] (773.117 ms) : 0, 773117
GlobalTracer [baseline] (277.3 ms) : 0, 277300
GlobalTracer [candidate] (274.389 ms) : 0, 274389
AppSec [baseline] (48.552 ms) : 0, 48552
AppSec [candidate] (47.735 ms) : 0, 47735
Remote Config [baseline] (600.321 µs) : 0, 600
Remote Config [candidate] (588.027 µs) : 0, 588
Telemetry [baseline] (7.664 ms) : 0, 7664
Telemetry [candidate] (8.344 ms) : 0, 8344
IAST [baseline] (15.211 ms) : 0, 15211
IAST [candidate] (17.093 ms) : 0, 17093
section profiling
BytebuddyAgent [baseline] (653.325 ms) : 0, 653325
BytebuddyAgent [candidate] (653.354 ms) : 0, 653354
GlobalTracer [baseline] (358.811 ms) : 0, 358811
GlobalTracer [candidate] (359.019 ms) : 0, 359019
AppSec [baseline] (49.693 ms) : 0, 49693
AppSec [candidate] (49.192 ms) : 0, 49192
Remote Config [baseline] (649.967 µs) : 0, 650
Remote Config [candidate] (653.644 µs) : 0, 654
Telemetry [baseline] (6.063 ms) : 0, 6063
Telemetry [candidate] (6.074 ms) : 0, 6074
ProfilingAgent [baseline] (80.109 ms) : 0, 80109
ProfilingAgent [candidate] (80.874 ms) : 0, 80874
Profiling [baseline] (80.134 ms) : 0, 80134
Profiling [candidate] (80.898 ms) : 0, 80898

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.23.0-SNAPSHOT~9b936ceddd, baseline=1.23.0-SNAPSHOT~c2cfdeaf5e

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.028 s) : 0, 1027719
Total [baseline] (8.81 s) : 0, 8810416
Agent [candidate] (1.029 s) : 0, 1029100
Total [candidate] (8.807 s) : 0, 8806506
section iast
Agent [baseline] (1.154 s) : 0, 1154429
Total [baseline] (9.271 s) : 0, 9270680
Agent [candidate] (1.156 s) : 0, 1155877
Total [candidate] (9.364 s) : 0, 9364294
section iast_TELEMETRY_OFF
Agent [baseline] (1.146 s) : 0, 1146382
Total [baseline] (9.282 s) : 0, 9282151
Agent [candidate] (1.147 s) : 0, 1146932
Total [candidate] (9.265 s) : 0, 9264913

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.028 s	-
Agent	iast	1.154 s	126.709 ms (12.3%)
Agent	iast_TELEMETRY_OFF	1.146 s	118.663 ms (11.5%)
Total	tracing	8.81 s	-
Total	iast	9.271 s	460.264 ms (5.2%)
Total	iast_TELEMETRY_OFF	9.282 s	471.736 ms (5.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.029 s	-
Agent	iast	1.156 s	126.777 ms (12.3%)
Agent	iast_TELEMETRY_OFF	1.147 s	117.832 ms (11.4%)
Total	tracing	8.807 s	-
Total	iast	9.364 s	557.788 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.265 s	458.407 ms (5.2%)

gantt
    title insecure-bank - break down per module: candidate=1.23.0-SNAPSHOT~9b936ceddd, baseline=1.23.0-SNAPSHOT~c2cfdeaf5e

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (642.679 ms) : 0, 642679
BytebuddyAgent [candidate] (643.486 ms) : 0, 643486
GlobalTracer [baseline] (294.809 ms) : 0, 294809
GlobalTracer [candidate] (295.252 ms) : 0, 295252
AppSec [baseline] (49.009 ms) : 0, 49009
AppSec [candidate] (49.283 ms) : 0, 49283
Remote Config [baseline] (682.505 µs) : 0, 683
Remote Config [candidate] (698.17 µs) : 0, 698
Telemetry [baseline] (6.048 ms) : 0, 6048
Telemetry [candidate] (6.11 ms) : 0, 6110
section iast
BytebuddyAgent [baseline] (772.711 ms) : 0, 772711
BytebuddyAgent [candidate] (773.935 ms) : 0, 773935
GlobalTracer [baseline] (274.213 ms) : 0, 274213
GlobalTracer [candidate] (274.535 ms) : 0, 274535
AppSec [baseline] (48.295 ms) : 0, 48295
AppSec [candidate] (48.593 ms) : 0, 48593
IAST [baseline] (16.063 ms) : 0, 16063
IAST [candidate] (16.21 ms) : 0, 16210
Remote Config [baseline] (571.804 µs) : 0, 572
Remote Config [candidate] (579.525 µs) : 0, 580
Telemetry [baseline] (8.178 ms) : 0, 8178
Telemetry [candidate] (7.555 ms) : 0, 7555
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (766.737 ms) : 0, 766737
BytebuddyAgent [candidate] (765.805 ms) : 0, 765805
GlobalTracer [baseline] (274.131 ms) : 0, 274131
GlobalTracer [candidate] (274.637 ms) : 0, 274637
AppSec [baseline] (46.381 ms) : 0, 46381
AppSec [candidate] (46.633 ms) : 0, 46633
IAST [baseline] (17.24 ms) : 0, 17240
IAST [candidate] (17.296 ms) : 0, 17296
Remote Config [baseline] (634.852 µs) : 0, 635
Remote Config [candidate] (573.253 µs) : 0, 573
Telemetry [baseline] (6.871 ms) : 0, 6871
Telemetry [candidate] (7.606 ms) : 0, 7606

Load

Parameters

	Baseline	Candidate
commit	1.23.0-SNAPSHOT~c2cfdeaf5e	1.23.0-SNAPSHOT~9b936ceddd
config	baseline	candidate
end_time	2023-10-27T14:10:27	2023-10-27T14:26:52
start_time	2023-10-27T14:10:14	2023-10-27T14:26:39

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~9b936ceddd, baseline=1.23.0-SNAPSHOT~c2cfdeaf5e
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.341 ms) : 1322, 1360
.   : milestone, 1341,
appsec (1.705 ms) : 1681, 1730
.   : milestone, 1705,
iast (1.48 ms) : 1455, 1505
.   : milestone, 1480,
profiling (1.485 ms) : 1460, 1509
.   : milestone, 1485,
tracing (1.463 ms) : 1437, 1489
.   : milestone, 1463,
section candidate
no_agent (1.345 ms) : 1325, 1364
.   : milestone, 1345,
appsec (1.724 ms) : 1700, 1748
.   : milestone, 1724,
iast (1.483 ms) : 1459, 1507
.   : milestone, 1483,
profiling (1.494 ms) : 1468, 1521
.   : milestone, 1494,
tracing (1.454 ms) : 1429, 1478
.   : milestone, 1454,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.341 ms [1.322 ms, 1.36 ms]	-
appsec	1.705 ms [1.681 ms, 1.73 ms]	364.741 µs (27.2%)
iast	1.48 ms [1.455 ms, 1.505 ms]	139.187 µs (10.4%)
profiling	1.485 ms [1.46 ms, 1.509 ms]	143.913 µs (10.7%)
tracing	1.463 ms [1.437 ms, 1.489 ms]	122.612 µs (9.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.345 ms [1.325 ms, 1.364 ms]	-
appsec	1.724 ms [1.7 ms, 1.748 ms]	379.282 µs (28.2%)
iast	1.483 ms [1.459 ms, 1.507 ms]	138.302 µs (10.3%)
profiling	1.494 ms [1.468 ms, 1.521 ms]	149.646 µs (11.1%)
tracing	1.454 ms [1.429 ms, 1.478 ms]	108.756 µs (8.1%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~9b936ceddd, baseline=1.23.0-SNAPSHOT~c2cfdeaf5e
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.051 µs) : 352, 392
.   : milestone, 372,
iast (464.183 µs) : 443, 485
.   : milestone, 464,
iast_FULL (528.748 µs) : 508, 549
.   : milestone, 529,
iast_INACTIVE (436.542 µs) : 416, 458
.   : milestone, 437,
iast_TELEMETRY_OFF (468.596 µs) : 448, 490
.   : milestone, 469,
tracing (447.86 µs) : 427, 469
.   : milestone, 448,
section candidate
no_agent (365.119 µs) : 344, 386
.   : milestone, 365,
iast (462.521 µs) : 442, 483
.   : milestone, 463,
iast_FULL (529.805 µs) : 509, 551
.   : milestone, 530,
iast_INACTIVE (442.536 µs) : 421, 464
.   : milestone, 443,
iast_TELEMETRY_OFF (470.176 µs) : 448, 492
.   : milestone, 470,
tracing (436.97 µs) : 416, 458
.   : milestone, 437,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.051 µs [351.912 µs, 392.189 µs]	-
iast	464.183 µs [443.127 µs, 485.238 µs]	92.132 µs (24.8%)
iast_FULL	528.748 µs [508.035 µs, 549.46 µs]	156.697 µs (42.1%)
iast_INACTIVE	436.542 µs [415.566 µs, 457.517 µs]	64.491 µs (17.3%)
iast_TELEMETRY_OFF	468.596 µs [447.639 µs, 489.553 µs]	96.546 µs (25.9%)
tracing	447.86 µs [426.795 µs, 468.925 µs]	75.809 µs (20.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	365.119 µs [344.282 µs, 385.957 µs]	-
iast	462.521 µs [441.745 µs, 483.298 µs]	97.402 µs (26.7%)
iast_FULL	529.805 µs [508.837 µs, 550.773 µs]	164.686 µs (45.1%)
iast_INACTIVE	442.536 µs [421.489 µs, 463.583 µs]	77.416 µs (21.2%)
iast_TELEMETRY_OFF	470.176 µs [447.947 µs, 492.406 µs]	105.057 µs (28.8%)
tracing	436.97 µs [415.992 µs, 457.948 µs]	71.85 µs (19.7%)

Upgrade to ddprof 0.82.0

9b936ce

richardstartin added the comp: profiling Profiling label Oct 27, 2023

richardstartin marked this pull request as ready for review October 27, 2023 14:36

richardstartin requested a review from a team as a code owner October 27, 2023 14:36

richardstartin requested review from dougqh, am312 and a team October 27, 2023 14:36

jbachorik approved these changes Oct 27, 2023

View reviewed changes

richardstartin merged commit cbff199 into master Oct 27, 2023
68 of 70 checks passed

richardstartin deleted the rgs/upgrade-ddprof-0.82.0 branch October 27, 2023 14:44

github-actions bot added this to the 1.23.0 milestone Oct 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to ddprof 0.82.0 #6109

Upgrade to ddprof 0.82.0 #6109

richardstartin commented Oct 27, 2023

pr-commenter bot commented Oct 27, 2023

Upgrade to ddprof 0.82.0 #6109

Upgrade to ddprof 0.82.0 #6109

Conversation

richardstartin commented Oct 27, 2023

What Does This Do

Motivation

Additional Notes

pr-commenter bot commented Oct 27, 2023

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary