Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name in sources for vertx 4 header names and param values #6114

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Add name in sources for vertx 4 header names and param values #6114

merged 1 commit into from
Oct 30, 2023

Conversation

manuel-alvarez-alvarez
Copy link
Contributor

What Does This Do

Adds the source name to the header and parameter names for Vertx.4 which was removed after the refactor in #6033

@manuel-alvarez-alvarez manuel-alvarez-alvarez added type: bug tag: no release notes Changes to exclude from release notes comp: asm iast Application Security Management (IAST) labels Oct 30, 2023
@pr-commenter
Copy link

pr-commenter bot commented Oct 30, 2023 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
commit 1.23.0-SNAPSHOT~cbff199155 1.23.0-SNAPSHOT~5c0cb03fa0
config baseline candidate
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
module Agent Agent
parent None None
variant iast iast

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 53 cases.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:insecure-bank:iast_TELEMETRY_OFF:IAST better
[-6.434ms; -0.540ms] or [-34.650%; -2.906%]		 15.081ms 18.567ms
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.23.0-SNAPSHOT~5c0cb03fa0, baseline=1.23.0-SNAPSHOT~cbff199155

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.029 s) : 0, 1028564
Total [baseline] (8.718 s) : 0, 8717768
Agent [candidate] (1.035 s) : 0, 1034758
Total [candidate] (8.793 s) : 0, 8792571
section iast
Agent [baseline] (1.153 s) : 0, 1153221
Total [baseline] (9.262 s) : 0, 9261808
Agent [candidate] (1.155 s) : 0, 1154857
Total [candidate] (9.296 s) : 0, 9295775
section iast_TELEMETRY_OFF
Agent [baseline] (1.146 s) : 0, 1145905
Total [baseline] (9.236 s) : 0, 9236365
Agent [candidate] (1.144 s) : 0, 1144110
Total [candidate] (9.255 s) : 0, 9255395
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.029 s -
Agent iast 1.153 s 124.658 ms (12.1%)
Agent iast_TELEMETRY_OFF 1.146 s 117.341 ms (11.4%)
Total tracing 8.718 s -
Total iast 9.262 s 544.04 ms (6.2%)
Total iast_TELEMETRY_OFF 9.236 s 518.598 ms (5.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.035 s -
Agent iast 1.155 s 120.099 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.144 s 109.352 ms (10.6%)
Total tracing 8.793 s -
Total iast 9.296 s 503.204 ms (5.7%)
Total iast_TELEMETRY_OFF 9.255 s 462.823 ms (5.3%) 
gantt
    title insecure-bank - break down per module: candidate=1.23.0-SNAPSHOT~5c0cb03fa0, baseline=1.23.0-SNAPSHOT~cbff199155

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (643.294 ms) : 0, 643294
BytebuddyAgent [candidate] (647.363 ms) : 0, 647363
GlobalTracer [baseline] (294.739 ms) : 0, 294739
GlobalTracer [candidate] (296.204 ms) : 0, 296204
AppSec [baseline] (49.189 ms) : 0, 49189
AppSec [candidate] (49.679 ms) : 0, 49679
Remote Config [baseline] (692.346 µs) : 0, 692
Remote Config [candidate] (692.872 µs) : 0, 693
Telemetry [baseline] (6.103 ms) : 0, 6103
Telemetry [candidate] (6.155 ms) : 0, 6155
section iast
BytebuddyAgent [baseline] (772.132 ms) : 0, 772132
BytebuddyAgent [candidate] (772.079 ms) : 0, 772079
GlobalTracer [baseline] (273.81 ms) : 0, 273810
GlobalTracer [candidate] (274.032 ms) : 0, 274032
AppSec [baseline] (46.235 ms) : 0, 46235
AppSec [candidate] (47.279 ms) : 0, 47279
IAST [baseline] (15.675 ms) : 0, 15675
IAST [candidate] (16.538 ms) : 0, 16538
Remote Config [baseline] (596.684 µs) : 0, 597
Remote Config [candidate] (603.72 µs) : 0, 604
Telemetry [baseline] (10.352 ms) : 0, 10352
Telemetry [candidate] (9.788 ms) : 0, 9788
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (765.068 ms) : 0, 765068
BytebuddyAgent [candidate] (765.635 ms) : 0, 765635
GlobalTracer [baseline] (273.614 ms) : 0, 273614
GlobalTracer [candidate] (273.74 ms) : 0, 273740
AppSec [baseline] (46.676 ms) : 0, 46676
AppSec [candidate] (46.4 ms) : 0, 46400
IAST [baseline] (18.567 ms) : 0, 18567
IAST [candidate] (15.081 ms) : 0, 15081
Remote Config [baseline] (696.263 µs) : 0, 696
Remote Config [candidate] (586.981 µs) : 0, 587
Telemetry [baseline] (6.815 ms) : 0, 6815
Telemetry [candidate] (8.145 ms) : 0, 8145
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.23.0-SNAPSHOT~5c0cb03fa0, baseline=1.23.0-SNAPSHOT~cbff199155

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1040955
Total [baseline] (9.322 s) : 0, 9322031
Agent [candidate] (1.025 s) : 0, 1024739
Total [candidate] (9.308 s) : 0, 9307892
section appsec
Agent [baseline] (1.115 s) : 0, 1115275
Total [baseline] (9.399 s) : 0, 9398941
Agent [candidate] (1.125 s) : 0, 1124571
Total [candidate] (9.353 s) : 0, 9353216
section iast
Agent [baseline] (1.151 s) : 0, 1150968
Total [baseline] (9.457 s) : 0, 9457164
Agent [candidate] (1.162 s) : 0, 1161568
Total [candidate] (9.533 s) : 0, 9532526
section profiling
Agent [baseline] (1.207 s) : 0, 1207400
Total [baseline] (9.572 s) : 0, 9571698
Agent [candidate] (1.205 s) : 0, 1205460
Total [candidate] (9.576 s) : 0, 9576015
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.041 s -
Agent appsec 1.115 s 74.319 ms (7.1%)
Agent iast 1.151 s 110.013 ms (10.6%)
Agent profiling 1.207 s 166.445 ms (16.0%)
Total tracing 9.322 s -
Total appsec 9.399 s 76.91 ms (0.8%)
Total iast 9.457 s 135.133 ms (1.4%)
Total profiling 9.572 s 249.667 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.025 s -
Agent appsec 1.125 s 99.832 ms (9.7%)
Agent iast 1.162 s 136.829 ms (13.4%)
Agent profiling 1.205 s 180.721 ms (17.6%)
Total tracing 9.308 s -
Total appsec 9.353 s 45.324 ms (0.5%)
Total iast 9.533 s 224.635 ms (2.4%)
Total profiling 9.576 s 268.123 ms (2.9%) 
gantt
    title petclinic - break down per module: candidate=1.23.0-SNAPSHOT~5c0cb03fa0, baseline=1.23.0-SNAPSHOT~cbff199155

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (651.29 ms) : 0, 651290
BytebuddyAgent [candidate] (641.365 ms) : 0, 641365
GlobalTracer [baseline] (297.939 ms) : 0, 297939
GlobalTracer [candidate] (293.388 ms) : 0, 293388
AppSec [baseline] (49.836 ms) : 0, 49836
AppSec [candidate] (49.002 ms) : 0, 49002
Remote Config [baseline] (699.057 µs) : 0, 699
Remote Config [candidate] (675.478 µs) : 0, 675
Telemetry [baseline] (6.222 ms) : 0, 6222
Telemetry [candidate] (6.054 ms) : 0, 6054
section appsec
BytebuddyAgent [baseline] (643.272 ms) : 0, 643272
BytebuddyAgent [candidate] (648.528 ms) : 0, 648528
GlobalTracer [baseline] (292.933 ms) : 0, 292933
GlobalTracer [candidate] (296.251 ms) : 0, 296251
AppSec [baseline] (138.261 ms) : 0, 138261
AppSec [candidate] (138.732 ms) : 0, 138732
Remote Config [baseline] (644.064 µs) : 0, 644
Remote Config [candidate] (644.046 µs) : 0, 644
Telemetry [baseline] (5.734 ms) : 0, 5734
Telemetry [candidate] (5.77 ms) : 0, 5770
section iast
BytebuddyAgent [baseline] (771.612 ms) : 0, 771612
BytebuddyAgent [candidate] (779.811 ms) : 0, 779811
GlobalTracer [baseline] (273.586 ms) : 0, 273586
GlobalTracer [candidate] (275.38 ms) : 0, 275380
AppSec [baseline] (47.736 ms) : 0, 47736
AppSec [candidate] (48.283 ms) : 0, 48283
IAST [baseline] (16.845 ms) : 0, 16845
IAST [candidate] (17.134 ms) : 0, 17134
Remote Config [baseline] (563.912 µs) : 0, 564
Remote Config [candidate] (587.857 µs) : 0, 588
Telemetry [baseline] (6.124 ms) : 0, 6124
Telemetry [candidate] (5.587 ms) : 0, 5587
section profiling
BytebuddyAgent [baseline] (654.577 ms) : 0, 654577
BytebuddyAgent [candidate] (654.89 ms) : 0, 654890
GlobalTracer [baseline] (361.162 ms) : 0, 361162
GlobalTracer [candidate] (359.609 ms) : 0, 359609
AppSec [baseline] (49.858 ms) : 0, 49858
AppSec [candidate] (49.844 ms) : 0, 49844
Remote Config [baseline] (662.734 µs) : 0, 663
Remote Config [candidate] (645.955 µs) : 0, 646
Telemetry [baseline] (6.105 ms) : 0, 6105
Telemetry [candidate] (6.087 ms) : 0, 6087
ProfilingAgent [baseline] (81.423 ms) : 0, 81423
ProfilingAgent [candidate] (80.818 ms) : 0, 80818
Profiling [baseline] (81.448 ms) : 0, 81448
Profiling [candidate] (80.843 ms) : 0, 80843
Loading

Load

Parameters

Baseline Candidate
commit 1.23.0-SNAPSHOT~cbff199155 1.23.0-SNAPSHOT~5c0cb03fa0
config baseline candidate
end_time 2023-10-30T12:15:22 2023-10-30T12:31:41
start_time 2023-10-30T12:15:09 2023-10-30T12:31:29
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~5c0cb03fa0, baseline=1.23.0-SNAPSHOT~cbff199155
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.765 µs) : 342, 385
.   : milestone, 364,
iast (457.397 µs) : 437, 478
.   : milestone, 457,
iast_FULL (519.992 µs) : 499, 541
.   : milestone, 520,
iast_INACTIVE (429.184 µs) : 408, 450
.   : milestone, 429,
iast_TELEMETRY_OFF (447.263 µs) : 427, 468
.   : milestone, 447,
tracing (432.56 µs) : 411, 454
.   : milestone, 433,
section candidate
no_agent (357.832 µs) : 339, 377
.   : milestone, 358,
iast (454.989 µs) : 434, 476
.   : milestone, 455,
iast_FULL (520.165 µs) : 499, 541
.   : milestone, 520,
iast_INACTIVE (425.656 µs) : 405, 446
.   : milestone, 426,
iast_TELEMETRY_OFF (456.301 µs) : 436, 477
.   : milestone, 456,
tracing (433.153 µs) : 412, 454
.   : milestone, 433,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.765 µs [342.389 µs, 385.14 µs] -
iast 457.397 µs [436.692 µs, 478.102 µs] 93.632 µs (25.7%)
iast_FULL 519.992 µs [499.419 µs, 540.564 µs] 156.227 µs (42.9%)
iast_INACTIVE 429.184 µs [408.35 µs, 450.017 µs] 65.419 µs (18.0%)
iast_TELEMETRY_OFF 447.263 µs [426.56 µs, 467.965 µs] 83.498 µs (23.0%)
tracing 432.56 µs [410.752 µs, 454.367 µs] 68.795 µs (18.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 357.832 µs [338.504 µs, 377.16 µs] -
iast 454.989 µs [434.43 µs, 475.548 µs] 97.156 µs (27.2%)
iast_FULL 520.165 µs [499.444 µs, 540.886 µs] 162.333 µs (45.4%)
iast_INACTIVE 425.656 µs [404.882 µs, 446.43 µs] 67.824 µs (19.0%)
iast_TELEMETRY_OFF 456.301 µs [435.576 µs, 477.026 µs] 98.469 µs (27.5%)
tracing 433.153 µs [411.893 µs, 454.414 µs] 75.321 µs (21.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~5c0cb03fa0, baseline=1.23.0-SNAPSHOT~cbff199155
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.339 ms) : 1320, 1358
.   : milestone, 1339,
appsec (1.708 ms) : 1683, 1732
.   : milestone, 1708,
iast (1.437 ms) : 1413, 1461
.   : milestone, 1437,
profiling (1.465 ms) : 1440, 1489
.   : milestone, 1465,
tracing (1.464 ms) : 1440, 1488
.   : milestone, 1464,
section candidate
no_agent (1.349 ms) : 1330, 1369
.   : milestone, 1349,
appsec (1.721 ms) : 1696, 1746
.   : milestone, 1721,
iast (1.427 ms) : 1403, 1452
.   : milestone, 1427,
profiling (1.456 ms) : 1431, 1481
.   : milestone, 1456,
tracing (1.452 ms) : 1428, 1477
.   : milestone, 1452,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.339 ms [1.32 ms, 1.358 ms] -
appsec 1.708 ms [1.683 ms, 1.732 ms] 368.548 µs (27.5%)
iast 1.437 ms [1.413 ms, 1.461 ms] 97.551 µs (7.3%)
profiling 1.465 ms [1.44 ms, 1.489 ms] 125.583 µs (9.4%)
tracing 1.464 ms [1.44 ms, 1.488 ms] 125.284 µs (9.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.33 ms, 1.369 ms] -
appsec 1.721 ms [1.696 ms, 1.746 ms] 372.063 µs (27.6%)
iast 1.427 ms [1.403 ms, 1.452 ms] 78.248 µs (5.8%)
profiling 1.456 ms [1.431 ms, 1.481 ms] 106.933 µs (7.9%)
tracing 1.452 ms [1.428 ms, 1.477 ms] 103.193 µs (7.6%)

@manuel-alvarez-alvarez manuel-alvarez-alvarez merged commit 3a6d76a into master Oct 30, 2023
67 of 69 checks passed
@manuel-alvarez-alvarez manuel-alvarez-alvarez deleted the malvarez/iast-fix-vertx4-sources branch October 30, 2023 13:08
@github-actions github-actions bot added this to the 1.23.0 milestone Oct 30, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smola smola smola approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@ValentinZakharov ValentinZakharov Awaiting requested review from ValentinZakharov ValentinZakharov is a code owner automatically assigned from DataDog/asm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal was automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: asm iast Application Security Management (IAST) tag: no release notes Changes to exclude from release notes type: bug
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
3 participants
@manuel-alvarez-alvarez @smola @PerfectSlayer