-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize common configuration telemetry #6694
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 42 metrics, 12 unstable metrics. LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 14 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~4f7daf4012, baseline=1.31.0-SNAPSHOT~9032a67633
dateFormat X
axisFormat %s
section baseline
no_agent (371.04 µs) : 351, 391
. : milestone, 371,
iast (483.464 µs) : 462, 505
. : milestone, 483,
iast_FULL (546.128 µs) : 525, 567
. : milestone, 546,
iast_GLOBAL (500.437 µs) : 480, 521
. : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (482.121 µs) : 462, 503
. : milestone, 482,
iast_INACTIVE (457.646 µs) : 437, 479
. : milestone, 458,
iast_TELEMETRY_OFF (473.074 µs) : 453, 494
. : milestone, 473,
tracing (446.454 µs) : 426, 467
. : milestone, 446,
section candidate
no_agent (367.797 µs) : 347, 389
. : milestone, 368,
iast (478.477 µs) : 458, 499
. : milestone, 478,
iast_FULL (538.188 µs) : 518, 559
. : milestone, 538,
iast_GLOBAL (491.355 µs) : 471, 512
. : milestone, 491,
iast_HARDCODED_SECRET_DISABLED (478.25 µs) : 458, 499
. : milestone, 478,
iast_INACTIVE (449.64 µs) : 428, 471
. : milestone, 450,
iast_TELEMETRY_OFF (469.648 µs) : 449, 490
. : milestone, 470,
tracing (457.915 µs) : 438, 478
. : milestone, 458,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~4f7daf4012, baseline=1.31.0-SNAPSHOT~9032a67633
dateFormat X
axisFormat %s
section baseline
no_agent (1.349 ms) : 1330, 1368
. : milestone, 1349,
appsec (1.784 ms) : 1761, 1808
. : milestone, 1784,
iast (1.524 ms) : 1500, 1548
. : milestone, 1524,
profiling (1.554 ms) : 1529, 1578
. : milestone, 1554,
tracing (1.492 ms) : 1469, 1516
. : milestone, 1492,
section candidate
no_agent (1.35 ms) : 1331, 1369
. : milestone, 1350,
appsec (1.798 ms) : 1775, 1821
. : milestone, 1798,
iast (1.554 ms) : 1531, 1578
. : milestone, 1554,
profiling (1.534 ms) : 1510, 1558
. : milestone, 1534,
tracing (1.496 ms) : 1472, 1520
. : milestone, 1496,
|
75bbd5a
to
3c7799b
Compare
b84c2bf
to
ff12525
Compare
ff12525
to
1804a50
Compare
Properly serialize inner maps as string.
Add the log.injection.enabled setting with the log.injection alias Add the trace.tags setting with the tags alias
1804a50
to
bcb6fde
Compare
bcb6fde
to
0f4353d
Compare
Hey @ygree 👋 |
@PerfectSlayer We have discussed all open questions and I have resolved all TODOs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but you might want another pair of eyes.
I got few minor questions but I am concerned about the default sampling rate change. Is it a breaking change or something worth notifying the customer on the release notes?
We end up agreeing to leave the default sample rate untouched. I've changed the PR description to explicitly state this. |
bc5b5af
to
a9c3256
Compare
@@ -36,7 +36,7 @@ instrumentation_modules: &instrumentation_modules "dd-java-agent/instrumentation | |||
debugger_modules: &debugger_modules "dd-java-agent/agent-debugger|dd-java-agent/agent-bootstrap|dd-java-agent/agent-builder|internal-api|communication|dd-trace-core" | |||
profiling_modules: &profiling_modules "dd-java-agent/agent-profiling" | |||
|
|||
default_system_tests_commit: &default_system_tests_commit 2374d120bbbc94109c449a0a9c182a9d4d0af60e | |||
default_system_tests_commit: &default_system_tests_commit 899511453a9beb4dd560eb45ec45a8328383c80a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Point to this fix for the test_app_started_client_configuration
system test cherry-picked on top of 2374d120bbbc94109c449a0a9c182a9d4d0af60e
* Collect null config defaults. Properly serialize inner maps as string. * Use snake_case for capture telemetry configuration * Test common standardized settings Add the log.injection.enabled setting with the log.injection alias Add the trace.tags setting with the tags alias * Empty maps and list config settings are collected as empty strings * Render default Config Setting Value as strings * Postpone config rendering as string until reporting phase * default_system_tests_commit set to system-test fix #1546
What Does This Do
logs_injection_enabled
with thelogs_injection
aliastrace_tags
with thetags
aliasnull
null
(JUST AS IT WAS), which means sample everything, but is not exactly the same as if it's explicitly set to1.0
Motivation
In-app APM Library Configuration Reporting
Additional Notes
Jira ticket: APMJAVA-1217
test_app_started_client_configuration
Corresponding Parametric Tests
Similar Python Tracer change