Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DD_TAGS should allow values without keys #6714

Closed
wants to merge 2 commits into from
Closed

DD_TAGS should allow values without keys #6714

wants to merge 2 commits into from

Conversation

bm1549
Copy link
Contributor

@bm1549 bm1549 commented Feb 21, 2024

What Does This Do

Permits optional values for DD_TAGS

Motivation

Aligns DD_TAGS usage with other mapped values and other libraries (pending research)

Additional Notes

Jira ticket: APMJAVA-1262

@pr-commenter
Copy link

pr-commenter bot commented Feb 21, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master brian.marks/dd_tags_allow_values
git_commit_date 1708728504 1708879717
git_commit_sha 6167d5e c03840b
release_version 1.31.0-SNAPSHOT~6167d5efc0 1.31.0-SNAPSHOT~c03840be69
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1708882601 1708882601
ci_job_id 442583537 442583537
ci_pipeline_id 28871179 28871179
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 9 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.31.0-SNAPSHOT~c03840be69, baseline=1.31.0-SNAPSHOT~6167d5efc0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077687
Total [baseline] (9.186 s) : 0, 9185903
Agent [candidate] (1.079 s) : 0, 1079314
Total [candidate] (9.148 s) : 0, 9147567
section appsec
Agent [baseline] (1.177 s) : 0, 1176727
Total [baseline] (9.342 s) : 0, 9341626
Agent [candidate] (1.194 s) : 0, 1194015
Total [candidate] (9.424 s) : 0, 9424217
section iast
Agent [baseline] (1.202 s) : 0, 1201884
Total [baseline] (9.361 s) : 0, 9361019
Agent [candidate] (1.206 s) : 0, 1205578
Total [candidate] (9.428 s) : 0, 9427549
section profiling
Agent [baseline] (1.27 s) : 0, 1269923
Total [baseline] (9.324 s) : 0, 9324108
Agent [candidate] (1.272 s) : 0, 1272475
Total [candidate] (9.431 s) : 0, 9431385
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.078 s -
Agent appsec 1.177 s 99.04 ms (9.2%)
Agent iast 1.202 s 124.198 ms (11.5%)
Agent profiling 1.27 s 192.236 ms (17.8%)
Total tracing 9.186 s -
Total appsec 9.342 s 155.722 ms (1.7%)
Total iast 9.361 s 175.115 ms (1.9%)
Total profiling 9.324 s 138.205 ms (1.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.079 s -
Agent appsec 1.194 s 114.701 ms (10.6%)
Agent iast 1.206 s 126.264 ms (11.7%)
Agent profiling 1.272 s 193.161 ms (17.9%)
Total tracing 9.148 s -
Total appsec 9.424 s 276.65 ms (3.0%)
Total iast 9.428 s 279.981 ms (3.1%)
Total profiling 9.431 s 283.817 ms (3.1%) 
gantt
    title petclinic - break down per module: candidate=1.31.0-SNAPSHOT~c03840be69, baseline=1.31.0-SNAPSHOT~6167d5efc0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.347 ms) : 0, 686347
BytebuddyAgent [candidate] (686.941 ms) : 0, 686941
GlobalTracer [baseline] (297.29 ms) : 0, 297290
GlobalTracer [candidate] (297.859 ms) : 0, 297859
AppSec [baseline] (51.176 ms) : 0, 51176
AppSec [candidate] (51.563 ms) : 0, 51563
Remote Config [baseline] (709.482 µs) : 0, 709
Remote Config [candidate] (730.379 µs) : 0, 730
Telemetry [baseline] (7.794 ms) : 0, 7794
Telemetry [candidate] (7.905 ms) : 0, 7905
section appsec
BytebuddyAgent [baseline] (686.591 ms) : 0, 686591
BytebuddyAgent [candidate] (696.636 ms) : 0, 696636
GlobalTracer [baseline] (297.418 ms) : 0, 297418
GlobalTracer [candidate] (302.324 ms) : 0, 302324
AppSec [baseline] (150.886 ms) : 0, 150886
AppSec [candidate] (152.515 ms) : 0, 152515
Remote Config [baseline] (634.836 µs) : 0, 635
Remote Config [candidate] (648.236 µs) : 0, 648
Telemetry [baseline] (6.899 ms) : 0, 6899
Telemetry [candidate] (7.037 ms) : 0, 7037
section iast
BytebuddyAgent [baseline] (796.017 ms) : 0, 796017
BytebuddyAgent [candidate] (798.384 ms) : 0, 798384
GlobalTracer [baseline] (287.678 ms) : 0, 287678
GlobalTracer [candidate] (289.117 ms) : 0, 289117
AppSec [baseline] (55.226 ms) : 0, 55226
AppSec [candidate] (56.248 ms) : 0, 56248
Remote Config [baseline] (624.889 µs) : 0, 625
Remote Config [candidate] (622.842 µs) : 0, 623
Telemetry [baseline] (6.55 ms) : 0, 6550
Telemetry [candidate] (6.662 ms) : 0, 6662
IAST [baseline] (21.493 ms) : 0, 21493
IAST [candidate] (20.121 ms) : 0, 20121
section profiling
BytebuddyAgent [baseline] (677.345 ms) : 0, 677345
BytebuddyAgent [candidate] (678.161 ms) : 0, 678161
GlobalTracer [baseline] (379.439 ms) : 0, 379439
GlobalTracer [candidate] (381.099 ms) : 0, 381099
AppSec [baseline] (52.965 ms) : 0, 52965
AppSec [candidate] (52.896 ms) : 0, 52896
Remote Config [baseline] (751.532 µs) : 0, 752
Remote Config [candidate] (786.979 µs) : 0, 787
Telemetry [baseline] (10.242 ms) : 0, 10242
Telemetry [candidate] (10.116 ms) : 0, 10116
ProfilingAgent [baseline] (93.198 ms) : 0, 93198
ProfilingAgent [candidate] (93.361 ms) : 0, 93361
Profiling [baseline] (93.222 ms) : 0, 93222
Profiling [candidate] (93.386 ms) : 0, 93386
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-02-25T17:13:02 2024-02-25T17:31:40
git_branch master brian.marks/dd_tags_allow_values
git_commit_date 1708728504 1708879717
git_commit_sha 6167d5e c03840b
release_version 1.31.0-SNAPSHOT~6167d5efc0 1.31.0-SNAPSHOT~c03840be69
start_time 2024-02-25T17:12:49 2024-02-25T17:31:27
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1708882601 1708882601
ci_job_id 442583537 442583537
ci_pipeline_id 28871179 28871179
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 15 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~c03840be69, baseline=1.31.0-SNAPSHOT~6167d5efc0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.356 ms) : 1337, 1375
.   : milestone, 1356,
appsec (1.804 ms) : 1780, 1827
.   : milestone, 1804,
iast (1.501 ms) : 1478, 1524
.   : milestone, 1501,
profiling (1.512 ms) : 1489, 1536
.   : milestone, 1512,
tracing (1.53 ms) : 1507, 1554
.   : milestone, 1530,
section candidate
no_agent (1.353 ms) : 1334, 1372
.   : milestone, 1353,
appsec (1.752 ms) : 1728, 1776
.   : milestone, 1752,
iast (1.525 ms) : 1501, 1548
.   : milestone, 1525,
profiling (1.555 ms) : 1530, 1579
.   : milestone, 1555,
tracing (1.514 ms) : 1491, 1538
.   : milestone, 1514,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.356 ms [1.337 ms, 1.375 ms] -
appsec 1.804 ms [1.78 ms, 1.827 ms] 447.671 µs (33.0%)
iast 1.501 ms [1.478 ms, 1.524 ms] 144.734 µs (10.7%)
profiling 1.512 ms [1.489 ms, 1.536 ms] 156.521 µs (11.5%)
tracing 1.53 ms [1.507 ms, 1.554 ms] 174.445 µs (12.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.353 ms [1.334 ms, 1.372 ms] -
appsec 1.752 ms [1.728 ms, 1.776 ms] 398.824 µs (29.5%)
iast 1.525 ms [1.501 ms, 1.548 ms] 171.351 µs (12.7%)
profiling 1.555 ms [1.53 ms, 1.579 ms] 201.354 µs (14.9%)
tracing 1.514 ms [1.491 ms, 1.538 ms] 161.026 µs (11.9%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~c03840be69, baseline=1.31.0-SNAPSHOT~6167d5efc0
    dateFormat X
    axisFormat %s
section baseline
no_agent (358.217 µs) : 338, 378
.   : milestone, 358,
iast (471.348 µs) : 450, 492
.   : milestone, 471,
iast_FULL (537.769 µs) : 517, 558
.   : milestone, 538,
iast_GLOBAL (496.477 µs) : 476, 517
.   : milestone, 496,
iast_HARDCODED_SECRET_DISABLED (474.149 µs) : 453, 495
.   : milestone, 474,
iast_INACTIVE (448.039 µs) : 427, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (464.705 µs) : 444, 485
.   : milestone, 465,
tracing (445.235 µs) : 425, 466
.   : milestone, 445,
section candidate
no_agent (360.01 µs) : 340, 380
.   : milestone, 360,
iast (470.15 µs) : 450, 491
.   : milestone, 470,
iast_FULL (533.496 µs) : 513, 554
.   : milestone, 533,
iast_GLOBAL (502.207 µs) : 480, 524
.   : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (475.947 µs) : 455, 497
.   : milestone, 476,
iast_INACTIVE (449.193 µs) : 428, 470
.   : milestone, 449,
iast_TELEMETRY_OFF (468.174 µs) : 447, 490
.   : milestone, 468,
tracing (437.376 µs) : 417, 458
.   : milestone, 437,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 358.217 µs [337.961 µs, 378.474 µs] -
iast 471.348 µs [450.446 µs, 492.25 µs] 113.131 µs (31.6%)
iast_FULL 537.769 µs [517.399 µs, 558.139 µs] 179.552 µs (50.1%)
iast_GLOBAL 496.477 µs [475.928 µs, 517.025 µs] 138.26 µs (38.6%)
iast_HARDCODED_SECRET_DISABLED 474.149 µs [453.371 µs, 494.927 µs] 115.932 µs (32.4%)
iast_INACTIVE 448.039 µs [426.637 µs, 469.44 µs] 89.822 µs (25.1%)
iast_TELEMETRY_OFF 464.705 µs [443.917 µs, 485.493 µs] 106.488 µs (29.7%)
tracing 445.235 µs [424.916 µs, 465.554 µs] 87.018 µs (24.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 360.01 µs [340.199 µs, 379.822 µs] -
iast 470.15 µs [449.685 µs, 490.614 µs] 110.139 µs (30.6%)
iast_FULL 533.496 µs [513.205 µs, 553.788 µs] 173.486 µs (48.2%)
iast_GLOBAL 502.207 µs [480.098 µs, 524.316 µs] 142.197 µs (39.5%)
iast_HARDCODED_SECRET_DISABLED 475.947 µs [454.963 µs, 496.93 µs] 115.936 µs (32.2%)
iast_INACTIVE 449.193 µs [428.458 µs, 469.928 µs] 89.183 µs (24.8%)
iast_TELEMETRY_OFF 468.174 µs [446.736 µs, 489.613 µs] 108.164 µs (30.0%)
tracing 437.376 µs [416.848 µs, 457.904 µs] 77.366 µs (21.5%)

@bm1549 bm1549 closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bm1549