-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DD_TAGS should allow values without keys #6714
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.31.0-SNAPSHOT~c03840be69, baseline=1.31.0-SNAPSHOT~6167d5efc0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.078 s) : 0, 1077687
Total [baseline] (9.186 s) : 0, 9185903
Agent [candidate] (1.079 s) : 0, 1079314
Total [candidate] (9.148 s) : 0, 9147567
section appsec
Agent [baseline] (1.177 s) : 0, 1176727
Total [baseline] (9.342 s) : 0, 9341626
Agent [candidate] (1.194 s) : 0, 1194015
Total [candidate] (9.424 s) : 0, 9424217
section iast
Agent [baseline] (1.202 s) : 0, 1201884
Total [baseline] (9.361 s) : 0, 9361019
Agent [candidate] (1.206 s) : 0, 1205578
Total [candidate] (9.428 s) : 0, 9427549
section profiling
Agent [baseline] (1.27 s) : 0, 1269923
Total [baseline] (9.324 s) : 0, 9324108
Agent [candidate] (1.272 s) : 0, 1272475
Total [candidate] (9.431 s) : 0, 9431385
gantt
title petclinic - break down per module: candidate=1.31.0-SNAPSHOT~c03840be69, baseline=1.31.0-SNAPSHOT~6167d5efc0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.347 ms) : 0, 686347
BytebuddyAgent [candidate] (686.941 ms) : 0, 686941
GlobalTracer [baseline] (297.29 ms) : 0, 297290
GlobalTracer [candidate] (297.859 ms) : 0, 297859
AppSec [baseline] (51.176 ms) : 0, 51176
AppSec [candidate] (51.563 ms) : 0, 51563
Remote Config [baseline] (709.482 µs) : 0, 709
Remote Config [candidate] (730.379 µs) : 0, 730
Telemetry [baseline] (7.794 ms) : 0, 7794
Telemetry [candidate] (7.905 ms) : 0, 7905
section appsec
BytebuddyAgent [baseline] (686.591 ms) : 0, 686591
BytebuddyAgent [candidate] (696.636 ms) : 0, 696636
GlobalTracer [baseline] (297.418 ms) : 0, 297418
GlobalTracer [candidate] (302.324 ms) : 0, 302324
AppSec [baseline] (150.886 ms) : 0, 150886
AppSec [candidate] (152.515 ms) : 0, 152515
Remote Config [baseline] (634.836 µs) : 0, 635
Remote Config [candidate] (648.236 µs) : 0, 648
Telemetry [baseline] (6.899 ms) : 0, 6899
Telemetry [candidate] (7.037 ms) : 0, 7037
section iast
BytebuddyAgent [baseline] (796.017 ms) : 0, 796017
BytebuddyAgent [candidate] (798.384 ms) : 0, 798384
GlobalTracer [baseline] (287.678 ms) : 0, 287678
GlobalTracer [candidate] (289.117 ms) : 0, 289117
AppSec [baseline] (55.226 ms) : 0, 55226
AppSec [candidate] (56.248 ms) : 0, 56248
Remote Config [baseline] (624.889 µs) : 0, 625
Remote Config [candidate] (622.842 µs) : 0, 623
Telemetry [baseline] (6.55 ms) : 0, 6550
Telemetry [candidate] (6.662 ms) : 0, 6662
IAST [baseline] (21.493 ms) : 0, 21493
IAST [candidate] (20.121 ms) : 0, 20121
section profiling
BytebuddyAgent [baseline] (677.345 ms) : 0, 677345
BytebuddyAgent [candidate] (678.161 ms) : 0, 678161
GlobalTracer [baseline] (379.439 ms) : 0, 379439
GlobalTracer [candidate] (381.099 ms) : 0, 381099
AppSec [baseline] (52.965 ms) : 0, 52965
AppSec [candidate] (52.896 ms) : 0, 52896
Remote Config [baseline] (751.532 µs) : 0, 752
Remote Config [candidate] (786.979 µs) : 0, 787
Telemetry [baseline] (10.242 ms) : 0, 10242
Telemetry [candidate] (10.116 ms) : 0, 10116
ProfilingAgent [baseline] (93.198 ms) : 0, 93198
ProfilingAgent [candidate] (93.361 ms) : 0, 93361
Profiling [baseline] (93.222 ms) : 0, 93222
Profiling [candidate] (93.386 ms) : 0, 93386
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 15 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~c03840be69, baseline=1.31.0-SNAPSHOT~6167d5efc0
dateFormat X
axisFormat %s
section baseline
no_agent (1.356 ms) : 1337, 1375
. : milestone, 1356,
appsec (1.804 ms) : 1780, 1827
. : milestone, 1804,
iast (1.501 ms) : 1478, 1524
. : milestone, 1501,
profiling (1.512 ms) : 1489, 1536
. : milestone, 1512,
tracing (1.53 ms) : 1507, 1554
. : milestone, 1530,
section candidate
no_agent (1.353 ms) : 1334, 1372
. : milestone, 1353,
appsec (1.752 ms) : 1728, 1776
. : milestone, 1752,
iast (1.525 ms) : 1501, 1548
. : milestone, 1525,
profiling (1.555 ms) : 1530, 1579
. : milestone, 1555,
tracing (1.514 ms) : 1491, 1538
. : milestone, 1514,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.31.0-SNAPSHOT~c03840be69, baseline=1.31.0-SNAPSHOT~6167d5efc0
dateFormat X
axisFormat %s
section baseline
no_agent (358.217 µs) : 338, 378
. : milestone, 358,
iast (471.348 µs) : 450, 492
. : milestone, 471,
iast_FULL (537.769 µs) : 517, 558
. : milestone, 538,
iast_GLOBAL (496.477 µs) : 476, 517
. : milestone, 496,
iast_HARDCODED_SECRET_DISABLED (474.149 µs) : 453, 495
. : milestone, 474,
iast_INACTIVE (448.039 µs) : 427, 469
. : milestone, 448,
iast_TELEMETRY_OFF (464.705 µs) : 444, 485
. : milestone, 465,
tracing (445.235 µs) : 425, 466
. : milestone, 445,
section candidate
no_agent (360.01 µs) : 340, 380
. : milestone, 360,
iast (470.15 µs) : 450, 491
. : milestone, 470,
iast_FULL (533.496 µs) : 513, 554
. : milestone, 533,
iast_GLOBAL (502.207 µs) : 480, 524
. : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (475.947 µs) : 455, 497
. : milestone, 476,
iast_INACTIVE (449.193 µs) : 428, 470
. : milestone, 449,
iast_TELEMETRY_OFF (468.174 µs) : 447, 490
. : milestone, 468,
tracing (437.376 µs) : 417, 458
. : milestone, 437,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Permits optional values for DD_TAGS
Motivation
Aligns DD_TAGS usage with other mapped values and other libraries (pending research)
Additional Notes
Jira ticket: APMJAVA-1262