Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support of literals in Expression Language #7018

Merged
merged 1 commit into from
May 13, 2024
Merged

Fix support of literals in Expression Language #7018

merged 1 commit into from
May 13, 2024

Conversation

jpbempel
Copy link
Member

@jpbempel jpbempel commented May 13, 2024 •
edited by jira bot
Loading

What Does This Do

Add support of boolean
support characters as strings

Motivation

Additional Notes

Jira ticket: DEBUG-2371

@jpbempel
Fix support of literals in Expression Language
6014ea9 
Add support of boolean
support characters as strings
@jpbempel jpbempel added type: bug comp: debugger Dynamic Instrumentation labels May 13, 2024
@jpbempel jpbempel requested a review from a team as a code owner May 13, 2024 11:14
@jpbempel jpbempel requested review from shatzi and removed request for a team May 13, 2024 11:14
@pr-commenter
Copy link

pr-commenter bot commented May 13, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-boolean-literals
git_commit_date 1715599092 1715598754
git_commit_sha ad042ce 6014ea9
release_version 1.35.0-SNAPSHOT~ad042ce4a2 1.35.0-SNAPSHOT~6014ea9ccf
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715601283 1715601283
ci_job_id 509862133 509862133
ci_pipeline_id 34125145 34125145
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 50 metrics, 11 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Remote Config worse
[+20.148µs; +70.746µs] or [+3.549%; +12.462%]		 613.158µs 567.711µs
scenario:startup:insecure-bank:iast_TELEMETRY_OFF:Remote Config worse
[+17.403µs; +48.712µs] or [+3.070%; +8.594%]		 599.900µs 566.842µs
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~6014ea9ccf, baseline=1.35.0-SNAPSHOT~ad042ce4a2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.074 s) : 0, 1074496
Total [baseline] (10.409 s) : 0, 10409306
Agent [candidate] (1.084 s) : 0, 1083874
Total [candidate] (10.391 s) : 0, 10390616
section appsec
Agent [baseline] (1.197 s) : 0, 1196951
Total [baseline] (10.451 s) : 0, 10451257
Agent [candidate] (1.196 s) : 0, 1196147
Total [candidate] (10.472 s) : 0, 10471743
section iast
Agent [baseline] (1.212 s) : 0, 1211665
Total [baseline] (10.764 s) : 0, 10763803
Agent [candidate] (1.208 s) : 0, 1207911
Total [candidate] (10.727 s) : 0, 10727066
section profiling
Agent [baseline] (1.269 s) : 0, 1268602
Total [baseline] (10.612 s) : 0, 10612459
Agent [candidate] (1.268 s) : 0, 1268377
Total [candidate] (10.555 s) : 0, 10554883
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.074 s -
Agent appsec 1.197 s 122.455 ms (11.4%)
Agent iast 1.212 s 137.169 ms (12.8%)
Agent profiling 1.269 s 194.106 ms (18.1%)
Total tracing 10.409 s -
Total appsec 10.451 s 41.95 ms (0.4%)
Total iast 10.764 s 354.496 ms (3.4%)
Total profiling 10.612 s 203.153 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.084 s -
Agent appsec 1.196 s 112.273 ms (10.4%)
Agent iast 1.208 s 124.037 ms (11.4%)
Agent profiling 1.268 s 184.503 ms (17.0%)
Total tracing 10.391 s -
Total appsec 10.472 s 81.127 ms (0.8%)
Total iast 10.727 s 336.45 ms (3.2%)
Total profiling 10.555 s 164.267 ms (1.6%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~6014ea9ccf, baseline=1.35.0-SNAPSHOT~ad042ce4a2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.524 ms) : 0, 672524
BytebuddyAgent [candidate] (678.186 ms) : 0, 678186
GlobalTracer [baseline] (309.837 ms) : 0, 309837
GlobalTracer [candidate] (313.239 ms) : 0, 313239
AppSec [baseline] (49.504 ms) : 0, 49504
AppSec [candidate] (49.587 ms) : 0, 49587
Remote Config [baseline] (666.276 µs) : 0, 666
Remote Config [candidate] (665.411 µs) : 0, 665
Telemetry [baseline] (7.621 ms) : 0, 7621
Telemetry [candidate] (7.55 ms) : 0, 7550
section appsec
BytebuddyAgent [baseline] (697.091 ms) : 0, 697091
BytebuddyAgent [candidate] (696.439 ms) : 0, 696439
GlobalTracer [baseline] (293.83 ms) : 0, 293830
GlobalTracer [candidate] (293.508 ms) : 0, 293508
AppSec [baseline] (152.808 ms) : 0, 152808
AppSec [candidate] (152.598 ms) : 0, 152598
IAST [baseline] (19.269 ms) : 0, 19269
IAST [candidate] (19.344 ms) : 0, 19344
Remote Config [baseline] (624.913 µs) : 0, 625
Remote Config [candidate] (616.679 µs) : 0, 617
Telemetry [baseline] (8.46 ms) : 0, 8460
Telemetry [candidate] (8.871 ms) : 0, 8871
section iast
BytebuddyAgent [baseline] (802.761 ms) : 0, 802761
BytebuddyAgent [candidate] (798.408 ms) : 0, 798408
GlobalTracer [baseline] (292.327 ms) : 0, 292327
GlobalTracer [candidate] (292.477 ms) : 0, 292477
AppSec [baseline] (50.863 ms) : 0, 50863
AppSec [candidate] (48.527 ms) : 0, 48527
IAST [baseline] (23.864 ms) : 0, 23864
IAST [candidate] (25.998 ms) : 0, 25998
Remote Config [baseline] (644.183 µs) : 0, 644
Remote Config [candidate] (1.331 ms) : 0, 1331
Telemetry [baseline] (6.59 ms) : 0, 6590
Telemetry [candidate] (6.627 ms) : 0, 6627
section profiling
BytebuddyAgent [baseline] (677.034 ms) : 0, 677034
BytebuddyAgent [candidate] (676.846 ms) : 0, 676846
GlobalTracer [baseline] (380.89 ms) : 0, 380890
GlobalTracer [candidate] (381.52 ms) : 0, 381520
AppSec [baseline] (50.122 ms) : 0, 50122
AppSec [candidate] (50.333 ms) : 0, 50333
Remote Config [baseline] (714.996 µs) : 0, 715
Remote Config [candidate] (700.06 µs) : 0, 700
Telemetry [baseline] (7.455 ms) : 0, 7455
Telemetry [candidate] (7.455 ms) : 0, 7455
ProfilingAgent [baseline] (96.033 ms) : 0, 96033
ProfilingAgent [candidate] (95.0 ms) : 0, 95000
Profiling [baseline] (96.057 ms) : 0, 96057
Profiling [candidate] (95.024 ms) : 0, 95024
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~6014ea9ccf, baseline=1.35.0-SNAPSHOT~ad042ce4a2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1074764
Total [baseline] (8.526 s) : 0, 8525634
Agent [candidate] (1.076 s) : 0, 1076329
Total [candidate] (8.561 s) : 0, 8561063
section iast
Agent [baseline] (1.202 s) : 0, 1202261
Total [baseline] (9.058 s) : 0, 9058253
Agent [candidate] (1.198 s) : 0, 1198072
Total [candidate] (9.048 s) : 0, 9047742
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.202 s) : 0, 1202300
Total [baseline] (8.983 s) : 0, 8982684
Agent [candidate] (1.213 s) : 0, 1212967
Total [candidate] (8.983 s) : 0, 8982920
section iast_TELEMETRY_OFF
Agent [baseline] (1.198 s) : 0, 1198156
Total [baseline] (8.988 s) : 0, 8988122
Agent [candidate] (1.2 s) : 0, 1199762
Total [candidate] (8.991 s) : 0, 8990762
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent iast 1.202 s 127.497 ms (11.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.202 s 127.536 ms (11.9%)
Agent iast_TELEMETRY_OFF 1.198 s 123.392 ms (11.5%)
Total tracing 8.526 s -
Total iast 9.058 s 532.619 ms (6.2%)
Total iast_HARDCODED_SECRET_DISABLED 8.983 s 457.05 ms (5.4%)
Total iast_TELEMETRY_OFF 8.988 s 462.488 ms (5.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent iast 1.198 s 121.743 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.213 s 136.638 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.2 s 123.433 ms (11.5%)
Total tracing 8.561 s -
Total iast 9.048 s 486.679 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.983 s 421.857 ms (4.9%)
Total iast_TELEMETRY_OFF 8.991 s 429.699 ms (5.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~6014ea9ccf, baseline=1.35.0-SNAPSHOT~ad042ce4a2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (672.437 ms) : 0, 672437
BytebuddyAgent [candidate] (673.23 ms) : 0, 673230
GlobalTracer [baseline] (310.6 ms) : 0, 310600
GlobalTracer [candidate] (311.131 ms) : 0, 311131
AppSec [baseline] (49.262 ms) : 0, 49262
AppSec [candidate] (49.361 ms) : 0, 49361
Remote Config [baseline] (660.966 µs) : 0, 661
Remote Config [candidate] (665.917 µs) : 0, 666
Telemetry [baseline] (7.525 ms) : 0, 7525
Telemetry [candidate] (7.588 ms) : 0, 7588
section iast
BytebuddyAgent [baseline] (795.726 ms) : 0, 795726
BytebuddyAgent [candidate] (791.281 ms) : 0, 791281
GlobalTracer [baseline] (290.637 ms) : 0, 290637
GlobalTracer [candidate] (290.256 ms) : 0, 290256
AppSec [baseline] (51.046 ms) : 0, 51046
AppSec [candidate] (51.72 ms) : 0, 51720
IAST [baseline] (23.33 ms) : 0, 23330
IAST [candidate] (22.67 ms) : 0, 22670
Remote Config [baseline] (578.12 µs) : 0, 578
Remote Config [candidate] (1.257 ms) : 0, 1257
Telemetry [baseline] (6.657 ms) : 0, 6657
Telemetry [candidate] (6.595 ms) : 0, 6595
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (795.565 ms) : 0, 795565
BytebuddyAgent [candidate] (800.543 ms) : 0, 800543
GlobalTracer [baseline] (290.521 ms) : 0, 290521
GlobalTracer [candidate] (294.532 ms) : 0, 294532
AppSec [baseline] (50.84 ms) : 0, 50840
AppSec [candidate] (52.609 ms) : 0, 52609
IAST [baseline] (23.822 ms) : 0, 23822
IAST [candidate] (23.219 ms) : 0, 23219
Remote Config [baseline] (567.711 µs) : 0, 568
Remote Config [candidate] (613.158 µs) : 0, 613
Telemetry [baseline] (6.578 ms) : 0, 6578
Telemetry [candidate] (6.83 ms) : 0, 6830
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (792.21 ms) : 0, 792210
BytebuddyAgent [candidate] (792.507 ms) : 0, 792507
GlobalTracer [baseline] (290.039 ms) : 0, 290039
GlobalTracer [candidate] (291.081 ms) : 0, 291081
AppSec [baseline] (53.333 ms) : 0, 53333
AppSec [candidate] (50.426 ms) : 0, 50426
IAST [baseline] (21.219 ms) : 0, 21219
IAST [candidate] (24.016 ms) : 0, 24016
Remote Config [baseline] (566.842 µs) : 0, 567
Remote Config [candidate] (599.9 µs) : 0, 600
Telemetry [baseline] (6.456 ms) : 0, 6456
Telemetry [candidate] (6.578 ms) : 0, 6578
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-13T11:25:38 2024-05-13T11:32:25
git_branch master jpbempel/fix-boolean-literals
git_commit_date 1715599092 1715598754
git_commit_sha ad042ce 6014ea9
release_version 1.35.0-SNAPSHOT~ad042ce4a2 1.35.0-SNAPSHOT~6014ea9ccf
start_time 2024-05-13T11:25:25 2024-05-13T11:32:12
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1715600286 1715600286
ci_job_id 509862134 509862134
ci_pipeline_id 34125145 34125145
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~6014ea9ccf, baseline=1.35.0-SNAPSHOT~ad042ce4a2
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.791 µs) : 344, 383
.   : milestone, 364,
iast (481.124 µs) : 460, 502
.   : milestone, 481,
iast_FULL (545.29 µs) : 524, 566
.   : milestone, 545,
iast_GLOBAL (498.784 µs) : 478, 520
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (473.983 µs) : 453, 495
.   : milestone, 474,
iast_INACTIVE (450.801 µs) : 429, 473
.   : milestone, 451,
iast_TELEMETRY_OFF (468.806 µs) : 447, 491
.   : milestone, 469,
tracing (433.825 µs) : 413, 454
.   : milestone, 434,
section candidate
no_agent (366.78 µs) : 347, 387
.   : milestone, 367,
iast (469.286 µs) : 448, 490
.   : milestone, 469,
iast_FULL (533.928 µs) : 513, 555
.   : milestone, 534,
iast_GLOBAL (484.085 µs) : 464, 504
.   : milestone, 484,
iast_HARDCODED_SECRET_DISABLED (461.863 µs) : 442, 482
.   : milestone, 462,
iast_INACTIVE (443.213 µs) : 422, 464
.   : milestone, 443,
iast_TELEMETRY_OFF (465.501 µs) : 443, 488
.   : milestone, 466,
tracing (436.626 µs) : 416, 457
.   : milestone, 437,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 363.791 µs [344.495 µs, 383.088 µs] -
iast 481.124 µs [459.801 µs, 502.448 µs] 117.333 µs (32.3%)
iast_FULL 545.29 µs [524.264 µs, 566.316 µs] 181.499 µs (49.9%)
iast_GLOBAL 498.784 µs [477.82 µs, 519.748 µs] 134.993 µs (37.1%)
iast_HARDCODED_SECRET_DISABLED 473.983 µs [452.628 µs, 495.339 µs] 110.192 µs (30.3%)
iast_INACTIVE 450.801 µs [429.081 µs, 472.52 µs] 87.01 µs (23.9%)
iast_TELEMETRY_OFF 468.806 µs [447.036 µs, 490.575 µs] 105.014 µs (28.9%)
tracing 433.825 µs [413.318 µs, 454.332 µs] 70.033 µs (19.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.78 µs [346.666 µs, 386.895 µs] -
iast 469.286 µs [448.43 µs, 490.141 µs] 102.505 µs (27.9%)
iast_FULL 533.928 µs [513.171 µs, 554.686 µs] 167.148 µs (45.6%)
iast_GLOBAL 484.085 µs [463.775 µs, 504.395 µs] 117.304 µs (32.0%)
iast_HARDCODED_SECRET_DISABLED 461.863 µs [441.605 µs, 482.12 µs] 95.082 µs (25.9%)
iast_INACTIVE 443.213 µs [422.257 µs, 464.169 µs] 76.432 µs (20.8%)
iast_TELEMETRY_OFF 465.501 µs [443.174 µs, 487.828 µs] 98.72 µs (26.9%)
tracing 436.626 µs [416.29 µs, 456.963 µs] 69.846 µs (19.0%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~6014ea9ccf, baseline=1.35.0-SNAPSHOT~ad042ce4a2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.346 ms) : 1327, 1365
.   : milestone, 1346,
appsec (1.697 ms) : 1674, 1720
.   : milestone, 1697,
appsec_no_iast (1.706 ms) : 1681, 1730
.   : milestone, 1706,
iast (1.471 ms) : 1448, 1494
.   : milestone, 1471,
profiling (1.497 ms) : 1473, 1521
.   : milestone, 1497,
tracing (1.473 ms) : 1449, 1498
.   : milestone, 1473,
section candidate
no_agent (1.325 ms) : 1306, 1345
.   : milestone, 1325,
appsec (1.714 ms) : 1691, 1738
.   : milestone, 1714,
appsec_no_iast (1.714 ms) : 1690, 1737
.   : milestone, 1714,
iast (1.467 ms) : 1444, 1490
.   : milestone, 1467,
profiling (1.471 ms) : 1446, 1495
.   : milestone, 1471,
tracing (1.488 ms) : 1464, 1512
.   : milestone, 1488,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.346 ms [1.327 ms, 1.365 ms] -
appsec 1.697 ms [1.674 ms, 1.72 ms] 351.042 µs (26.1%)
appsec_no_iast 1.706 ms [1.681 ms, 1.73 ms] 359.787 µs (26.7%)
iast 1.471 ms [1.448 ms, 1.494 ms] 124.982 µs (9.3%)
profiling 1.497 ms [1.473 ms, 1.521 ms] 150.778 µs (11.2%)
tracing 1.473 ms [1.449 ms, 1.498 ms] 127.351 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.325 ms [1.306 ms, 1.345 ms] -
appsec 1.714 ms [1.691 ms, 1.738 ms] 388.767 µs (29.3%)
appsec_no_iast 1.714 ms [1.69 ms, 1.737 ms] 388.154 µs (29.3%)
iast 1.467 ms [1.444 ms, 1.49 ms] 141.77 µs (10.7%)
profiling 1.471 ms [1.446 ms, 1.495 ms] 145.139 µs (10.9%)
tracing 1.488 ms [1.464 ms, 1.512 ms] 162.882 µs (12.3%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-boolean-literals
git_commit_date 1715599092 1715598754
git_commit_sha ad042ce 6014ea9
release_version 1.35.0-SNAPSHOT~ad042ce4a2 1.35.0-SNAPSHOT~6014ea9ccf
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1715600894 1715600894
ci_job_id 509862135 509862135
ci_pipeline_id 34125145 34125145
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~6014ea9ccf, baseline=1.35.0-SNAPSHOT~ad042ce4a2
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.017 s) : 15017000, 15017000
.   : milestone, 15017000,
appsec (15.095 s) : 15095000, 15095000
.   : milestone, 15095000,
iast (18.951 s) : 18951000, 18951000
.   : milestone, 18951000,
iast_GLOBAL (17.654 s) : 17654000, 17654000
.   : milestone, 17654000,
profiling (15.037 s) : 15037000, 15037000
.   : milestone, 15037000,
tracing (14.942 s) : 14942000, 14942000
.   : milestone, 14942000,
section candidate
no_agent (14.902 s) : 14902000, 14902000
.   : milestone, 14902000,
appsec (15.054 s) : 15054000, 15054000
.   : milestone, 15054000,
iast (18.591 s) : 18591000, 18591000
.   : milestone, 18591000,
iast_GLOBAL (17.704 s) : 17704000, 17704000
.   : milestone, 17704000,
profiling (15.699 s) : 15699000, 15699000
.   : milestone, 15699000,
tracing (14.852 s) : 14852000, 14852000
.   : milestone, 14852000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.017 s [15.017 s, 15.017 s] -
appsec 15.095 s [15.095 s, 15.095 s] 78.0 ms (0.5%)
iast 18.951 s [18.951 s, 18.951 s] 3.934 s (26.2%)
iast_GLOBAL 17.654 s [17.654 s, 17.654 s] 2.637 s (17.6%)
profiling 15.037 s [15.037 s, 15.037 s] 20.0 ms (0.1%)
tracing 14.942 s [14.942 s, 14.942 s] -75.0 ms (-0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.902 s [14.902 s, 14.902 s] -
appsec 15.054 s [15.054 s, 15.054 s] 152.0 ms (1.0%)
iast 18.591 s [18.591 s, 18.591 s] 3.689 s (24.8%)
iast_GLOBAL 17.704 s [17.704 s, 17.704 s] 2.802 s (18.8%)
profiling 15.699 s [15.699 s, 15.699 s] 797.0 ms (5.3%)
tracing 14.852 s [14.852 s, 14.852 s] -50.0 ms (-0.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~6014ea9ccf, baseline=1.35.0-SNAPSHOT~ad042ce4a2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1472
.   : milestone, 1460,
appsec (2.192 ms) : 2158, 2226
.   : milestone, 2192,
iast (1.94 ms) : 1899, 1980
.   : milestone, 1940,
iast_GLOBAL (1.976 ms) : 1936, 2017
.   : milestone, 1976,
profiling (1.83 ms) : 1798, 1863
.   : milestone, 1830,
tracing (1.818 ms) : 1786, 1849
.   : milestone, 1818,
section candidate
no_agent (1.46 ms) : 1449, 1472
.   : milestone, 1460,
appsec (2.179 ms) : 2146, 2213
.   : milestone, 2179,
iast (1.87 ms) : 1835, 1905
.   : milestone, 1870,
iast_GLOBAL (1.916 ms) : 1880, 1952
.   : milestone, 1916,
profiling (1.836 ms) : 1803, 1868
.   : milestone, 1836,
tracing (1.82 ms) : 1788, 1852
.   : milestone, 1820,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.472 ms] -
appsec 2.192 ms [2.158 ms, 2.226 ms] 731.829 µs (50.1%)
iast 1.94 ms [1.899 ms, 1.98 ms] 479.373 µs (32.8%)
iast_GLOBAL 1.976 ms [1.936 ms, 2.017 ms] 516.066 µs (35.3%)
profiling 1.83 ms [1.798 ms, 1.863 ms] 369.826 µs (25.3%)
tracing 1.818 ms [1.786 ms, 1.849 ms] 357.582 µs (24.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.472 ms] -
appsec 2.179 ms [2.146 ms, 2.213 ms] 718.871 µs (49.2%)
iast 1.87 ms [1.835 ms, 1.905 ms] 409.468 µs (28.0%)
iast_GLOBAL 1.916 ms [1.88 ms, 1.952 ms] 455.65 µs (31.2%)
profiling 1.836 ms [1.803 ms, 1.868 ms] 375.134 µs (25.7%)
tracing 1.82 ms [1.788 ms, 1.852 ms] 360.051 µs (24.7%)

shatzi
shatzi approved these changes May 13, 2024
View reviewed changes
dd-java-agent/agent-debugger/debugger-el/src/main/java/com/datadog/debugger/el/Value.java
@@ -64,6 +64,8 @@ static Value<?> of(Object value) {
}
if (value instanceof Boolean) {
return new BooleanValue((Boolean) value);
} else if (value instanceof Character) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add support for Byte and Short as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not specifically. Byte and Short are Number and falls automatically in the same Integer category

@jpbempel jpbempel merged commit 6c2d477 into master May 13, 2024
82 checks passed
@jpbempel jpbempel deleted the jpbempel/fix-boolean-literals branch May 13, 2024 15:48
@github-actions github-actions bot added this to the 1.35.0 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatzi shatzi shatzi approved these changes

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation type: bug
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpbempel @shatzi