-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit rate limited JFR events when RejectedExecutionHandlers run #7076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardstartin
force-pushed
the
rgs/rejected-execution-events
branch
3 times, most recently
from
May 24, 2024 16:43
5ce19eb
to
395eb06
Compare
richardstartin
force-pushed
the
rgs/rejected-execution-events
branch
from
June 4, 2024 11:30
395eb06
to
460eca9
Compare
jbachorik
approved these changes
Jun 4, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~87dc12035d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.572 s) : 0, 1572008
Total [baseline] (12.01 s) : 0, 12009805
Agent [candidate] (1.585 s) : 0, 1584883
Total [candidate] (11.954 s) : 0, 11954310
section iast
Agent [baseline] (1.712 s) : 0, 1711633
Total [baseline] (12.539 s) : 0, 12538590
Agent [candidate] (1.708 s) : 0, 1707959
Total [candidate] (12.499 s) : 0, 12499034
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.706 s) : 0, 1706062
Total [baseline] (12.509 s) : 0, 12508927
Agent [candidate] (1.708 s) : 0, 1707819
Total [candidate] (12.498 s) : 0, 12497906
section iast_TELEMETRY_OFF
Agent [baseline] (1.696 s) : 0, 1696424
Total [baseline] (12.559 s) : 0, 12559412
Agent [candidate] (1.702 s) : 0, 1702452
Total [candidate] (12.582 s) : 0, 12581626
gantt
title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~87dc12035d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (967.148 ms) : 0, 967148
BytebuddyAgent [candidate] (975.227 ms) : 0, 975227
GlobalTracer [baseline] (462.05 ms) : 0, 462050
GlobalTracer [candidate] (465.995 ms) : 0, 465995
AppSec [baseline] (71.683 ms) : 0, 71683
AppSec [candidate] (71.987 ms) : 0, 71987
Remote Config [baseline] (834.393 µs) : 0, 834
Remote Config [candidate] (851.648 µs) : 0, 852
Telemetry [baseline] (9.818 ms) : 0, 9818
Telemetry [candidate] (9.861 ms) : 0, 9861
section iast
BytebuddyAgent [baseline] (1.15 s) : 0, 1150149
BytebuddyAgent [candidate] (1.144 s) : 0, 1144167
GlobalTracer [baseline] (432.819 ms) : 0, 432819
GlobalTracer [candidate] (431.26 ms) : 0, 431260
AppSec [baseline] (67.32 ms) : 0, 67320
AppSec [candidate] (67.19 ms) : 0, 67190
IAST [baseline] (29.113 ms) : 0, 29113
IAST [candidate] (34.142 ms) : 0, 34142
Remote Config [baseline] (774.273 µs) : 0, 774
Remote Config [candidate] (777.863 µs) : 0, 778
Telemetry [baseline] (11.683 ms) : 0, 11683
Telemetry [candidate] (10.616 ms) : 0, 10616
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.144 s) : 0, 1144155
BytebuddyAgent [candidate] (1.145 s) : 0, 1144869
GlobalTracer [baseline] (430.824 ms) : 0, 430824
GlobalTracer [candidate] (432.029 ms) : 0, 432029
AppSec [baseline] (65.906 ms) : 0, 65906
AppSec [candidate] (67.725 ms) : 0, 67725
IAST [baseline] (33.141 ms) : 0, 33141
IAST [candidate] (33.401 ms) : 0, 33401
Remote Config [baseline] (769.756 µs) : 0, 770
Remote Config [candidate] (790.007 µs) : 0, 790
Telemetry [baseline] (11.451 ms) : 0, 11451
Telemetry [candidate] (9.163 ms) : 0, 9163
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.138 s) : 0, 1137524
BytebuddyAgent [candidate] (1.141 s) : 0, 1141171
GlobalTracer [baseline] (429.818 ms) : 0, 429818
GlobalTracer [candidate] (431.314 ms) : 0, 431314
AppSec [baseline] (67.3 ms) : 0, 67300
AppSec [candidate] (68.417 ms) : 0, 68417
IAST [baseline] (31.324 ms) : 0, 31324
IAST [candidate] (31.071 ms) : 0, 31071
Remote Config [baseline] (788.366 µs) : 0, 788
Remote Config [candidate] (771.31 µs) : 0, 771
Telemetry [baseline] (9.902 ms) : 0, 9902
Telemetry [candidate] (9.763 ms) : 0, 9763
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~87dc12035d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.575 s) : 0, 1575484
Total [baseline] (14.147 s) : 0, 14146501
Agent [candidate] (1.575 s) : 0, 1574835
Total [candidate] (14.266 s) : 0, 14266330
section appsec
Agent [baseline] (1.751 s) : 0, 1751245
Total [baseline] (14.383 s) : 0, 14382843
Agent [candidate] (1.756 s) : 0, 1756238
Total [candidate] (14.392 s) : 0, 14391850
section iast
Agent [baseline] (1.704 s) : 0, 1703916
Total [baseline] (14.764 s) : 0, 14763826
Agent [candidate] (1.707 s) : 0, 1707087
Total [candidate] (14.715 s) : 0, 14715037
section profiling
Agent [baseline] (1.891 s) : 0, 1890790
Total [baseline] (14.661 s) : 0, 14661283
Agent [candidate] (1.896 s) : 0, 1896218
Total [candidate] (14.75 s) : 0, 14750465
gantt
title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~87dc12035d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (969.259 ms) : 0, 969259
BytebuddyAgent [candidate] (969.11 ms) : 0, 969110
GlobalTracer [baseline] (463.45 ms) : 0, 463450
GlobalTracer [candidate] (463.122 ms) : 0, 463122
AppSec [baseline] (71.613 ms) : 0, 71613
AppSec [candidate] (71.376 ms) : 0, 71376
Remote Config [baseline] (830.751 µs) : 0, 831
Remote Config [candidate] (841.035 µs) : 0, 841
Telemetry [baseline] (9.811 ms) : 0, 9811
Telemetry [candidate] (9.778 ms) : 0, 9778
section appsec
BytebuddyAgent [baseline] (1.0 s) : 0, 1000488
BytebuddyAgent [candidate] (1.003 s) : 0, 1002552
GlobalTracer [baseline] (436.85 ms) : 0, 436850
GlobalTracer [candidate] (439.104 ms) : 0, 439104
AppSec [baseline] (231.369 ms) : 0, 231369
AppSec [candidate] (231.713 ms) : 0, 231713
IAST [baseline] (23.932 ms) : 0, 23932
IAST [candidate] (24.191 ms) : 0, 24191
Remote Config [baseline] (785.905 µs) : 0, 786
Remote Config [candidate] (792.66 µs) : 0, 793
Telemetry [baseline] (9.248 ms) : 0, 9248
Telemetry [candidate] (9.27 ms) : 0, 9270
section iast
BytebuddyAgent [baseline] (1.145 s) : 0, 1144966
BytebuddyAgent [candidate] (1.144 s) : 0, 1144483
GlobalTracer [baseline] (430.592 ms) : 0, 430592
GlobalTracer [candidate] (430.997 ms) : 0, 430997
AppSec [baseline] (67.195 ms) : 0, 67195
AppSec [candidate] (66.977 ms) : 0, 66977
IAST [baseline] (29.868 ms) : 0, 29868
IAST [candidate] (34.222 ms) : 0, 34222
Remote Config [baseline] (767.461 µs) : 0, 767
Remote Config [candidate] (781.406 µs) : 0, 781
Telemetry [baseline] (10.836 ms) : 0, 10836
Telemetry [candidate] (9.89 ms) : 0, 9890
section profiling
BytebuddyAgent [baseline] (983.321 ms) : 0, 983321
BytebuddyAgent [candidate] (982.725 ms) : 0, 982725
GlobalTracer [baseline] (579.172 ms) : 0, 579172
GlobalTracer [candidate] (579.509 ms) : 0, 579509
AppSec [baseline] (73.135 ms) : 0, 73135
AppSec [candidate] (73.709 ms) : 0, 73709
Remote Config [baseline] (954.587 µs) : 0, 955
Remote Config [candidate] (959.559 µs) : 0, 960
Telemetry [baseline] (9.514 ms) : 0, 9514
Telemetry [candidate] (9.536 ms) : 0, 9536
ProfilingAgent [baseline] (151.39 ms) : 0, 151390
ProfilingAgent [candidate] (156.295 ms) : 0, 156295
Profiling [baseline] (151.459 ms) : 0, 151459
Profiling [candidate] (156.351 ms) : 0, 156351
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~ad2cc7a93e
dateFormat X
axisFormat %s
section baseline
no_agent (1.351 ms) : 1332, 1370
. : milestone, 1351,
appsec (1.713 ms) : 1690, 1737
. : milestone, 1713,
appsec_no_iast (1.729 ms) : 1705, 1753
. : milestone, 1729,
iast (1.485 ms) : 1462, 1508
. : milestone, 1485,
profiling (1.494 ms) : 1470, 1518
. : milestone, 1494,
tracing (1.475 ms) : 1451, 1500
. : milestone, 1475,
section candidate
no_agent (1.332 ms) : 1312, 1351
. : milestone, 1332,
appsec (1.698 ms) : 1674, 1722
. : milestone, 1698,
appsec_no_iast (1.732 ms) : 1708, 1755
. : milestone, 1732,
iast (1.482 ms) : 1459, 1505
. : milestone, 1482,
profiling (1.534 ms) : 1508, 1560
. : milestone, 1534,
tracing (1.459 ms) : 1435, 1483
. : milestone, 1459,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~ad2cc7a93e
dateFormat X
axisFormat %s
section baseline
no_agent (372.465 µs) : 353, 392
. : milestone, 372,
iast (480.202 µs) : 459, 502
. : milestone, 480,
iast_FULL (555.689 µs) : 535, 576
. : milestone, 556,
iast_GLOBAL (502.901 µs) : 481, 525
. : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (475.413 µs) : 455, 496
. : milestone, 475,
iast_INACTIVE (448.49 µs) : 427, 470
. : milestone, 448,
iast_TELEMETRY_OFF (475.841 µs) : 454, 498
. : milestone, 476,
tracing (441.049 µs) : 420, 462
. : milestone, 441,
section candidate
no_agent (368.063 µs) : 347, 389
. : milestone, 368,
iast (488.612 µs) : 467, 510
. : milestone, 489,
iast_FULL (546.062 µs) : 525, 567
. : milestone, 546,
iast_GLOBAL (508.526 µs) : 487, 530
. : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (488.987 µs) : 467, 511
. : milestone, 489,
iast_INACTIVE (449.99 µs) : 429, 471
. : milestone, 450,
iast_TELEMETRY_OFF (472.7 µs) : 451, 494
. : milestone, 473,
tracing (436.952 µs) : 417, 457
. : milestone, 437,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~ad2cc7a93e
dateFormat X
axisFormat %s
section baseline
no_agent (1.457 ms) : 1446, 1468
. : milestone, 1457,
appsec (2.193 ms) : 2159, 2227
. : milestone, 2193,
iast (1.959 ms) : 1917, 2000
. : milestone, 1959,
iast_GLOBAL (1.989 ms) : 1949, 2030
. : milestone, 1989,
profiling (1.833 ms) : 1799, 1867
. : milestone, 1833,
tracing (1.83 ms) : 1797, 1862
. : milestone, 1830,
section candidate
no_agent (1.458 ms) : 1447, 1470
. : milestone, 1458,
appsec (2.189 ms) : 2156, 2223
. : milestone, 2189,
iast (1.961 ms) : 1920, 2003
. : milestone, 1961,
iast_GLOBAL (1.974 ms) : 1934, 2015
. : milestone, 1974,
profiling (1.838 ms) : 1804, 1872
. : milestone, 1838,
tracing (1.831 ms) : 1799, 1863
. : milestone, 1831,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~460eca9f39, baseline=1.35.0-SNAPSHOT~ad2cc7a93e
dateFormat X
axisFormat %s
section baseline
no_agent (14.835 s) : 14835000, 14835000
. : milestone, 14835000,
appsec (15.344 s) : 15344000, 15344000
. : milestone, 15344000,
iast (18.738 s) : 18738000, 18738000
. : milestone, 18738000,
iast_GLOBAL (17.969 s) : 17969000, 17969000
. : milestone, 17969000,
profiling (15.072 s) : 15072000, 15072000
. : milestone, 15072000,
tracing (15.16 s) : 15160000, 15160000
. : milestone, 15160000,
section candidate
no_agent (14.896 s) : 14896000, 14896000
. : milestone, 14896000,
appsec (15.248 s) : 15248000, 15248000
. : milestone, 15248000,
iast (18.838 s) : 18838000, 18838000
. : milestone, 18838000,
iast_GLOBAL (17.731 s) : 17731000, 17731000
. : milestone, 17731000,
profiling (15.328 s) : 15328000, 15328000
. : milestone, 15328000,
tracing (15.058 s) : 15058000, 15058000
. : milestone, 15058000,
|
PerfectSlayer
changed the title
emit rate limited JFR events when RejectedExecutionHandlers run
Emit rate limited JFR events when RejectedExecutionHandlers run
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This emits a custom JFR event with the name of the rejected execution handler type and the name of the user's code when execution is rejected. Emission of these events is controlled by a PID controller with the same parameters as the exception profiler. The feature is disabled by default, and given the structure of the project (in particular with respect to JDK8 + JFR), unit testing this feature is difficult. I would like to merge the change as is and iterate on it on internal systems, and undergo the rigmarole of unit tests before enabling it by default.
Motivation
Show task rejection in the profiling timeline and Code Hotspots.
Additional Notes
Jira ticket: PROF-9882