-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve agentServiceCheck to handle scenarios where the tracer is configured to use UDS #7098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
added
comp: core
Tracer core
tag: diagnostics
Diagnostics related changes
labels
May 30, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.569 s) : 0, 1568720
Total [baseline] (11.958 s) : 0, 11958276
Agent [candidate] (1.571 s) : 0, 1570726
Total [candidate] (11.948 s) : 0, 11948366
section iast
Agent [baseline] (1.703 s) : 0, 1703009
Total [baseline] (12.553 s) : 0, 12552905
Agent [candidate] (1.703 s) : 0, 1703144
Total [candidate] (12.548 s) : 0, 12547854
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.725 s) : 0, 1725440
Total [baseline] (12.516 s) : 0, 12516478
Agent [candidate] (1.702 s) : 0, 1702147
Total [candidate] (12.506 s) : 0, 12505705
section iast_TELEMETRY_OFF
Agent [baseline] (1.708 s) : 0, 1708408
Total [baseline] (12.52 s) : 0, 12519958
Agent [candidate] (1.701 s) : 0, 1700826
Total [candidate] (12.592 s) : 0, 12592210
gantt
title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (966.155 ms) : 0, 966155
BytebuddyAgent [candidate] (966.314 ms) : 0, 966314
GlobalTracer [baseline] (460.684 ms) : 0, 460684
GlobalTracer [candidate] (462.306 ms) : 0, 462306
AppSec [baseline] (70.635 ms) : 0, 70635
AppSec [candidate] (70.877 ms) : 0, 70877
Remote Config [baseline] (837.174 µs) : 0, 837
Remote Config [candidate] (836.236 µs) : 0, 836
Telemetry [baseline] (9.836 ms) : 0, 9836
Telemetry [candidate] (9.858 ms) : 0, 9858
section iast
BytebuddyAgent [baseline] (1.145 s) : 0, 1144542
BytebuddyAgent [candidate] (1.143 s) : 0, 1143471
GlobalTracer [baseline] (430.643 ms) : 0, 430643
GlobalTracer [candidate] (430.706 ms) : 0, 430706
AppSec [baseline] (66.245 ms) : 0, 66245
AppSec [candidate] (68.578 ms) : 0, 68578
Remote Config [baseline] (789.476 µs) : 0, 789
Remote Config [candidate] (796.939 µs) : 0, 797
Telemetry [baseline] (10.929 ms) : 0, 10929
Telemetry [candidate] (10.778 ms) : 0, 10778
IAST [baseline] (30.15 ms) : 0, 30150
IAST [candidate] (29.038 ms) : 0, 29038
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.159 s) : 0, 1159285
BytebuddyAgent [candidate] (1.144 s) : 0, 1144479
GlobalTracer [baseline] (435.148 ms) : 0, 435148
GlobalTracer [candidate] (429.97 ms) : 0, 429970
AppSec [baseline] (68.087 ms) : 0, 68087
AppSec [candidate] (66.948 ms) : 0, 66948
Remote Config [baseline] (796.714 µs) : 0, 797
Remote Config [candidate] (776.634 µs) : 0, 777
Telemetry [baseline] (10.832 ms) : 0, 10832
Telemetry [candidate] (9.989 ms) : 0, 9989
IAST [baseline] (31.237 ms) : 0, 31237
IAST [candidate] (30.001 ms) : 0, 30001
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.145 s) : 0, 1145447
BytebuddyAgent [candidate] (1.141 s) : 0, 1140696
GlobalTracer [baseline] (431.638 ms) : 0, 431638
GlobalTracer [candidate] (430.787 ms) : 0, 430787
AppSec [baseline] (70.56 ms) : 0, 70560
AppSec [candidate] (69.824 ms) : 0, 69824
Remote Config [baseline] (804.764 µs) : 0, 805
Remote Config [candidate] (748.094 µs) : 0, 748
Telemetry [baseline] (9.786 ms) : 0, 9786
Telemetry [candidate] (9.652 ms) : 0, 9652
IAST [baseline] (30.333 ms) : 0, 30333
IAST [candidate] (29.252 ms) : 0, 29252
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.57 s) : 0, 1569779
Total [baseline] (14.274 s) : 0, 14274281
Agent [candidate] (1.575 s) : 0, 1574839
Total [candidate] (14.3 s) : 0, 14300061
section appsec
Agent [baseline] (1.758 s) : 0, 1758017
Total [baseline] (14.343 s) : 0, 14342538
Agent [candidate] (1.751 s) : 0, 1750606
Total [candidate] (14.317 s) : 0, 14316566
section iast
Agent [baseline] (1.704 s) : 0, 1703581
Total [baseline] (14.82 s) : 0, 14820074
Agent [candidate] (1.709 s) : 0, 1708871
Total [candidate] (14.849 s) : 0, 14849200
section profiling
Agent [baseline] (1.901 s) : 0, 1900565
Total [baseline] (14.653 s) : 0, 14652762
Agent [candidate] (1.895 s) : 0, 1895336
Total [candidate] (14.735 s) : 0, 14734790
gantt
title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (967.076 ms) : 0, 967076
BytebuddyAgent [candidate] (969.94 ms) : 0, 969940
GlobalTracer [baseline] (460.858 ms) : 0, 460858
GlobalTracer [candidate] (462.127 ms) : 0, 462127
AppSec [baseline] (70.746 ms) : 0, 70746
AppSec [candidate] (71.403 ms) : 0, 71403
Remote Config [baseline] (841.533 µs) : 0, 842
Remote Config [candidate] (838.859 µs) : 0, 839
Telemetry [baseline] (9.837 ms) : 0, 9837
Telemetry [candidate] (9.86 ms) : 0, 9860
section appsec
BytebuddyAgent [baseline] (1.005 s) : 0, 1005202
BytebuddyAgent [candidate] (1.001 s) : 0, 1000606
GlobalTracer [baseline] (438.38 ms) : 0, 438380
GlobalTracer [candidate] (436.976 ms) : 0, 436976
AppSec [baseline] (231.478 ms) : 0, 231478
AppSec [candidate] (230.771 ms) : 0, 230771
Remote Config [baseline] (776.396 µs) : 0, 776
Remote Config [candidate] (781.539 µs) : 0, 782
Telemetry [baseline] (9.289 ms) : 0, 9289
Telemetry [candidate] (8.823 ms) : 0, 8823
IAST [baseline] (24.301 ms) : 0, 24301
IAST [candidate] (24.127 ms) : 0, 24127
section iast
BytebuddyAgent [baseline] (1.143 s) : 0, 1143188
BytebuddyAgent [candidate] (1.146 s) : 0, 1146337
GlobalTracer [baseline] (429.894 ms) : 0, 429894
GlobalTracer [candidate] (432.473 ms) : 0, 432473
AppSec [baseline] (66.878 ms) : 0, 66878
AppSec [candidate] (66.882 ms) : 0, 66882
Remote Config [baseline] (774.229 µs) : 0, 774
Remote Config [candidate] (797.16 µs) : 0, 797
Telemetry [baseline] (12.372 ms) : 0, 12372
Telemetry [candidate] (11.564 ms) : 0, 11564
IAST [baseline] (30.787 ms) : 0, 30787
IAST [candidate] (31.004 ms) : 0, 31004
section profiling
BytebuddyAgent [baseline] (988.163 ms) : 0, 988163
BytebuddyAgent [candidate] (989.254 ms) : 0, 989254
GlobalTracer [baseline] (581.211 ms) : 0, 581211
GlobalTracer [candidate] (579.07 ms) : 0, 579070
AppSec [baseline] (72.26 ms) : 0, 72260
AppSec [candidate] (71.438 ms) : 0, 71438
Remote Config [baseline] (1.018 ms) : 0, 1018
Remote Config [candidate] (1.057 ms) : 0, 1057
Telemetry [baseline] (9.91 ms) : 0, 9910
Telemetry [candidate] (9.842 ms) : 0, 9842
ProfilingAgent [baseline] (154.153 ms) : 0, 154153
ProfilingAgent [candidate] (150.742 ms) : 0, 150742
Profiling [baseline] (154.209 ms) : 0, 154209
Profiling [candidate] (150.804 ms) : 0, 150804
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67
dateFormat X
axisFormat %s
section baseline
no_agent (372.486 µs) : 352, 393
. : milestone, 372,
iast (487.457 µs) : 466, 509
. : milestone, 487,
iast_FULL (555.454 µs) : 534, 577
. : milestone, 555,
iast_GLOBAL (520.726 µs) : 497, 544
. : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (483.595 µs) : 463, 504
. : milestone, 484,
iast_INACTIVE (455.259 µs) : 434, 476
. : milestone, 455,
iast_TELEMETRY_OFF (483.399 µs) : 462, 505
. : milestone, 483,
tracing (451.021 µs) : 430, 472
. : milestone, 451,
section candidate
no_agent (373.103 µs) : 354, 393
. : milestone, 373,
iast (485.641 µs) : 464, 507
. : milestone, 486,
iast_FULL (555.73 µs) : 534, 577
. : milestone, 556,
iast_GLOBAL (507.454 µs) : 486, 528
. : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (486.681 µs) : 465, 508
. : milestone, 487,
iast_INACTIVE (459.806 µs) : 438, 482
. : milestone, 460,
iast_TELEMETRY_OFF (476.675 µs) : 455, 498
. : milestone, 477,
tracing (444.871 µs) : 424, 466
. : milestone, 445,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67
dateFormat X
axisFormat %s
section baseline
no_agent (1.349 ms) : 1330, 1368
. : milestone, 1349,
appsec (1.731 ms) : 1708, 1754
. : milestone, 1731,
appsec_no_iast (1.716 ms) : 1691, 1740
. : milestone, 1716,
iast (1.509 ms) : 1486, 1533
. : milestone, 1509,
profiling (1.486 ms) : 1461, 1511
. : milestone, 1486,
tracing (1.485 ms) : 1460, 1509
. : milestone, 1485,
section candidate
no_agent (1.345 ms) : 1324, 1365
. : milestone, 1345,
appsec (1.735 ms) : 1711, 1759
. : milestone, 1735,
appsec_no_iast (1.719 ms) : 1695, 1744
. : milestone, 1719,
iast (1.483 ms) : 1460, 1506
. : milestone, 1483,
profiling (1.548 ms) : 1523, 1573
. : milestone, 1548,
tracing (1.486 ms) : 1461, 1510
. : milestone, 1486,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67
dateFormat X
axisFormat %s
section baseline
no_agent (1.458 ms) : 1447, 1470
. : milestone, 1458,
appsec (2.182 ms) : 2149, 2215
. : milestone, 2182,
iast (1.958 ms) : 1917, 1999
. : milestone, 1958,
iast_GLOBAL (2.0 ms) : 1959, 2041
. : milestone, 2000,
profiling (1.833 ms) : 1801, 1865
. : milestone, 1833,
tracing (1.828 ms) : 1796, 1860
. : milestone, 1828,
section candidate
no_agent (1.461 ms) : 1449, 1472
. : milestone, 1461,
appsec (2.187 ms) : 2153, 2220
. : milestone, 2187,
iast (1.953 ms) : 1912, 1994
. : milestone, 1953,
iast_GLOBAL (1.996 ms) : 1955, 2037
. : milestone, 1996,
profiling (1.832 ms) : 1799, 1864
. : milestone, 1832,
tracing (1.82 ms) : 1789, 1852
. : milestone, 1820,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67
dateFormat X
axisFormat %s
section baseline
no_agent (15.434 s) : 15434000, 15434000
. : milestone, 15434000,
appsec (15.163 s) : 15163000, 15163000
. : milestone, 15163000,
iast (18.678 s) : 18678000, 18678000
. : milestone, 18678000,
iast_GLOBAL (17.737 s) : 17737000, 17737000
. : milestone, 17737000,
profiling (15.2 s) : 15200000, 15200000
. : milestone, 15200000,
tracing (14.955 s) : 14955000, 14955000
. : milestone, 14955000,
section candidate
no_agent (15.436 s) : 15436000, 15436000
. : milestone, 15436000,
appsec (15.271 s) : 15271000, 15271000
. : milestone, 15271000,
iast (18.828 s) : 18828000, 18828000
. : milestone, 18828000,
iast_GLOBAL (17.944 s) : 17944000, 17944000
. : milestone, 17944000,
profiling (15.219 s) : 15219000, 15219000
. : milestone, 15219000,
tracing (15.166 s) : 15166000, 15166000
. : milestone, 15166000,
|
…figured to use UDS
mcculls
force-pushed
the
mcculls/improve-agent-service-check
branch
from
May 31, 2024 13:14
35b0340
to
ac4ef66
Compare
am312
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Avoids misleading
agent_error
statuses when the simplehost:port
check fails, but UDS would have succeeded.Jira ticket: APMJAVA-1147