Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve agentServiceCheck to handle scenarios where the tracer is configured to use UDS #7098

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Improve agentServiceCheck to handle scenarios where the tracer is configured to use UDS #7098

merged 1 commit into from
Jun 3, 2024

Conversation

mcculls
Copy link
Contributor

@mcculls mcculls commented May 30, 2024 •
edited by jira bot
Loading

Motivation

Avoids misleading agent_error statuses when the simple host:port check fails, but UDS would have succeeded.

Jira ticket: APMJAVA-1147

@mcculls mcculls added comp: core Tracer core tag: diagnostics Diagnostics related changes labels May 30, 2024
@mcculls mcculls marked this pull request as ready for review May 30, 2024 16:16
@mcculls mcculls requested a review from a team as a code owner May 30, 2024 16:16
@mcculls mcculls requested review from ygree and am312 May 30, 2024 16:16
@pr-commenter
Copy link

pr-commenter bot commented May 30, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/improve-agent-service-check
git_commit_date 1717158264 1717161286
git_commit_sha dadbd53 ac4ef66
release_version 1.35.0-SNAPSHOT~dadbd53b67 1.35.0-SNAPSHOT~ac4ef6640e
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717165438 1717165438
ci_job_id 528754140 528754140
ci_pipeline_id 35570992 35570992
cpu_model Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 14 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.569 s) : 0, 1568720
Total [baseline] (11.958 s) : 0, 11958276
Agent [candidate] (1.571 s) : 0, 1570726
Total [candidate] (11.948 s) : 0, 11948366
section iast
Agent [baseline] (1.703 s) : 0, 1703009
Total [baseline] (12.553 s) : 0, 12552905
Agent [candidate] (1.703 s) : 0, 1703144
Total [candidate] (12.548 s) : 0, 12547854
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.725 s) : 0, 1725440
Total [baseline] (12.516 s) : 0, 12516478
Agent [candidate] (1.702 s) : 0, 1702147
Total [candidate] (12.506 s) : 0, 12505705
section iast_TELEMETRY_OFF
Agent [baseline] (1.708 s) : 0, 1708408
Total [baseline] (12.52 s) : 0, 12519958
Agent [candidate] (1.701 s) : 0, 1700826
Total [candidate] (12.592 s) : 0, 12592210
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.569 s -
Agent iast 1.703 s 134.289 ms (8.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.725 s 156.719 ms (10.0%)
Agent iast_TELEMETRY_OFF 1.708 s 139.687 ms (8.9%)
Total tracing 11.958 s -
Total iast 12.553 s 594.629 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 12.516 s 558.202 ms (4.7%)
Total iast_TELEMETRY_OFF 12.52 s 561.682 ms (4.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.571 s -
Agent iast 1.703 s 132.418 ms (8.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.702 s 131.421 ms (8.4%)
Agent iast_TELEMETRY_OFF 1.701 s 130.101 ms (8.3%)
Total tracing 11.948 s -
Total iast 12.548 s 599.488 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 12.506 s 557.339 ms (4.7%)
Total iast_TELEMETRY_OFF 12.592 s 643.844 ms (5.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (966.155 ms) : 0, 966155
BytebuddyAgent [candidate] (966.314 ms) : 0, 966314
GlobalTracer [baseline] (460.684 ms) : 0, 460684
GlobalTracer [candidate] (462.306 ms) : 0, 462306
AppSec [baseline] (70.635 ms) : 0, 70635
AppSec [candidate] (70.877 ms) : 0, 70877
Remote Config [baseline] (837.174 µs) : 0, 837
Remote Config [candidate] (836.236 µs) : 0, 836
Telemetry [baseline] (9.836 ms) : 0, 9836
Telemetry [candidate] (9.858 ms) : 0, 9858
section iast
BytebuddyAgent [baseline] (1.145 s) : 0, 1144542
BytebuddyAgent [candidate] (1.143 s) : 0, 1143471
GlobalTracer [baseline] (430.643 ms) : 0, 430643
GlobalTracer [candidate] (430.706 ms) : 0, 430706
AppSec [baseline] (66.245 ms) : 0, 66245
AppSec [candidate] (68.578 ms) : 0, 68578
Remote Config [baseline] (789.476 µs) : 0, 789
Remote Config [candidate] (796.939 µs) : 0, 797
Telemetry [baseline] (10.929 ms) : 0, 10929
Telemetry [candidate] (10.778 ms) : 0, 10778
IAST [baseline] (30.15 ms) : 0, 30150
IAST [candidate] (29.038 ms) : 0, 29038
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.159 s) : 0, 1159285
BytebuddyAgent [candidate] (1.144 s) : 0, 1144479
GlobalTracer [baseline] (435.148 ms) : 0, 435148
GlobalTracer [candidate] (429.97 ms) : 0, 429970
AppSec [baseline] (68.087 ms) : 0, 68087
AppSec [candidate] (66.948 ms) : 0, 66948
Remote Config [baseline] (796.714 µs) : 0, 797
Remote Config [candidate] (776.634 µs) : 0, 777
Telemetry [baseline] (10.832 ms) : 0, 10832
Telemetry [candidate] (9.989 ms) : 0, 9989
IAST [baseline] (31.237 ms) : 0, 31237
IAST [candidate] (30.001 ms) : 0, 30001
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.145 s) : 0, 1145447
BytebuddyAgent [candidate] (1.141 s) : 0, 1140696
GlobalTracer [baseline] (431.638 ms) : 0, 431638
GlobalTracer [candidate] (430.787 ms) : 0, 430787
AppSec [baseline] (70.56 ms) : 0, 70560
AppSec [candidate] (69.824 ms) : 0, 69824
Remote Config [baseline] (804.764 µs) : 0, 805
Remote Config [candidate] (748.094 µs) : 0, 748
Telemetry [baseline] (9.786 ms) : 0, 9786
Telemetry [candidate] (9.652 ms) : 0, 9652
IAST [baseline] (30.333 ms) : 0, 30333
IAST [candidate] (29.252 ms) : 0, 29252
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.57 s) : 0, 1569779
Total [baseline] (14.274 s) : 0, 14274281
Agent [candidate] (1.575 s) : 0, 1574839
Total [candidate] (14.3 s) : 0, 14300061
section appsec
Agent [baseline] (1.758 s) : 0, 1758017
Total [baseline] (14.343 s) : 0, 14342538
Agent [candidate] (1.751 s) : 0, 1750606
Total [candidate] (14.317 s) : 0, 14316566
section iast
Agent [baseline] (1.704 s) : 0, 1703581
Total [baseline] (14.82 s) : 0, 14820074
Agent [candidate] (1.709 s) : 0, 1708871
Total [candidate] (14.849 s) : 0, 14849200
section profiling
Agent [baseline] (1.901 s) : 0, 1900565
Total [baseline] (14.653 s) : 0, 14652762
Agent [candidate] (1.895 s) : 0, 1895336
Total [candidate] (14.735 s) : 0, 14734790
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.57 s -
Agent appsec 1.758 s 188.238 ms (12.0%)
Agent iast 1.704 s 133.802 ms (8.5%)
Agent profiling 1.901 s 330.787 ms (21.1%)
Total tracing 14.274 s -
Total appsec 14.343 s 68.257 ms (0.5%)
Total iast 14.82 s 545.793 ms (3.8%)
Total profiling 14.653 s 378.481 ms (2.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.575 s -
Agent appsec 1.751 s 175.767 ms (11.2%)
Agent iast 1.709 s 134.033 ms (8.5%)
Agent profiling 1.895 s 320.497 ms (20.4%)
Total tracing 14.3 s -
Total appsec 14.317 s 16.506 ms (0.1%)
Total iast 14.849 s 549.139 ms (3.8%)
Total profiling 14.735 s 434.729 ms (3.0%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (967.076 ms) : 0, 967076
BytebuddyAgent [candidate] (969.94 ms) : 0, 969940
GlobalTracer [baseline] (460.858 ms) : 0, 460858
GlobalTracer [candidate] (462.127 ms) : 0, 462127
AppSec [baseline] (70.746 ms) : 0, 70746
AppSec [candidate] (71.403 ms) : 0, 71403
Remote Config [baseline] (841.533 µs) : 0, 842
Remote Config [candidate] (838.859 µs) : 0, 839
Telemetry [baseline] (9.837 ms) : 0, 9837
Telemetry [candidate] (9.86 ms) : 0, 9860
section appsec
BytebuddyAgent [baseline] (1.005 s) : 0, 1005202
BytebuddyAgent [candidate] (1.001 s) : 0, 1000606
GlobalTracer [baseline] (438.38 ms) : 0, 438380
GlobalTracer [candidate] (436.976 ms) : 0, 436976
AppSec [baseline] (231.478 ms) : 0, 231478
AppSec [candidate] (230.771 ms) : 0, 230771
Remote Config [baseline] (776.396 µs) : 0, 776
Remote Config [candidate] (781.539 µs) : 0, 782
Telemetry [baseline] (9.289 ms) : 0, 9289
Telemetry [candidate] (8.823 ms) : 0, 8823
IAST [baseline] (24.301 ms) : 0, 24301
IAST [candidate] (24.127 ms) : 0, 24127
section iast
BytebuddyAgent [baseline] (1.143 s) : 0, 1143188
BytebuddyAgent [candidate] (1.146 s) : 0, 1146337
GlobalTracer [baseline] (429.894 ms) : 0, 429894
GlobalTracer [candidate] (432.473 ms) : 0, 432473
AppSec [baseline] (66.878 ms) : 0, 66878
AppSec [candidate] (66.882 ms) : 0, 66882
Remote Config [baseline] (774.229 µs) : 0, 774
Remote Config [candidate] (797.16 µs) : 0, 797
Telemetry [baseline] (12.372 ms) : 0, 12372
Telemetry [candidate] (11.564 ms) : 0, 11564
IAST [baseline] (30.787 ms) : 0, 30787
IAST [candidate] (31.004 ms) : 0, 31004
section profiling
BytebuddyAgent [baseline] (988.163 ms) : 0, 988163
BytebuddyAgent [candidate] (989.254 ms) : 0, 989254
GlobalTracer [baseline] (581.211 ms) : 0, 581211
GlobalTracer [candidate] (579.07 ms) : 0, 579070
AppSec [baseline] (72.26 ms) : 0, 72260
AppSec [candidate] (71.438 ms) : 0, 71438
Remote Config [baseline] (1.018 ms) : 0, 1018
Remote Config [candidate] (1.057 ms) : 0, 1057
Telemetry [baseline] (9.91 ms) : 0, 9910
Telemetry [candidate] (9.842 ms) : 0, 9842
ProfilingAgent [baseline] (154.153 ms) : 0, 154153
ProfilingAgent [candidate] (150.742 ms) : 0, 150742
Profiling [baseline] (154.209 ms) : 0, 154209
Profiling [candidate] (150.804 ms) : 0, 150804
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-05-31T13:42:28 2024-05-31T13:49:20
git_branch master mcculls/improve-agent-service-check
git_commit_date 1717158264 1717161286
git_commit_sha dadbd53 ac4ef66
release_version 1.35.0-SNAPSHOT~dadbd53b67 1.35.0-SNAPSHOT~ac4ef6640e
start_time 2024-05-31T13:42:15 2024-05-31T13:49:07
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717163707 1717163707
ci_job_id 528754141 528754141
ci_pipeline_id 35570992 35570992
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:profiling worse
[+35.570µs; +89.070µs] or [+2.394%; +5.994%]		 unstable
[-639.900op/s; +393.746op/s] or [-19.997%; +12.305%]		 1.548ms 3076.923op/s 1.486ms 3200.000op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.486 µs) : 352, 393
.   : milestone, 372,
iast (487.457 µs) : 466, 509
.   : milestone, 487,
iast_FULL (555.454 µs) : 534, 577
.   : milestone, 555,
iast_GLOBAL (520.726 µs) : 497, 544
.   : milestone, 521,
iast_HARDCODED_SECRET_DISABLED (483.595 µs) : 463, 504
.   : milestone, 484,
iast_INACTIVE (455.259 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (483.399 µs) : 462, 505
.   : milestone, 483,
tracing (451.021 µs) : 430, 472
.   : milestone, 451,
section candidate
no_agent (373.103 µs) : 354, 393
.   : milestone, 373,
iast (485.641 µs) : 464, 507
.   : milestone, 486,
iast_FULL (555.73 µs) : 534, 577
.   : milestone, 556,
iast_GLOBAL (507.454 µs) : 486, 528
.   : milestone, 507,
iast_HARDCODED_SECRET_DISABLED (486.681 µs) : 465, 508
.   : milestone, 487,
iast_INACTIVE (459.806 µs) : 438, 482
.   : milestone, 460,
iast_TELEMETRY_OFF (476.675 µs) : 455, 498
.   : milestone, 477,
tracing (444.871 µs) : 424, 466
.   : milestone, 445,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.486 µs [352.318 µs, 392.654 µs] -
iast 487.457 µs [465.578 µs, 509.336 µs] 114.971 µs (30.9%)
iast_FULL 555.454 µs [534.108 µs, 576.801 µs] 182.968 µs (49.1%)
iast_GLOBAL 520.726 µs [497.288 µs, 544.163 µs] 148.24 µs (39.8%)
iast_HARDCODED_SECRET_DISABLED 483.595 µs [462.738 µs, 504.453 µs] 111.109 µs (29.8%)
iast_INACTIVE 455.259 µs [434.39 µs, 476.128 µs] 82.773 µs (22.2%)
iast_TELEMETRY_OFF 483.399 µs [461.933 µs, 504.865 µs] 110.913 µs (29.8%)
tracing 451.021 µs [429.905 µs, 472.138 µs] 78.535 µs (21.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.103 µs [353.682 µs, 392.524 µs] -
iast 485.641 µs [464.415 µs, 506.866 µs] 112.538 µs (30.2%)
iast_FULL 555.73 µs [534.369 µs, 577.092 µs] 182.627 µs (48.9%)
iast_GLOBAL 507.454 µs [486.478 µs, 528.431 µs] 134.351 µs (36.0%)
iast_HARDCODED_SECRET_DISABLED 486.681 µs [465.132 µs, 508.23 µs] 113.578 µs (30.4%)
iast_INACTIVE 459.806 µs [438.032 µs, 481.58 µs] 86.703 µs (23.2%)
iast_TELEMETRY_OFF 476.675 µs [455.023 µs, 498.326 µs] 103.571 µs (27.8%)
tracing 444.871 µs [423.954 µs, 465.788 µs] 71.768 µs (19.2%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.349 ms) : 1330, 1368
.   : milestone, 1349,
appsec (1.731 ms) : 1708, 1754
.   : milestone, 1731,
appsec_no_iast (1.716 ms) : 1691, 1740
.   : milestone, 1716,
iast (1.509 ms) : 1486, 1533
.   : milestone, 1509,
profiling (1.486 ms) : 1461, 1511
.   : milestone, 1486,
tracing (1.485 ms) : 1460, 1509
.   : milestone, 1485,
section candidate
no_agent (1.345 ms) : 1324, 1365
.   : milestone, 1345,
appsec (1.735 ms) : 1711, 1759
.   : milestone, 1735,
appsec_no_iast (1.719 ms) : 1695, 1744
.   : milestone, 1719,
iast (1.483 ms) : 1460, 1506
.   : milestone, 1483,
profiling (1.548 ms) : 1523, 1573
.   : milestone, 1548,
tracing (1.486 ms) : 1461, 1510
.   : milestone, 1486,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.349 ms [1.33 ms, 1.368 ms] -
appsec 1.731 ms [1.708 ms, 1.754 ms] 381.718 µs (28.3%)
appsec_no_iast 1.716 ms [1.691 ms, 1.74 ms] 366.561 µs (27.2%)
iast 1.509 ms [1.486 ms, 1.533 ms] 160.188 µs (11.9%)
profiling 1.486 ms [1.461 ms, 1.511 ms] 136.78 µs (10.1%)
tracing 1.485 ms [1.46 ms, 1.509 ms] 135.583 µs (10.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.345 ms [1.324 ms, 1.365 ms] -
appsec 1.735 ms [1.711 ms, 1.759 ms] 390.688 µs (29.1%)
appsec_no_iast 1.719 ms [1.695 ms, 1.744 ms] 374.7 µs (27.9%)
iast 1.483 ms [1.46 ms, 1.506 ms] 138.653 µs (10.3%)
profiling 1.548 ms [1.523 ms, 1.573 ms] 203.791 µs (15.2%)
tracing 1.486 ms [1.461 ms, 1.51 ms] 140.95 µs (10.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/improve-agent-service-check
git_commit_date 1717158264 1717161286
git_commit_sha dadbd53 ac4ef66
release_version 1.35.0-SNAPSHOT~dadbd53b67 1.35.0-SNAPSHOT~ac4ef6640e
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1717164316 1717164316
ci_job_id 528754142 528754142
ci_pipeline_id 35570992 35570992
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.458 ms) : 1447, 1470
.   : milestone, 1458,
appsec (2.182 ms) : 2149, 2215
.   : milestone, 2182,
iast (1.958 ms) : 1917, 1999
.   : milestone, 1958,
iast_GLOBAL (2.0 ms) : 1959, 2041
.   : milestone, 2000,
profiling (1.833 ms) : 1801, 1865
.   : milestone, 1833,
tracing (1.828 ms) : 1796, 1860
.   : milestone, 1828,
section candidate
no_agent (1.461 ms) : 1449, 1472
.   : milestone, 1461,
appsec (2.187 ms) : 2153, 2220
.   : milestone, 2187,
iast (1.953 ms) : 1912, 1994
.   : milestone, 1953,
iast_GLOBAL (1.996 ms) : 1955, 2037
.   : milestone, 1996,
profiling (1.832 ms) : 1799, 1864
.   : milestone, 1832,
tracing (1.82 ms) : 1789, 1852
.   : milestone, 1820,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.458 ms [1.447 ms, 1.47 ms] -
appsec 2.182 ms [2.149 ms, 2.215 ms] 723.619 µs (49.6%)
iast 1.958 ms [1.917 ms, 1.999 ms] 500.004 µs (34.3%)
iast_GLOBAL 2.0 ms [1.959 ms, 2.041 ms] 541.579 µs (37.1%)
profiling 1.833 ms [1.801 ms, 1.865 ms] 374.446 µs (25.7%)
tracing 1.828 ms [1.796 ms, 1.86 ms] 369.757 µs (25.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.461 ms [1.449 ms, 1.472 ms] -
appsec 2.187 ms [2.153 ms, 2.22 ms] 725.921 µs (49.7%)
iast 1.953 ms [1.912 ms, 1.994 ms] 491.828 µs (33.7%)
iast_GLOBAL 1.996 ms [1.955 ms, 2.037 ms] 535.212 µs (36.6%)
profiling 1.832 ms [1.799 ms, 1.864 ms] 370.884 µs (25.4%)
tracing 1.82 ms [1.789 ms, 1.852 ms] 359.56 µs (24.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~ac4ef6640e, baseline=1.35.0-SNAPSHOT~dadbd53b67
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.434 s) : 15434000, 15434000
.   : milestone, 15434000,
appsec (15.163 s) : 15163000, 15163000
.   : milestone, 15163000,
iast (18.678 s) : 18678000, 18678000
.   : milestone, 18678000,
iast_GLOBAL (17.737 s) : 17737000, 17737000
.   : milestone, 17737000,
profiling (15.2 s) : 15200000, 15200000
.   : milestone, 15200000,
tracing (14.955 s) : 14955000, 14955000
.   : milestone, 14955000,
section candidate
no_agent (15.436 s) : 15436000, 15436000
.   : milestone, 15436000,
appsec (15.271 s) : 15271000, 15271000
.   : milestone, 15271000,
iast (18.828 s) : 18828000, 18828000
.   : milestone, 18828000,
iast_GLOBAL (17.944 s) : 17944000, 17944000
.   : milestone, 17944000,
profiling (15.219 s) : 15219000, 15219000
.   : milestone, 15219000,
tracing (15.166 s) : 15166000, 15166000
.   : milestone, 15166000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.434 s [15.434 s, 15.434 s] -
appsec 15.163 s [15.163 s, 15.163 s] -271.0 ms (-1.8%)
iast 18.678 s [18.678 s, 18.678 s] 3.244 s (21.0%)
iast_GLOBAL 17.737 s [17.737 s, 17.737 s] 2.303 s (14.9%)
profiling 15.2 s [15.2 s, 15.2 s] -234.0 ms (-1.5%)
tracing 14.955 s [14.955 s, 14.955 s] -479.0 ms (-3.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.436 s [15.436 s, 15.436 s] -
appsec 15.271 s [15.271 s, 15.271 s] -165.0 ms (-1.1%)
iast 18.828 s [18.828 s, 18.828 s] 3.392 s (22.0%)
iast_GLOBAL 17.944 s [17.944 s, 17.944 s] 2.508 s (16.2%)
profiling 15.219 s [15.219 s, 15.219 s] -217.0 ms (-1.4%)
tracing 15.166 s [15.166 s, 15.166 s] -270.0 ms (-1.7%)

@mcculls mcculls force-pushed the mcculls/improve-agent-service-check branch from 35b0340 to ac4ef66 Compare May 31, 2024 13:14
@mcculls mcculls enabled auto-merge (squash) May 31, 2024 16:36
@mcculls mcculls merged commit fccff88 into master Jun 3, 2024
81 checks passed
@mcculls mcculls deleted the mcculls/improve-agent-service-check branch June 3, 2024 12:50
@github-actions github-actions bot added this to the 1.35.0 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am312 am312 am312 approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: core Tracer core tag: diagnostics Diagnostics related changes
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mcculls @am312