Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isRemote to DDSpanContext #7108

Merged
merged 5 commits into from
Jun 3, 2024
Merged

Add isRemote to DDSpanContext #7108

merged 5 commits into from
Jun 3, 2024

Conversation

am312
Copy link
Contributor

@am312 am312 commented Jun 1, 2024 •
edited by jira bot
Loading

What Does This Do

Adds isRemote() to DDSpanContext similarly to how it was added to other trace agents per W3C phase 2 requirements.

Motivation

Required by #7067

Jira ticket: [AIT-9906]

@am312 am312 changed the title add isRemote add isRemote to DDSpanContext Jun 1, 2024
@am312 am312 added the tag: no release notes Changes to exclude from release notes label Jun 1, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jun 1, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrew.munn/is-remote
git_commit_date 1717427688 1717427649
git_commit_sha bf9fd09 fa17a58
release_version 1.35.0-SNAPSHOT~bf9fd09c02 1.35.0-SNAPSHOT~fa17a5849d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717430705 1717430705
ci_job_id 530555596 530555596
ci_pipeline_id 35707299 35707299
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 17 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079922
Total [baseline] (8.588 s) : 0, 8588071
Agent [candidate] (1.065 s) : 0, 1064520
Total [candidate] (8.553 s) : 0, 8552517
section iast
Agent [baseline] (1.165 s) : 0, 1164804
Total [baseline] (8.966 s) : 0, 8965895
Agent [candidate] (1.168 s) : 0, 1167907
Total [candidate] (9.027 s) : 0, 9026678
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1174479
Total [baseline] (8.997 s) : 0, 8997331
Agent [candidate] (1.177 s) : 0, 1176914
Total [candidate] (8.974 s) : 0, 8973789
section iast_TELEMETRY_OFF
Agent [baseline] (1.161 s) : 0, 1160553
Total [baseline] (8.98 s) : 0, 8979952
Agent [candidate] (1.172 s) : 0, 1171862
Total [candidate] (8.981 s) : 0, 8981185
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.08 s -
Agent iast 1.165 s 84.882 ms (7.9%)
Agent iast_HARDCODED_SECRET_DISABLED 1.174 s 94.557 ms (8.8%)
Agent iast_TELEMETRY_OFF 1.161 s 80.632 ms (7.5%)
Total tracing 8.588 s -
Total iast 8.966 s 377.824 ms (4.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.997 s 409.259 ms (4.8%)
Total iast_TELEMETRY_OFF 8.98 s 391.881 ms (4.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.065 s -
Agent iast 1.168 s 103.387 ms (9.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.177 s 112.394 ms (10.6%)
Agent iast_TELEMETRY_OFF 1.172 s 107.343 ms (10.1%)
Total tracing 8.553 s -
Total iast 9.027 s 474.161 ms (5.5%)
Total iast_HARDCODED_SECRET_DISABLED 8.974 s 421.272 ms (4.9%)
Total iast_TELEMETRY_OFF 8.981 s 428.668 ms (5.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.417 ms) : 0, 666417
BytebuddyAgent [candidate] (656.602 ms) : 0, 656602
GlobalTracer [baseline] (319.325 ms) : 0, 319325
GlobalTracer [candidate] (314.979 ms) : 0, 314979
AppSec [baseline] (50.773 ms) : 0, 50773
AppSec [candidate] (50.031 ms) : 0, 50031
Remote Config [baseline] (680.448 µs) : 0, 680
Remote Config [candidate] (668.969 µs) : 0, 669
Telemetry [baseline] (7.703 ms) : 0, 7703
Telemetry [candidate] (7.6 ms) : 0, 7600
section iast
BytebuddyAgent [baseline] (776.902 ms) : 0, 776902
BytebuddyAgent [candidate] (779.238 ms) : 0, 779238
GlobalTracer [baseline] (292.401 ms) : 0, 292401
GlobalTracer [candidate] (292.833 ms) : 0, 292833
AppSec [baseline] (49.957 ms) : 0, 49957
AppSec [candidate] (48.147 ms) : 0, 48147
IAST [baseline] (24.052 ms) : 0, 24052
IAST [candidate] (26.233 ms) : 0, 26233
Remote Config [baseline] (602.345 µs) : 0, 602
Remote Config [candidate] (588.723 µs) : 0, 589
Telemetry [baseline] (7.661 ms) : 0, 7661
Telemetry [candidate] (7.603 ms) : 0, 7603
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (784.133 ms) : 0, 784133
BytebuddyAgent [candidate] (785.384 ms) : 0, 785384
GlobalTracer [baseline] (295.122 ms) : 0, 295122
GlobalTracer [candidate] (294.748 ms) : 0, 294748
AppSec [baseline] (49.379 ms) : 0, 49379
AppSec [candidate] (49.956 ms) : 0, 49956
IAST [baseline] (23.433 ms) : 0, 23433
IAST [candidate] (25.899 ms) : 0, 25899
Remote Config [baseline] (605.313 µs) : 0, 605
Remote Config [candidate] (602.99 µs) : 0, 603
Telemetry [baseline] (8.412 ms) : 0, 8412
Telemetry [candidate] (6.931 ms) : 0, 6931
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (774.204 ms) : 0, 774204
BytebuddyAgent [candidate] (781.387 ms) : 0, 781387
GlobalTracer [baseline] (291.962 ms) : 0, 291962
GlobalTracer [candidate] (294.593 ms) : 0, 294593
AppSec [baseline] (50.386 ms) : 0, 50386
AppSec [candidate] (50.895 ms) : 0, 50895
IAST [baseline] (23.36 ms) : 0, 23360
IAST [candidate] (24.254 ms) : 0, 24254
Remote Config [baseline] (595.543 µs) : 0, 596
Remote Config [candidate] (599.46 µs) : 0, 599
Telemetry [baseline] (6.741 ms) : 0, 6741
Telemetry [candidate] (6.768 ms) : 0, 6768
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054963
Total [baseline] (10.29 s) : 0, 10290262
Agent [candidate] (1.072 s) : 0, 1072275
Total [candidate] (10.392 s) : 0, 10392243
section appsec
Agent [baseline] (1.176 s) : 0, 1176307
Total [baseline] (10.493 s) : 0, 10493242
Agent [candidate] (1.175 s) : 0, 1175303
Total [candidate] (10.424 s) : 0, 10423524
section iast
Agent [baseline] (1.174 s) : 0, 1174076
Total [baseline] (10.744 s) : 0, 10744452
Agent [candidate] (1.175 s) : 0, 1174839
Total [candidate] (10.76 s) : 0, 10760282
section profiling
Agent [baseline] (1.27 s) : 0, 1269611
Total [baseline] (10.634 s) : 0, 10634046
Agent [candidate] (1.256 s) : 0, 1255965
Total [candidate] (10.581 s) : 0, 10581051
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.176 s 121.344 ms (11.5%)
Agent iast 1.174 s 119.113 ms (11.3%)
Agent profiling 1.27 s 214.648 ms (20.3%)
Total tracing 10.29 s -
Total appsec 10.493 s 202.98 ms (2.0%)
Total iast 10.744 s 454.19 ms (4.4%)
Total profiling 10.634 s 343.783 ms (3.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.072 s -
Agent appsec 1.175 s 103.028 ms (9.6%)
Agent iast 1.175 s 102.565 ms (9.6%)
Agent profiling 1.256 s 183.691 ms (17.1%)
Total tracing 10.392 s -
Total appsec 10.424 s 31.281 ms (0.3%)
Total iast 10.76 s 368.039 ms (3.5%)
Total profiling 10.581 s 188.808 ms (1.8%) 
gantt
    title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (650.392 ms) : 0, 650392
BytebuddyAgent [candidate] (661.504 ms) : 0, 661504
GlobalTracer [baseline] (312.486 ms) : 0, 312486
GlobalTracer [candidate] (317.268 ms) : 0, 317268
AppSec [baseline] (49.64 ms) : 0, 49640
AppSec [candidate] (50.315 ms) : 0, 50315
Remote Config [baseline] (658.156 µs) : 0, 658
Remote Config [candidate] (669.886 µs) : 0, 670
Telemetry [baseline] (7.537 ms) : 0, 7537
Telemetry [candidate] (7.62 ms) : 0, 7620
section appsec
BytebuddyAgent [baseline] (675.419 ms) : 0, 675419
BytebuddyAgent [candidate] (673.835 ms) : 0, 673835
GlobalTracer [baseline] (295.585 ms) : 0, 295585
GlobalTracer [candidate] (296.157 ms) : 0, 296157
AppSec [baseline] (151.853 ms) : 0, 151853
AppSec [candidate] (152.69 ms) : 0, 152690
IAST [baseline] (18.665 ms) : 0, 18665
IAST [candidate] (18.713 ms) : 0, 18713
Remote Config [baseline] (618.986 µs) : 0, 619
Remote Config [candidate] (624.399 µs) : 0, 624
Telemetry [baseline] (9.042 ms) : 0, 9042
Telemetry [candidate] (8.136 ms) : 0, 8136
section iast
BytebuddyAgent [baseline] (785.458 ms) : 0, 785458
BytebuddyAgent [candidate] (784.072 ms) : 0, 784072
GlobalTracer [baseline] (294.931 ms) : 0, 294931
GlobalTracer [candidate] (294.438 ms) : 0, 294438
AppSec [baseline] (47.088 ms) : 0, 47088
AppSec [candidate] (49.149 ms) : 0, 49149
IAST [baseline] (24.259 ms) : 0, 24259
IAST [candidate] (24.099 ms) : 0, 24099
Remote Config [baseline] (598.884 µs) : 0, 599
Remote Config [candidate] (608.96 µs) : 0, 609
Telemetry [baseline] (8.422 ms) : 0, 8422
Telemetry [candidate] (9.16 ms) : 0, 9160
section profiling
BytebuddyAgent [baseline] (669.81 ms) : 0, 669810
BytebuddyAgent [candidate] (660.276 ms) : 0, 660276
GlobalTracer [baseline] (387.436 ms) : 0, 387436
GlobalTracer [candidate] (384.722 ms) : 0, 384722
AppSec [baseline] (50.778 ms) : 0, 50778
AppSec [candidate] (50.515 ms) : 0, 50515
Remote Config [baseline] (801.573 µs) : 0, 802
Remote Config [candidate] (842.364 µs) : 0, 842
Telemetry [baseline] (7.554 ms) : 0, 7554
Telemetry [candidate] (7.426 ms) : 0, 7426
ProfilingAgent [baseline] (95.964 ms) : 0, 95964
ProfilingAgent [candidate] (95.722 ms) : 0, 95722
Profiling [baseline] (95.99 ms) : 0, 95990
Profiling [candidate] (95.747 ms) : 0, 95747
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-03T15:36:00 2024-06-03T15:42:49
git_branch master andrew.munn/is-remote
git_commit_date 1717427688 1717427649
git_commit_sha bf9fd09 fa17a58
release_version 1.35.0-SNAPSHOT~bf9fd09c02 1.35.0-SNAPSHOT~fa17a5849d
start_time 2024-06-03T15:35:47 2024-06-03T15:42:36
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1717429715 1717429715
ci_job_id 530555597 530555597
ci_pipeline_id 35707299 35707299
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.342 ms) : 1323, 1362
.   : milestone, 1342,
appsec (1.71 ms) : 1686, 1735
.   : milestone, 1710,
appsec_no_iast (1.701 ms) : 1676, 1726
.   : milestone, 1701,
iast (1.475 ms) : 1452, 1498
.   : milestone, 1475,
profiling (1.479 ms) : 1455, 1503
.   : milestone, 1479,
tracing (1.466 ms) : 1440, 1492
.   : milestone, 1466,
section candidate
no_agent (1.334 ms) : 1314, 1353
.   : milestone, 1334,
appsec (1.728 ms) : 1704, 1752
.   : milestone, 1728,
appsec_no_iast (1.721 ms) : 1697, 1745
.   : milestone, 1721,
iast (1.474 ms) : 1452, 1497
.   : milestone, 1474,
profiling (1.533 ms) : 1508, 1559
.   : milestone, 1533,
tracing (1.455 ms) : 1430, 1480
.   : milestone, 1455,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.323 ms, 1.362 ms] -
appsec 1.71 ms [1.686 ms, 1.735 ms] 367.987 µs (27.4%)
appsec_no_iast 1.701 ms [1.676 ms, 1.726 ms] 358.28 µs (26.7%)
iast 1.475 ms [1.452 ms, 1.498 ms] 132.517 µs (9.9%)
profiling 1.479 ms [1.455 ms, 1.503 ms] 136.456 µs (10.2%)
tracing 1.466 ms [1.44 ms, 1.492 ms] 123.372 µs (9.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.334 ms [1.314 ms, 1.353 ms] -
appsec 1.728 ms [1.704 ms, 1.752 ms] 394.497 µs (29.6%)
appsec_no_iast 1.721 ms [1.697 ms, 1.745 ms] 387.428 µs (29.0%)
iast 1.474 ms [1.452 ms, 1.497 ms] 140.444 µs (10.5%)
profiling 1.533 ms [1.508 ms, 1.559 ms] 199.353 µs (14.9%)
tracing 1.455 ms [1.43 ms, 1.48 ms] 121.055 µs (9.1%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02
    dateFormat X
    axisFormat %s
section baseline
no_agent (368.311 µs) : 347, 389
.   : milestone, 368,
iast (485.397 µs) : 464, 507
.   : milestone, 485,
iast_FULL (553.678 µs) : 533, 575
.   : milestone, 554,
iast_GLOBAL (508.198 µs) : 486, 530
.   : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (481.243 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (453.59 µs) : 432, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (471.365 µs) : 450, 493
.   : milestone, 471,
tracing (440.244 µs) : 420, 461
.   : milestone, 440,
section candidate
no_agent (370.012 µs) : 350, 390
.   : milestone, 370,
iast (482.591 µs) : 462, 504
.   : milestone, 483,
iast_FULL (553.589 µs) : 532, 575
.   : milestone, 554,
iast_GLOBAL (500.417 µs) : 479, 522
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (486.51 µs) : 465, 508
.   : milestone, 487,
iast_INACTIVE (455.4 µs) : 434, 477
.   : milestone, 455,
iast_TELEMETRY_OFF (474.212 µs) : 453, 495
.   : milestone, 474,
tracing (439.206 µs) : 418, 460
.   : milestone, 439,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 368.311 µs [347.423 µs, 389.199 µs] -
iast 485.397 µs [464.202 µs, 506.593 µs] 117.086 µs (31.8%)
iast_FULL 553.678 µs [532.537 µs, 574.818 µs] 185.367 µs (50.3%)
iast_GLOBAL 508.198 µs [486.435 µs, 529.962 µs] 139.887 µs (38.0%)
iast_HARDCODED_SECRET_DISABLED 481.243 µs [460.074 µs, 502.413 µs] 112.932 µs (30.7%)
iast_INACTIVE 453.59 µs [432.202 µs, 474.977 µs] 85.278 µs (23.2%)
iast_TELEMETRY_OFF 471.365 µs [450.141 µs, 492.589 µs] 103.054 µs (28.0%)
tracing 440.244 µs [419.77 µs, 460.717 µs] 71.932 µs (19.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 370.012 µs [350.18 µs, 389.845 µs] -
iast 482.591 µs [461.534 µs, 503.649 µs] 112.579 µs (30.4%)
iast_FULL 553.589 µs [532.155 µs, 575.024 µs] 183.577 µs (49.6%)
iast_GLOBAL 500.417 µs [478.85 µs, 521.985 µs] 130.405 µs (35.2%)
iast_HARDCODED_SECRET_DISABLED 486.51 µs [465.014 µs, 508.006 µs] 116.497 µs (31.5%)
iast_INACTIVE 455.4 µs [433.624 µs, 477.175 µs] 85.387 µs (23.1%)
iast_TELEMETRY_OFF 474.212 µs [453.007 µs, 495.417 µs] 104.2 µs (28.2%)
tracing 439.206 µs [418.282 µs, 460.13 µs] 69.193 µs (18.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrew.munn/is-remote
git_commit_date 1717427688 1717427649
git_commit_sha bf9fd09 fa17a58
release_version 1.35.0-SNAPSHOT~bf9fd09c02 1.35.0-SNAPSHOT~fa17a5849d
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1717430230 1717430230
ci_job_id 530555598 530555598
ci_pipeline_id 35707299 35707299
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.008 s) : 15008000, 15008000
.   : milestone, 15008000,
appsec (14.963 s) : 14963000, 14963000
.   : milestone, 14963000,
iast (18.678 s) : 18678000, 18678000
.   : milestone, 18678000,
iast_GLOBAL (17.929 s) : 17929000, 17929000
.   : milestone, 17929000,
profiling (15.777 s) : 15777000, 15777000
.   : milestone, 15777000,
tracing (15.149 s) : 15149000, 15149000
.   : milestone, 15149000,
section candidate
no_agent (14.809 s) : 14809000, 14809000
.   : milestone, 14809000,
appsec (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
iast (19.005 s) : 19005000, 19005000
.   : milestone, 19005000,
iast_GLOBAL (17.786 s) : 17786000, 17786000
.   : milestone, 17786000,
profiling (15.872 s) : 15872000, 15872000
.   : milestone, 15872000,
tracing (15.091 s) : 15091000, 15091000
.   : milestone, 15091000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.008 s [15.008 s, 15.008 s] -
appsec 14.963 s [14.963 s, 14.963 s] -45.0 ms (-0.3%)
iast 18.678 s [18.678 s, 18.678 s] 3.67 s (24.5%)
iast_GLOBAL 17.929 s [17.929 s, 17.929 s] 2.921 s (19.5%)
profiling 15.777 s [15.777 s, 15.777 s] 769.0 ms (5.1%)
tracing 15.149 s [15.149 s, 15.149 s] 141.0 ms (0.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.809 s [14.809 s, 14.809 s] -
appsec 14.998 s [14.998 s, 14.998 s] 189.0 ms (1.3%)
iast 19.005 s [19.005 s, 19.005 s] 4.196 s (28.3%)
iast_GLOBAL 17.786 s [17.786 s, 17.786 s] 2.977 s (20.1%)
profiling 15.872 s [15.872 s, 15.872 s] 1.063 s (7.2%)
tracing 15.091 s [15.091 s, 15.091 s] 282.0 ms (1.9%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.455 ms) : 1444, 1467
.   : milestone, 1455,
appsec (2.177 ms) : 2143, 2210
.   : milestone, 2177,
iast (1.943 ms) : 1902, 1983
.   : milestone, 1943,
iast_GLOBAL (1.987 ms) : 1947, 2027
.   : milestone, 1987,
profiling (1.831 ms) : 1799, 1864
.   : milestone, 1831,
tracing (1.82 ms) : 1788, 1852
.   : milestone, 1820,
section candidate
no_agent (1.459 ms) : 1448, 1471
.   : milestone, 1459,
appsec (2.184 ms) : 2151, 2218
.   : milestone, 2184,
iast (1.95 ms) : 1909, 1991
.   : milestone, 1950,
iast_GLOBAL (1.989 ms) : 1948, 2030
.   : milestone, 1989,
profiling (1.84 ms) : 1807, 1874
.   : milestone, 1840,
tracing (1.823 ms) : 1792, 1855
.   : milestone, 1823,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.455 ms [1.444 ms, 1.467 ms] -
appsec 2.177 ms [2.143 ms, 2.21 ms] 721.443 µs (49.6%)
iast 1.943 ms [1.902 ms, 1.983 ms] 487.233 µs (33.5%)
iast_GLOBAL 1.987 ms [1.947 ms, 2.027 ms] 531.67 µs (36.5%)
profiling 1.831 ms [1.799 ms, 1.864 ms] 376.07 µs (25.8%)
tracing 1.82 ms [1.788 ms, 1.852 ms] 364.716 µs (25.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.459 ms [1.448 ms, 1.471 ms] -
appsec 2.184 ms [2.151 ms, 2.218 ms] 725.388 µs (49.7%)
iast 1.95 ms [1.909 ms, 1.991 ms] 490.666 µs (33.6%)
iast_GLOBAL 1.989 ms [1.948 ms, 2.03 ms] 530.24 µs (36.3%)
profiling 1.84 ms [1.807 ms, 1.874 ms] 381.398 µs (26.1%)
tracing 1.823 ms [1.792 ms, 1.855 ms] 364.397 µs (25.0%)

@am312 am312 added the comp: context propagation Trace context propagation label Jun 1, 2024
mcculls
mcculls requested changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@mcculls mcculls left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't need so many changes, why not just:

  • add the isRemote argument to just the one DDSpanContext constructor used by CoreTracer.buildSpanContext
  • then update CoreTracer.buildSpanContext to set isRemote to true in the existing block where parentContext instanceof ExtractedContext and false everywhere else

You don't need to update all the other constructors, just let them default isRemote to false when calling the updated constructor.

Also whenever you add elements to a constructor, consider creating a new constructor with the additional argument and having the old constructor delegate to the new one with a default for the new argument. (Whether this is appropriate depends on how many places call the original constructor.)

@am312
Copy link
Contributor Author

am312 commented Jun 3, 2024

just let them default isRemote to false when calling the updated constructor.

Updated as suggested, thanks. I originally thought passing a default value would not be possible because each test would now need to be evaluated to see if it is remote or not otherwise the default value may be inaccurate. If the CoreTracer.buildSpanContext usage you mention is the only place where isRemote==true then that simplifies things a lot.

Do you know if DDCoreSpecification can safely default to false here too?

@mcculls
Copy link
Contributor

mcculls commented Jun 3, 2024

Do you know if DDCoreSpecification can safely default to false here too?

Yes, since the buildSpan method is used to test local span behaviour - any new tests that need iRemote=true could use a new method such as buildRemoteSpan.

@am312 am312 marked this pull request as ready for review June 3, 2024 16:23
@am312 am312 requested a review from a team as a code owner June 3, 2024 16:23
@am312 am312 requested review from mcculls and dougqh June 3, 2024 16:23
@am312 am312 merged commit a155857 into master Jun 3, 2024
81 checks passed
@am312 am312 deleted the andrew.munn/is-remote branch June 3, 2024 16:51
@github-actions github-actions bot added this to the 1.35.0 milestone Jun 3, 2024
@PerfectSlayer PerfectSlayer changed the title add isRemote to DDSpanContext Add isRemote to DDSpanContext Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcculls mcculls mcculls approved these changes

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: context propagation Trace context propagation tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@am312 @mcculls