-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isRemote to DDSpanContext #7108
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 17 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.08 s) : 0, 1079922
Total [baseline] (8.588 s) : 0, 8588071
Agent [candidate] (1.065 s) : 0, 1064520
Total [candidate] (8.553 s) : 0, 8552517
section iast
Agent [baseline] (1.165 s) : 0, 1164804
Total [baseline] (8.966 s) : 0, 8965895
Agent [candidate] (1.168 s) : 0, 1167907
Total [candidate] (9.027 s) : 0, 9026678
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1174479
Total [baseline] (8.997 s) : 0, 8997331
Agent [candidate] (1.177 s) : 0, 1176914
Total [candidate] (8.974 s) : 0, 8973789
section iast_TELEMETRY_OFF
Agent [baseline] (1.161 s) : 0, 1160553
Total [baseline] (8.98 s) : 0, 8979952
Agent [candidate] (1.172 s) : 0, 1171862
Total [candidate] (8.981 s) : 0, 8981185
gantt
title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.417 ms) : 0, 666417
BytebuddyAgent [candidate] (656.602 ms) : 0, 656602
GlobalTracer [baseline] (319.325 ms) : 0, 319325
GlobalTracer [candidate] (314.979 ms) : 0, 314979
AppSec [baseline] (50.773 ms) : 0, 50773
AppSec [candidate] (50.031 ms) : 0, 50031
Remote Config [baseline] (680.448 µs) : 0, 680
Remote Config [candidate] (668.969 µs) : 0, 669
Telemetry [baseline] (7.703 ms) : 0, 7703
Telemetry [candidate] (7.6 ms) : 0, 7600
section iast
BytebuddyAgent [baseline] (776.902 ms) : 0, 776902
BytebuddyAgent [candidate] (779.238 ms) : 0, 779238
GlobalTracer [baseline] (292.401 ms) : 0, 292401
GlobalTracer [candidate] (292.833 ms) : 0, 292833
AppSec [baseline] (49.957 ms) : 0, 49957
AppSec [candidate] (48.147 ms) : 0, 48147
IAST [baseline] (24.052 ms) : 0, 24052
IAST [candidate] (26.233 ms) : 0, 26233
Remote Config [baseline] (602.345 µs) : 0, 602
Remote Config [candidate] (588.723 µs) : 0, 589
Telemetry [baseline] (7.661 ms) : 0, 7661
Telemetry [candidate] (7.603 ms) : 0, 7603
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (784.133 ms) : 0, 784133
BytebuddyAgent [candidate] (785.384 ms) : 0, 785384
GlobalTracer [baseline] (295.122 ms) : 0, 295122
GlobalTracer [candidate] (294.748 ms) : 0, 294748
AppSec [baseline] (49.379 ms) : 0, 49379
AppSec [candidate] (49.956 ms) : 0, 49956
IAST [baseline] (23.433 ms) : 0, 23433
IAST [candidate] (25.899 ms) : 0, 25899
Remote Config [baseline] (605.313 µs) : 0, 605
Remote Config [candidate] (602.99 µs) : 0, 603
Telemetry [baseline] (8.412 ms) : 0, 8412
Telemetry [candidate] (6.931 ms) : 0, 6931
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (774.204 ms) : 0, 774204
BytebuddyAgent [candidate] (781.387 ms) : 0, 781387
GlobalTracer [baseline] (291.962 ms) : 0, 291962
GlobalTracer [candidate] (294.593 ms) : 0, 294593
AppSec [baseline] (50.386 ms) : 0, 50386
AppSec [candidate] (50.895 ms) : 0, 50895
IAST [baseline] (23.36 ms) : 0, 23360
IAST [candidate] (24.254 ms) : 0, 24254
Remote Config [baseline] (595.543 µs) : 0, 596
Remote Config [candidate] (599.46 µs) : 0, 599
Telemetry [baseline] (6.741 ms) : 0, 6741
Telemetry [candidate] (6.768 ms) : 0, 6768
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054963
Total [baseline] (10.29 s) : 0, 10290262
Agent [candidate] (1.072 s) : 0, 1072275
Total [candidate] (10.392 s) : 0, 10392243
section appsec
Agent [baseline] (1.176 s) : 0, 1176307
Total [baseline] (10.493 s) : 0, 10493242
Agent [candidate] (1.175 s) : 0, 1175303
Total [candidate] (10.424 s) : 0, 10423524
section iast
Agent [baseline] (1.174 s) : 0, 1174076
Total [baseline] (10.744 s) : 0, 10744452
Agent [candidate] (1.175 s) : 0, 1174839
Total [candidate] (10.76 s) : 0, 10760282
section profiling
Agent [baseline] (1.27 s) : 0, 1269611
Total [baseline] (10.634 s) : 0, 10634046
Agent [candidate] (1.256 s) : 0, 1255965
Total [candidate] (10.581 s) : 0, 10581051
gantt
title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (650.392 ms) : 0, 650392
BytebuddyAgent [candidate] (661.504 ms) : 0, 661504
GlobalTracer [baseline] (312.486 ms) : 0, 312486
GlobalTracer [candidate] (317.268 ms) : 0, 317268
AppSec [baseline] (49.64 ms) : 0, 49640
AppSec [candidate] (50.315 ms) : 0, 50315
Remote Config [baseline] (658.156 µs) : 0, 658
Remote Config [candidate] (669.886 µs) : 0, 670
Telemetry [baseline] (7.537 ms) : 0, 7537
Telemetry [candidate] (7.62 ms) : 0, 7620
section appsec
BytebuddyAgent [baseline] (675.419 ms) : 0, 675419
BytebuddyAgent [candidate] (673.835 ms) : 0, 673835
GlobalTracer [baseline] (295.585 ms) : 0, 295585
GlobalTracer [candidate] (296.157 ms) : 0, 296157
AppSec [baseline] (151.853 ms) : 0, 151853
AppSec [candidate] (152.69 ms) : 0, 152690
IAST [baseline] (18.665 ms) : 0, 18665
IAST [candidate] (18.713 ms) : 0, 18713
Remote Config [baseline] (618.986 µs) : 0, 619
Remote Config [candidate] (624.399 µs) : 0, 624
Telemetry [baseline] (9.042 ms) : 0, 9042
Telemetry [candidate] (8.136 ms) : 0, 8136
section iast
BytebuddyAgent [baseline] (785.458 ms) : 0, 785458
BytebuddyAgent [candidate] (784.072 ms) : 0, 784072
GlobalTracer [baseline] (294.931 ms) : 0, 294931
GlobalTracer [candidate] (294.438 ms) : 0, 294438
AppSec [baseline] (47.088 ms) : 0, 47088
AppSec [candidate] (49.149 ms) : 0, 49149
IAST [baseline] (24.259 ms) : 0, 24259
IAST [candidate] (24.099 ms) : 0, 24099
Remote Config [baseline] (598.884 µs) : 0, 599
Remote Config [candidate] (608.96 µs) : 0, 609
Telemetry [baseline] (8.422 ms) : 0, 8422
Telemetry [candidate] (9.16 ms) : 0, 9160
section profiling
BytebuddyAgent [baseline] (669.81 ms) : 0, 669810
BytebuddyAgent [candidate] (660.276 ms) : 0, 660276
GlobalTracer [baseline] (387.436 ms) : 0, 387436
GlobalTracer [candidate] (384.722 ms) : 0, 384722
AppSec [baseline] (50.778 ms) : 0, 50778
AppSec [candidate] (50.515 ms) : 0, 50515
Remote Config [baseline] (801.573 µs) : 0, 802
Remote Config [candidate] (842.364 µs) : 0, 842
Telemetry [baseline] (7.554 ms) : 0, 7554
Telemetry [candidate] (7.426 ms) : 0, 7426
ProfilingAgent [baseline] (95.964 ms) : 0, 95964
ProfilingAgent [candidate] (95.722 ms) : 0, 95722
Profiling [baseline] (95.99 ms) : 0, 95990
Profiling [candidate] (95.747 ms) : 0, 95747
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02
dateFormat X
axisFormat %s
section baseline
no_agent (1.342 ms) : 1323, 1362
. : milestone, 1342,
appsec (1.71 ms) : 1686, 1735
. : milestone, 1710,
appsec_no_iast (1.701 ms) : 1676, 1726
. : milestone, 1701,
iast (1.475 ms) : 1452, 1498
. : milestone, 1475,
profiling (1.479 ms) : 1455, 1503
. : milestone, 1479,
tracing (1.466 ms) : 1440, 1492
. : milestone, 1466,
section candidate
no_agent (1.334 ms) : 1314, 1353
. : milestone, 1334,
appsec (1.728 ms) : 1704, 1752
. : milestone, 1728,
appsec_no_iast (1.721 ms) : 1697, 1745
. : milestone, 1721,
iast (1.474 ms) : 1452, 1497
. : milestone, 1474,
profiling (1.533 ms) : 1508, 1559
. : milestone, 1533,
tracing (1.455 ms) : 1430, 1480
. : milestone, 1455,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02
dateFormat X
axisFormat %s
section baseline
no_agent (368.311 µs) : 347, 389
. : milestone, 368,
iast (485.397 µs) : 464, 507
. : milestone, 485,
iast_FULL (553.678 µs) : 533, 575
. : milestone, 554,
iast_GLOBAL (508.198 µs) : 486, 530
. : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (481.243 µs) : 460, 502
. : milestone, 481,
iast_INACTIVE (453.59 µs) : 432, 475
. : milestone, 454,
iast_TELEMETRY_OFF (471.365 µs) : 450, 493
. : milestone, 471,
tracing (440.244 µs) : 420, 461
. : milestone, 440,
section candidate
no_agent (370.012 µs) : 350, 390
. : milestone, 370,
iast (482.591 µs) : 462, 504
. : milestone, 483,
iast_FULL (553.589 µs) : 532, 575
. : milestone, 554,
iast_GLOBAL (500.417 µs) : 479, 522
. : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (486.51 µs) : 465, 508
. : milestone, 487,
iast_INACTIVE (455.4 µs) : 434, 477
. : milestone, 455,
iast_TELEMETRY_OFF (474.212 µs) : 453, 495
. : milestone, 474,
tracing (439.206 µs) : 418, 460
. : milestone, 439,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02
dateFormat X
axisFormat %s
section baseline
no_agent (15.008 s) : 15008000, 15008000
. : milestone, 15008000,
appsec (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
iast (18.678 s) : 18678000, 18678000
. : milestone, 18678000,
iast_GLOBAL (17.929 s) : 17929000, 17929000
. : milestone, 17929000,
profiling (15.777 s) : 15777000, 15777000
. : milestone, 15777000,
tracing (15.149 s) : 15149000, 15149000
. : milestone, 15149000,
section candidate
no_agent (14.809 s) : 14809000, 14809000
. : milestone, 14809000,
appsec (14.998 s) : 14998000, 14998000
. : milestone, 14998000,
iast (19.005 s) : 19005000, 19005000
. : milestone, 19005000,
iast_GLOBAL (17.786 s) : 17786000, 17786000
. : milestone, 17786000,
profiling (15.872 s) : 15872000, 15872000
. : milestone, 15872000,
tracing (15.091 s) : 15091000, 15091000
. : milestone, 15091000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~fa17a5849d, baseline=1.35.0-SNAPSHOT~bf9fd09c02
dateFormat X
axisFormat %s
section baseline
no_agent (1.455 ms) : 1444, 1467
. : milestone, 1455,
appsec (2.177 ms) : 2143, 2210
. : milestone, 2177,
iast (1.943 ms) : 1902, 1983
. : milestone, 1943,
iast_GLOBAL (1.987 ms) : 1947, 2027
. : milestone, 1987,
profiling (1.831 ms) : 1799, 1864
. : milestone, 1831,
tracing (1.82 ms) : 1788, 1852
. : milestone, 1820,
section candidate
no_agent (1.459 ms) : 1448, 1471
. : milestone, 1459,
appsec (2.184 ms) : 2151, 2218
. : milestone, 2184,
iast (1.95 ms) : 1909, 1991
. : milestone, 1950,
iast_GLOBAL (1.989 ms) : 1948, 2030
. : milestone, 1989,
profiling (1.84 ms) : 1807, 1874
. : milestone, 1840,
tracing (1.823 ms) : 1792, 1855
. : milestone, 1823,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't need so many changes, why not just:
- add the
isRemote
argument to just the oneDDSpanContext
constructor used byCoreTracer.buildSpanContext
- then update
CoreTracer.buildSpanContext
to setisRemote
totrue
in the existing block whereparentContext instanceof ExtractedContext
andfalse
everywhere else
You don't need to update all the other constructors, just let them default isRemote
to false
when calling the updated constructor.
Also whenever you add elements to a constructor, consider creating a new constructor with the additional argument and having the old constructor delegate to the new one with a default for the new argument. (Whether this is appropriate depends on how many places call the original constructor.)
Updated as suggested, thanks. I originally thought passing a default value would not be possible because each test would now need to be evaluated to see if it is remote or not otherwise the default value may be inaccurate. If the Do you know if |
Yes, since the |
What Does This Do
Adds
isRemote()
toDDSpanContext
similarly to how it was added to other trace agents per W3C phase 2 requirements.Motivation
Required by #7067
Jira ticket: [AIT-9906]