-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable OpenTelemetry 1.x support by default #7120
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 18 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~bd93b7dd30, baseline=1.36.0-SNAPSHOT~fff0006e38
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066468
Total [baseline] (10.391 s) : 0, 10391152
Agent [candidate] (1.07 s) : 0, 1069901
Total [candidate] (10.475 s) : 0, 10474632
section appsec
Agent [baseline] (1.177 s) : 0, 1176761
Total [baseline] (10.516 s) : 0, 10516000
Agent [candidate] (1.178 s) : 0, 1178409
Total [candidate] (10.596 s) : 0, 10596143
section iast
Agent [baseline] (1.17 s) : 0, 1170008
Total [baseline] (10.744 s) : 0, 10743890
Agent [candidate] (1.171 s) : 0, 1171346
Total [candidate] (10.797 s) : 0, 10796829
section profiling
Agent [baseline] (1.275 s) : 0, 1274699
Total [baseline] (10.796 s) : 0, 10795822
Agent [candidate] (1.261 s) : 0, 1260637
Total [candidate] (10.685 s) : 0, 10685132
gantt
title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~bd93b7dd30, baseline=1.36.0-SNAPSHOT~fff0006e38
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.271 ms) : 0, 668271
BytebuddyAgent [candidate] (669.874 ms) : 0, 669874
GlobalTracer [baseline] (304.783 ms) : 0, 304783
GlobalTracer [candidate] (306.166 ms) : 0, 306166
AppSec [baseline] (50.215 ms) : 0, 50215
AppSec [candidate] (50.591 ms) : 0, 50591
Logs Intake [baseline] (408.671 µs) : 0, 409
Logs Intake [candidate] (428.86 µs) : 0, 429
Remote Config [baseline] (666.596 µs) : 0, 667
Remote Config [candidate] (681.397 µs) : 0, 681
Telemetry [baseline] (7.58 ms) : 0, 7580
Telemetry [candidate] (7.621 ms) : 0, 7621
section appsec
BytebuddyAgent [baseline] (673.954 ms) : 0, 673954
BytebuddyAgent [candidate] (675.67 ms) : 0, 675670
GlobalTracer [baseline] (296.867 ms) : 0, 296867
GlobalTracer [candidate] (297.477 ms) : 0, 297477
AppSec [baseline] (152.833 ms) : 0, 152833
AppSec [candidate] (153.347 ms) : 0, 153347
Logs Intake [baseline] (334.175 µs) : 0, 334
Logs Intake [candidate] (329.22 µs) : 0, 329
Remote Config [baseline] (627.615 µs) : 0, 628
Remote Config [candidate] (610.216 µs) : 0, 610
Telemetry [baseline] (7.814 ms) : 0, 7814
Telemetry [candidate] (7.211 ms) : 0, 7211
IAST [baseline] (19.966 ms) : 0, 19966
IAST [candidate] (18.706 ms) : 0, 18706
section iast
BytebuddyAgent [baseline] (778.912 ms) : 0, 778912
BytebuddyAgent [candidate] (784.043 ms) : 0, 784043
GlobalTracer [baseline] (294.712 ms) : 0, 294712
GlobalTracer [candidate] (292.709 ms) : 0, 292709
AppSec [baseline] (47.337 ms) : 0, 47337
AppSec [candidate] (46.78 ms) : 0, 46780
Logs Intake [baseline] (302.706 µs) : 0, 303
Logs Intake [candidate] (322.951 µs) : 0, 323
Remote Config [baseline] (584.162 µs) : 0, 584
Remote Config [candidate] (665.459 µs) : 0, 665
Telemetry [baseline] (9.95 ms) : 0, 9950
Telemetry [candidate] (7.053 ms) : 0, 7053
IAST [baseline] (24.969 ms) : 0, 24969
IAST [candidate] (26.464 ms) : 0, 26464
section profiling
BytebuddyAgent [baseline] (670.051 ms) : 0, 670051
BytebuddyAgent [candidate] (662.681 ms) : 0, 662681
GlobalTracer [baseline] (388.981 ms) : 0, 388981
GlobalTracer [candidate] (386.52 ms) : 0, 386520
AppSec [baseline] (51.52 ms) : 0, 51520
AppSec [candidate] (50.789 ms) : 0, 50789
Logs Intake [baseline] (341.859 µs) : 0, 342
Logs Intake [candidate] (342.673 µs) : 0, 343
Remote Config [baseline] (776.375 µs) : 0, 776
Remote Config [candidate] (725.936 µs) : 0, 726
Telemetry [baseline] (7.469 ms) : 0, 7469
Telemetry [candidate] (7.306 ms) : 0, 7306
ProfilingAgent [baseline] (98.205 ms) : 0, 98205
ProfilingAgent [candidate] (95.788 ms) : 0, 95788
Profiling [baseline] (98.23 ms) : 0, 98230
Profiling [candidate] (95.813 ms) : 0, 95813
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~bd93b7dd30, baseline=1.36.0-SNAPSHOT~fff0006e38
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069054
Total [baseline] (8.568 s) : 0, 8568413
Agent [candidate] (1.059 s) : 0, 1059449
Total [candidate] (8.549 s) : 0, 8548913
section iast
Agent [baseline] (1.175 s) : 0, 1174709
Total [baseline] (8.992 s) : 0, 8992160
Agent [candidate] (1.183 s) : 0, 1182916
Total [candidate] (9.006 s) : 0, 9006373
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.168 s) : 0, 1168421
Total [baseline] (9.007 s) : 0, 9007013
Agent [candidate] (1.168 s) : 0, 1167530
Total [candidate] (8.989 s) : 0, 8988528
section iast_TELEMETRY_OFF
Agent [baseline] (1.162 s) : 0, 1161878
Total [baseline] (8.991 s) : 0, 8990577
Agent [candidate] (1.164 s) : 0, 1163626
Total [candidate] (9.029 s) : 0, 9029108
gantt
title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~bd93b7dd30, baseline=1.36.0-SNAPSHOT~fff0006e38
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (668.874 ms) : 0, 668874
BytebuddyAgent [candidate] (663.337 ms) : 0, 663337
GlobalTracer [baseline] (306.07 ms) : 0, 306070
GlobalTracer [candidate] (303.256 ms) : 0, 303256
AppSec [baseline] (50.712 ms) : 0, 50712
AppSec [candidate] (49.973 ms) : 0, 49973
Logs Intake [baseline] (406.648 µs) : 0, 407
Logs Intake [candidate] (385.666 µs) : 0, 386
Remote Config [baseline] (671.454 µs) : 0, 671
Remote Config [candidate] (679.055 µs) : 0, 679
Telemetry [baseline] (7.603 ms) : 0, 7603
Telemetry [candidate] (7.507 ms) : 0, 7507
section iast
BytebuddyAgent [baseline] (783.42 ms) : 0, 783420
BytebuddyAgent [candidate] (789.844 ms) : 0, 789844
GlobalTracer [baseline] (295.069 ms) : 0, 295069
GlobalTracer [candidate] (296.198 ms) : 0, 296198
AppSec [baseline] (47.573 ms) : 0, 47573
AppSec [candidate] (47.299 ms) : 0, 47299
IAST [baseline] (26.887 ms) : 0, 26887
IAST [candidate] (28.235 ms) : 0, 28235
Logs Intake [baseline] (297.534 µs) : 0, 298
Logs Intake [candidate] (318.491 µs) : 0, 318
Remote Config [baseline] (570.084 µs) : 0, 570
Remote Config [candidate] (642.441 µs) : 0, 642
Telemetry [baseline] (7.553 ms) : 0, 7553
Telemetry [candidate] (6.969 ms) : 0, 6969
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (778.577 ms) : 0, 778577
BytebuddyAgent [candidate] (778.583 ms) : 0, 778583
GlobalTracer [baseline] (294.017 ms) : 0, 294017
GlobalTracer [candidate] (292.89 ms) : 0, 292890
AppSec [baseline] (46.939 ms) : 0, 46939
AppSec [candidate] (46.873 ms) : 0, 46873
IAST [baseline] (27.049 ms) : 0, 27049
IAST [candidate] (26.539 ms) : 0, 26539
Logs Intake [baseline] (307.404 µs) : 0, 307
Logs Intake [candidate] (299.589 µs) : 0, 300
Remote Config [baseline] (585.359 µs) : 0, 585
Remote Config [candidate] (574.213 µs) : 0, 574
Telemetry [baseline] (7.639 ms) : 0, 7639
Telemetry [candidate] (8.45 ms) : 0, 8450
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.447 ms) : 0, 775447
BytebuddyAgent [candidate] (775.96 ms) : 0, 775960
GlobalTracer [baseline] (293.445 ms) : 0, 293445
GlobalTracer [candidate] (292.737 ms) : 0, 292737
AppSec [baseline] (49.307 ms) : 0, 49307
AppSec [candidate] (46.447 ms) : 0, 46447
IAST [baseline] (22.698 ms) : 0, 22698
IAST [candidate] (25.982 ms) : 0, 25982
Logs Intake [baseline] (297.149 µs) : 0, 297
Logs Intake [candidate] (304.636 µs) : 0, 305
Remote Config [baseline] (565.165 µs) : 0, 565
Remote Config [candidate] (571.384 µs) : 0, 571
Telemetry [baseline] (6.825 ms) : 0, 6825
Telemetry [candidate] (8.345 ms) : 0, 8345
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~bd93b7dd30, baseline=1.36.0-SNAPSHOT~fff0006e38
dateFormat X
axisFormat %s
section baseline
no_agent (375.834 µs) : 356, 396
. : milestone, 376,
iast (481.42 µs) : 460, 503
. : milestone, 481,
iast_FULL (547.998 µs) : 527, 569
. : milestone, 548,
iast_GLOBAL (504.471 µs) : 483, 526
. : milestone, 504,
iast_HARDCODED_SECRET_DISABLED (477.066 µs) : 456, 498
. : milestone, 477,
iast_INACTIVE (445.818 µs) : 425, 467
. : milestone, 446,
iast_TELEMETRY_OFF (467.859 µs) : 447, 489
. : milestone, 468,
tracing (443.426 µs) : 422, 464
. : milestone, 443,
section candidate
no_agent (365.705 µs) : 346, 385
. : milestone, 366,
iast (481.166 µs) : 460, 502
. : milestone, 481,
iast_FULL (542.101 µs) : 521, 563
. : milestone, 542,
iast_GLOBAL (509.721 µs) : 488, 532
. : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (471.828 µs) : 451, 493
. : milestone, 472,
iast_INACTIVE (450.834 µs) : 429, 473
. : milestone, 451,
iast_TELEMETRY_OFF (468.263 µs) : 447, 490
. : milestone, 468,
tracing (441.716 µs) : 421, 463
. : milestone, 442,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~bd93b7dd30, baseline=1.36.0-SNAPSHOT~fff0006e38
dateFormat X
axisFormat %s
section baseline
no_agent (1.348 ms) : 1329, 1367
. : milestone, 1348,
appsec (1.725 ms) : 1702, 1749
. : milestone, 1725,
appsec_no_iast (1.731 ms) : 1707, 1756
. : milestone, 1731,
iast (1.481 ms) : 1459, 1503
. : milestone, 1481,
profiling (1.55 ms) : 1524, 1576
. : milestone, 1550,
tracing (1.462 ms) : 1439, 1486
. : milestone, 1462,
section candidate
no_agent (1.342 ms) : 1323, 1362
. : milestone, 1342,
appsec (1.708 ms) : 1683, 1732
. : milestone, 1708,
appsec_no_iast (1.706 ms) : 1681, 1732
. : milestone, 1706,
iast (1.47 ms) : 1447, 1493
. : milestone, 1470,
profiling (1.466 ms) : 1441, 1490
. : milestone, 1466,
tracing (1.471 ms) : 1447, 1494
. : milestone, 1471,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~bd93b7dd30, baseline=1.36.0-SNAPSHOT~fff0006e38
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1452, 1475
. : milestone, 1464,
appsec (2.19 ms) : 2156, 2224
. : milestone, 2190,
iast (1.958 ms) : 1918, 1999
. : milestone, 1958,
iast_GLOBAL (1.988 ms) : 1948, 2028
. : milestone, 1988,
profiling (1.852 ms) : 1818, 1886
. : milestone, 1852,
tracing (1.829 ms) : 1797, 1861
. : milestone, 1829,
section candidate
no_agent (1.451 ms) : 1440, 1462
. : milestone, 1451,
appsec (2.217 ms) : 2182, 2252
. : milestone, 2217,
iast (1.969 ms) : 1927, 2011
. : milestone, 1969,
iast_GLOBAL (2.001 ms) : 1960, 2042
. : milestone, 2001,
profiling (1.847 ms) : 1813, 1882
. : milestone, 1847,
tracing (1.835 ms) : 1802, 1868
. : milestone, 1835,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~bd93b7dd30, baseline=1.36.0-SNAPSHOT~fff0006e38
dateFormat X
axisFormat %s
section baseline
no_agent (14.806 s) : 14806000, 14806000
. : milestone, 14806000,
appsec (14.957 s) : 14957000, 14957000
. : milestone, 14957000,
iast (18.94 s) : 18940000, 18940000
. : milestone, 18940000,
iast_GLOBAL (17.938 s) : 17938000, 17938000
. : milestone, 17938000,
profiling (15.284 s) : 15284000, 15284000
. : milestone, 15284000,
tracing (15.356 s) : 15356000, 15356000
. : milestone, 15356000,
section candidate
no_agent (14.902 s) : 14902000, 14902000
. : milestone, 14902000,
appsec (15.092 s) : 15092000, 15092000
. : milestone, 15092000,
iast (18.858 s) : 18858000, 18858000
. : milestone, 18858000,
iast_GLOBAL (17.789 s) : 17789000, 17789000
. : milestone, 17789000,
profiling (15.0 s) : 15000000, 15000000
. : milestone, 15000000,
tracing (14.88 s) : 14880000, 14880000
. : milestone, 14880000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some (public) documentation update needed related to this change?
Yes, I'll be updating the documentation this week - assuming no blockers to changing this default ... the other option I'm considering is to implicitly enable this when using the new drop-in support. |
cf1ffc9
to
158bcad
Compare
158bcad
to
bd93b7d
Compare
No description provided.