-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure locals are in scope when generating metrics #7121
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verify that where the metric is inserted, the local variable that we try to access is in scope (from the LocalVariableTable) We are doing this for CapturedContext now we add this for metrics to avoid having a VerifyError raised because the variable is not accessible or reused with another type than expected.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.574 s) : 0, 1574228
Total [baseline] (14.206 s) : 0, 14206363
Agent [candidate] (1.571 s) : 0, 1570951
Total [candidate] (14.231 s) : 0, 14230633
section appsec
Agent [baseline] (1.749 s) : 0, 1749086
Total [baseline] (14.317 s) : 0, 14316855
Agent [candidate] (1.748 s) : 0, 1748238
Total [candidate] (14.426 s) : 0, 14425882
section iast
Agent [baseline] (1.709 s) : 0, 1708653
Total [baseline] (14.701 s) : 0, 14700710
Agent [candidate] (1.706 s) : 0, 1705994
Total [candidate] (14.741 s) : 0, 14740981
section profiling
Agent [baseline] (1.885 s) : 0, 1884655
Total [baseline] (14.672 s) : 0, 14671994
Agent [candidate] (1.879 s) : 0, 1879392
Total [candidate] (14.698 s) : 0, 14698004
gantt
title petclinic - break down per module: candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (969.715 ms) : 0, 969715
BytebuddyAgent [candidate] (966.739 ms) : 0, 966739
GlobalTracer [baseline] (462.093 ms) : 0, 462093
GlobalTracer [candidate] (461.771 ms) : 0, 461771
AppSec [baseline] (71.127 ms) : 0, 71127
AppSec [candidate] (71.265 ms) : 0, 71265
Remote Config [baseline] (835.999 µs) : 0, 836
Remote Config [candidate] (833.936 µs) : 0, 834
Telemetry [baseline] (9.87 ms) : 0, 9870
Telemetry [candidate] (9.841 ms) : 0, 9841
section appsec
BytebuddyAgent [baseline] (999.047 ms) : 0, 999047
BytebuddyAgent [candidate] (998.214 ms) : 0, 998214
GlobalTracer [baseline] (436.486 ms) : 0, 436486
GlobalTracer [candidate] (436.329 ms) : 0, 436329
AppSec [baseline] (231.451 ms) : 0, 231451
AppSec [candidate] (231.463 ms) : 0, 231463
IAST [baseline] (23.967 ms) : 0, 23967
IAST [candidate] (24.129 ms) : 0, 24129
Remote Config [baseline] (782.084 µs) : 0, 782
Remote Config [candidate] (778.671 µs) : 0, 779
Telemetry [baseline] (8.873 ms) : 0, 8873
Telemetry [candidate] (8.837 ms) : 0, 8837
section iast
BytebuddyAgent [baseline] (1.146 s) : 0, 1146242
BytebuddyAgent [candidate] (1.145 s) : 0, 1145342
GlobalTracer [baseline] (432.259 ms) : 0, 432259
GlobalTracer [candidate] (430.518 ms) : 0, 430518
AppSec [baseline] (66.784 ms) : 0, 66784
AppSec [candidate] (68.238 ms) : 0, 68238
IAST [baseline] (33.968 ms) : 0, 33968
IAST [candidate] (30.655 ms) : 0, 30655
Remote Config [baseline] (761.528 µs) : 0, 762
Remote Config [candidate] (775.202 µs) : 0, 775
Telemetry [baseline] (8.973 ms) : 0, 8973
Telemetry [candidate] (10.728 ms) : 0, 10728
section profiling
BytebuddyAgent [baseline] (979.779 ms) : 0, 979779
BytebuddyAgent [candidate] (979.255 ms) : 0, 979255
GlobalTracer [baseline] (577.352 ms) : 0, 577352
GlobalTracer [candidate] (575.014 ms) : 0, 575014
AppSec [baseline] (73.423 ms) : 0, 73423
AppSec [candidate] (71.656 ms) : 0, 71656
Remote Config [baseline] (944.132 µs) : 0, 944
Remote Config [candidate] (974.502 µs) : 0, 975
Telemetry [baseline] (9.531 ms) : 0, 9531
Telemetry [candidate] (9.791 ms) : 0, 9791
ProfilingAgent [baseline] (150.439 ms) : 0, 150439
ProfilingAgent [candidate] (149.578 ms) : 0, 149578
Profiling [baseline] (150.5 ms) : 0, 150500
Profiling [candidate] (149.635 ms) : 0, 149635
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.576 s) : 0, 1576080
Total [baseline] (11.917 s) : 0, 11916995
Agent [candidate] (1.568 s) : 0, 1568249
Total [candidate] (11.911 s) : 0, 11910542
section iast
Agent [baseline] (1.708 s) : 0, 1707630
Total [baseline] (12.543 s) : 0, 12543419
Agent [candidate] (1.703 s) : 0, 1702525
Total [candidate] (12.607 s) : 0, 12607131
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.713 s) : 0, 1713352
Total [baseline] (12.503 s) : 0, 12502843
Agent [candidate] (1.704 s) : 0, 1704343
Total [candidate] (12.493 s) : 0, 12493449
section iast_TELEMETRY_OFF
Agent [baseline] (1.699 s) : 0, 1699308
Total [baseline] (12.555 s) : 0, 12554834
Agent [candidate] (1.711 s) : 0, 1711116
Total [candidate] (12.532 s) : 0, 12531767
gantt
title insecure-bank - break down per module: candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (970.384 ms) : 0, 970384
BytebuddyAgent [candidate] (966.053 ms) : 0, 966053
GlobalTracer [baseline] (463.141 ms) : 0, 463141
GlobalTracer [candidate] (460.196 ms) : 0, 460196
AppSec [baseline] (71.313 ms) : 0, 71313
AppSec [candidate] (70.777 ms) : 0, 70777
Remote Config [baseline] (828.504 µs) : 0, 829
Remote Config [candidate] (833.419 µs) : 0, 833
Telemetry [baseline] (9.744 ms) : 0, 9744
Telemetry [candidate] (9.802 ms) : 0, 9802
section iast
BytebuddyAgent [baseline] (1.146 s) : 0, 1146013
BytebuddyAgent [candidate] (1.144 s) : 0, 1144093
GlobalTracer [baseline] (430.886 ms) : 0, 430886
GlobalTracer [candidate] (430.154 ms) : 0, 430154
AppSec [baseline] (67.456 ms) : 0, 67456
AppSec [candidate] (66.708 ms) : 0, 66708
IAST [baseline] (33.054 ms) : 0, 33054
IAST [candidate] (31.029 ms) : 0, 31029
Remote Config [baseline] (769.429 µs) : 0, 769
Remote Config [candidate] (786.786 µs) : 0, 787
Telemetry [baseline] (9.766 ms) : 0, 9766
Telemetry [candidate] (10.001 ms) : 0, 10001
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (1.149 s) : 0, 1148872
BytebuddyAgent [candidate] (1.144 s) : 0, 1144279
GlobalTracer [baseline] (432.372 ms) : 0, 432372
GlobalTracer [candidate] (430.364 ms) : 0, 430364
AppSec [baseline] (67.155 ms) : 0, 67155
AppSec [candidate] (68.312 ms) : 0, 68312
IAST [baseline] (34.382 ms) : 0, 34382
IAST [candidate] (30.706 ms) : 0, 30706
Remote Config [baseline] (772.243 µs) : 0, 772
Remote Config [candidate] (783.936 µs) : 0, 784
Telemetry [baseline] (9.895 ms) : 0, 9895
Telemetry [candidate] (9.921 ms) : 0, 9921
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (1.139 s) : 0, 1139239
BytebuddyAgent [candidate] (1.148 s) : 0, 1148481
GlobalTracer [baseline] (430.319 ms) : 0, 430319
GlobalTracer [candidate] (433.054 ms) : 0, 433054
AppSec [baseline] (67.518 ms) : 0, 67518
AppSec [candidate] (68.056 ms) : 0, 68056
IAST [baseline] (32.824 ms) : 0, 32824
IAST [candidate] (31.65 ms) : 0, 31650
Remote Config [baseline] (772.041 µs) : 0, 772
Remote Config [candidate] (794.167 µs) : 0, 794
Telemetry [baseline] (8.881 ms) : 0, 8881
Telemetry [candidate] (9.131 ms) : 0, 9131
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 5 metrics, 22 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751
dateFormat X
axisFormat %s
section baseline
no_agent (458.028 µs) : 429, 487
. : milestone, 458,
iast (585.749 µs) : 554, 618
. : milestone, 586,
iast_FULL (683.481 µs) : 652, 715
. : milestone, 683,
iast_GLOBAL (618.407 µs) : 586, 650
. : milestone, 618,
iast_HARDCODED_SECRET_DISABLED (590.377 µs) : 559, 622
. : milestone, 590,
iast_INACTIVE (552.726 µs) : 522, 584
. : milestone, 553,
iast_TELEMETRY_OFF (571.485 µs) : 540, 603
. : milestone, 571,
tracing (532.215 µs) : 502, 562
. : milestone, 532,
section candidate
no_agent (455.155 µs) : 426, 484
. : milestone, 455,
iast (580.652 µs) : 549, 613
. : milestone, 581,
iast_FULL (691.031 µs) : 659, 723
. : milestone, 691,
iast_GLOBAL (611.702 µs) : 580, 644
. : milestone, 612,
iast_HARDCODED_SECRET_DISABLED (595.473 µs) : 564, 626
. : milestone, 595,
iast_INACTIVE (550.747 µs) : 519, 583
. : milestone, 551,
iast_TELEMETRY_OFF (572.014 µs) : 541, 603
. : milestone, 572,
tracing (535.878 µs) : 506, 565
. : milestone, 536,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751
dateFormat X
axisFormat %s
section baseline
no_agent (1.706 ms) : 1681, 1731
. : milestone, 1706,
appsec (2.179 ms) : 2147, 2211
. : milestone, 2179,
appsec_no_iast (2.194 ms) : 2161, 2226
. : milestone, 2194,
iast (1.903 ms) : 1874, 1933
. : milestone, 1903,
profiling (1.968 ms) : 1932, 2004
. : milestone, 1968,
tracing (1.884 ms) : 1851, 1916
. : milestone, 1884,
section candidate
no_agent (1.703 ms) : 1678, 1728
. : milestone, 1703,
appsec (2.208 ms) : 2176, 2240
. : milestone, 2208,
appsec_no_iast (2.156 ms) : 2124, 2187
. : milestone, 2156,
iast (1.906 ms) : 1876, 1935
. : milestone, 1906,
profiling (1.848 ms) : 1817, 1878
. : milestone, 1848,
tracing (1.872 ms) : 1840, 1903
. : milestone, 1872,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751
dateFormat X
axisFormat %s
section baseline
no_agent (20.383 s) : 20383000, 20383000
. : milestone, 20383000,
appsec (21.163 s) : 21163000, 21163000
. : milestone, 21163000,
iast (24.278 s) : 24278000, 24278000
. : milestone, 24278000,
iast_GLOBAL (25.069 s) : 25069000, 25069000
. : milestone, 25069000,
profiling (20.748 s) : 20748000, 20748000
. : milestone, 20748000,
tracing (20.489 s) : 20489000, 20489000
. : milestone, 20489000,
section candidate
no_agent (20.735 s) : 20735000, 20735000
. : milestone, 20735000,
appsec (21.583 s) : 21583000, 21583000
. : milestone, 21583000,
iast (24.327 s) : 24327000, 24327000
. : milestone, 24327000,
iast_GLOBAL (25.058 s) : 25058000, 25058000
. : milestone, 25058000,
profiling (20.876 s) : 20876000, 20876000
. : milestone, 20876000,
tracing (20.877 s) : 20877000, 20877000
. : milestone, 20877000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.35.0-SNAPSHOT~95d4f51838, baseline=1.35.0-SNAPSHOT~70f9058751
dateFormat X
axisFormat %s
section baseline
no_agent (1.543 ms) : 1531, 1556
. : milestone, 1543,
appsec (2.674 ms) : 2614, 2735
. : milestone, 2674,
iast (2.337 ms) : 2266, 2407
. : milestone, 2337,
iast_GLOBAL (2.406 ms) : 2334, 2479
. : milestone, 2406,
profiling (2.205 ms) : 2143, 2266
. : milestone, 2205,
tracing (2.168 ms) : 2110, 2226
. : milestone, 2168,
section candidate
no_agent (1.546 ms) : 1533, 1559
. : milestone, 1546,
appsec (2.671 ms) : 2611, 2730
. : milestone, 2671,
iast (2.352 ms) : 2280, 2424
. : milestone, 2352,
iast_GLOBAL (2.384 ms) : 2314, 2454
. : milestone, 2384,
profiling (2.191 ms) : 2130, 2251
. : milestone, 2191,
tracing (2.162 ms) : 2106, 2219
. : milestone, 2162,
|
shatzi
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Verify that where the metric is inserted, the local variable that we
try to access is in scope (from the LocalVariableTable)
We are doing this for CapturedContext now we add this for metrics to avoid having a VerifyError raised because the variable is not accessible or reused with another type than expected.
Motivation
avoid VerifyError exception when loading the instrumented class
Additional Notes
Jira ticket: DEBUG-2400