-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not modify readonly message attributes map on SNS integration #7150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcculls
approved these changes
Jun 10, 2024
amarziali
approved these changes
Jun 10, 2024
amarziali
changed the title
bugfixe(s) on SNS integration
SNS integration: do not modify readonly message attributes map
Jun 10, 2024
amarziali
added
inst: aws sdk
AWS SDK instrumentation
tag: serverless
Serverless support
type: bug
labels
Jun 10, 2024
BenchmarksStartupLoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~9579b09cf4, baseline=1.36.0-SNAPSHOT~b7b9e6991e
dateFormat X
axisFormat %s
section baseline
no_agent (371.317 µs) : 352, 391
. : milestone, 371,
iast (484.659 µs) : 463, 506
. : milestone, 485,
iast_FULL (550.414 µs) : 529, 572
. : milestone, 550,
iast_GLOBAL (504.762 µs) : 484, 526
. : milestone, 505,
iast_HARDCODED_SECRET_DISABLED (480.144 µs) : 459, 502
. : milestone, 480,
iast_INACTIVE (453.204 µs) : 432, 474
. : milestone, 453,
iast_TELEMETRY_OFF (474.661 µs) : 453, 496
. : milestone, 475,
tracing (433.721 µs) : 414, 454
. : milestone, 434,
section candidate
no_agent (366.993 µs) : 347, 387
. : milestone, 367,
iast (480.601 µs) : 460, 502
. : milestone, 481,
iast_FULL (553.533 µs) : 532, 575
. : milestone, 554,
iast_GLOBAL (518.048 µs) : 495, 541
. : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (477.713 µs) : 457, 499
. : milestone, 478,
iast_INACTIVE (450.386 µs) : 429, 472
. : milestone, 450,
iast_TELEMETRY_OFF (469.593 µs) : 448, 491
. : milestone, 470,
tracing (443.738 µs) : 423, 465
. : milestone, 444,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~9579b09cf4, baseline=1.36.0-SNAPSHOT~b7b9e6991e
dateFormat X
axisFormat %s
section baseline
no_agent (1.341 ms) : 1321, 1360
. : milestone, 1341,
appsec (1.715 ms) : 1691, 1738
. : milestone, 1715,
appsec_no_iast (1.722 ms) : 1699, 1746
. : milestone, 1722,
iast (1.47 ms) : 1447, 1493
. : milestone, 1470,
profiling (1.505 ms) : 1479, 1531
. : milestone, 1505,
tracing (1.476 ms) : 1452, 1500
. : milestone, 1476,
section candidate
no_agent (1.359 ms) : 1340, 1378
. : milestone, 1359,
appsec (1.724 ms) : 1700, 1748
. : milestone, 1724,
appsec_no_iast (1.721 ms) : 1697, 1745
. : milestone, 1721,
iast (1.46 ms) : 1437, 1482
. : milestone, 1460,
profiling (1.513 ms) : 1486, 1539
. : milestone, 1513,
tracing (1.437 ms) : 1413, 1462
. : milestone, 1437,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~9579b09cf4, baseline=1.36.0-SNAPSHOT~b7b9e6991e
dateFormat X
axisFormat %s
section baseline
no_agent (15.695 s) : 15695000, 15695000
. : milestone, 15695000,
appsec (15.102 s) : 15102000, 15102000
. : milestone, 15102000,
iast (18.719 s) : 18719000, 18719000
. : milestone, 18719000,
iast_GLOBAL (18.047 s) : 18047000, 18047000
. : milestone, 18047000,
profiling (16.045 s) : 16045000, 16045000
. : milestone, 16045000,
tracing (15.074 s) : 15074000, 15074000
. : milestone, 15074000,
section candidate
no_agent (15.38 s) : 15380000, 15380000
. : milestone, 15380000,
appsec (14.869 s) : 14869000, 14869000
. : milestone, 14869000,
iast (18.815 s) : 18815000, 18815000
. : milestone, 18815000,
iast_GLOBAL (18.017 s) : 18017000, 18017000
. : milestone, 18017000,
profiling (15.212 s) : 15212000, 15212000
. : milestone, 15212000,
tracing (15.05 s) : 15050000, 15050000
. : milestone, 15050000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~9579b09cf4, baseline=1.36.0-SNAPSHOT~b7b9e6991e
dateFormat X
axisFormat %s
section baseline
no_agent (1.461 ms) : 1450, 1473
. : milestone, 1461,
appsec (2.211 ms) : 2177, 2245
. : milestone, 2211,
iast (1.979 ms) : 1938, 2021
. : milestone, 1979,
iast_GLOBAL (2.012 ms) : 1971, 2054
. : milestone, 2012,
profiling (1.854 ms) : 1820, 1887
. : milestone, 1854,
tracing (1.845 ms) : 1812, 1878
. : milestone, 1845,
section candidate
no_agent (1.458 ms) : 1446, 1469
. : milestone, 1458,
appsec (2.199 ms) : 2165, 2233
. : milestone, 2199,
iast (1.969 ms) : 1927, 2010
. : milestone, 1969,
iast_GLOBAL (2.014 ms) : 1973, 2056
. : milestone, 2014,
profiling (1.857 ms) : 1823, 1891
. : milestone, 1857,
tracing (1.838 ms) : 1806, 1871
. : milestone, 1838,
|
mcculls
pushed a commit
that referenced
this pull request
Jun 12, 2024
* fix bug when SNS message attr are readonly + test * fix extra bug in v2 on message attr size
mcculls
pushed a commit
that referenced
this pull request
Jun 12, 2024
* fix bug when SNS message attr are readonly + test * fix extra bug in v2 on message attr size
PerfectSlayer
changed the title
SNS integration: do not modify readonly message attributes map
Do not modify readonly message attributes map on SNS integration
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Fix a bug where the integration would crash in the sdk v1 integration if the message attributes were a readonly map
Also fix a minor bug in the sdk v2 batch requests where we'd write more than 10 message attributes, which is not supported in SQS.
Motivation
#7147