Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore exception when trying to remove Git data upload shutdown hook during JVM shutdown #7204

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Ignore exception when trying to remove Git data upload shutdown hook during JVM shutdown #7204

merged 1 commit into from
Jun 17, 2024

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Jun 17, 2024 •
edited by jira bot
Loading

What Does This Do

Suppresses IllegalStateException that can be thrown when removing Git data upload shutdown hook.

Motivation

The Git data upload shutdown hook is needed to make JVM wait before shutting down if Git data upload hasn't had enough time to finish.
If Git data upload finishes while the JVM is running, no shutdown hook is needed.
Which is why the hook is removed when the upload completes.

However, if by the time the upload completes the JVM has already started shutdown, an attempt to remove the shutdown hook will result in exception.
This exception does not indicate any problem and can be annoying for the users, therefore it's best if it is suppressed.

Additional Notes

Jira ticket: CIVIS-10174

@nikita-tkachenko-datadog nikita-tkachenko-datadog added the comp: ci visibility Continuous Integration Visibility label Jun 17, 2024
@nikita-tkachenko-datadog nikita-tkachenko-datadog linked an issue Jun 17, 2024 that may be closed by this pull request
java.lang.IllegalStateException: Shutdown in progress in dd-ci-git-data-uploader #7202
Closed
@pr-commenter
Copy link

pr-commenter bot commented Jun 17, 2024

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/suppress-git-upload-shutdown-hook-errors
git_commit_date 1718611431 1718612834
git_commit_sha 8f7a318 e9426d5
release_version 1.36.0-SNAPSHOT~8f7a318653 1.36.0-SNAPSHOT~e9426d54ca
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718616146 1718616146
ci_job_id 544784526 544784526
ci_pipeline_id 36873513 36873513
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 16 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~e9426d54ca, baseline=1.36.0-SNAPSHOT~8f7a318653

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1068227
Total [baseline] (10.356 s) : 0, 10356156
Agent [candidate] (1.062 s) : 0, 1061666
Total [candidate] (10.346 s) : 0, 10346486
section appsec
Agent [baseline] (1.179 s) : 0, 1179287
Total [baseline] (10.437 s) : 0, 10436548
Agent [candidate] (1.18 s) : 0, 1179654
Total [candidate] (10.425 s) : 0, 10425009
section iast
Agent [baseline] (1.167 s) : 0, 1166892
Total [baseline] (10.706 s) : 0, 10706492
Agent [candidate] (1.172 s) : 0, 1172464
Total [candidate] (10.744 s) : 0, 10744246
section profiling
Agent [baseline] (1.26 s) : 0, 1259533
Total [baseline] (10.566 s) : 0, 10565742
Agent [candidate] (1.26 s) : 0, 1259761
Total [candidate] (10.551 s) : 0, 10551122
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent appsec 1.179 s 111.06 ms (10.4%)
Agent iast 1.167 s 98.665 ms (9.2%)
Agent profiling 1.26 s 191.307 ms (17.9%)
Total tracing 10.356 s -
Total appsec 10.437 s 80.391 ms (0.8%)
Total iast 10.706 s 350.336 ms (3.4%)
Total profiling 10.566 s 209.586 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.18 s 117.988 ms (11.1%)
Agent iast 1.172 s 110.798 ms (10.4%)
Agent profiling 1.26 s 198.096 ms (18.7%)
Total tracing 10.346 s -
Total appsec 10.425 s 78.523 ms (0.8%)
Total iast 10.744 s 397.76 ms (3.8%)
Total profiling 10.551 s 204.636 ms (2.0%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~e9426d54ca, baseline=1.36.0-SNAPSHOT~8f7a318653

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.57 ms) : 0, 669570
BytebuddyAgent [candidate] (664.872 ms) : 0, 664872
GlobalTracer [baseline] (305.244 ms) : 0, 305244
GlobalTracer [candidate] (303.696 ms) : 0, 303696
AppSec [baseline] (50.298 ms) : 0, 50298
AppSec [candidate] (50.086 ms) : 0, 50086
Logs Intake [baseline] (335.62 µs) : 0, 336
Logs Intake [candidate] (333.058 µs) : 0, 333
Remote Config [baseline] (671.796 µs) : 0, 672
Remote Config [candidate] (661.301 µs) : 0, 661
Telemetry [baseline] (7.622 ms) : 0, 7622
Telemetry [candidate] (7.549 ms) : 0, 7549
section appsec
BytebuddyAgent [baseline] (674.531 ms) : 0, 674531
BytebuddyAgent [candidate] (673.929 ms) : 0, 673929
GlobalTracer [baseline] (296.613 ms) : 0, 296613
GlobalTracer [candidate] (296.322 ms) : 0, 296322
AppSec [baseline] (153.615 ms) : 0, 153615
AppSec [candidate] (153.946 ms) : 0, 153946
IAST [baseline] (21.595 ms) : 0, 21595
IAST [candidate] (22.264 ms) : 0, 22264
Logs Intake [baseline] (326.424 µs) : 0, 326
Logs Intake [candidate] (322.324 µs) : 0, 322
Remote Config [baseline] (622.248 µs) : 0, 622
Remote Config [candidate] (622.303 µs) : 0, 622
Telemetry [baseline] (8.482 ms) : 0, 8482
Telemetry [candidate] (9.068 ms) : 0, 9068
section iast
BytebuddyAgent [baseline] (777.86 ms) : 0, 777860
BytebuddyAgent [candidate] (780.373 ms) : 0, 780373
GlobalTracer [baseline] (292.97 ms) : 0, 292970
GlobalTracer [candidate] (294.074 ms) : 0, 294074
AppSec [baseline] (46.874 ms) : 0, 46874
AppSec [candidate] (47.221 ms) : 0, 47221
IAST [baseline] (26.653 ms) : 0, 26653
IAST [candidate] (28.819 ms) : 0, 28819
Logs Intake [baseline] (1.008 ms) : 0, 1008
Logs Intake [candidate] (1.067 ms) : 0, 1067
Remote Config [baseline] (629.663 µs) : 0, 630
Remote Config [candidate] (652.091 µs) : 0, 652
Telemetry [baseline] (7.624 ms) : 0, 7624
Telemetry [candidate] (6.968 ms) : 0, 6968
section profiling
BytebuddyAgent [baseline] (661.631 ms) : 0, 661631
BytebuddyAgent [candidate] (661.405 ms) : 0, 661405
GlobalTracer [baseline] (385.398 ms) : 0, 385398
GlobalTracer [candidate] (385.36 ms) : 0, 385360
AppSec [baseline] (51.455 ms) : 0, 51455
AppSec [candidate] (51.572 ms) : 0, 51572
Logs Intake [baseline] (343.738 µs) : 0, 344
Logs Intake [candidate] (329.909 µs) : 0, 330
Remote Config [baseline] (714.227 µs) : 0, 714
Remote Config [candidate] (702.596 µs) : 0, 703
Telemetry [baseline] (7.363 ms) : 0, 7363
Telemetry [candidate] (7.31 ms) : 0, 7310
ProfilingAgent [baseline] (95.792 ms) : 0, 95792
ProfilingAgent [candidate] (96.198 ms) : 0, 96198
Profiling [baseline] (95.817 ms) : 0, 95817
Profiling [candidate] (96.223 ms) : 0, 96223
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~e9426d54ca, baseline=1.36.0-SNAPSHOT~8f7a318653

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061441
Total [baseline] (8.526 s) : 0, 8525920
Agent [candidate] (1.062 s) : 0, 1061868
Total [candidate] (8.54 s) : 0, 8539792
section iast
Agent [baseline] (1.167 s) : 0, 1167097
Total [baseline] (8.98 s) : 0, 8979550
Agent [candidate] (1.177 s) : 0, 1177024
Total [candidate] (9.034 s) : 0, 9034135
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.178 s) : 0, 1177512
Total [baseline] (9.016 s) : 0, 9015794
Agent [candidate] (1.17 s) : 0, 1169730
Total [candidate] (8.96 s) : 0, 8960203
section iast_TELEMETRY_OFF
Agent [baseline] (1.165 s) : 0, 1164807
Total [baseline] (8.985 s) : 0, 8984914
Agent [candidate] (1.165 s) : 0, 1164524
Total [candidate] (8.975 s) : 0, 8974818
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent iast 1.167 s 105.656 ms (10.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.178 s 116.071 ms (10.9%)
Agent iast_TELEMETRY_OFF 1.165 s 103.366 ms (9.7%)
Total tracing 8.526 s -
Total iast 8.98 s 453.63 ms (5.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.016 s 489.874 ms (5.7%)
Total iast_TELEMETRY_OFF 8.985 s 458.994 ms (5.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.177 s 115.157 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.17 s 107.863 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.165 s 102.656 ms (9.7%)
Total tracing 8.54 s -
Total iast 9.034 s 494.343 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.96 s 420.41 ms (4.9%)
Total iast_TELEMETRY_OFF 8.975 s 435.026 ms (5.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~e9426d54ca, baseline=1.36.0-SNAPSHOT~8f7a318653

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.913 ms) : 0, 664913
BytebuddyAgent [candidate] (665.583 ms) : 0, 665583
GlobalTracer [baseline] (303.395 ms) : 0, 303395
GlobalTracer [candidate] (303.286 ms) : 0, 303286
AppSec [baseline] (50.196 ms) : 0, 50196
AppSec [candidate] (49.966 ms) : 0, 49966
Logs Intake [baseline] (329.373 µs) : 0, 329
Logs Intake [candidate] (332.501 µs) : 0, 333
Remote Config [baseline] (668.94 µs) : 0, 669
Remote Config [candidate] (665.471 µs) : 0, 665
Telemetry [baseline] (7.595 ms) : 0, 7595
Telemetry [candidate] (7.567 ms) : 0, 7567
section iast
BytebuddyAgent [baseline] (777.322 ms) : 0, 777322
BytebuddyAgent [candidate] (784.942 ms) : 0, 784942
GlobalTracer [baseline] (292.279 ms) : 0, 292279
GlobalTracer [candidate] (295.387 ms) : 0, 295387
AppSec [baseline] (46.945 ms) : 0, 46945
AppSec [candidate] (47.138 ms) : 0, 47138
IAST [baseline] (28.547 ms) : 0, 28547
IAST [candidate] (28.213 ms) : 0, 28213
Logs Intake [baseline] (326.161 µs) : 0, 326
Logs Intake [candidate] (318.628 µs) : 0, 319
Remote Config [baseline] (678.507 µs) : 0, 679
Remote Config [candidate] (649.594 µs) : 0, 650
Telemetry [baseline] (7.755 ms) : 0, 7755
Telemetry [candidate] (6.959 ms) : 0, 6959
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (784.448 ms) : 0, 784448
BytebuddyAgent [candidate] (779.164 ms) : 0, 779164
GlobalTracer [baseline] (295.09 ms) : 0, 295090
GlobalTracer [candidate] (293.684 ms) : 0, 293684
AppSec [baseline] (47.672 ms) : 0, 47672
AppSec [candidate] (47.004 ms) : 0, 47004
IAST [baseline] (26.681 ms) : 0, 26681
IAST [candidate] (25.616 ms) : 0, 25616
Logs Intake [baseline] (314.413 µs) : 0, 314
Logs Intake [candidate] (302.644 µs) : 0, 303
Remote Config [baseline] (2.813 ms) : 0, 2813
Remote Config [candidate] (3.548 ms) : 0, 3548
Telemetry [baseline] (7.058 ms) : 0, 7058
Telemetry [candidate] (7.014 ms) : 0, 7014
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (775.397 ms) : 0, 775397
BytebuddyAgent [candidate] (775.49 ms) : 0, 775490
GlobalTracer [baseline] (292.578 ms) : 0, 292578
GlobalTracer [candidate] (293.35 ms) : 0, 293350
AppSec [baseline] (47.053 ms) : 0, 47053
AppSec [candidate] (46.973 ms) : 0, 46973
IAST [baseline] (26.276 ms) : 0, 26276
IAST [candidate] (26.847 ms) : 0, 26847
Logs Intake [baseline] (311.205 µs) : 0, 311
Logs Intake [candidate] (306.966 µs) : 0, 307
Remote Config [baseline] (590.362 µs) : 0, 590
Remote Config [candidate] (568.699 µs) : 0, 569
Telemetry [baseline] (9.305 ms) : 0, 9305
Telemetry [candidate] (7.581 ms) : 0, 7581
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-17T08:53:20 2024-06-17T09:00:10
git_branch master nikita-tkachenko/suppress-git-upload-shutdown-hook-errors
git_commit_date 1718611431 1718612834
git_commit_sha 8f7a318 e9426d5
release_version 1.36.0-SNAPSHOT~8f7a318653 1.36.0-SNAPSHOT~e9426d54ca
start_time 2024-06-17T08:53:07 2024-06-17T08:59:57
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718615155 1718615155
ci_job_id 544784527 544784527
ci_pipeline_id 36873513 36873513
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~e9426d54ca, baseline=1.36.0-SNAPSHOT~8f7a318653
    dateFormat X
    axisFormat %s
section baseline
no_agent (373.332 µs) : 354, 393
.   : milestone, 373,
iast (485.084 µs) : 463, 507
.   : milestone, 485,
iast_FULL (552.437 µs) : 531, 574
.   : milestone, 552,
iast_GLOBAL (499.92 µs) : 479, 521
.   : milestone, 500,
iast_HARDCODED_SECRET_DISABLED (487.512 µs) : 466, 509
.   : milestone, 488,
iast_INACTIVE (453.754 µs) : 432, 475
.   : milestone, 454,
iast_TELEMETRY_OFF (477.72 µs) : 456, 499
.   : milestone, 478,
tracing (444.061 µs) : 424, 464
.   : milestone, 444,
section candidate
no_agent (367.383 µs) : 347, 387
.   : milestone, 367,
iast (485.485 µs) : 465, 506
.   : milestone, 485,
iast_FULL (553.976 µs) : 533, 575
.   : milestone, 554,
iast_GLOBAL (506.352 µs) : 485, 528
.   : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (482.352 µs) : 461, 504
.   : milestone, 482,
iast_INACTIVE (453.049 µs) : 432, 474
.   : milestone, 453,
iast_TELEMETRY_OFF (471.459 µs) : 451, 492
.   : milestone, 471,
tracing (445.884 µs) : 425, 467
.   : milestone, 446,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 373.332 µs [353.716 µs, 392.948 µs] -
iast 485.084 µs [463.09 µs, 507.078 µs] 111.752 µs (29.9%)
iast_FULL 552.437 µs [531.27 µs, 573.605 µs] 179.105 µs (48.0%)
iast_GLOBAL 499.92 µs [478.977 µs, 520.862 µs] 126.588 µs (33.9%)
iast_HARDCODED_SECRET_DISABLED 487.512 µs [466.339 µs, 508.686 µs] 114.18 µs (30.6%)
iast_INACTIVE 453.754 µs [432.334 µs, 475.174 µs] 80.422 µs (21.5%)
iast_TELEMETRY_OFF 477.72 µs [456.334 µs, 499.107 µs] 104.388 µs (28.0%)
tracing 444.061 µs [423.651 µs, 464.47 µs] 70.729 µs (18.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.383 µs [347.287 µs, 387.479 µs] -
iast 485.485 µs [464.632 µs, 506.337 µs] 118.101 µs (32.1%)
iast_FULL 553.976 µs [532.865 µs, 575.087 µs] 186.593 µs (50.8%)
iast_GLOBAL 506.352 µs [484.94 µs, 527.764 µs] 138.969 µs (37.8%)
iast_HARDCODED_SECRET_DISABLED 482.352 µs [461.007 µs, 503.697 µs] 114.969 µs (31.3%)
iast_INACTIVE 453.049 µs [431.605 µs, 474.492 µs] 85.665 µs (23.3%)
iast_TELEMETRY_OFF 471.459 µs [450.646 µs, 492.272 µs] 104.076 µs (28.3%)
tracing 445.884 µs [424.754 µs, 467.013 µs] 78.501 µs (21.4%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~e9426d54ca, baseline=1.36.0-SNAPSHOT~8f7a318653
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.339 ms) : 1320, 1359
.   : milestone, 1339,
appsec (1.755 ms) : 1732, 1778
.   : milestone, 1755,
appsec_no_iast (1.694 ms) : 1669, 1719
.   : milestone, 1694,
iast (1.48 ms) : 1458, 1503
.   : milestone, 1480,
profiling (1.479 ms) : 1454, 1503
.   : milestone, 1479,
tracing (1.46 ms) : 1436, 1485
.   : milestone, 1460,
section candidate
no_agent (1.357 ms) : 1338, 1376
.   : milestone, 1357,
appsec (1.706 ms) : 1681, 1731
.   : milestone, 1706,
appsec_no_iast (1.716 ms) : 1692, 1740
.   : milestone, 1716,
iast (1.476 ms) : 1453, 1499
.   : milestone, 1476,
profiling (1.519 ms) : 1493, 1545
.   : milestone, 1519,
tracing (1.468 ms) : 1444, 1492
.   : milestone, 1468,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.339 ms [1.32 ms, 1.359 ms] -
appsec 1.755 ms [1.732 ms, 1.778 ms] 415.735 µs (31.0%)
appsec_no_iast 1.694 ms [1.669 ms, 1.719 ms] 354.448 µs (26.5%)
iast 1.48 ms [1.458 ms, 1.503 ms] 140.772 µs (10.5%)
profiling 1.479 ms [1.454 ms, 1.503 ms] 139.072 µs (10.4%)
tracing 1.46 ms [1.436 ms, 1.485 ms] 120.961 µs (9.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.357 ms [1.338 ms, 1.376 ms] -
appsec 1.706 ms [1.681 ms, 1.731 ms] 349.087 µs (25.7%)
appsec_no_iast 1.716 ms [1.692 ms, 1.74 ms] 358.77 µs (26.4%)
iast 1.476 ms [1.453 ms, 1.499 ms] 118.916 µs (8.8%)
profiling 1.519 ms [1.493 ms, 1.545 ms] 161.645 µs (11.9%)
tracing 1.468 ms [1.444 ms, 1.492 ms] 110.98 µs (8.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita-tkachenko/suppress-git-upload-shutdown-hook-errors
git_commit_date 1718611431 1718612834
git_commit_sha 8f7a318 e9426d5
release_version 1.36.0-SNAPSHOT~8f7a318653 1.36.0-SNAPSHOT~e9426d54ca
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718615665 1718615665
ci_job_id 544784528 544784528
ci_pipeline_id 36873513 36873513
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~e9426d54ca, baseline=1.36.0-SNAPSHOT~8f7a318653
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.016 s) : 15016000, 15016000
.   : milestone, 15016000,
appsec (15.125 s) : 15125000, 15125000
.   : milestone, 15125000,
iast (18.704 s) : 18704000, 18704000
.   : milestone, 18704000,
iast_GLOBAL (18.036 s) : 18036000, 18036000
.   : milestone, 18036000,
profiling (15.159 s) : 15159000, 15159000
.   : milestone, 15159000,
tracing (15.039 s) : 15039000, 15039000
.   : milestone, 15039000,
section candidate
no_agent (15.48 s) : 15480000, 15480000
.   : milestone, 15480000,
appsec (14.942 s) : 14942000, 14942000
.   : milestone, 14942000,
iast (18.766 s) : 18766000, 18766000
.   : milestone, 18766000,
iast_GLOBAL (17.857 s) : 17857000, 17857000
.   : milestone, 17857000,
profiling (15.976 s) : 15976000, 15976000
.   : milestone, 15976000,
tracing (15.006 s) : 15006000, 15006000
.   : milestone, 15006000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.016 s [15.016 s, 15.016 s] -
appsec 15.125 s [15.125 s, 15.125 s] 109.0 ms (0.7%)
iast 18.704 s [18.704 s, 18.704 s] 3.688 s (24.6%)
iast_GLOBAL 18.036 s [18.036 s, 18.036 s] 3.02 s (20.1%)
profiling 15.159 s [15.159 s, 15.159 s] 143.0 ms (1.0%)
tracing 15.039 s [15.039 s, 15.039 s] 23.0 ms (0.2%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.48 s [15.48 s, 15.48 s] -
appsec 14.942 s [14.942 s, 14.942 s] -538.0 ms (-3.5%)
iast 18.766 s [18.766 s, 18.766 s] 3.286 s (21.2%)
iast_GLOBAL 17.857 s [17.857 s, 17.857 s] 2.377 s (15.4%)
profiling 15.976 s [15.976 s, 15.976 s] 496.0 ms (3.2%)
tracing 15.006 s [15.006 s, 15.006 s] -474.0 ms (-3.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~e9426d54ca, baseline=1.36.0-SNAPSHOT~8f7a318653
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.193 ms) : 2160, 2227
.   : milestone, 2193,
iast (1.97 ms) : 1928, 2011
.   : milestone, 1970,
iast_GLOBAL (1.997 ms) : 1956, 2037
.   : milestone, 1997,
profiling (1.865 ms) : 1830, 1900
.   : milestone, 1865,
tracing (1.836 ms) : 1805, 1868
.   : milestone, 1836,
section candidate
no_agent (1.464 ms) : 1452, 1475
.   : milestone, 1464,
appsec (2.228 ms) : 2193, 2263
.   : milestone, 2228,
iast (1.973 ms) : 1931, 2014
.   : milestone, 1973,
iast_GLOBAL (2.009 ms) : 1966, 2051
.   : milestone, 2009,
profiling (1.854 ms) : 1820, 1888
.   : milestone, 1854,
tracing (1.84 ms) : 1807, 1872
.   : milestone, 1840,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 2.193 ms [2.16 ms, 2.227 ms] 724.626 µs (49.3%)
iast 1.97 ms [1.928 ms, 2.011 ms] 501.039 µs (34.1%)
iast_GLOBAL 1.997 ms [1.956 ms, 2.037 ms] 528.033 µs (36.0%)
profiling 1.865 ms [1.83 ms, 1.9 ms] 396.444 µs (27.0%)
tracing 1.836 ms [1.805 ms, 1.868 ms] 367.599 µs (25.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.452 ms, 1.475 ms] -
appsec 2.228 ms [2.193 ms, 2.263 ms] 764.443 µs (52.2%)
iast 1.973 ms [1.931 ms, 2.014 ms] 509.008 µs (34.8%)
iast_GLOBAL 2.009 ms [1.966 ms, 2.051 ms] 545.139 µs (37.2%)
profiling 1.854 ms [1.82 ms, 1.888 ms] 390.474 µs (26.7%)
tracing 1.84 ms [1.807 ms, 1.872 ms] 376.052 µs (25.7%)

@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review June 17, 2024 10:53
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner June 17, 2024 10:53
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit 841d933 into master Jun 17, 2024
83 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/suppress-git-upload-shutdown-hook-errors branch June 17, 2024 13:11
@github-actions github-actions bot added this to the 1.35.1 milestone Jun 17, 2024
@mcculls mcculls modified the milestones: 1.35.1, 1.36.0 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainkomorndatadog romainkomorndatadog romainkomorndatadog approved these changes

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility
Projects
None yet
Milestone
1.36.0
Development

Successfully merging this pull request may close these issues.

java.lang.IllegalStateException: Shutdown in progress in dd-ci-git-data-uploader
3 participants
@nikita-tkachenko-datadog @romainkomorndatadog @mcculls