-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace string constants with a dedicated enum for test statuses #7218
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/test-status-enum
Jun 19, 2024
Merged
Replace string constants with a dedicated enum for test statuses #7218
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/test-status-enum
Jun 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-tkachenko-datadog
added
type: refactoring
comp: ci visibility
Continuous Integration Visibility
labels
Jun 19, 2024
anmarchenko
approved these changes
Jun 19, 2024
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~0022308e28, baseline=1.36.0-SNAPSHOT~7294eaf157
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061222
Total [baseline] (8.544 s) : 0, 8543853
Agent [candidate] (1.071 s) : 0, 1070609
Total [candidate] (8.564 s) : 0, 8564458
section iast
Agent [baseline] (1.168 s) : 0, 1168025
Total [baseline] (8.989 s) : 0, 8988838
Agent [candidate] (1.169 s) : 0, 1169393
Total [candidate] (8.991 s) : 0, 8991220
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171919
Total [baseline] (9.022 s) : 0, 9021947
Agent [candidate] (1.171 s) : 0, 1170959
Total [candidate] (8.987 s) : 0, 8986847
section iast_TELEMETRY_OFF
Agent [baseline] (1.163 s) : 0, 1163035
Total [baseline] (8.959 s) : 0, 8958966
Agent [candidate] (1.175 s) : 0, 1175404
Total [candidate] (9.014 s) : 0, 9013594
gantt
title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~0022308e28, baseline=1.36.0-SNAPSHOT~7294eaf157
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.769 ms) : 0, 664769
BytebuddyAgent [candidate] (671.101 ms) : 0, 671101
GlobalTracer [baseline] (303.467 ms) : 0, 303467
GlobalTracer [candidate] (305.968 ms) : 0, 305968
AppSec [baseline] (50.326 ms) : 0, 50326
AppSec [candidate] (50.681 ms) : 0, 50681
Remote Config [baseline] (683.868 µs) : 0, 684
Remote Config [candidate] (694.335 µs) : 0, 694
Telemetry [baseline] (7.568 ms) : 0, 7568
Telemetry [candidate] (7.672 ms) : 0, 7672
section iast
BytebuddyAgent [baseline] (779.107 ms) : 0, 779107
BytebuddyAgent [candidate] (781.23 ms) : 0, 781230
GlobalTracer [baseline] (292.524 ms) : 0, 292524
GlobalTracer [candidate] (293.521 ms) : 0, 293521
AppSec [baseline] (47.051 ms) : 0, 47051
AppSec [candidate] (47.057 ms) : 0, 47057
IAST [baseline] (27.781 ms) : 0, 27781
IAST [candidate] (26.708 ms) : 0, 26708
Remote Config [baseline] (594.355 µs) : 0, 594
Remote Config [candidate] (619.72 µs) : 0, 620
Telemetry [baseline] (7.679 ms) : 0, 7679
Telemetry [candidate] (6.963 ms) : 0, 6963
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.998 ms) : 0, 779998
BytebuddyAgent [candidate] (781.12 ms) : 0, 781120
GlobalTracer [baseline] (295.27 ms) : 0, 295270
GlobalTracer [candidate] (294.194 ms) : 0, 294194
AppSec [baseline] (47.428 ms) : 0, 47428
AppSec [candidate] (47.308 ms) : 0, 47308
IAST [baseline] (28.259 ms) : 0, 28259
IAST [candidate] (26.575 ms) : 0, 26575
Remote Config [baseline] (677.341 µs) : 0, 677
Remote Config [candidate] (649.116 µs) : 0, 649
Telemetry [baseline] (6.973 ms) : 0, 6973
Telemetry [candidate] (7.758 ms) : 0, 7758
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (774.607 ms) : 0, 774607
BytebuddyAgent [candidate] (783.971 ms) : 0, 783971
GlobalTracer [baseline] (293.098 ms) : 0, 293098
GlobalTracer [candidate] (295.666 ms) : 0, 295666
AppSec [baseline] (47.168 ms) : 0, 47168
AppSec [candidate] (47.453 ms) : 0, 47453
IAST [baseline] (25.916 ms) : 0, 25916
IAST [candidate] (25.801 ms) : 0, 25801
Remote Config [baseline] (590.176 µs) : 0, 590
Remote Config [candidate] (619.764 µs) : 0, 620
Telemetry [baseline] (8.358 ms) : 0, 8358
Telemetry [candidate] (8.471 ms) : 0, 8471
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~0022308e28, baseline=1.36.0-SNAPSHOT~7294eaf157
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1060611
Total [baseline] (10.387 s) : 0, 10386767
Agent [candidate] (1.069 s) : 0, 1068508
Total [candidate] (10.363 s) : 0, 10362851
section appsec
Agent [baseline] (1.182 s) : 0, 1181923
Total [baseline] (10.439 s) : 0, 10438501
Agent [candidate] (1.189 s) : 0, 1188614
Total [candidate] (10.49 s) : 0, 10490258
section iast
Agent [baseline] (1.169 s) : 0, 1168986
Total [baseline] (10.708 s) : 0, 10708159
Agent [candidate] (1.179 s) : 0, 1179054
Total [candidate] (10.666 s) : 0, 10666457
section profiling
Agent [baseline] (1.273 s) : 0, 1272771
Total [baseline] (10.621 s) : 0, 10621420
Agent [candidate] (1.263 s) : 0, 1262561
Total [candidate] (10.643 s) : 0, 10642793
gantt
title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~0022308e28, baseline=1.36.0-SNAPSHOT~7294eaf157
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (664.777 ms) : 0, 664777
BytebuddyAgent [candidate] (669.767 ms) : 0, 669767
GlobalTracer [baseline] (303.14 ms) : 0, 303140
GlobalTracer [candidate] (305.183 ms) : 0, 305183
AppSec [baseline] (50.012 ms) : 0, 50012
AppSec [candidate] (50.579 ms) : 0, 50579
Remote Config [baseline] (683.467 µs) : 0, 683
Remote Config [candidate] (686.793 µs) : 0, 687
Telemetry [baseline] (7.618 ms) : 0, 7618
Telemetry [candidate] (7.628 ms) : 0, 7628
section appsec
BytebuddyAgent [baseline] (676.32 ms) : 0, 676320
BytebuddyAgent [candidate] (680.482 ms) : 0, 680482
GlobalTracer [baseline] (297.678 ms) : 0, 297678
GlobalTracer [candidate] (299.2 ms) : 0, 299200
AppSec [baseline] (153.86 ms) : 0, 153860
AppSec [candidate] (154.431 ms) : 0, 154431
IAST [baseline] (21.673 ms) : 0, 21673
IAST [candidate] (20.675 ms) : 0, 20675
Remote Config [baseline] (641.168 µs) : 0, 641
Remote Config [candidate] (634.864 µs) : 0, 635
Telemetry [baseline] (8.116 ms) : 0, 8116
Telemetry [candidate] (8.83 ms) : 0, 8830
section iast
BytebuddyAgent [baseline] (780.216 ms) : 0, 780216
BytebuddyAgent [candidate] (785.934 ms) : 0, 785934
GlobalTracer [baseline] (293.709 ms) : 0, 293709
GlobalTracer [candidate] (295.94 ms) : 0, 295940
AppSec [baseline] (47.06 ms) : 0, 47060
AppSec [candidate] (47.423 ms) : 0, 47423
IAST [baseline] (26.262 ms) : 0, 26262
IAST [candidate] (28.833 ms) : 0, 28833
Remote Config [baseline] (696.485 µs) : 0, 696
Remote Config [candidate] (591.928 µs) : 0, 592
Telemetry [baseline] (7.737 ms) : 0, 7737
Telemetry [candidate] (6.925 ms) : 0, 6925
section profiling
BytebuddyAgent [baseline] (668.829 ms) : 0, 668829
BytebuddyAgent [candidate] (663.116 ms) : 0, 663116
GlobalTracer [baseline] (388.43 ms) : 0, 388430
GlobalTracer [candidate] (386.442 ms) : 0, 386442
AppSec [baseline] (51.89 ms) : 0, 51890
AppSec [candidate] (51.541 ms) : 0, 51541
Remote Config [baseline] (737.525 µs) : 0, 738
Remote Config [candidate] (740.618 µs) : 0, 741
Telemetry [baseline] (7.484 ms) : 0, 7484
Telemetry [candidate] (7.423 ms) : 0, 7423
ProfilingAgent [baseline] (97.914 ms) : 0, 97914
ProfilingAgent [candidate] (96.203 ms) : 0, 96203
Profiling [baseline] (97.939 ms) : 0, 97939
Profiling [candidate] (96.228 ms) : 0, 96228
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~0022308e28, baseline=1.36.0-SNAPSHOT~7294eaf157
dateFormat X
axisFormat %s
section baseline
no_agent (1.365 ms) : 1345, 1384
. : milestone, 1365,
appsec (1.734 ms) : 1709, 1758
. : milestone, 1734,
appsec_no_iast (1.715 ms) : 1690, 1740
. : milestone, 1715,
iast (1.487 ms) : 1464, 1510
. : milestone, 1487,
profiling (1.499 ms) : 1475, 1523
. : milestone, 1499,
tracing (1.462 ms) : 1438, 1486
. : milestone, 1462,
section candidate
no_agent (1.372 ms) : 1353, 1392
. : milestone, 1372,
appsec (1.72 ms) : 1696, 1744
. : milestone, 1720,
appsec_no_iast (1.716 ms) : 1691, 1742
. : milestone, 1716,
iast (1.494 ms) : 1472, 1517
. : milestone, 1494,
profiling (1.488 ms) : 1463, 1513
. : milestone, 1488,
tracing (1.486 ms) : 1462, 1510
. : milestone, 1486,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~0022308e28, baseline=1.36.0-SNAPSHOT~7294eaf157
dateFormat X
axisFormat %s
section baseline
no_agent (377.125 µs) : 358, 397
. : milestone, 377,
iast (488.268 µs) : 467, 509
. : milestone, 488,
iast_FULL (563.259 µs) : 542, 585
. : milestone, 563,
iast_GLOBAL (507.846 µs) : 487, 529
. : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (485.674 µs) : 465, 507
. : milestone, 486,
iast_INACTIVE (459.604 µs) : 438, 481
. : milestone, 460,
iast_TELEMETRY_OFF (481.2 µs) : 460, 503
. : milestone, 481,
tracing (446.879 µs) : 426, 467
. : milestone, 447,
section candidate
no_agent (371.004 µs) : 352, 390
. : milestone, 371,
iast (492.187 µs) : 471, 514
. : milestone, 492,
iast_FULL (558.901 µs) : 538, 580
. : milestone, 559,
iast_GLOBAL (512.272 µs) : 491, 533
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (491.105 µs) : 470, 513
. : milestone, 491,
iast_INACTIVE (462.351 µs) : 441, 484
. : milestone, 462,
iast_TELEMETRY_OFF (473.053 µs) : 452, 494
. : milestone, 473,
tracing (449.901 µs) : 429, 471
. : milestone, 450,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~0022308e28, baseline=1.36.0-SNAPSHOT~7294eaf157
dateFormat X
axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
. : milestone, 1464,
appsec (2.219 ms) : 2185, 2254
. : milestone, 2219,
iast (1.985 ms) : 1942, 2027
. : milestone, 1985,
iast_GLOBAL (2.028 ms) : 1986, 2070
. : milestone, 2028,
profiling (1.845 ms) : 1811, 1879
. : milestone, 1845,
tracing (1.836 ms) : 1804, 1868
. : milestone, 1836,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.217 ms) : 2182, 2251
. : milestone, 2217,
iast (1.986 ms) : 1944, 2028
. : milestone, 1986,
iast_GLOBAL (2.008 ms) : 1967, 2049
. : milestone, 2008,
profiling (1.878 ms) : 1844, 1912
. : milestone, 1878,
tracing (1.836 ms) : 1804, 1868
. : milestone, 1836,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~0022308e28, baseline=1.36.0-SNAPSHOT~7294eaf157
dateFormat X
axisFormat %s
section baseline
no_agent (15.415 s) : 15415000, 15415000
. : milestone, 15415000,
appsec (14.952 s) : 14952000, 14952000
. : milestone, 14952000,
iast (18.864 s) : 18864000, 18864000
. : milestone, 18864000,
iast_GLOBAL (17.953 s) : 17953000, 17953000
. : milestone, 17953000,
profiling (15.72 s) : 15720000, 15720000
. : milestone, 15720000,
tracing (15.192 s) : 15192000, 15192000
. : milestone, 15192000,
section candidate
no_agent (15.423 s) : 15423000, 15423000
. : milestone, 15423000,
appsec (15.062 s) : 15062000, 15062000
. : milestone, 15062000,
iast (18.869 s) : 18869000, 18869000
. : milestone, 18869000,
iast_GLOBAL (17.765 s) : 17765000, 17765000
. : milestone, 17765000,
profiling (15.631 s) : 15631000, 15631000
. : milestone, 15631000,
tracing (15.007 s) : 15007000, 15007000
. : milestone, 15007000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Updates CI Visibility code to use a dedicated enum for test statuses, rather than a set of string constants.
Jira ticket: SDTEST-473