enable timeline events by default when ddprof disabled #7224

richardstartin · 2024-06-20T10:17:14Z

What Does This Do

Enables timeline events by default when JFR profiler is used, which allows for better integration into the timeline.

Motivation

Additional Notes

jbachorik · 2024-06-20T10:25:38Z

dd-trace-api/src/main/java/datadog/trace/api/config/ProfilingConfig.java

@@ -216,7 +216,7 @@ public final class ProfilingConfig {

  public static final String PROFILING_TIMELINE_EVENTS_ENABLED =
      "profiling.timeline.events.enabled";
-  public static final boolean PROFILING_TIMELINE_EVENTS_ENABLED_DEFAULT = false;
+  public static final boolean PROFILING_TIMELINE_EVENTS_ENABLED_DEFAULT = true;


This will always enable thoese events, not only when ddprof is disabled, correct?

Only when ddprof is disabled (or DatadogProfilingIntegration fails to load) according to the logic in Agent#createProfilingContextIntegration

Ok. Can you add a comment for the default, please?

pr-commenter · 2024-06-20T11:09:40Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	rgs/timeline-events-default
git_commit_date	1718873384	1718878556
git_commit_sha	`01fd984`	`484ef6c`
release_version	1.36.0-SNAPSHOT~01fd984c16	1.36.0-SNAPSHOT~484ef6ccba

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1718881608	1718881608
ci_job_id	548729885	548729885
ci_pipeline_id	37156045	37156045
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~484ef6ccba, baseline=1.36.0-SNAPSHOT~01fd984c16

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.068 s) : 0, 1067557
Total [baseline] (8.608 s) : 0, 8607765
Agent [candidate] (1.062 s) : 0, 1061884
Total [candidate] (8.542 s) : 0, 8542423
section iast
Agent [baseline] (1.17 s) : 0, 1169863
Total [baseline] (9.001 s) : 0, 9000844
Agent [candidate] (1.171 s) : 0, 1170681
Total [candidate] (8.997 s) : 0, 8997457
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.17 s) : 0, 1170180
Total [baseline] (8.994 s) : 0, 8994175
Agent [candidate] (1.172 s) : 0, 1172238
Total [candidate] (8.959 s) : 0, 8959377
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1168984
Total [baseline] (9.01 s) : 0, 9009685
Agent [candidate] (1.172 s) : 0, 1172332
Total [candidate] (9.022 s) : 0, 9021745

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.068 s	-
Agent	iast	1.17 s	102.306 ms (9.6%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.17 s	102.623 ms (9.6%)
Agent	iast_TELEMETRY_OFF	1.169 s	101.427 ms (9.5%)
Total	tracing	8.608 s	-
Total	iast	9.001 s	393.079 ms (4.6%)
Total	iast_HARDCODED_SECRET_DISABLED	8.994 s	386.41 ms (4.5%)
Total	iast_TELEMETRY_OFF	9.01 s	401.92 ms (4.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.062 s	-
Agent	iast	1.171 s	108.797 ms (10.2%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.172 s	110.354 ms (10.4%)
Agent	iast_TELEMETRY_OFF	1.172 s	110.447 ms (10.4%)
Total	tracing	8.542 s	-
Total	iast	8.997 s	455.033 ms (5.3%)
Total	iast_HARDCODED_SECRET_DISABLED	8.959 s	416.954 ms (4.9%)
Total	iast_TELEMETRY_OFF	9.022 s	479.321 ms (5.6%)

gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~484ef6ccba, baseline=1.36.0-SNAPSHOT~01fd984c16

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.089 ms) : 0, 669089
BytebuddyAgent [candidate] (665.802 ms) : 0, 665802
GlobalTracer [baseline] (305.203 ms) : 0, 305203
GlobalTracer [candidate] (303.506 ms) : 0, 303506
AppSec [baseline] (50.452 ms) : 0, 50452
AppSec [candidate] (50.009 ms) : 0, 50009
Remote Config [baseline] (684.467 µs) : 0, 684
Remote Config [candidate] (678.093 µs) : 0, 678
Telemetry [baseline] (7.59 ms) : 0, 7590
Telemetry [candidate] (7.568 ms) : 0, 7568
section iast
BytebuddyAgent [baseline] (780.106 ms) : 0, 780106
BytebuddyAgent [candidate] (779.953 ms) : 0, 779953
GlobalTracer [baseline] (293.078 ms) : 0, 293078
GlobalTracer [candidate] (293.218 ms) : 0, 293218
AppSec [baseline] (47.09 ms) : 0, 47090
AppSec [candidate] (47.231 ms) : 0, 47231
IAST [baseline] (28.809 ms) : 0, 28809
IAST [candidate] (28.495 ms) : 0, 28495
Remote Config [baseline] (628.939 µs) : 0, 629
Remote Config [candidate] (682.421 µs) : 0, 682
Telemetry [baseline] (6.891 ms) : 0, 6891
Telemetry [candidate] (7.823 ms) : 0, 7823
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (780.377 ms) : 0, 780377
BytebuddyAgent [candidate] (781.345 ms) : 0, 781345
GlobalTracer [baseline] (293.767 ms) : 0, 293767
GlobalTracer [candidate] (294.167 ms) : 0, 294167
AppSec [baseline] (47.374 ms) : 0, 47374
AppSec [candidate] (47.345 ms) : 0, 47345
IAST [baseline] (27.735 ms) : 0, 27735
IAST [candidate] (27.515 ms) : 0, 27515
Remote Config [baseline] (647.434 µs) : 0, 647
Remote Config [candidate] (698.819 µs) : 0, 699
Telemetry [baseline] (6.963 ms) : 0, 6963
Telemetry [candidate] (7.814 ms) : 0, 7814
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.977 ms) : 0, 779977
BytebuddyAgent [candidate] (782.215 ms) : 0, 782215
GlobalTracer [baseline] (294.946 ms) : 0, 294946
GlobalTracer [candidate] (293.588 ms) : 0, 293588
AppSec [baseline] (47.081 ms) : 0, 47081
AppSec [candidate] (47.036 ms) : 0, 47036
IAST [baseline] (25.319 ms) : 0, 25319
IAST [candidate] (27.064 ms) : 0, 27064
Remote Config [baseline] (603.449 µs) : 0, 603
Remote Config [candidate] (593.382 µs) : 0, 593
Telemetry [baseline] (7.725 ms) : 0, 7725
Telemetry [candidate] (8.437 ms) : 0, 8437

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~484ef6ccba, baseline=1.36.0-SNAPSHOT~01fd984c16

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.061 s) : 0, 1061258
Total [baseline] (10.457 s) : 0, 10457095
Agent [candidate] (1.061 s) : 0, 1061048
Total [candidate] (10.373 s) : 0, 10373351
section appsec
Agent [baseline] (1.186 s) : 0, 1185928
Total [baseline] (10.456 s) : 0, 10456394
Agent [candidate] (1.182 s) : 0, 1182132
Total [candidate] (10.494 s) : 0, 10494153
section iast
Agent [baseline] (1.171 s) : 0, 1171163
Total [baseline] (10.65 s) : 0, 10650079
Agent [candidate] (1.173 s) : 0, 1172765
Total [candidate] (10.73 s) : 0, 10730018
section profiling
Agent [baseline] (1.272 s) : 0, 1272495
Total [baseline] (10.722 s) : 0, 10721648
Agent [candidate] (1.268 s) : 0, 1268421
Total [candidate] (10.688 s) : 0, 10687525

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.061 s	-
Agent	appsec	1.186 s	124.67 ms (11.7%)
Agent	iast	1.171 s	109.905 ms (10.4%)
Agent	profiling	1.272 s	211.237 ms (19.9%)
Total	tracing	10.457 s	-
Total	appsec	10.456 s	-700.513 µs (-0.0%)
Total	iast	10.65 s	192.984 ms (1.8%)
Total	profiling	10.722 s	264.553 ms (2.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.061 s	-
Agent	appsec	1.182 s	121.085 ms (11.4%)
Agent	iast	1.173 s	111.717 ms (10.5%)
Agent	profiling	1.268 s	207.374 ms (19.5%)
Total	tracing	10.373 s	-
Total	appsec	10.494 s	120.802 ms (1.2%)
Total	iast	10.73 s	356.667 ms (3.4%)
Total	profiling	10.688 s	314.175 ms (3.0%)

gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~484ef6ccba, baseline=1.36.0-SNAPSHOT~01fd984c16

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.228 ms) : 0, 665228
BytebuddyAgent [candidate] (665.115 ms) : 0, 665115
GlobalTracer [baseline] (303.629 ms) : 0, 303629
GlobalTracer [candidate] (303.148 ms) : 0, 303148
AppSec [baseline] (49.891 ms) : 0, 49891
AppSec [candidate] (50.289 ms) : 0, 50289
Remote Config [baseline] (687.019 µs) : 0, 687
Remote Config [candidate] (682.195 µs) : 0, 682
Telemetry [baseline] (7.554 ms) : 0, 7554
Telemetry [candidate] (7.572 ms) : 0, 7572
section appsec
BytebuddyAgent [baseline] (678.355 ms) : 0, 678355
BytebuddyAgent [candidate] (676.484 ms) : 0, 676484
GlobalTracer [baseline] (298.038 ms) : 0, 298038
GlobalTracer [candidate] (297.65 ms) : 0, 297650
AppSec [baseline] (154.266 ms) : 0, 154266
AppSec [candidate] (153.908 ms) : 0, 153908
Remote Config [baseline] (634.564 µs) : 0, 635
Remote Config [candidate] (630.181 µs) : 0, 630
Telemetry [baseline] (9.534 ms) : 0, 9534
Telemetry [candidate] (8.84 ms) : 0, 8840
IAST [baseline] (21.085 ms) : 0, 21085
IAST [candidate] (20.237 ms) : 0, 20237
section iast
BytebuddyAgent [baseline] (781.339 ms) : 0, 781339
BytebuddyAgent [candidate] (782.341 ms) : 0, 782341
GlobalTracer [baseline] (293.946 ms) : 0, 293946
GlobalTracer [candidate] (294.675 ms) : 0, 294675
AppSec [baseline] (47.122 ms) : 0, 47122
AppSec [candidate] (46.992 ms) : 0, 46992
Remote Config [baseline] (609.797 µs) : 0, 610
Remote Config [candidate] (645.805 µs) : 0, 646
Telemetry [baseline] (6.868 ms) : 0, 6868
Telemetry [candidate] (6.891 ms) : 0, 6891
IAST [baseline] (27.98 ms) : 0, 27980
IAST [candidate] (27.907 ms) : 0, 27907
section profiling
ProfilingAgent [baseline] (97.116 ms) : 0, 97116
ProfilingAgent [candidate] (96.527 ms) : 0, 96527
BytebuddyAgent [baseline] (668.81 ms) : 0, 668810
BytebuddyAgent [candidate] (668.03 ms) : 0, 668030
GlobalTracer [baseline] (388.84 ms) : 0, 388840
GlobalTracer [candidate] (386.601 ms) : 0, 386601
AppSec [baseline] (52.035 ms) : 0, 52035
AppSec [candidate] (51.724 ms) : 0, 51724
Remote Config [baseline] (750.805 µs) : 0, 751
Remote Config [candidate] (747.311 µs) : 0, 747
Telemetry [baseline] (7.414 ms) : 0, 7414
Telemetry [candidate] (7.442 ms) : 0, 7442
Profiling [baseline] (97.141 ms) : 0, 97141
Profiling [candidate] (96.551 ms) : 0, 96551

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-06-20T10:37:40	2024-06-20T10:44:32
git_branch	master	rgs/timeline-events-default
git_commit_date	1718873384	1718878556
git_commit_sha	`01fd984`	`484ef6c`
release_version	1.36.0-SNAPSHOT~01fd984c16	1.36.0-SNAPSHOT~484ef6ccba
start_time	2024-06-20T10:37:26	2024-06-20T10:44:18

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1718880623	1718880623
ci_job_id	548729886	548729886
ci_pipeline_id	37156045	37156045
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~484ef6ccba, baseline=1.36.0-SNAPSHOT~01fd984c16
    dateFormat X
    axisFormat %s
section baseline
no_agent (375.855 µs) : 356, 396
.   : milestone, 376,
iast (487.946 µs) : 467, 509
.   : milestone, 488,
iast_FULL (562.367 µs) : 541, 584
.   : milestone, 562,
iast_GLOBAL (510.063 µs) : 489, 531
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (498.763 µs) : 477, 521
.   : milestone, 499,
iast_INACTIVE (460.86 µs) : 439, 482
.   : milestone, 461,
iast_TELEMETRY_OFF (483.374 µs) : 461, 506
.   : milestone, 483,
tracing (450.929 µs) : 431, 471
.   : milestone, 451,
section candidate
no_agent (370.375 µs) : 350, 391
.   : milestone, 370,
iast (502.249 µs) : 480, 524
.   : milestone, 502,
iast_FULL (560.948 µs) : 539, 583
.   : milestone, 561,
iast_GLOBAL (525.753 µs) : 503, 549
.   : milestone, 526,
iast_HARDCODED_SECRET_DISABLED (494.605 µs) : 473, 516
.   : milestone, 495,
iast_INACTIVE (467.879 µs) : 446, 490
.   : milestone, 468,
iast_TELEMETRY_OFF (483.396 µs) : 462, 505
.   : milestone, 483,
tracing (444.662 µs) : 425, 465
.   : milestone, 445,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	375.855 µs [355.701 µs, 396.008 µs]	-
iast	487.946 µs [466.733 µs, 509.159 µs]	112.092 µs (29.8%)
iast_FULL	562.367 µs [541.137 µs, 583.598 µs]	186.513 µs (49.6%)
iast_GLOBAL	510.063 µs [488.961 µs, 531.166 µs]	134.209 µs (35.7%)
iast_HARDCODED_SECRET_DISABLED	498.763 µs [476.516 µs, 521.01 µs]	122.908 µs (32.7%)
iast_INACTIVE	460.86 µs [439.486 µs, 482.234 µs]	85.005 µs (22.6%)
iast_TELEMETRY_OFF	483.374 µs [461.051 µs, 505.697 µs]	107.52 µs (28.6%)
tracing	450.929 µs [430.634 µs, 471.224 µs]	75.074 µs (20.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	370.375 µs [350.015 µs, 390.736 µs]	-
iast	502.249 µs [480.243 µs, 524.255 µs]	131.874 µs (35.6%)
iast_FULL	560.948 µs [539.38 µs, 582.516 µs]	190.573 µs (51.5%)
iast_GLOBAL	525.753 µs [502.693 µs, 548.814 µs]	155.378 µs (42.0%)
iast_HARDCODED_SECRET_DISABLED	494.605 µs [473.169 µs, 516.042 µs]	124.23 µs (33.5%)
iast_INACTIVE	467.879 µs [445.742 µs, 490.016 µs]	97.503 µs (26.3%)
iast_TELEMETRY_OFF	483.396 µs [461.741 µs, 505.051 µs]	113.021 µs (30.5%)
tracing	444.662 µs [424.635 µs, 464.689 µs]	74.287 µs (20.1%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~484ef6ccba, baseline=1.36.0-SNAPSHOT~01fd984c16
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.35 ms) : 1330, 1370
.   : milestone, 1350,
appsec (1.753 ms) : 1728, 1777
.   : milestone, 1753,
appsec_no_iast (1.728 ms) : 1703, 1753
.   : milestone, 1728,
iast (1.49 ms) : 1467, 1513
.   : milestone, 1490,
profiling (1.513 ms) : 1488, 1538
.   : milestone, 1513,
tracing (1.478 ms) : 1454, 1502
.   : milestone, 1478,
section candidate
no_agent (1.37 ms) : 1351, 1390
.   : milestone, 1370,
appsec (1.761 ms) : 1738, 1784
.   : milestone, 1761,
appsec_no_iast (1.736 ms) : 1711, 1761
.   : milestone, 1736,
iast (1.519 ms) : 1497, 1541
.   : milestone, 1519,
profiling (1.56 ms) : 1534, 1586
.   : milestone, 1560,
tracing (1.504 ms) : 1480, 1529
.   : milestone, 1504,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.35 ms [1.33 ms, 1.37 ms]	-
appsec	1.753 ms [1.728 ms, 1.777 ms]	402.842 µs (29.8%)
appsec_no_iast	1.728 ms [1.703 ms, 1.753 ms]	378.155 µs (28.0%)
iast	1.49 ms [1.467 ms, 1.513 ms]	139.737 µs (10.4%)
profiling	1.513 ms [1.488 ms, 1.538 ms]	162.823 µs (12.1%)
tracing	1.478 ms [1.454 ms, 1.502 ms]	128.075 µs (9.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.37 ms [1.351 ms, 1.39 ms]	-
appsec	1.761 ms [1.738 ms, 1.784 ms]	390.819 µs (28.5%)
appsec_no_iast	1.736 ms [1.711 ms, 1.761 ms]	365.485 µs (26.7%)
iast	1.519 ms [1.497 ms, 1.541 ms]	148.76 µs (10.9%)
profiling	1.56 ms [1.534 ms, 1.586 ms]	189.789 µs (13.8%)
tracing	1.504 ms [1.48 ms, 1.529 ms]	133.778 µs (9.8%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	rgs/timeline-events-default
git_commit_date	1718873384	1718878556
git_commit_sha	`01fd984`	`484ef6c`
release_version	1.36.0-SNAPSHOT~01fd984c16	1.36.0-SNAPSHOT~484ef6ccba

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1718881115	1718881115
ci_job_id	548729887	548729887
ci_pipeline_id	37156045	37156045
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~484ef6ccba, baseline=1.36.0-SNAPSHOT~01fd984c16
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.461 ms) : 1449, 1472
.   : milestone, 1461,
appsec (2.196 ms) : 2162, 2230
.   : milestone, 2196,
iast (1.956 ms) : 1915, 1998
.   : milestone, 1956,
iast_GLOBAL (1.996 ms) : 1955, 2037
.   : milestone, 1996,
profiling (1.839 ms) : 1806, 1873
.   : milestone, 1839,
tracing (1.822 ms) : 1790, 1854
.   : milestone, 1822,
section candidate
no_agent (1.462 ms) : 1450, 1473
.   : milestone, 1462,
appsec (2.196 ms) : 2162, 2229
.   : milestone, 2196,
iast (1.966 ms) : 1924, 2008
.   : milestone, 1966,
iast_GLOBAL (1.996 ms) : 1955, 2037
.   : milestone, 1996,
profiling (1.838 ms) : 1805, 1871
.   : milestone, 1838,
tracing (1.819 ms) : 1787, 1851
.   : milestone, 1819,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.461 ms [1.449 ms, 1.472 ms]	-
appsec	2.196 ms [2.162 ms, 2.23 ms]	735.554 µs (50.4%)
iast	1.956 ms [1.915 ms, 1.998 ms]	495.567 µs (33.9%)
iast_GLOBAL	1.996 ms [1.955 ms, 2.037 ms]	535.307 µs (36.6%)
profiling	1.839 ms [1.806 ms, 1.873 ms]	378.777 µs (25.9%)
tracing	1.822 ms [1.79 ms, 1.854 ms]	361.339 µs (24.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.462 ms [1.45 ms, 1.473 ms]	-
appsec	2.196 ms [2.162 ms, 2.229 ms]	733.728 µs (50.2%)
iast	1.966 ms [1.924 ms, 2.008 ms]	504.076 µs (34.5%)
iast_GLOBAL	1.996 ms [1.955 ms, 2.037 ms]	533.706 µs (36.5%)
profiling	1.838 ms [1.805 ms, 1.871 ms]	376.393 µs (25.7%)
tracing	1.819 ms [1.787 ms, 1.851 ms]	356.992 µs (24.4%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~484ef6ccba, baseline=1.36.0-SNAPSHOT~01fd984c16
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.817 s) : 14817000, 14817000
.   : milestone, 14817000,
appsec (15.122 s) : 15122000, 15122000
.   : milestone, 15122000,
iast (18.748 s) : 18748000, 18748000
.   : milestone, 18748000,
iast_GLOBAL (17.978 s) : 17978000, 17978000
.   : milestone, 17978000,
profiling (15.243 s) : 15243000, 15243000
.   : milestone, 15243000,
tracing (15.328 s) : 15328000, 15328000
.   : milestone, 15328000,
section candidate
no_agent (15.023 s) : 15023000, 15023000
.   : milestone, 15023000,
appsec (15.164 s) : 15164000, 15164000
.   : milestone, 15164000,
iast (18.688 s) : 18688000, 18688000
.   : milestone, 18688000,
iast_GLOBAL (18.058 s) : 18058000, 18058000
.   : milestone, 18058000,
profiling (15.623 s) : 15623000, 15623000
.   : milestone, 15623000,
tracing (15.182 s) : 15182000, 15182000
.   : milestone, 15182000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.817 s [14.817 s, 14.817 s]	-
appsec	15.122 s [15.122 s, 15.122 s]	305.0 ms (2.1%)
iast	18.748 s [18.748 s, 18.748 s]	3.931 s (26.5%)
iast_GLOBAL	17.978 s [17.978 s, 17.978 s]	3.161 s (21.3%)
profiling	15.243 s [15.243 s, 15.243 s]	426.0 ms (2.9%)
tracing	15.328 s [15.328 s, 15.328 s]	511.0 ms (3.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.023 s [15.023 s, 15.023 s]	-
appsec	15.164 s [15.164 s, 15.164 s]	141.0 ms (0.9%)
iast	18.688 s [18.688 s, 18.688 s]	3.665 s (24.4%)
iast_GLOBAL	18.058 s [18.058 s, 18.058 s]	3.035 s (20.2%)
profiling	15.623 s [15.623 s, 15.623 s]	600.0 ms (4.0%)
tracing	15.182 s [15.182 s, 15.182 s]	159.0 ms (1.1%)

enable timeline events by default when ddprof disabled

484ef6c

richardstartin added the comp: profiling Profiling label Jun 20, 2024

richardstartin requested a review from a team June 20, 2024 10:17

richardstartin requested a review from a team as a code owner June 20, 2024 10:17

richardstartin requested review from dougqh and ygree June 20, 2024 10:17

jbachorik reviewed Jun 20, 2024

View reviewed changes

jbachorik approved these changes Jun 20, 2024

View reviewed changes

richardstartin merged commit 9bf5bbd into master Jun 20, 2024
84 checks passed

richardstartin deleted the rgs/timeline-events-default branch June 20, 2024 15:11

github-actions bot added this to the 1.36.0 milestone Jun 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable timeline events by default when ddprof disabled #7224

enable timeline events by default when ddprof disabled #7224

richardstartin commented Jun 20, 2024 •

edited by jira bot

Loading

jbachorik Jun 20, 2024 •

edited

Loading

richardstartin Jun 20, 2024

jbachorik Jun 20, 2024

pr-commenter bot commented Jun 20, 2024

enable timeline events by default when ddprof disabled #7224

enable timeline events by default when ddprof disabled #7224

Conversation

richardstartin commented Jun 20, 2024 • edited by jira bot Loading

What Does This Do

Motivation

Additional Notes

jbachorik Jun 20, 2024 • edited Loading

Choose a reason for hiding this comment

richardstartin Jun 20, 2024

Choose a reason for hiding this comment

jbachorik Jun 20, 2024

Choose a reason for hiding this comment

pr-commenter bot commented Jun 20, 2024

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

richardstartin commented Jun 20, 2024 •

edited by jira bot

Loading

jbachorik Jun 20, 2024 •

edited

Loading