Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track JVM RSS in JDK 21+ #7227

Merged
merged 18 commits into from
Jul 10, 2024
Merged

Track JVM RSS in JDK 21+ #7227

merged 18 commits into from
Jul 10, 2024

Conversation

MattAlp
Copy link
Contributor

@MattAlp MattAlp commented Jun 20, 2024 •
edited
Loading

What Does This Do

This is a new PR following an extension of #7107's original changes + my botching of the commit history.

This PR is responsible for reading fromprocfs' smaps entries for JVMs running on Linux, and optionally using existing NMT region annotations in JDK22+ (for now) to identify where the RSS is coming from.

Motivation

NMT within the JVM does not account for tracking of all memory used by the process itself, which means that the NMT timeseries metrics we report are underestimating the real memory usage of the JVM (i.e. from the JVM itself, or native libraries used via JNI). See the discrepancy in reported memory vs actual memory usage below; this is particularly problematic when running within containers, where the heap may be sized correctly relative to the available memory, but the overall usage exceeds what is available leading to an OOMKill.

image image (Note around 1GB of memory out of 4 that is not tracked via NMT).

Additional Notes

  • The pattern matching used for parsing System.map output and the MBean interactions are a little hacky, but prevent us from needing to dive into VMStructs or working on OpenJDK to start collecting this data. Open to feedback for cleaning this up.
  • Integration testing for this feature is nonexistent, open to pushback here as well.

Jira ticket: PROF-9851

@MattAlp MattAlp requested review from a team as code owners June 20, 2024 18:32
@pr-commenter
Copy link

pr-commenter bot commented Jun 20, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mattalp/smaps-rebased
git_commit_date 1720619307 1720634694
git_commit_sha 120b584 d2672ea
release_version 1.38.0-SNAPSHOT~120b584fde 1.36.0-SNAPSHOT~d2672ea954
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720637585 1720637585
ci_job_id 568655595 568655595
ci_pipeline_id 38871494 38871494
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 50 metrics, 12 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:petclinic:profiling:Remote Config worse
[+69.708µs; +108.712µs] or [+10.823%; +16.879%]		 733.271µs 644.061µs
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~d2672ea954, baseline=1.38.0-SNAPSHOT~120b584fde

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.073 s) : 0, 1072873
Total [baseline] (8.518 s) : 0, 8518172
Agent [candidate] (1.059 s) : 0, 1058919
Total [candidate] (8.502 s) : 0, 8501768
section iast
Agent [baseline] (1.169 s) : 0, 1168982
Total [baseline] (8.98 s) : 0, 8980220
Agent [candidate] (1.168 s) : 0, 1167679
Total [candidate] (8.977 s) : 0, 8977133
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.17 s) : 0, 1169607
Total [baseline] (8.93 s) : 0, 8930420
Agent [candidate] (1.173 s) : 0, 1173260
Total [candidate] (8.967 s) : 0, 8967138
section iast_TELEMETRY_OFF
Agent [baseline] (1.168 s) : 0, 1168116
Total [baseline] (8.948 s) : 0, 8947741
Agent [candidate] (1.167 s) : 0, 1166612
Total [candidate] (8.947 s) : 0, 8946538
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.073 s -
Agent iast 1.169 s 96.109 ms (9.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.17 s 96.734 ms (9.0%)
Agent iast_TELEMETRY_OFF 1.168 s 95.243 ms (8.9%)
Total tracing 8.518 s -
Total iast 8.98 s 462.047 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.93 s 412.248 ms (4.8%)
Total iast_TELEMETRY_OFF 8.948 s 429.569 ms (5.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent iast 1.168 s 108.76 ms (10.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.173 s 114.341 ms (10.8%)
Agent iast_TELEMETRY_OFF 1.167 s 107.694 ms (10.2%)
Total tracing 8.502 s -
Total iast 8.977 s 475.364 ms (5.6%)
Total iast_HARDCODED_SECRET_DISABLED 8.967 s 465.37 ms (5.5%)
Total iast_TELEMETRY_OFF 8.947 s 444.769 ms (5.2%) 
gantt
    title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~d2672ea954, baseline=1.38.0-SNAPSHOT~120b584fde

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (673.706 ms) : 0, 673706
BytebuddyAgent [candidate] (662.825 ms) : 0, 662825
GlobalTracer [baseline] (305.759 ms) : 0, 305759
GlobalTracer [candidate] (303.54 ms) : 0, 303540
AppSec [baseline] (50.03 ms) : 0, 50030
AppSec [candidate] (50.019 ms) : 0, 50019
Remote Config [baseline] (677.222 µs) : 0, 677
Remote Config [candidate] (681.131 µs) : 0, 681
Telemetry [baseline] (7.673 ms) : 0, 7673
Telemetry [candidate] (7.556 ms) : 0, 7556
section iast
BytebuddyAgent [baseline] (779.006 ms) : 0, 779006
BytebuddyAgent [candidate] (777.772 ms) : 0, 777772
GlobalTracer [baseline] (295.452 ms) : 0, 295452
GlobalTracer [candidate] (293.381 ms) : 0, 293381
AppSec [baseline] (47.251 ms) : 0, 47251
AppSec [candidate] (46.949 ms) : 0, 46949
IAST [baseline] (26.238 ms) : 0, 26238
IAST [candidate] (28.802 ms) : 0, 28802
Remote Config [baseline] (573.489 µs) : 0, 573
Remote Config [candidate] (635.264 µs) : 0, 635
Telemetry [baseline] (7.017 ms) : 0, 7017
Telemetry [candidate] (6.877 ms) : 0, 6877
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (778.029 ms) : 0, 778029
BytebuddyAgent [candidate] (782.07 ms) : 0, 782070
GlobalTracer [baseline] (294.94 ms) : 0, 294940
GlobalTracer [candidate] (294.245 ms) : 0, 294245
AppSec [baseline] (47.103 ms) : 0, 47103
AppSec [candidate] (47.417 ms) : 0, 47417
IAST [baseline] (27.78 ms) : 0, 27780
IAST [candidate] (28.662 ms) : 0, 28662
Remote Config [baseline] (575.236 µs) : 0, 575
Remote Config [candidate] (586.246 µs) : 0, 586
Telemetry [baseline] (7.641 ms) : 0, 7641
Telemetry [candidate] (6.902 ms) : 0, 6902
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.27 ms) : 0, 776270
BytebuddyAgent [candidate] (778.377 ms) : 0, 778377
GlobalTracer [baseline] (295.531 ms) : 0, 295531
GlobalTracer [candidate] (294.225 ms) : 0, 294225
AppSec [baseline] (46.926 ms) : 0, 46926
AppSec [candidate] (47.25 ms) : 0, 47250
IAST [baseline] (27.729 ms) : 0, 27729
IAST [candidate] (25.154 ms) : 0, 25154
Remote Config [baseline] (600.481 µs) : 0, 600
Remote Config [candidate] (602.149 µs) : 0, 602
Telemetry [baseline] (7.557 ms) : 0, 7557
Telemetry [candidate] (7.656 ms) : 0, 7656
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~d2672ea954, baseline=1.38.0-SNAPSHOT~120b584fde

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.076 s) : 0, 1076338
Total [baseline] (10.354 s) : 0, 10354111
Agent [candidate] (1.059 s) : 0, 1058661
Total [candidate] (10.338 s) : 0, 10338120
section appsec
Agent [baseline] (1.185 s) : 0, 1185134
Total [baseline] (10.513 s) : 0, 10513127
Agent [candidate] (1.185 s) : 0, 1184801
Total [candidate] (10.449 s) : 0, 10449029
section iast
Agent [baseline] (1.183 s) : 0, 1183015
Total [baseline] (10.771 s) : 0, 10771424
Agent [candidate] (1.164 s) : 0, 1163860
Total [candidate] (10.668 s) : 0, 10668050
section profiling
Agent [baseline] (1.265 s) : 0, 1265364
Total [baseline] (10.616 s) : 0, 10615924
Agent [candidate] (1.257 s) : 0, 1257472
Total [candidate] (10.597 s) : 0, 10597331
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.076 s -
Agent appsec 1.185 s 108.796 ms (10.1%)
Agent iast 1.183 s 106.678 ms (9.9%)
Agent profiling 1.265 s 189.026 ms (17.6%)
Total tracing 10.354 s -
Total appsec 10.513 s 159.016 ms (1.5%)
Total iast 10.771 s 417.313 ms (4.0%)
Total profiling 10.616 s 261.813 ms (2.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent appsec 1.185 s 126.141 ms (11.9%)
Agent iast 1.164 s 105.2 ms (9.9%)
Agent profiling 1.257 s 198.811 ms (18.8%)
Total tracing 10.338 s -
Total appsec 10.449 s 110.909 ms (1.1%)
Total iast 10.668 s 329.93 ms (3.2%)
Total profiling 10.597 s 259.212 ms (2.5%) 
gantt
    title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~d2672ea954, baseline=1.38.0-SNAPSHOT~120b584fde

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (674.633 ms) : 0, 674633
BytebuddyAgent [candidate] (663.027 ms) : 0, 663027
GlobalTracer [baseline] (307.796 ms) : 0, 307796
GlobalTracer [candidate] (303.022 ms) : 0, 303022
AppSec [baseline] (50.432 ms) : 0, 50432
AppSec [candidate] (49.975 ms) : 0, 49975
Remote Config [baseline] (677.243 µs) : 0, 677
Remote Config [candidate] (680.186 µs) : 0, 680
Telemetry [baseline] (7.653 ms) : 0, 7653
Telemetry [candidate] (7.55 ms) : 0, 7550
section appsec
BytebuddyAgent [baseline] (678.018 ms) : 0, 678018
BytebuddyAgent [candidate] (677.76 ms) : 0, 677760
GlobalTracer [baseline] (300.006 ms) : 0, 300006
GlobalTracer [candidate] (298.191 ms) : 0, 298191
AppSec [baseline] (154.25 ms) : 0, 154250
AppSec [candidate] (154.165 ms) : 0, 154165
IAST [baseline] (18.967 ms) : 0, 18967
IAST [candidate] (22.42 ms) : 0, 22420
Remote Config [baseline] (622.317 µs) : 0, 622
Remote Config [candidate] (644.05 µs) : 0, 644
Telemetry [baseline] (7.998 ms) : 0, 7998
Telemetry [candidate] (8.155 ms) : 0, 8155
section iast
BytebuddyAgent [baseline] (786.907 ms) : 0, 786907
BytebuddyAgent [candidate] (776.297 ms) : 0, 776297
GlobalTracer [baseline] (298.635 ms) : 0, 298635
GlobalTracer [candidate] (292.742 ms) : 0, 292742
AppSec [baseline] (47.53 ms) : 0, 47530
AppSec [candidate] (47.041 ms) : 0, 47041
IAST [baseline] (27.852 ms) : 0, 27852
IAST [candidate] (26.881 ms) : 0, 26881
Remote Config [baseline] (585.149 µs) : 0, 585
Remote Config [candidate] (632.891 µs) : 0, 633
Telemetry [baseline] (7.855 ms) : 0, 7855
Telemetry [candidate] (7.002 ms) : 0, 7002
section profiling
BytebuddyAgent [baseline] (661.989 ms) : 0, 661989
BytebuddyAgent [candidate] (660.253 ms) : 0, 660253
GlobalTracer [baseline] (389.38 ms) : 0, 389380
GlobalTracer [candidate] (385.689 ms) : 0, 385689
AppSec [baseline] (51.999 ms) : 0, 51999
AppSec [candidate] (51.13 ms) : 0, 51130
Remote Config [baseline] (644.061 µs) : 0, 644
Remote Config [candidate] (733.271 µs) : 0, 733
Telemetry [baseline] (7.355 ms) : 0, 7355
Telemetry [candidate] (7.363 ms) : 0, 7363
ProfilingAgent [baseline] (96.731 ms) : 0, 96731
ProfilingAgent [candidate] (95.412 ms) : 0, 95412
Profiling [baseline] (96.756 ms) : 0, 96756
Profiling [candidate] (95.437 ms) : 0, 95437
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-07-10T18:23:49 2024-07-10T18:30:38
git_branch master mattalp/smaps-rebased
git_commit_date 1720619307 1720634694
git_commit_sha 120b584 d2672ea
release_version 1.38.0-SNAPSHOT~120b584fde 1.36.0-SNAPSHOT~d2672ea954
start_time 2024-07-10T18:23:36 2024-07-10T18:30:25
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720636584 1720636584
ci_job_id 568655596 568655596
ci_pipeline_id 38871494 38871494
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~d2672ea954, baseline=1.38.0-SNAPSHOT~120b584fde
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.337 ms) : 1317, 1356
.   : milestone, 1337,
appsec (1.704 ms) : 1680, 1728
.   : milestone, 1704,
appsec_no_iast (1.723 ms) : 1696, 1750
.   : milestone, 1723,
iast (1.459 ms) : 1437, 1481
.   : milestone, 1459,
profiling (1.524 ms) : 1498, 1550
.   : milestone, 1524,
tracing (1.464 ms) : 1439, 1488
.   : milestone, 1464,
section candidate
no_agent (1.354 ms) : 1335, 1373
.   : milestone, 1354,
appsec (1.707 ms) : 1684, 1731
.   : milestone, 1707,
appsec_no_iast (1.73 ms) : 1705, 1755
.   : milestone, 1730,
iast (1.481 ms) : 1458, 1504
.   : milestone, 1481,
profiling (1.488 ms) : 1465, 1512
.   : milestone, 1488,
tracing (1.475 ms) : 1452, 1499
.   : milestone, 1475,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.337 ms [1.317 ms, 1.356 ms] -
appsec 1.704 ms [1.68 ms, 1.728 ms] 367.327 µs (27.5%)
appsec_no_iast 1.723 ms [1.696 ms, 1.75 ms] 386.076 µs (28.9%)
iast 1.459 ms [1.437 ms, 1.481 ms] 122.211 µs (9.1%)
profiling 1.524 ms [1.498 ms, 1.55 ms] 187.08 µs (14.0%)
tracing 1.464 ms [1.439 ms, 1.488 ms] 126.647 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.354 ms [1.335 ms, 1.373 ms] -
appsec 1.707 ms [1.684 ms, 1.731 ms] 353.635 µs (26.1%)
appsec_no_iast 1.73 ms [1.705 ms, 1.755 ms] 376.148 µs (27.8%)
iast 1.481 ms [1.458 ms, 1.504 ms] 127.164 µs (9.4%)
profiling 1.488 ms [1.465 ms, 1.512 ms] 134.369 µs (9.9%)
tracing 1.475 ms [1.452 ms, 1.499 ms] 121.692 µs (9.0%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~d2672ea954, baseline=1.38.0-SNAPSHOT~120b584fde
    dateFormat X
    axisFormat %s
section baseline
no_agent (361.037 µs) : 341, 381
.   : milestone, 361,
iast (486.277 µs) : 465, 508
.   : milestone, 486,
iast_FULL (544.051 µs) : 523, 565
.   : milestone, 544,
iast_GLOBAL (499.179 µs) : 478, 520
.   : milestone, 499,
iast_HARDCODED_SECRET_DISABLED (486.008 µs) : 465, 507
.   : milestone, 486,
iast_INACTIVE (454.642 µs) : 433, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (468.642 µs) : 447, 490
.   : milestone, 469,
tracing (439.044 µs) : 418, 460
.   : milestone, 439,
section candidate
no_agent (367.987 µs) : 349, 387
.   : milestone, 368,
iast (479.303 µs) : 458, 500
.   : milestone, 479,
iast_FULL (549.133 µs) : 528, 570
.   : milestone, 549,
iast_GLOBAL (511.217 µs) : 489, 533
.   : milestone, 511,
iast_HARDCODED_SECRET_DISABLED (485.352 µs) : 464, 507
.   : milestone, 485,
iast_INACTIVE (452.38 µs) : 431, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (469.618 µs) : 448, 491
.   : milestone, 470,
tracing (441.126 µs) : 421, 462
.   : milestone, 441,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 361.037 µs [341.184 µs, 380.891 µs] -
iast 486.277 µs [465.042 µs, 507.513 µs] 125.24 µs (34.7%)
iast_FULL 544.051 µs [523.19 µs, 564.913 µs] 183.014 µs (50.7%)
iast_GLOBAL 499.179 µs [477.915 µs, 520.444 µs] 138.142 µs (38.3%)
iast_HARDCODED_SECRET_DISABLED 486.008 µs [464.848 µs, 507.169 µs] 124.971 µs (34.6%)
iast_INACTIVE 454.642 µs [432.99 µs, 476.294 µs] 93.605 µs (25.9%)
iast_TELEMETRY_OFF 468.642 µs [446.9 µs, 490.385 µs] 107.605 µs (29.8%)
tracing 439.044 µs [418.463 µs, 459.625 µs] 78.007 µs (21.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.987 µs [348.599 µs, 387.376 µs] -
iast 479.303 µs [458.173 µs, 500.432 µs] 111.315 µs (30.2%)
iast_FULL 549.133 µs [528.145 µs, 570.121 µs] 181.146 µs (49.2%)
iast_GLOBAL 511.217 µs [489.017 µs, 533.418 µs] 143.23 µs (38.9%)
iast_HARDCODED_SECRET_DISABLED 485.352 µs [463.79 µs, 506.913 µs] 117.364 µs (31.9%)
iast_INACTIVE 452.38 µs [431.387 µs, 473.373 µs] 84.393 µs (22.9%)
iast_TELEMETRY_OFF 469.618 µs [448.165 µs, 491.07 µs] 101.63 µs (27.6%)
tracing 441.126 µs [420.655 µs, 461.597 µs] 73.138 µs (19.9%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mattalp/smaps-rebased
git_commit_date 1720619307 1720634694
git_commit_sha 120b584 d2672ea
release_version 1.38.0-SNAPSHOT~120b584fde 1.36.0-SNAPSHOT~d2672ea954
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1720637121 1720637121
ci_job_id 568655597 568655597
ci_pipeline_id 38871494 38871494
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~d2672ea954, baseline=1.38.0-SNAPSHOT~120b584fde
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.46 ms) : 1449, 1472
.   : milestone, 1460,
appsec (2.225 ms) : 2190, 2260
.   : milestone, 2225,
iast (1.961 ms) : 1920, 2003
.   : milestone, 1961,
iast_GLOBAL (2.02 ms) : 1978, 2061
.   : milestone, 2020,
profiling (1.862 ms) : 1828, 1897
.   : milestone, 1862,
tracing (1.844 ms) : 1811, 1877
.   : milestone, 1844,
section candidate
no_agent (1.463 ms) : 1451, 1474
.   : milestone, 1463,
appsec (2.192 ms) : 2160, 2225
.   : milestone, 2192,
iast (1.948 ms) : 1909, 1988
.   : milestone, 1948,
iast_GLOBAL (1.997 ms) : 1957, 2037
.   : milestone, 1997,
profiling (1.846 ms) : 1814, 1878
.   : milestone, 1846,
tracing (1.809 ms) : 1779, 1839
.   : milestone, 1809,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.46 ms [1.449 ms, 1.472 ms] -
appsec 2.225 ms [2.19 ms, 2.26 ms] 764.777 µs (52.4%)
iast 1.961 ms [1.92 ms, 2.003 ms] 501.321 µs (34.3%)
iast_GLOBAL 2.02 ms [1.978 ms, 2.061 ms] 559.651 µs (38.3%)
profiling 1.862 ms [1.828 ms, 1.897 ms] 402.245 µs (27.5%)
tracing 1.844 ms [1.811 ms, 1.877 ms] 383.867 µs (26.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.463 ms [1.451 ms, 1.474 ms] -
appsec 2.192 ms [2.16 ms, 2.225 ms] 729.613 µs (49.9%)
iast 1.948 ms [1.909 ms, 1.988 ms] 485.689 µs (33.2%)
iast_GLOBAL 1.997 ms [1.957 ms, 2.037 ms] 534.603 µs (36.5%)
profiling 1.846 ms [1.814 ms, 1.878 ms] 383.11 µs (26.2%)
tracing 1.809 ms [1.779 ms, 1.839 ms] 346.275 µs (23.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~d2672ea954, baseline=1.38.0-SNAPSHOT~120b584fde
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.012 s) : 15012000, 15012000
.   : milestone, 15012000,
appsec (14.807 s) : 14807000, 14807000
.   : milestone, 14807000,
iast (19.062 s) : 19062000, 19062000
.   : milestone, 19062000,
iast_GLOBAL (17.856 s) : 17856000, 17856000
.   : milestone, 17856000,
profiling (15.044 s) : 15044000, 15044000
.   : milestone, 15044000,
tracing (14.748 s) : 14748000, 14748000
.   : milestone, 14748000,
section candidate
no_agent (15.364 s) : 15364000, 15364000
.   : milestone, 15364000,
appsec (15.264 s) : 15264000, 15264000
.   : milestone, 15264000,
iast (18.539 s) : 18539000, 18539000
.   : milestone, 18539000,
iast_GLOBAL (17.785 s) : 17785000, 17785000
.   : milestone, 17785000,
profiling (15.353 s) : 15353000, 15353000
.   : milestone, 15353000,
tracing (14.894 s) : 14894000, 14894000
.   : milestone, 14894000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.012 s [15.012 s, 15.012 s] -
appsec 14.807 s [14.807 s, 14.807 s] -205.0 ms (-1.4%)
iast 19.062 s [19.062 s, 19.062 s] 4.05 s (27.0%)
iast_GLOBAL 17.856 s [17.856 s, 17.856 s] 2.844 s (18.9%)
profiling 15.044 s [15.044 s, 15.044 s] 32.0 ms (0.2%)
tracing 14.748 s [14.748 s, 14.748 s] -264.0 ms (-1.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.364 s [15.364 s, 15.364 s] -
appsec 15.264 s [15.264 s, 15.264 s] -100.0 ms (-0.7%)
iast 18.539 s [18.539 s, 18.539 s] 3.175 s (20.7%)
iast_GLOBAL 17.785 s [17.785 s, 17.785 s] 2.421 s (15.8%)
profiling 15.353 s [15.353 s, 15.353 s] -11.0 ms (-0.1%)
tracing 14.894 s [14.894 s, 14.894 s] -470.0 ms (-3.1%)

richardstartin
richardstartin approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@richardstartin richardstartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the pattern a static final, otherwise LGTM

@MattAlp
Copy link
Contributor Author

MattAlp commented Jun 28, 2024

Note: the text format being parsed for extracting NMT annotations is expected to change in upcoming JDK releases

@MattAlp MattAlp changed the title Track JVM RSS in JDK 22+ Track JVM RSS in JDK 21+ Jul 10, 2024
@MattAlp MattAlp merged commit 1294ac2 into master Jul 10, 2024
82 checks passed
@MattAlp MattAlp deleted the mattalp/smaps-rebased branch July 10, 2024 19:13
@github-actions github-actions bot added this to the 1.38.0 milestone Jul 10, 2024
@nayeem-kamal nayeem-kamal added the comp: profiling Profiling label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbachorik jbachorik jbachorik approved these changes

@jpbempel jpbempel jpbempel left review comments

@richardstartin richardstartin richardstartin approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: profiling Profiling
Projects
None yet
Milestone
1.38.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MattAlp @jbachorik @jpbempel @richardstartin @nayeem-kamal