Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ddpfrof to 1.9.0 #7229

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Update ddpfrof to 1.9.0 #7229

merged 1 commit into from
Jun 24, 2024

Conversation

jbachorik
Copy link
Contributor

What Does This Do

Bumps ddprof lib to 1.9.0

@jbachorik jbachorik requested a review from a team as a code owner June 21, 2024 15:42
@jbachorik jbachorik requested review from mcculls and dougqh June 21, 2024 15:42
@pr-commenter
Copy link

pr-commenter bot commented Jun 21, 2024

Benchmarks

Startup

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-06-21T16:08:46 2024-06-21T16:15:35
git_branch master jb/ddprof_1.9.0
git_commit_date 1718966972 1718984245
git_commit_sha 901334b c8ed6f3
release_version 1.36.0-SNAPSHOT~901334b037 1.36.0-SNAPSHOT~c8ed6f38b5
start_time 2024-06-21T16:08:33 2024-06-21T16:15:22
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1718986878 1718986878
ci_job_id 550580552 550580552
ci_pipeline_id 37320757 37320757
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~c8ed6f38b5, baseline=1.36.0-SNAPSHOT~901334b037
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.332 ms) : 1313, 1352
.   : milestone, 1332,
appsec (1.731 ms) : 1705, 1758
.   : milestone, 1731,
appsec_no_iast (1.719 ms) : 1694, 1743
.   : milestone, 1719,
iast (1.46 ms) : 1438, 1483
.   : milestone, 1460,
profiling (1.518 ms) : 1493, 1544
.   : milestone, 1518,
tracing (1.471 ms) : 1448, 1495
.   : milestone, 1471,
section candidate
no_agent (1.324 ms) : 1304, 1344
.   : milestone, 1324,
appsec (1.709 ms) : 1686, 1733
.   : milestone, 1709,
appsec_no_iast (1.7 ms) : 1675, 1725
.   : milestone, 1700,
iast (1.487 ms) : 1465, 1509
.   : milestone, 1487,
profiling (1.494 ms) : 1469, 1518
.   : milestone, 1494,
tracing (1.474 ms) : 1451, 1498
.   : milestone, 1474,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.332 ms [1.313 ms, 1.352 ms] -
appsec 1.731 ms [1.705 ms, 1.758 ms] 399.084 µs (30.0%)
appsec_no_iast 1.719 ms [1.694 ms, 1.743 ms] 386.387 µs (29.0%)
iast 1.46 ms [1.438 ms, 1.483 ms] 127.949 µs (9.6%)
profiling 1.518 ms [1.493 ms, 1.544 ms] 186.03 µs (14.0%)
tracing 1.471 ms [1.448 ms, 1.495 ms] 139.142 µs (10.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.324 ms [1.304 ms, 1.344 ms] -
appsec 1.709 ms [1.686 ms, 1.733 ms] 385.332 µs (29.1%)
appsec_no_iast 1.7 ms [1.675 ms, 1.725 ms] 375.727 µs (28.4%)
iast 1.487 ms [1.465 ms, 1.509 ms] 162.778 µs (12.3%)
profiling 1.494 ms [1.469 ms, 1.518 ms] 169.375 µs (12.8%)
tracing 1.474 ms [1.451 ms, 1.498 ms] 150.318 µs (11.4%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~c8ed6f38b5, baseline=1.36.0-SNAPSHOT~901334b037
    dateFormat X
    axisFormat %s
section baseline
no_agent (369.599 µs) : 350, 389
.   : milestone, 370,
iast (478.156 µs) : 457, 500
.   : milestone, 478,
iast_FULL (549.44 µs) : 528, 571
.   : milestone, 549,
iast_GLOBAL (517.065 µs) : 494, 540
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (480.249 µs) : 459, 502
.   : milestone, 480,
iast_INACTIVE (459.859 µs) : 438, 482
.   : milestone, 460,
iast_TELEMETRY_OFF (474.372 µs) : 453, 496
.   : milestone, 474,
tracing (438.299 µs) : 417, 459
.   : milestone, 438,
section candidate
no_agent (366.59 µs) : 347, 387
.   : milestone, 367,
iast (474.586 µs) : 454, 495
.   : milestone, 475,
iast_FULL (546.225 µs) : 525, 567
.   : milestone, 546,
iast_GLOBAL (503.413 µs) : 482, 525
.   : milestone, 503,
iast_HARDCODED_SECRET_DISABLED (480.671 µs) : 460, 502
.   : milestone, 481,
iast_INACTIVE (451.62 µs) : 430, 473
.   : milestone, 452,
iast_TELEMETRY_OFF (463.618 µs) : 443, 485
.   : milestone, 464,
tracing (442.851 µs) : 422, 464
.   : milestone, 443,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 369.599 µs [350.15 µs, 389.048 µs] -
iast 478.156 µs [456.664 µs, 499.648 µs] 108.557 µs (29.4%)
iast_FULL 549.44 µs [528.102 µs, 570.778 µs] 179.841 µs (48.7%)
iast_GLOBAL 517.065 µs [494.285 µs, 539.845 µs] 147.466 µs (39.9%)
iast_HARDCODED_SECRET_DISABLED 480.249 µs [458.715 µs, 501.784 µs] 110.65 µs (29.9%)
iast_INACTIVE 459.859 µs [437.695 µs, 482.023 µs] 90.26 µs (24.4%)
iast_TELEMETRY_OFF 474.372 µs [453.178 µs, 495.566 µs] 104.773 µs (28.3%)
tracing 438.299 µs [417.341 µs, 459.257 µs] 68.7 µs (18.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.59 µs [346.637 µs, 386.543 µs] -
iast 474.586 µs [453.832 µs, 495.339 µs] 107.996 µs (29.5%)
iast_FULL 546.225 µs [525.361 µs, 567.09 µs] 179.636 µs (49.0%)
iast_GLOBAL 503.413 µs [481.587 µs, 525.24 µs] 136.824 µs (37.3%)
iast_HARDCODED_SECRET_DISABLED 480.671 µs [459.559 µs, 501.783 µs] 114.082 µs (31.1%)
iast_INACTIVE 451.62 µs [430.05 µs, 473.189 µs] 85.03 µs (23.2%)
iast_TELEMETRY_OFF 463.618 µs [442.593 µs, 484.642 µs] 97.028 µs (26.5%)
tracing 442.851 µs [421.658 µs, 464.044 µs] 76.261 µs (20.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jb/ddprof_1.9.0
git_commit_date 1718966972 1718984245
git_commit_sha 901334b c8ed6f3
release_version 1.36.0-SNAPSHOT~901334b037 1.36.0-SNAPSHOT~c8ed6f38b5
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1718987423 1718987423
ci_job_id 550580554 550580554
ci_pipeline_id 37320757 37320757
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~c8ed6f38b5, baseline=1.36.0-SNAPSHOT~901334b037
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.457 ms) : 1446, 1469
.   : milestone, 1457,
appsec (2.19 ms) : 2156, 2223
.   : milestone, 2190,
iast (1.953 ms) : 1912, 1994
.   : milestone, 1953,
iast_GLOBAL (2.003 ms) : 1961, 2044
.   : milestone, 2003,
profiling (1.838 ms) : 1803, 1872
.   : milestone, 1838,
tracing (1.822 ms) : 1790, 1854
.   : milestone, 1822,
section candidate
no_agent (1.456 ms) : 1444, 1467
.   : milestone, 1456,
appsec (2.203 ms) : 2169, 2236
.   : milestone, 2203,
iast (1.952 ms) : 1912, 1993
.   : milestone, 1952,
iast_GLOBAL (2.0 ms) : 1958, 2041
.   : milestone, 2000,
profiling (1.843 ms) : 1809, 1878
.   : milestone, 1843,
tracing (1.822 ms) : 1790, 1854
.   : milestone, 1822,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.457 ms [1.446 ms, 1.469 ms] -
appsec 2.19 ms [2.156 ms, 2.223 ms] 732.412 µs (50.3%)
iast 1.953 ms [1.912 ms, 1.994 ms] 495.724 µs (34.0%)
iast_GLOBAL 2.003 ms [1.961 ms, 2.044 ms] 545.214 µs (37.4%)
profiling 1.838 ms [1.803 ms, 1.872 ms] 380.187 µs (26.1%)
tracing 1.822 ms [1.79 ms, 1.854 ms] 364.649 µs (25.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.456 ms [1.444 ms, 1.467 ms] -
appsec 2.203 ms [2.169 ms, 2.236 ms] 746.793 µs (51.3%)
iast 1.952 ms [1.912 ms, 1.993 ms] 496.486 µs (34.1%)
iast_GLOBAL 2.0 ms [1.958 ms, 2.041 ms] 543.963 µs (37.4%)
profiling 1.843 ms [1.809 ms, 1.878 ms] 387.668 µs (26.6%)
tracing 1.822 ms [1.79 ms, 1.854 ms] 366.475 µs (25.2%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~c8ed6f38b5, baseline=1.36.0-SNAPSHOT~901334b037
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.077 s) : 15077000, 15077000
.   : milestone, 15077000,
appsec (15.127 s) : 15127000, 15127000
.   : milestone, 15127000,
iast (18.786 s) : 18786000, 18786000
.   : milestone, 18786000,
iast_GLOBAL (17.861 s) : 17861000, 17861000
.   : milestone, 17861000,
profiling (14.802 s) : 14802000, 14802000
.   : milestone, 14802000,
tracing (15.084 s) : 15084000, 15084000
.   : milestone, 15084000,
section candidate
no_agent (15.025 s) : 15025000, 15025000
.   : milestone, 15025000,
appsec (14.915 s) : 14915000, 14915000
.   : milestone, 14915000,
iast (18.942 s) : 18942000, 18942000
.   : milestone, 18942000,
iast_GLOBAL (17.945 s) : 17945000, 17945000
.   : milestone, 17945000,
profiling (15.179 s) : 15179000, 15179000
.   : milestone, 15179000,
tracing (15.125 s) : 15125000, 15125000
.   : milestone, 15125000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.077 s [15.077 s, 15.077 s] -
appsec 15.127 s [15.127 s, 15.127 s] 50.0 ms (0.3%)
iast 18.786 s [18.786 s, 18.786 s] 3.709 s (24.6%)
iast_GLOBAL 17.861 s [17.861 s, 17.861 s] 2.784 s (18.5%)
profiling 14.802 s [14.802 s, 14.802 s] -275.0 ms (-1.8%)
tracing 15.084 s [15.084 s, 15.084 s] 7.0 ms (0.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.025 s [15.025 s, 15.025 s] -
appsec 14.915 s [14.915 s, 14.915 s] -110.0 ms (-0.7%)
iast 18.942 s [18.942 s, 18.942 s] 3.917 s (26.1%)
iast_GLOBAL 17.945 s [17.945 s, 17.945 s] 2.92 s (19.4%)
profiling 15.179 s [15.179 s, 15.179 s] 154.0 ms (1.0%)
tracing 15.125 s [15.125 s, 15.125 s] 100.0 ms (0.7%)

@jbachorik jbachorik merged commit 46c883a into master Jun 24, 2024
84 checks passed
@jbachorik jbachorik deleted the jb/ddprof_1.9.0 branch June 24, 2024 09:03
@github-actions github-actions bot added this to the 1.36.0 milestone Jun 24, 2024
@oriy oriy mentioned this pull request Jun 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardstartin richardstartin richardstartin approved these changes

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

@dougqh dougqh Awaiting requested review from dougqh dougqh is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: profiling Profiling
Projects
None yet
Milestone
1.36.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbachorik @richardstartin