-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Record the class-loader context that triggered loading of JMX and pass it through to JMXFetch #7234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s it through to JMXFetch
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~c8e7fb4f7d, baseline=1.36.0-SNAPSHOT~901334b037
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058721
Total [baseline] (8.512 s) : 0, 8512292
Agent [candidate] (1.062 s) : 0, 1062312
Total [candidate] (8.562 s) : 0, 8561803
section iast
Agent [baseline] (1.166 s) : 0, 1166323
Total [baseline] (9.016 s) : 0, 9016323
Agent [candidate] (1.169 s) : 0, 1169431
Total [candidate] (9.006 s) : 0, 9006137
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.174 s) : 0, 1173701
Total [baseline] (9.02 s) : 0, 9019819
Agent [candidate] (1.169 s) : 0, 1169400
Total [candidate] (8.977 s) : 0, 8976997
section iast_TELEMETRY_OFF
Agent [baseline] (1.171 s) : 0, 1171354
Total [baseline] (8.982 s) : 0, 8982061
Agent [candidate] (1.175 s) : 0, 1174803
Total [candidate] (8.998 s) : 0, 8998457
gantt
title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~c8e7fb4f7d, baseline=1.36.0-SNAPSHOT~901334b037
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (663.525 ms) : 0, 663525
BytebuddyAgent [candidate] (664.564 ms) : 0, 664564
GlobalTracer [baseline] (302.476 ms) : 0, 302476
GlobalTracer [candidate] (304.549 ms) : 0, 304549
AppSec [baseline] (50.289 ms) : 0, 50289
AppSec [candidate] (50.577 ms) : 0, 50577
Remote Config [baseline] (683.464 µs) : 0, 683
Remote Config [candidate] (692.476 µs) : 0, 692
Telemetry [baseline] (7.484 ms) : 0, 7484
Telemetry [candidate] (7.614 ms) : 0, 7614
section iast
BytebuddyAgent [baseline] (778.603 ms) : 0, 778603
BytebuddyAgent [candidate] (779.31 ms) : 0, 779310
GlobalTracer [baseline] (292.494 ms) : 0, 292494
GlobalTracer [candidate] (293.25 ms) : 0, 293250
AppSec [baseline] (46.82 ms) : 0, 46820
AppSec [candidate] (47.048 ms) : 0, 47048
IAST [baseline] (27.583 ms) : 0, 27583
IAST [candidate] (28.062 ms) : 0, 28062
Remote Config [baseline] (630.856 µs) : 0, 631
Remote Config [candidate] (714.263 µs) : 0, 714
Telemetry [baseline] (6.948 ms) : 0, 6948
Telemetry [candidate] (7.771 ms) : 0, 7771
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (783.514 ms) : 0, 783514
BytebuddyAgent [candidate] (781.487 ms) : 0, 781487
GlobalTracer [baseline] (294.507 ms) : 0, 294507
GlobalTracer [candidate] (292.261 ms) : 0, 292261
AppSec [baseline] (47.525 ms) : 0, 47525
AppSec [candidate] (47.244 ms) : 0, 47244
IAST [baseline] (26.344 ms) : 0, 26344
IAST [candidate] (27.487 ms) : 0, 27487
Remote Config [baseline] (607.072 µs) : 0, 607
Remote Config [candidate] (598.462 µs) : 0, 598
Telemetry [baseline] (7.806 ms) : 0, 7806
Telemetry [candidate] (6.939 ms) : 0, 6939
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (781.158 ms) : 0, 781158
BytebuddyAgent [candidate] (783.851 ms) : 0, 783851
GlobalTracer [baseline] (294.093 ms) : 0, 294093
GlobalTracer [candidate] (295.903 ms) : 0, 295903
AppSec [baseline] (47.172 ms) : 0, 47172
AppSec [candidate] (47.226 ms) : 0, 47226
IAST [baseline] (27.271 ms) : 0, 27271
IAST [candidate] (24.478 ms) : 0, 24478
Remote Config [baseline] (606.573 µs) : 0, 607
Remote Config [candidate] (594.626 µs) : 0, 595
Telemetry [baseline] (7.675 ms) : 0, 7675
Telemetry [candidate] (9.307 ms) : 0, 9307
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~c8e7fb4f7d, baseline=1.36.0-SNAPSHOT~901334b037
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1065712
Total [baseline] (10.457 s) : 0, 10456556
Agent [candidate] (1.061 s) : 0, 1061120
Total [candidate] (10.306 s) : 0, 10306419
section appsec
Agent [baseline] (1.182 s) : 0, 1182245
Total [baseline] (10.467 s) : 0, 10467055
Agent [candidate] (1.184 s) : 0, 1183772
Total [candidate] (10.437 s) : 0, 10436975
section iast
Agent [baseline] (1.177 s) : 0, 1176524
Total [baseline] (10.681 s) : 0, 10681272
Agent [candidate] (1.168 s) : 0, 1168273
Total [candidate] (10.679 s) : 0, 10678792
section profiling
Agent [baseline] (1.266 s) : 0, 1266491
Total [baseline] (10.753 s) : 0, 10753131
Agent [candidate] (1.269 s) : 0, 1268715
Total [candidate] (10.639 s) : 0, 10638885
gantt
title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~c8e7fb4f7d, baseline=1.36.0-SNAPSHOT~901334b037
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.638 ms) : 0, 669638
BytebuddyAgent [candidate] (665.274 ms) : 0, 665274
GlobalTracer [baseline] (303.058 ms) : 0, 303058
GlobalTracer [candidate] (303.045 ms) : 0, 303045
AppSec [baseline] (50.083 ms) : 0, 50083
AppSec [candidate] (50.149 ms) : 0, 50149
Remote Config [baseline] (690.016 µs) : 0, 690
Remote Config [candidate] (685.709 µs) : 0, 686
Telemetry [baseline] (7.539 ms) : 0, 7539
Telemetry [candidate] (7.52 ms) : 0, 7520
section appsec
BytebuddyAgent [baseline] (676.233 ms) : 0, 676233
BytebuddyAgent [candidate] (677.653 ms) : 0, 677653
GlobalTracer [baseline] (297.051 ms) : 0, 297051
GlobalTracer [candidate] (297.448 ms) : 0, 297448
AppSec [baseline] (153.346 ms) : 0, 153346
AppSec [candidate] (154.123 ms) : 0, 154123
Remote Config [baseline] (639.905 µs) : 0, 640
Remote Config [candidate] (633.341 µs) : 0, 633
Telemetry [baseline] (9.999 ms) : 0, 9999
Telemetry [candidate] (8.465 ms) : 0, 8465
IAST [baseline] (20.977 ms) : 0, 20977
IAST [candidate] (21.831 ms) : 0, 21831
section iast
BytebuddyAgent [baseline] (784.124 ms) : 0, 784124
BytebuddyAgent [candidate] (779.188 ms) : 0, 779188
GlobalTracer [baseline] (294.892 ms) : 0, 294892
GlobalTracer [candidate] (292.871 ms) : 0, 292871
AppSec [baseline] (47.433 ms) : 0, 47433
AppSec [candidate] (46.969 ms) : 0, 46969
Remote Config [baseline] (623.701 µs) : 0, 624
Remote Config [candidate] (664.86 µs) : 0, 665
Telemetry [baseline] (6.921 ms) : 0, 6921
Telemetry [candidate] (6.935 ms) : 0, 6935
IAST [baseline] (29.177 ms) : 0, 29177
IAST [candidate] (28.317 ms) : 0, 28317
section profiling
ProfilingAgent [baseline] (96.617 ms) : 0, 96617
ProfilingAgent [candidate] (97.314 ms) : 0, 97314
BytebuddyAgent [baseline] (665.508 ms) : 0, 665508
BytebuddyAgent [candidate] (666.795 ms) : 0, 666795
GlobalTracer [baseline] (387.467 ms) : 0, 387467
GlobalTracer [candidate] (387.322 ms) : 0, 387322
AppSec [baseline] (51.844 ms) : 0, 51844
AppSec [candidate] (51.727 ms) : 0, 51727
Remote Config [baseline] (751.542 µs) : 0, 752
Remote Config [candidate] (739.154 µs) : 0, 739
Telemetry [baseline] (7.392 ms) : 0, 7392
Telemetry [candidate] (7.376 ms) : 0, 7376
Profiling [baseline] (96.642 ms) : 0, 96642
Profiling [candidate] (97.339 ms) : 0, 97339
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~c8e7fb4f7d, baseline=1.36.0-SNAPSHOT~901334b037
dateFormat X
axisFormat %s
section baseline
no_agent (374.325 µs) : 354, 394
. : milestone, 374,
iast (485.391 µs) : 464, 507
. : milestone, 485,
iast_FULL (557.676 µs) : 536, 579
. : milestone, 558,
iast_GLOBAL (517.616 µs) : 496, 540
. : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (485.034 µs) : 464, 507
. : milestone, 485,
iast_INACTIVE (459.445 µs) : 438, 481
. : milestone, 459,
iast_TELEMETRY_OFF (476.173 µs) : 454, 498
. : milestone, 476,
tracing (450.654 µs) : 430, 471
. : milestone, 451,
section candidate
no_agent (375.723 µs) : 354, 397
. : milestone, 376,
iast (483.785 µs) : 463, 505
. : milestone, 484,
iast_FULL (558.538 µs) : 538, 579
. : milestone, 559,
iast_GLOBAL (506.323 µs) : 485, 528
. : milestone, 506,
iast_HARDCODED_SECRET_DISABLED (482.061 µs) : 461, 503
. : milestone, 482,
iast_INACTIVE (454.154 µs) : 433, 475
. : milestone, 454,
iast_TELEMETRY_OFF (483.573 µs) : 462, 505
. : milestone, 484,
tracing (451.307 µs) : 430, 473
. : milestone, 451,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~c8e7fb4f7d, baseline=1.36.0-SNAPSHOT~901334b037
dateFormat X
axisFormat %s
section baseline
no_agent (1.35 ms) : 1330, 1370
. : milestone, 1350,
appsec (1.739 ms) : 1715, 1763
. : milestone, 1739,
appsec_no_iast (1.696 ms) : 1671, 1720
. : milestone, 1696,
iast (1.471 ms) : 1448, 1494
. : milestone, 1471,
profiling (1.533 ms) : 1507, 1559
. : milestone, 1533,
tracing (1.457 ms) : 1434, 1481
. : milestone, 1457,
section candidate
no_agent (1.368 ms) : 1349, 1387
. : milestone, 1368,
appsec (1.752 ms) : 1729, 1776
. : milestone, 1752,
appsec_no_iast (1.717 ms) : 1692, 1742
. : milestone, 1717,
iast (1.493 ms) : 1471, 1514
. : milestone, 1493,
profiling (1.488 ms) : 1463, 1513
. : milestone, 1488,
tracing (1.471 ms) : 1447, 1494
. : milestone, 1471,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~c8e7fb4f7d, baseline=1.36.0-SNAPSHOT~901334b037
dateFormat X
axisFormat %s
section baseline
no_agent (1.459 ms) : 1447, 1470
. : milestone, 1459,
appsec (2.206 ms) : 2171, 2241
. : milestone, 2206,
iast (1.96 ms) : 1918, 2001
. : milestone, 1960,
iast_GLOBAL (2.009 ms) : 1967, 2052
. : milestone, 2009,
profiling (1.846 ms) : 1812, 1879
. : milestone, 1846,
tracing (1.824 ms) : 1792, 1856
. : milestone, 1824,
section candidate
no_agent (1.456 ms) : 1445, 1468
. : milestone, 1456,
appsec (2.201 ms) : 2167, 2235
. : milestone, 2201,
iast (1.959 ms) : 1918, 2000
. : milestone, 1959,
iast_GLOBAL (2.006 ms) : 1964, 2049
. : milestone, 2006,
profiling (1.841 ms) : 1808, 1873
. : milestone, 1841,
tracing (1.819 ms) : 1788, 1851
. : milestone, 1819,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~c8e7fb4f7d, baseline=1.36.0-SNAPSHOT~901334b037
dateFormat X
axisFormat %s
section baseline
no_agent (14.982 s) : 14982000, 14982000
. : milestone, 14982000,
appsec (15.087 s) : 15087000, 15087000
. : milestone, 15087000,
iast (18.895 s) : 18895000, 18895000
. : milestone, 18895000,
iast_GLOBAL (17.804 s) : 17804000, 17804000
. : milestone, 17804000,
profiling (15.204 s) : 15204000, 15204000
. : milestone, 15204000,
tracing (14.848 s) : 14848000, 14848000
. : milestone, 14848000,
section candidate
no_agent (15.097 s) : 15097000, 15097000
. : milestone, 15097000,
appsec (14.868 s) : 14868000, 14868000
. : milestone, 14868000,
iast (18.798 s) : 18798000, 18798000
. : milestone, 18798000,
iast_GLOBAL (17.853 s) : 17853000, 17853000
. : milestone, 17853000,
profiling (15.292 s) : 15292000, 15292000
. : milestone, 15292000,
tracing (15.366 s) : 15366000, 15366000
. : milestone, 15366000,
|
Not required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: jmx-fetch
JMX fetch
tag: do not merge
Do not merge changes
tag: no release notes
Changes to exclude from release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Jira ticket: [PROJ-IDENT]