Support Websphere JMX admin metrics #7235

amarziali · 2024-06-24T06:43:46Z

What Does This Do

Allows capturing the websphere vendor mbeanServer and using it in jmxfetch in order to capture metrics from it instead of the default platform mbean server.

This PR also bundles basic threadpool metrics collection for websphere

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

pr-commenter · 2024-06-24T07:35:09Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/websphere-jmx
git_commit_date	1722530509	1722604016
git_commit_sha	`b20b6cf`	`c426b28`
release_version	1.38.0-SNAPSHOT~b20b6cfb7a	1.38.0-SNAPSHOT~c426b286fa

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1722606330	1722606330
ci_job_id	593170720	593170720
ci_pipeline_id	40771774	40771774
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 51 metrics, 12 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~c426b286fa, baseline=1.38.0-SNAPSHOT~b20b6cfb7a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1044404
Total [baseline] (8.47 s) : 0, 8470139
Agent [candidate] (1.045 s) : 0, 1044648
Total [candidate] (8.497 s) : 0, 8497018
section iast
Agent [baseline] (1.171 s) : 0, 1170558
Total [baseline] (8.97 s) : 0, 8969597
Agent [candidate] (1.174 s) : 0, 1173967
Total [candidate] (8.962 s) : 0, 8962092
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1171390
Total [baseline] (8.928 s) : 0, 8927879
Agent [candidate] (1.183 s) : 0, 1182576
Total [candidate] (8.957 s) : 0, 8957481
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170228
Total [baseline] (8.947 s) : 0, 8946534
Agent [candidate] (1.17 s) : 0, 1169942
Total [candidate] (8.942 s) : 0, 8942046

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	iast	1.171 s	126.153 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.171 s	126.986 ms (12.2%)
Agent	iast_TELEMETRY_OFF	1.17 s	125.824 ms (12.0%)
Total	tracing	8.47 s	-
Total	iast	8.97 s	499.458 ms (5.9%)
Total	iast_HARDCODED_SECRET_DISABLED	8.928 s	457.74 ms (5.4%)
Total	iast_TELEMETRY_OFF	8.947 s	476.395 ms (5.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.045 s	-
Agent	iast	1.174 s	129.319 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.183 s	137.928 ms (13.2%)
Agent	iast_TELEMETRY_OFF	1.17 s	125.295 ms (12.0%)
Total	tracing	8.497 s	-
Total	iast	8.962 s	465.074 ms (5.5%)
Total	iast_HARDCODED_SECRET_DISABLED	8.957 s	460.463 ms (5.4%)
Total	iast_TELEMETRY_OFF	8.942 s	445.028 ms (5.2%)

gantt
    title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~c426b286fa, baseline=1.38.0-SNAPSHOT~b20b6cfb7a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.233 ms) : 0, 667233
BytebuddyAgent [candidate] (667.238 ms) : 0, 667238
GlobalTracer [baseline] (305.691 ms) : 0, 305691
GlobalTracer [candidate] (305.819 ms) : 0, 305819
AppSec [baseline] (50.145 ms) : 0, 50145
AppSec [candidate] (50.243 ms) : 0, 50243
Remote Config [baseline] (670.955 µs) : 0, 671
Remote Config [candidate] (681.689 µs) : 0, 682
Telemetry [baseline] (7.265 ms) : 0, 7265
Telemetry [candidate] (7.27 ms) : 0, 7270
section iast
BytebuddyAgent [baseline] (780.527 ms) : 0, 780527
BytebuddyAgent [candidate] (782.049 ms) : 0, 782049
GlobalTracer [baseline] (295.251 ms) : 0, 295251
GlobalTracer [candidate] (295.24 ms) : 0, 295240
AppSec [baseline] (51.3 ms) : 0, 51300
AppSec [candidate] (50.866 ms) : 0, 50866
IAST [baseline] (22.453 ms) : 0, 22453
IAST [candidate] (24.865 ms) : 0, 24865
Remote Config [baseline] (568.315 µs) : 0, 568
Remote Config [candidate] (567.225 µs) : 0, 567
Telemetry [baseline] (7.023 ms) : 0, 7023
Telemetry [candidate] (6.926 ms) : 0, 6926
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (782.327 ms) : 0, 782327
BytebuddyAgent [candidate] (787.793 ms) : 0, 787793
GlobalTracer [baseline] (295.644 ms) : 0, 295644
GlobalTracer [candidate] (297.334 ms) : 0, 297334
AppSec [baseline] (49.391 ms) : 0, 49391
AppSec [candidate] (52.449 ms) : 0, 52449
IAST [baseline] (22.834 ms) : 0, 22834
IAST [candidate] (22.992 ms) : 0, 22992
Remote Config [baseline] (596.708 µs) : 0, 597
Remote Config [candidate] (1.273 ms) : 0, 1273
Telemetry [baseline] (7.114 ms) : 0, 7114
Telemetry [candidate] (7.135 ms) : 0, 7135
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (779.084 ms) : 0, 779084
BytebuddyAgent [candidate] (779.556 ms) : 0, 779556
GlobalTracer [baseline] (295.927 ms) : 0, 295927
GlobalTracer [candidate] (295.532 ms) : 0, 295532
AppSec [baseline] (47.038 ms) : 0, 47038
AppSec [candidate] (46.941 ms) : 0, 46941
IAST [baseline] (27.099 ms) : 0, 27099
IAST [candidate] (26.923 ms) : 0, 26923
Remote Config [baseline] (615.07 µs) : 0, 615
Remote Config [candidate] (618.794 µs) : 0, 619
Telemetry [baseline] (7.008 ms) : 0, 7008
Telemetry [candidate] (6.882 ms) : 0, 6882

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~c426b286fa, baseline=1.38.0-SNAPSHOT~b20b6cfb7a

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043983
Total [baseline] (10.303 s) : 0, 10303268
Agent [candidate] (1.047 s) : 0, 1047099
Total [candidate] (10.307 s) : 0, 10307195
section appsec
Agent [baseline] (1.168 s) : 0, 1167711
Total [baseline] (10.513 s) : 0, 10513450
Agent [candidate] (1.165 s) : 0, 1164846
Total [candidate] (10.518 s) : 0, 10517955
section iast
Agent [baseline] (1.172 s) : 0, 1171652
Total [baseline] (10.819 s) : 0, 10818917
Agent [candidate] (1.172 s) : 0, 1171690
Total [candidate] (10.732 s) : 0, 10732037
section profiling
Agent [baseline] (1.25 s) : 0, 1250153
Total [baseline] (10.711 s) : 0, 10710844
Agent [candidate] (1.244 s) : 0, 1244137
Total [candidate] (10.606 s) : 0, 10606361

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	appsec	1.168 s	123.728 ms (11.9%)
Agent	iast	1.172 s	127.67 ms (12.2%)
Agent	profiling	1.25 s	206.17 ms (19.7%)
Total	tracing	10.303 s	-
Total	appsec	10.513 s	210.182 ms (2.0%)
Total	iast	10.819 s	515.649 ms (5.0%)
Total	profiling	10.711 s	407.576 ms (4.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.047 s	-
Agent	appsec	1.165 s	117.747 ms (11.2%)
Agent	iast	1.172 s	124.591 ms (11.9%)
Agent	profiling	1.244 s	197.038 ms (18.8%)
Total	tracing	10.307 s	-
Total	appsec	10.518 s	210.759 ms (2.0%)
Total	iast	10.732 s	424.842 ms (4.1%)
Total	profiling	10.606 s	299.165 ms (2.9%)

gantt
    title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~c426b286fa, baseline=1.38.0-SNAPSHOT~b20b6cfb7a

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.322 ms) : 0, 667322
BytebuddyAgent [candidate] (668.679 ms) : 0, 668679
GlobalTracer [baseline] (304.891 ms) : 0, 304891
GlobalTracer [candidate] (306.473 ms) : 0, 306473
AppSec [baseline] (50.417 ms) : 0, 50417
AppSec [candidate] (50.412 ms) : 0, 50412
Remote Config [baseline] (678.002 µs) : 0, 678
Remote Config [candidate] (686.809 µs) : 0, 687
Telemetry [baseline] (7.267 ms) : 0, 7267
Telemetry [candidate] (7.4 ms) : 0, 7400
section appsec
BytebuddyAgent [baseline] (678.198 ms) : 0, 678198
BytebuddyAgent [candidate] (677.884 ms) : 0, 677884
GlobalTracer [baseline] (300.585 ms) : 0, 300585
GlobalTracer [candidate] (298.657 ms) : 0, 298657
AppSec [baseline] (155.552 ms) : 0, 155552
AppSec [candidate] (155.511 ms) : 0, 155511
IAST [baseline] (21.253 ms) : 0, 21253
IAST [candidate] (19.672 ms) : 0, 19672
Remote Config [baseline] (606.361 µs) : 0, 606
Remote Config [candidate] (601.401 µs) : 0, 601
Telemetry [baseline] (8.662 ms) : 0, 8662
Telemetry [candidate] (8.9 ms) : 0, 8900
section iast
BytebuddyAgent [baseline] (782.34 ms) : 0, 782340
BytebuddyAgent [candidate] (781.608 ms) : 0, 781608
GlobalTracer [baseline] (295.188 ms) : 0, 295188
GlobalTracer [candidate] (294.946 ms) : 0, 294946
AppSec [baseline] (48.872 ms) : 0, 48872
AppSec [candidate] (49.038 ms) : 0, 49038
IAST [baseline] (24.152 ms) : 0, 24152
IAST [candidate] (24.313 ms) : 0, 24313
Remote Config [baseline] (570.478 µs) : 0, 570
Remote Config [candidate] (1.277 ms) : 0, 1277
Telemetry [baseline] (7.023 ms) : 0, 7023
Telemetry [candidate] (7.037 ms) : 0, 7037
section profiling
BytebuddyAgent [baseline] (667.69 ms) : 0, 667690
BytebuddyAgent [candidate] (662.998 ms) : 0, 662998
GlobalTracer [baseline] (389.958 ms) : 0, 389958
GlobalTracer [candidate] (388.532 ms) : 0, 388532
AppSec [baseline] (51.979 ms) : 0, 51979
AppSec [candidate] (51.939 ms) : 0, 51939
Remote Config [baseline] (754.139 µs) : 0, 754
Remote Config [candidate] (699.576 µs) : 0, 700
Telemetry [baseline] (7.312 ms) : 0, 7312
Telemetry [candidate] (7.287 ms) : 0, 7287
ProfilingAgent [baseline] (95.401 ms) : 0, 95401
ProfilingAgent [candidate] (95.791 ms) : 0, 95791
Profiling [baseline] (95.425 ms) : 0, 95425
Profiling [candidate] (95.816 ms) : 0, 95816

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-08-02T13:18:37	2024-08-02T13:25:26
git_branch	master	andrea.marziali/websphere-jmx
git_commit_date	1722530509	1722604016
git_commit_sha	`b20b6cf`	`c426b28`
release_version	1.38.0-SNAPSHOT~b20b6cfb7a	1.38.0-SNAPSHOT~c426b286fa
start_time	2024-08-02T13:18:23	2024-08-02T13:25:13

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1722605474	1722605474
ci_job_id	593170721	593170721
ci_pipeline_id	40771774	40771774
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~c426b286fa, baseline=1.38.0-SNAPSHOT~b20b6cfb7a
    dateFormat X
    axisFormat %s
section baseline
no_agent (365.424 µs) : 346, 385
.   : milestone, 365,
iast (485.678 µs) : 464, 508
.   : milestone, 486,
iast_FULL (549.907 µs) : 529, 571
.   : milestone, 550,
iast_GLOBAL (516.648 µs) : 494, 540
.   : milestone, 517,
iast_HARDCODED_SECRET_DISABLED (482.508 µs) : 461, 504
.   : milestone, 483,
iast_INACTIVE (460.838 µs) : 439, 483
.   : milestone, 461,
iast_TELEMETRY_OFF (467.776 µs) : 447, 489
.   : milestone, 468,
tracing (443.345 µs) : 423, 464
.   : milestone, 443,
section candidate
no_agent (360.295 µs) : 341, 380
.   : milestone, 360,
iast (492.374 µs) : 471, 514
.   : milestone, 492,
iast_FULL (564.569 µs) : 543, 586
.   : milestone, 565,
iast_GLOBAL (515.48 µs) : 492, 539
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (479.38 µs) : 459, 500
.   : milestone, 479,
iast_INACTIVE (454.61 µs) : 433, 477
.   : milestone, 455,
iast_TELEMETRY_OFF (474.561 µs) : 453, 496
.   : milestone, 475,
tracing (437.163 µs) : 417, 457
.   : milestone, 437,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	365.424 µs [345.645 µs, 385.204 µs]	-
iast	485.678 µs [463.719 µs, 507.637 µs]	120.254 µs (32.9%)
iast_FULL	549.907 µs [529.02 µs, 570.794 µs]	184.483 µs (50.5%)
iast_GLOBAL	516.648 µs [493.608 µs, 539.689 µs]	151.224 µs (41.4%)
iast_HARDCODED_SECRET_DISABLED	482.508 µs [461.382 µs, 503.633 µs]	117.084 µs (32.0%)
iast_INACTIVE	460.838 µs [439.02 µs, 482.657 µs]	95.414 µs (26.1%)
iast_TELEMETRY_OFF	467.776 µs [446.603 µs, 488.949 µs]	102.352 µs (28.0%)
tracing	443.345 µs [422.511 µs, 464.179 µs]	77.921 µs (21.3%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	360.295 µs [340.502 µs, 380.088 µs]	-
iast	492.374 µs [470.671 µs, 514.076 µs]	132.079 µs (36.7%)
iast_FULL	564.569 µs [543.41 µs, 585.727 µs]	204.274 µs (56.7%)
iast_GLOBAL	515.48 µs [492.412 µs, 538.548 µs]	155.185 µs (43.1%)
iast_HARDCODED_SECRET_DISABLED	479.38 µs [458.638 µs, 500.122 µs]	119.085 µs (33.1%)
iast_INACTIVE	454.61 µs [432.646 µs, 476.574 µs]	94.315 µs (26.2%)
iast_TELEMETRY_OFF	474.561 µs [453.183 µs, 495.938 µs]	114.266 µs (31.7%)
tracing	437.163 µs [417.099 µs, 457.227 µs]	76.868 µs (21.3%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~c426b286fa, baseline=1.38.0-SNAPSHOT~b20b6cfb7a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.34 ms) : 1319, 1360
.   : milestone, 1340,
appsec (1.736 ms) : 1712, 1760
.   : milestone, 1736,
appsec_no_iast (1.707 ms) : 1682, 1732
.   : milestone, 1707,
iast (1.485 ms) : 1462, 1508
.   : milestone, 1485,
profiling (1.514 ms) : 1487, 1540
.   : milestone, 1514,
tracing (1.458 ms) : 1433, 1483
.   : milestone, 1458,
section candidate
no_agent (1.35 ms) : 1331, 1369
.   : milestone, 1350,
appsec (1.707 ms) : 1682, 1732
.   : milestone, 1707,
appsec_no_iast (1.706 ms) : 1682, 1730
.   : milestone, 1706,
iast (1.473 ms) : 1451, 1496
.   : milestone, 1473,
profiling (1.502 ms) : 1478, 1525
.   : milestone, 1502,
tracing (1.467 ms) : 1442, 1492
.   : milestone, 1467,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.34 ms [1.319 ms, 1.36 ms]	-
appsec	1.736 ms [1.712 ms, 1.76 ms]	396.301 µs (29.6%)
appsec_no_iast	1.707 ms [1.682 ms, 1.732 ms]	367.181 µs (27.4%)
iast	1.485 ms [1.462 ms, 1.508 ms]	145.553 µs (10.9%)
profiling	1.514 ms [1.487 ms, 1.54 ms]	174.009 µs (13.0%)
tracing	1.458 ms [1.433 ms, 1.483 ms]	118.313 µs (8.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.35 ms [1.331 ms, 1.369 ms]	-
appsec	1.707 ms [1.682 ms, 1.732 ms]	356.941 µs (26.4%)
appsec_no_iast	1.706 ms [1.682 ms, 1.73 ms]	355.466 µs (26.3%)
iast	1.473 ms [1.451 ms, 1.496 ms]	123.263 µs (9.1%)
profiling	1.502 ms [1.478 ms, 1.525 ms]	151.485 µs (11.2%)
tracing	1.467 ms [1.442 ms, 1.492 ms]	116.577 µs (8.6%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/websphere-jmx
git_commit_date	1722530509	1722604016
git_commit_sha	`b20b6cf`	`c426b28`
release_version	1.38.0-SNAPSHOT~b20b6cfb7a	1.38.0-SNAPSHOT~c426b286fa

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1722605979	1722605979
ci_job_id	593170722	593170722
ci_pipeline_id	40771774	40771774
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~c426b286fa, baseline=1.38.0-SNAPSHOT~b20b6cfb7a
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.052 s) : 15052000, 15052000
.   : milestone, 15052000,
appsec (15.045 s) : 15045000, 15045000
.   : milestone, 15045000,
iast (18.635 s) : 18635000, 18635000
.   : milestone, 18635000,
iast_GLOBAL (17.682 s) : 17682000, 17682000
.   : milestone, 17682000,
profiling (15.836 s) : 15836000, 15836000
.   : milestone, 15836000,
tracing (15.176 s) : 15176000, 15176000
.   : milestone, 15176000,
section candidate
no_agent (15.066 s) : 15066000, 15066000
.   : milestone, 15066000,
appsec (15.166 s) : 15166000, 15166000
.   : milestone, 15166000,
iast (18.787 s) : 18787000, 18787000
.   : milestone, 18787000,
iast_GLOBAL (17.924 s) : 17924000, 17924000
.   : milestone, 17924000,
profiling (15.157 s) : 15157000, 15157000
.   : milestone, 15157000,
tracing (15.107 s) : 15107000, 15107000
.   : milestone, 15107000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.052 s [15.052 s, 15.052 s]	-
appsec	15.045 s [15.045 s, 15.045 s]	-7.0 ms (-0.0%)
iast	18.635 s [18.635 s, 18.635 s]	3.583 s (23.8%)
iast_GLOBAL	17.682 s [17.682 s, 17.682 s]	2.63 s (17.5%)
profiling	15.836 s [15.836 s, 15.836 s]	784.0 ms (5.2%)
tracing	15.176 s [15.176 s, 15.176 s]	124.0 ms (0.8%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.066 s [15.066 s, 15.066 s]	-
appsec	15.166 s [15.166 s, 15.166 s]	100.0 ms (0.7%)
iast	18.787 s [18.787 s, 18.787 s]	3.721 s (24.7%)
iast_GLOBAL	17.924 s [17.924 s, 17.924 s]	2.858 s (19.0%)
profiling	15.157 s [15.157 s, 15.157 s]	91.0 ms (0.6%)
tracing	15.107 s [15.107 s, 15.107 s]	41.0 ms (0.3%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~c426b286fa, baseline=1.38.0-SNAPSHOT~b20b6cfb7a
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
.   : milestone, 1468,
appsec (2.236 ms) : 2201, 2272
.   : milestone, 2236,
iast (1.978 ms) : 1936, 2019
.   : milestone, 1978,
iast_GLOBAL (2.007 ms) : 1965, 2050
.   : milestone, 2007,
profiling (1.873 ms) : 1839, 1908
.   : milestone, 1873,
tracing (1.851 ms) : 1819, 1884
.   : milestone, 1851,
section candidate
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.224 ms) : 2189, 2259
.   : milestone, 2224,
iast (1.982 ms) : 1940, 2025
.   : milestone, 1982,
iast_GLOBAL (2.032 ms) : 1988, 2076
.   : milestone, 2032,
profiling (1.863 ms) : 1829, 1896
.   : milestone, 1863,
tracing (1.845 ms) : 1812, 1877
.   : milestone, 1845,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.468 ms [1.456 ms, 1.479 ms]	-
appsec	2.236 ms [2.201 ms, 2.272 ms]	768.623 µs (52.4%)
iast	1.978 ms [1.936 ms, 2.019 ms]	510.074 µs (34.8%)
iast_GLOBAL	2.007 ms [1.965 ms, 2.05 ms]	539.779 µs (36.8%)
profiling	1.873 ms [1.839 ms, 1.908 ms]	405.771 µs (27.6%)
tracing	1.851 ms [1.819 ms, 1.884 ms]	383.818 µs (26.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.471 ms [1.459 ms, 1.482 ms]	-
appsec	2.224 ms [2.189 ms, 2.259 ms]	753.09 µs (51.2%)
iast	1.982 ms [1.94 ms, 2.025 ms]	511.513 µs (34.8%)
iast_GLOBAL	2.032 ms [1.988 ms, 2.076 ms]	560.951 µs (38.1%)
profiling	1.863 ms [1.829 ms, 1.896 ms]	391.699 µs (26.6%)
tracing	1.845 ms [1.812 ms, 1.877 ms]	373.754 µs (25.4%)

...ing/src/main/resources/datadog/trace/agent/tooling/bytebuddy/matcher/ignored_class_name.trie

dd-java-agent/agent-jmxfetch/build.gradle

.../main/java/datadog/trace/instrumentation/websphere_jmx/WebsphereSecurityInstrumentation.java

...bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/jmx/MBeanServerRegistry.java

amarziali · 2024-07-12T14:17:15Z

Note: need to wait a release of JMXFetch before bumping that dependency and merge this PR

amarziali force-pushed the andrea.marziali/websphere-jmx branch 3 times, most recently from fec9c36 to 8760a06 Compare June 24, 2024 14:04

amarziali commented Jul 9, 2024

View reviewed changes

...ing/src/main/resources/datadog/trace/agent/tooling/bytebuddy/matcher/ignored_class_name.trie Outdated Show resolved Hide resolved

amarziali commented Jul 9, 2024

View reviewed changes

dd-java-agent/agent-jmxfetch/build.gradle Outdated Show resolved Hide resolved

amarziali force-pushed the andrea.marziali/websphere-jmx branch from d2f7c43 to 034d4f1 Compare July 11, 2024 08:19

amarziali changed the title ~~[WIP]Upgrade JMX Mbean server when using custom one~~ [WIP] Support Websphere JMX admin metrics Jul 11, 2024

amarziali marked this pull request as ready for review July 11, 2024 08:20

amarziali requested review from a team as code owners July 11, 2024 08:20

amarziali requested review from mcculls and nayeem-kamal July 11, 2024 08:20

amarziali marked this pull request as draft July 11, 2024 08:20

amarziali force-pushed the andrea.marziali/websphere-jmx branch from 034d4f1 to 41a5e24 Compare July 11, 2024 08:26

amarziali changed the title ~~[WIP] Support Websphere JMX admin metrics~~ Support Websphere JMX admin metrics Jul 11, 2024

mcculls reviewed Jul 12, 2024

View reviewed changes

.../main/java/datadog/trace/instrumentation/websphere_jmx/WebsphereSecurityInstrumentation.java Show resolved Hide resolved

mcculls reviewed Jul 12, 2024

View reviewed changes

.../main/java/datadog/trace/instrumentation/websphere_jmx/WebsphereSecurityInstrumentation.java Show resolved Hide resolved

mcculls reviewed Jul 12, 2024

View reviewed changes

...bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/jmx/MBeanServerRegistry.java Outdated Show resolved Hide resolved

mcculls reviewed Jul 12, 2024

View reviewed changes

...bootstrap/src/main/java/datadog/trace/bootstrap/instrumentation/jmx/MBeanServerRegistry.java Outdated Show resolved Hide resolved

amarziali requested a review from mcculls July 12, 2024 14:16

amarziali added the comp: jmx-fetch JMX fetch label Jul 12, 2024

mcculls force-pushed the andrea.marziali/websphere-jmx branch 2 times, most recently from 739bc47 to 54e35bd Compare July 29, 2024 17:34

mcculls marked this pull request as ready for review July 29, 2024 17:34

mcculls approved these changes Jul 29, 2024

View reviewed changes

amarziali added 3 commits August 2, 2024 14:06

[WIP]Upgrade JMX Mbean server when using custom one

93365a6

wip

91205cf

Add Websphere JMX config and security helper

6620286

amarziali and others added 5 commits August 2, 2024 14:06

Bump jmxfetch

37e68fd

review

153c240

Use jmxfetch 0.49.3 release

e8b61aa

Review feedback

92df099

Review feedback

c426b28

mcculls force-pushed the andrea.marziali/websphere-jmx branch from 54e35bd to c426b28 Compare August 2, 2024 13:06

mcculls merged commit 0a5a92f into master Aug 2, 2024
80 checks passed

mcculls deleted the andrea.marziali/websphere-jmx branch August 2, 2024 16:18

github-actions bot added this to the 1.38.0 milestone Aug 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Websphere JMX admin metrics #7235

Support Websphere JMX admin metrics #7235

amarziali commented Jun 24, 2024 •

edited

Loading

pr-commenter bot commented Jun 24, 2024 •

edited

Loading

amarziali commented Jul 12, 2024

Support Websphere JMX admin metrics #7235

Support Websphere JMX admin metrics #7235

Conversation

amarziali commented Jun 24, 2024 • edited Loading

What Does This Do

Motivation

Additional Notes

pr-commenter bot commented Jun 24, 2024 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

amarziali commented Jul 12, 2024

amarziali commented Jun 24, 2024 •

edited

Loading

pr-commenter bot commented Jun 24, 2024 •

edited

Loading