-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Gradle version locking #7239
Merged
Merged
+39
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 50 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.36.0-SNAPSHOT~7cea4dc426, baseline=1.36.0-SNAPSHOT~d19ceac03e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058999
Total [baseline] (10.355 s) : 0, 10355385
Agent [candidate] (1.069 s) : 0, 1068883
Total [candidate] (10.355 s) : 0, 10355242
section appsec
Agent [baseline] (1.184 s) : 0, 1184312
Total [baseline] (10.444 s) : 0, 10444092
Agent [candidate] (1.183 s) : 0, 1182668
Total [candidate] (10.49 s) : 0, 10489659
section iast
Agent [baseline] (1.177 s) : 0, 1177201
Total [baseline] (10.671 s) : 0, 10670746
Agent [candidate] (1.185 s) : 0, 1184589
Total [candidate] (10.78 s) : 0, 10779853
section profiling
Agent [baseline] (1.259 s) : 0, 1258545
Total [baseline] (10.666 s) : 0, 10666061
Agent [candidate] (1.259 s) : 0, 1258956
Total [candidate] (10.585 s) : 0, 10584728
gantt
title petclinic - break down per module: candidate=1.36.0-SNAPSHOT~7cea4dc426, baseline=1.36.0-SNAPSHOT~d19ceac03e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (663.787 ms) : 0, 663787
BytebuddyAgent [candidate] (670.089 ms) : 0, 670089
GlobalTracer [baseline] (302.673 ms) : 0, 302673
GlobalTracer [candidate] (305.517 ms) : 0, 305517
AppSec [baseline] (50.024 ms) : 0, 50024
AppSec [candidate] (50.421 ms) : 0, 50421
Remote Config [baseline] (688.229 µs) : 0, 688
Remote Config [candidate] (690.779 µs) : 0, 691
Telemetry [baseline] (7.61 ms) : 0, 7610
Telemetry [candidate] (7.625 ms) : 0, 7625
section appsec
BytebuddyAgent [baseline] (676.621 ms) : 0, 676621
BytebuddyAgent [candidate] (677.432 ms) : 0, 677432
GlobalTracer [baseline] (298.495 ms) : 0, 298495
GlobalTracer [candidate] (297.021 ms) : 0, 297021
AppSec [baseline] (154.167 ms) : 0, 154167
AppSec [candidate] (154.191 ms) : 0, 154191
IAST [baseline] (22.344 ms) : 0, 22344
IAST [candidate] (20.543 ms) : 0, 20543
Remote Config [baseline] (639.579 µs) : 0, 640
Remote Config [candidate] (635.778 µs) : 0, 636
Telemetry [baseline] (8.829 ms) : 0, 8829
Telemetry [candidate] (8.504 ms) : 0, 8504
section iast
BytebuddyAgent [baseline] (785.554 ms) : 0, 785554
BytebuddyAgent [candidate] (789.71 ms) : 0, 789710
GlobalTracer [baseline] (295.098 ms) : 0, 295098
GlobalTracer [candidate] (296.807 ms) : 0, 296807
AppSec [baseline] (47.404 ms) : 0, 47404
AppSec [candidate] (47.825 ms) : 0, 47825
IAST [baseline] (28.29 ms) : 0, 28290
IAST [candidate] (29.046 ms) : 0, 29046
Remote Config [baseline] (607.573 µs) : 0, 608
Remote Config [candidate] (631.899 µs) : 0, 632
Telemetry [baseline] (6.871 ms) : 0, 6871
Telemetry [candidate] (7.125 ms) : 0, 7125
section profiling
BytebuddyAgent [baseline] (660.644 ms) : 0, 660644
BytebuddyAgent [candidate] (661.208 ms) : 0, 661208
GlobalTracer [baseline] (385.772 ms) : 0, 385772
GlobalTracer [candidate] (385.39 ms) : 0, 385390
AppSec [baseline] (51.367 ms) : 0, 51367
AppSec [candidate] (51.286 ms) : 0, 51286
Remote Config [baseline] (742.166 µs) : 0, 742
Remote Config [candidate] (747.544 µs) : 0, 748
Telemetry [baseline] (7.335 ms) : 0, 7335
Telemetry [candidate] (7.369 ms) : 0, 7369
ProfilingAgent [baseline] (96.007 ms) : 0, 96007
ProfilingAgent [candidate] (96.131 ms) : 0, 96131
Profiling [baseline] (96.031 ms) : 0, 96031
Profiling [candidate] (96.155 ms) : 0, 96155
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.36.0-SNAPSHOT~7cea4dc426, baseline=1.36.0-SNAPSHOT~d19ceac03e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1065401
Total [baseline] (8.546 s) : 0, 8545873
Agent [candidate] (1.059 s) : 0, 1058992
Total [candidate] (8.575 s) : 0, 8575243
section iast
Agent [baseline] (1.167 s) : 0, 1167427
Total [baseline] (8.98 s) : 0, 8979695
Agent [candidate] (1.169 s) : 0, 1169077
Total [candidate] (8.991 s) : 0, 8990935
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.169 s) : 0, 1169209
Total [baseline] (9.021 s) : 0, 9021435
Agent [candidate] (1.167 s) : 0, 1167364
Total [candidate] (8.951 s) : 0, 8950912
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1165981
Total [baseline] (8.968 s) : 0, 8967549
Agent [candidate] (1.173 s) : 0, 1173081
Total [candidate] (9.002 s) : 0, 9002393
gantt
title insecure-bank - break down per module: candidate=1.36.0-SNAPSHOT~7cea4dc426, baseline=1.36.0-SNAPSHOT~d19ceac03e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.965 ms) : 0, 667965
BytebuddyAgent [candidate] (663.764 ms) : 0, 663764
GlobalTracer [baseline] (304.331 ms) : 0, 304331
GlobalTracer [candidate] (302.586 ms) : 0, 302586
AppSec [baseline] (50.377 ms) : 0, 50377
AppSec [candidate] (50.098 ms) : 0, 50098
Remote Config [baseline] (690.038 µs) : 0, 690
Remote Config [candidate] (688.1 µs) : 0, 688
Telemetry [baseline] (7.569 ms) : 0, 7569
Telemetry [candidate] (7.579 ms) : 0, 7579
section iast
BytebuddyAgent [baseline] (778.412 ms) : 0, 778412
BytebuddyAgent [candidate] (779.329 ms) : 0, 779329
GlobalTracer [baseline] (292.474 ms) : 0, 292474
GlobalTracer [candidate] (292.983 ms) : 0, 292983
AppSec [baseline] (46.955 ms) : 0, 46955
AppSec [candidate] (46.972 ms) : 0, 46972
IAST [baseline] (28.109 ms) : 0, 28109
IAST [candidate] (28.21 ms) : 0, 28210
Remote Config [baseline] (603.024 µs) : 0, 603
Remote Config [candidate] (640.737 µs) : 0, 641
Telemetry [baseline] (7.631 ms) : 0, 7631
Telemetry [candidate] (7.663 ms) : 0, 7663
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.197 ms) : 0, 779197
BytebuddyAgent [candidate] (777.398 ms) : 0, 777398
GlobalTracer [baseline] (293.239 ms) : 0, 293239
GlobalTracer [candidate] (292.865 ms) : 0, 292865
AppSec [baseline] (47.27 ms) : 0, 47270
AppSec [candidate] (47.041 ms) : 0, 47041
IAST [baseline] (27.869 ms) : 0, 27869
IAST [candidate] (28.437 ms) : 0, 28437
Remote Config [baseline] (630.764 µs) : 0, 631
Remote Config [candidate] (633.654 µs) : 0, 634
Telemetry [baseline] (7.664 ms) : 0, 7664
Telemetry [candidate] (7.685 ms) : 0, 7685
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (776.247 ms) : 0, 776247
BytebuddyAgent [candidate] (781.575 ms) : 0, 781575
GlobalTracer [baseline] (293.852 ms) : 0, 293852
GlobalTracer [candidate] (294.702 ms) : 0, 294702
AppSec [baseline] (47.251 ms) : 0, 47251
AppSec [candidate] (47.496 ms) : 0, 47496
IAST [baseline] (25.639 ms) : 0, 25639
IAST [candidate] (26.801 ms) : 0, 26801
Remote Config [baseline] (614.984 µs) : 0, 615
Remote Config [candidate] (598.188 µs) : 0, 598
Telemetry [baseline] (9.092 ms) : 0, 9092
Telemetry [candidate] (8.471 ms) : 0, 8471
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~7cea4dc426, baseline=1.36.0-SNAPSHOT~d19ceac03e
dateFormat X
axisFormat %s
section baseline
no_agent (383.914 µs) : 364, 404
. : milestone, 384,
iast (486.257 µs) : 465, 508
. : milestone, 486,
iast_FULL (560.245 µs) : 539, 581
. : milestone, 560,
iast_GLOBAL (508.345 µs) : 487, 530
. : milestone, 508,
iast_HARDCODED_SECRET_DISABLED (493.64 µs) : 472, 515
. : milestone, 494,
iast_INACTIVE (464.495 µs) : 443, 486
. : milestone, 464,
iast_TELEMETRY_OFF (479.991 µs) : 458, 502
. : milestone, 480,
tracing (444.354 µs) : 423, 465
. : milestone, 444,
section candidate
no_agent (375.323 µs) : 356, 395
. : milestone, 375,
iast (485.38 µs) : 464, 506
. : milestone, 485,
iast_FULL (554.616 µs) : 533, 576
. : milestone, 555,
iast_GLOBAL (518.397 µs) : 496, 541
. : milestone, 518,
iast_HARDCODED_SECRET_DISABLED (486.614 µs) : 465, 508
. : milestone, 487,
iast_INACTIVE (449.55 µs) : 429, 470
. : milestone, 450,
iast_TELEMETRY_OFF (477.862 µs) : 457, 499
. : milestone, 478,
tracing (446.853 µs) : 426, 468
. : milestone, 447,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~7cea4dc426, baseline=1.36.0-SNAPSHOT~d19ceac03e
dateFormat X
axisFormat %s
section baseline
no_agent (1.349 ms) : 1330, 1369
. : milestone, 1349,
appsec (1.746 ms) : 1722, 1769
. : milestone, 1746,
appsec_no_iast (1.724 ms) : 1699, 1749
. : milestone, 1724,
iast (1.488 ms) : 1466, 1510
. : milestone, 1488,
profiling (1.544 ms) : 1519, 1570
. : milestone, 1544,
tracing (1.491 ms) : 1467, 1516
. : milestone, 1491,
section candidate
no_agent (1.36 ms) : 1340, 1380
. : milestone, 1360,
appsec (1.711 ms) : 1686, 1735
. : milestone, 1711,
appsec_no_iast (1.721 ms) : 1695, 1746
. : milestone, 1721,
iast (1.497 ms) : 1474, 1519
. : milestone, 1497,
profiling (1.565 ms) : 1540, 1589
. : milestone, 1565,
tracing (1.484 ms) : 1460, 1508
. : milestone, 1484,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~7cea4dc426, baseline=1.36.0-SNAPSHOT~d19ceac03e
dateFormat X
axisFormat %s
section baseline
no_agent (15.401 s) : 15401000, 15401000
. : milestone, 15401000,
appsec (14.997 s) : 14997000, 14997000
. : milestone, 14997000,
iast (18.817 s) : 18817000, 18817000
. : milestone, 18817000,
iast_GLOBAL (17.635 s) : 17635000, 17635000
. : milestone, 17635000,
profiling (15.273 s) : 15273000, 15273000
. : milestone, 15273000,
tracing (15.13 s) : 15130000, 15130000
. : milestone, 15130000,
section candidate
no_agent (15.086 s) : 15086000, 15086000
. : milestone, 15086000,
appsec (14.993 s) : 14993000, 14993000
. : milestone, 14993000,
iast (19.092 s) : 19092000, 19092000
. : milestone, 19092000,
iast_GLOBAL (19.102 s) : 19102000, 19102000
. : milestone, 19102000,
profiling (14.859 s) : 14859000, 14859000
. : milestone, 14859000,
tracing (15.009 s) : 15009000, 15009000
. : milestone, 15009000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~7cea4dc426, baseline=1.36.0-SNAPSHOT~d19ceac03e
dateFormat X
axisFormat %s
section baseline
no_agent (1.46 ms) : 1448, 1471
. : milestone, 1460,
appsec (2.192 ms) : 2158, 2225
. : milestone, 2192,
iast (1.96 ms) : 1919, 2002
. : milestone, 1960,
iast_GLOBAL (1.998 ms) : 1957, 2039
. : milestone, 1998,
profiling (2.317 ms) : 2137, 2497
. : milestone, 2317,
tracing (1.828 ms) : 1796, 1861
. : milestone, 1828,
section candidate
no_agent (1.456 ms) : 1444, 1467
. : milestone, 1456,
appsec (2.195 ms) : 2161, 2229
. : milestone, 2195,
iast (1.964 ms) : 1922, 2005
. : milestone, 1964,
iast_GLOBAL (1.995 ms) : 1954, 2036
. : milestone, 1995,
profiling (1.846 ms) : 1811, 1880
. : milestone, 1846,
tracing (1.83 ms) : 1797, 1862
. : milestone, 1830,
|
smola
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR moves the version locking into a Gradle convention plugin as
subprojects
andallprojects
must be avoid for shared project configuration.It also updates the pinned version before building nightly versions.
Motivation
Version locking was broken. Nightly build does no more test latest library versions.
Additional Notes
Not sure about the CI script update... Can it mess with the cache?
Jira ticket: [PROJ-IDENT]