Include propagationTags when resetting ContextInterpreter state #7247

am312 · 2024-06-26T18:01:14Z

What Does This Do

clears propagationTags when resetting ContextInterpreter.

Jira ticket: [AIT-9906]

pr-commenter · 2024-06-26T18:46:50Z

Benchmarks

Startup

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2024-06-26T18:22:53	2024-06-26T18:29:42
git_branch	master	andrew.munn/clear-propagation-tags
git_commit_date	1719418036	1719424728
git_commit_sha	`42fde89`	`27318e5`
release_version	1.36.0-SNAPSHOT~42fde89a19	1.36.0-SNAPSHOT~27318e5151
start_time	2024-06-26T18:22:40	2024-06-26T18:29:28

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1719426926	1719426926
ci_job_id	553923956	553923956
ci_pipeline_id	37605928	37605928
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~27318e5151, baseline=1.36.0-SNAPSHOT~42fde89a19
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.345 ms) : 1327, 1364
.   : milestone, 1345,
appsec (1.705 ms) : 1681, 1730
.   : milestone, 1705,
appsec_no_iast (1.718 ms) : 1694, 1743
.   : milestone, 1718,
iast (1.476 ms) : 1453, 1498
.   : milestone, 1476,
profiling (1.517 ms) : 1492, 1541
.   : milestone, 1517,
tracing (1.455 ms) : 1431, 1478
.   : milestone, 1455,
section candidate
no_agent (1.35 ms) : 1332, 1369
.   : milestone, 1350,
appsec (1.706 ms) : 1681, 1730
.   : milestone, 1706,
appsec_no_iast (1.73 ms) : 1706, 1754
.   : milestone, 1730,
iast (1.471 ms) : 1448, 1493
.   : milestone, 1471,
profiling (1.491 ms) : 1466, 1516
.   : milestone, 1491,
tracing (1.48 ms) : 1456, 1503
.   : milestone, 1480,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.345 ms [1.327 ms, 1.364 ms]	-
appsec	1.705 ms [1.681 ms, 1.73 ms]	360.08 µs (26.8%)
appsec_no_iast	1.718 ms [1.694 ms, 1.743 ms]	372.998 µs (27.7%)
iast	1.476 ms [1.453 ms, 1.498 ms]	130.384 µs (9.7%)
profiling	1.517 ms [1.492 ms, 1.541 ms]	171.316 µs (12.7%)
tracing	1.455 ms [1.431 ms, 1.478 ms]	109.56 µs (8.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.35 ms [1.332 ms, 1.369 ms]	-
appsec	1.706 ms [1.681 ms, 1.73 ms]	355.251 µs (26.3%)
appsec_no_iast	1.73 ms [1.706 ms, 1.754 ms]	379.492 µs (28.1%)
iast	1.471 ms [1.448 ms, 1.493 ms]	120.068 µs (8.9%)
profiling	1.491 ms [1.466 ms, 1.516 ms]	140.647 µs (10.4%)
tracing	1.48 ms [1.456 ms, 1.503 ms]	129.255 µs (9.6%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.36.0-SNAPSHOT~27318e5151, baseline=1.36.0-SNAPSHOT~42fde89a19
    dateFormat X
    axisFormat %s
section baseline
no_agent (363.815 µs) : 344, 383
.   : milestone, 364,
iast (481.772 µs) : 460, 503
.   : milestone, 482,
iast_FULL (549.057 µs) : 528, 570
.   : milestone, 549,
iast_GLOBAL (512.636 µs) : 490, 535
.   : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (475.421 µs) : 455, 496
.   : milestone, 475,
iast_INACTIVE (450.917 µs) : 430, 472
.   : milestone, 451,
iast_TELEMETRY_OFF (461.722 µs) : 441, 483
.   : milestone, 462,
tracing (436.862 µs) : 416, 458
.   : milestone, 437,
section candidate
no_agent (364.465 µs) : 345, 384
.   : milestone, 364,
iast (482.448 µs) : 461, 504
.   : milestone, 482,
iast_FULL (550.604 µs) : 530, 572
.   : milestone, 551,
iast_GLOBAL (508.825 µs) : 487, 531
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (477.439 µs) : 456, 499
.   : milestone, 477,
iast_INACTIVE (450.318 µs) : 429, 472
.   : milestone, 450,
iast_TELEMETRY_OFF (473.549 µs) : 452, 495
.   : milestone, 474,
tracing (442.563 µs) : 421, 464
.   : milestone, 443,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	363.815 µs [344.366 µs, 383.264 µs]	-
iast	481.772 µs [460.431 µs, 503.113 µs]	117.957 µs (32.4%)
iast_FULL	549.057 µs [528.042 µs, 570.072 µs]	185.242 µs (50.9%)
iast_GLOBAL	512.636 µs [490.422 µs, 534.849 µs]	148.821 µs (40.9%)
iast_HARDCODED_SECRET_DISABLED	475.421 µs [454.549 µs, 496.292 µs]	111.605 µs (30.7%)
iast_INACTIVE	450.917 µs [429.79 µs, 472.045 µs]	87.102 µs (23.9%)
iast_TELEMETRY_OFF	461.722 µs [440.823 µs, 482.621 µs]	97.907 µs (26.9%)
tracing	436.862 µs [415.716 µs, 458.008 µs]	73.046 µs (20.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	364.465 µs [345.137 µs, 383.793 µs]	-
iast	482.448 µs [461.344 µs, 503.552 µs]	117.983 µs (32.4%)
iast_FULL	550.604 µs [529.621 µs, 571.586 µs]	186.139 µs (51.1%)
iast_GLOBAL	508.825 µs [486.986 µs, 530.664 µs]	144.36 µs (39.6%)
iast_HARDCODED_SECRET_DISABLED	477.439 µs [456.377 µs, 498.502 µs]	112.974 µs (31.0%)
iast_INACTIVE	450.318 µs [428.767 µs, 471.868 µs]	85.853 µs (23.6%)
iast_TELEMETRY_OFF	473.549 µs [452.274 µs, 494.823 µs]	109.084 µs (29.9%)
tracing	442.563 µs [421.469 µs, 463.658 µs]	78.098 µs (21.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrew.munn/clear-propagation-tags
git_commit_date	1719418036	1719424728
git_commit_sha	`42fde89`	`27318e5`
release_version	1.36.0-SNAPSHOT~42fde89a19	1.36.0-SNAPSHOT~27318e5151

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1719427449	1719427449
ci_job_id	553923957	553923957
ci_pipeline_id	37605928	37605928
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~27318e5151, baseline=1.36.0-SNAPSHOT~42fde89a19
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.466 ms) : 1454, 1477
.   : milestone, 1466,
appsec (2.211 ms) : 2178, 2245
.   : milestone, 2211,
iast (1.97 ms) : 1928, 2011
.   : milestone, 1970,
iast_GLOBAL (2.017 ms) : 1976, 2059
.   : milestone, 2017,
profiling (2.344 ms) : 2165, 2522
.   : milestone, 2344,
tracing (1.837 ms) : 1805, 1869
.   : milestone, 1837,
section candidate
no_agent (1.469 ms) : 1458, 1480
.   : milestone, 1469,
appsec (2.233 ms) : 2198, 2267
.   : milestone, 2233,
iast (1.977 ms) : 1936, 2018
.   : milestone, 1977,
iast_GLOBAL (2.014 ms) : 1974, 2055
.   : milestone, 2014,
profiling (1.858 ms) : 1824, 1892
.   : milestone, 1858,
tracing (1.845 ms) : 1813, 1877
.   : milestone, 1845,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.466 ms [1.454 ms, 1.477 ms]	-
appsec	2.211 ms [2.178 ms, 2.245 ms]	745.856 µs (50.9%)
iast	1.97 ms [1.928 ms, 2.011 ms]	504.158 µs (34.4%)
iast_GLOBAL	2.017 ms [1.976 ms, 2.059 ms]	551.632 µs (37.6%)
profiling	2.344 ms [2.165 ms, 2.522 ms]	878.095 µs (59.9%)
tracing	1.837 ms [1.805 ms, 1.869 ms]	371.594 µs (25.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.458 ms, 1.48 ms]	-
appsec	2.233 ms [2.198 ms, 2.267 ms]	763.446 µs (52.0%)
iast	1.977 ms [1.936 ms, 2.018 ms]	508.117 µs (34.6%)
iast_GLOBAL	2.014 ms [1.974 ms, 2.055 ms]	545.191 µs (37.1%)
profiling	1.858 ms [1.824 ms, 1.892 ms]	389.045 µs (26.5%)
tracing	1.845 ms [1.813 ms, 1.877 ms]	376.018 µs (25.6%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.36.0-SNAPSHOT~27318e5151, baseline=1.36.0-SNAPSHOT~42fde89a19
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.32 s) : 15320000, 15320000
.   : milestone, 15320000,
appsec (15.118 s) : 15118000, 15118000
.   : milestone, 15118000,
iast (18.937 s) : 18937000, 18937000
.   : milestone, 18937000,
iast_GLOBAL (17.966 s) : 17966000, 17966000
.   : milestone, 17966000,
profiling (15.751 s) : 15751000, 15751000
.   : milestone, 15751000,
tracing (15.21 s) : 15210000, 15210000
.   : milestone, 15210000,
section candidate
no_agent (15.425 s) : 15425000, 15425000
.   : milestone, 15425000,
appsec (14.998 s) : 14998000, 14998000
.   : milestone, 14998000,
iast (18.984 s) : 18984000, 18984000
.   : milestone, 18984000,
iast_GLOBAL (18.137 s) : 18137000, 18137000
.   : milestone, 18137000,
profiling (15.864 s) : 15864000, 15864000
.   : milestone, 15864000,
tracing (14.958 s) : 14958000, 14958000
.   : milestone, 14958000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.32 s [15.32 s, 15.32 s]	-
appsec	15.118 s [15.118 s, 15.118 s]	-202.0 ms (-1.3%)
iast	18.937 s [18.937 s, 18.937 s]	3.617 s (23.6%)
iast_GLOBAL	17.966 s [17.966 s, 17.966 s]	2.646 s (17.3%)
profiling	15.751 s [15.751 s, 15.751 s]	431.0 ms (2.8%)
tracing	15.21 s [15.21 s, 15.21 s]	-110.0 ms (-0.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.425 s [15.425 s, 15.425 s]	-
appsec	14.998 s [14.998 s, 14.998 s]	-427.0 ms (-2.8%)
iast	18.984 s [18.984 s, 18.984 s]	3.559 s (23.1%)
iast_GLOBAL	18.137 s [18.137 s, 18.137 s]	2.712 s (17.6%)
profiling	15.864 s [15.864 s, 15.864 s]	439.0 ms (2.8%)
tracing	14.958 s [14.958 s, 14.958 s]	-467.0 ms (-3.0%)

clear propagationTags

27318e5

am312 added type: bug tag: no release notes Changes to exclude from release notes comp: context propagation Trace context propagation labels Jun 26, 2024

mcculls approved these changes Jun 26, 2024

View reviewed changes

am312 marked this pull request as ready for review June 26, 2024 20:12

am312 requested a review from a team as a code owner June 26, 2024 20:12

am312 requested review from dougqh and ygree June 26, 2024 20:12

am312 merged commit 9e325ef into master Jun 26, 2024
84 checks passed

am312 deleted the andrew.munn/clear-propagation-tags branch June 26, 2024 20:24

github-actions bot added this to the 1.36.0 milestone Jun 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include propagationTags when resetting ContextInterpreter state #7247

Include propagationTags when resetting ContextInterpreter state #7247

am312 commented Jun 26, 2024 •

edited by jira bot

Loading

pr-commenter bot commented Jun 26, 2024

Include propagationTags when resetting ContextInterpreter state #7247

Include propagationTags when resetting ContextInterpreter state #7247

Conversation

am312 commented Jun 26, 2024 • edited by jira bot Loading

What Does This Do

pr-commenter bot commented Jun 26, 2024

Benchmarks

Startup

Load

Parameters

Summary

Dacapo

Parameters

Summary

am312 commented Jun 26, 2024 •

edited by jira bot

Loading