-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default trace protocol version in smoke tests #7258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 47 metrics, 16 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.37.0-SNAPSHOT~396e5bd119, baseline=1.37.0-SNAPSHOT~11753cac4d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064741
Total [baseline] (10.318 s) : 0, 10318250
Agent [candidate] (1.076 s) : 0, 1076370
Total [candidate] (10.358 s) : 0, 10358078
section appsec
Agent [baseline] (1.185 s) : 0, 1184588
Total [baseline] (10.491 s) : 0, 10491117
Agent [candidate] (1.19 s) : 0, 1190056
Total [candidate] (10.48 s) : 0, 10480393
section iast
Agent [baseline] (1.17 s) : 0, 1169537
Total [baseline] (10.779 s) : 0, 10778826
Agent [candidate] (1.171 s) : 0, 1170530
Total [candidate] (10.785 s) : 0, 10784577
section profiling
Agent [baseline] (1.266 s) : 0, 1265840
Total [baseline] (10.568 s) : 0, 10568431
Agent [candidate] (1.265 s) : 0, 1264680
Total [candidate] (10.601 s) : 0, 10600804
gantt
title petclinic - break down per module: candidate=1.37.0-SNAPSHOT~396e5bd119, baseline=1.37.0-SNAPSHOT~11753cac4d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (666.714 ms) : 0, 666714
BytebuddyAgent [candidate] (675.621 ms) : 0, 675621
GlobalTracer [baseline] (305.252 ms) : 0, 305252
GlobalTracer [candidate] (306.731 ms) : 0, 306731
AppSec [baseline] (49.939 ms) : 0, 49939
AppSec [candidate] (50.537 ms) : 0, 50537
Remote Config [baseline] (743.794 µs) : 0, 744
Remote Config [candidate] (758.356 µs) : 0, 758
Telemetry [baseline] (7.514 ms) : 0, 7514
Telemetry [candidate] (7.682 ms) : 0, 7682
section appsec
BytebuddyAgent [baseline] (677.945 ms) : 0, 677945
BytebuddyAgent [candidate] (681.041 ms) : 0, 681041
GlobalTracer [baseline] (298.006 ms) : 0, 298006
GlobalTracer [candidate] (299.426 ms) : 0, 299426
AppSec [baseline] (154.065 ms) : 0, 154065
AppSec [candidate] (154.437 ms) : 0, 154437
Remote Config [baseline] (633.277 µs) : 0, 633
Remote Config [candidate] (630.851 µs) : 0, 631
Telemetry [baseline] (8.382 ms) : 0, 8382
Telemetry [candidate] (9.408 ms) : 0, 9408
IAST [baseline] (21.826 ms) : 0, 21826
IAST [candidate] (20.417 ms) : 0, 20417
section iast
BytebuddyAgent [baseline] (778.701 ms) : 0, 778701
BytebuddyAgent [candidate] (779.259 ms) : 0, 779259
GlobalTracer [baseline] (294.242 ms) : 0, 294242
GlobalTracer [candidate] (294.016 ms) : 0, 294016
AppSec [baseline] (47.393 ms) : 0, 47393
AppSec [candidate] (47.336 ms) : 0, 47336
Remote Config [baseline] (611.607 µs) : 0, 612
Remote Config [candidate] (588.632 µs) : 0, 589
Telemetry [baseline] (7.027 ms) : 0, 7027
Telemetry [candidate] (6.964 ms) : 0, 6964
IAST [baseline] (28.121 ms) : 0, 28121
IAST [candidate] (28.902 ms) : 0, 28902
section profiling
BytebuddyAgent [baseline] (664.011 ms) : 0, 664011
BytebuddyAgent [candidate] (663.317 ms) : 0, 663317
GlobalTracer [baseline] (388.251 ms) : 0, 388251
GlobalTracer [candidate] (387.287 ms) : 0, 387287
AppSec [baseline] (52.016 ms) : 0, 52016
AppSec [candidate] (52.024 ms) : 0, 52024
Remote Config [baseline] (655.278 µs) : 0, 655
Remote Config [candidate] (652.113 µs) : 0, 652
Telemetry [baseline] (7.357 ms) : 0, 7357
Telemetry [candidate] (7.365 ms) : 0, 7365
ProfilingAgent [baseline] (96.407 ms) : 0, 96407
ProfilingAgent [candidate] (96.822 ms) : 0, 96822
Profiling [baseline] (96.432 ms) : 0, 96432
Profiling [candidate] (96.847 ms) : 0, 96847
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.37.0-SNAPSHOT~396e5bd119, baseline=1.37.0-SNAPSHOT~11753cac4d
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064650
Total [baseline] (8.526 s) : 0, 8526340
Agent [candidate] (1.061 s) : 0, 1060628
Total [candidate] (8.565 s) : 0, 8564803
section iast
Agent [baseline] (1.178 s) : 0, 1178423
Total [baseline] (9.016 s) : 0, 9015782
Agent [candidate] (1.171 s) : 0, 1170727
Total [candidate] (9.008 s) : 0, 9007717
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.179 s) : 0, 1178666
Total [baseline] (8.986 s) : 0, 8986178
Agent [candidate] (1.168 s) : 0, 1168032
Total [candidate] (8.997 s) : 0, 8997319
section iast_TELEMETRY_OFF
Agent [baseline] (1.168 s) : 0, 1168436
Total [baseline] (8.993 s) : 0, 8992519
Agent [candidate] (1.167 s) : 0, 1167047
Total [candidate] (8.987 s) : 0, 8987169
gantt
title insecure-bank - break down per module: candidate=1.37.0-SNAPSHOT~396e5bd119, baseline=1.37.0-SNAPSHOT~11753cac4d
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.077 ms) : 0, 667077
BytebuddyAgent [candidate] (663.536 ms) : 0, 663536
GlobalTracer [baseline] (304.448 ms) : 0, 304448
GlobalTracer [candidate] (303.872 ms) : 0, 303872
AppSec [baseline] (50.25 ms) : 0, 50250
AppSec [candidate] (50.358 ms) : 0, 50358
Remote Config [baseline] (746.669 µs) : 0, 747
Remote Config [candidate] (752.536 µs) : 0, 753
Telemetry [baseline] (7.588 ms) : 0, 7588
Telemetry [candidate] (7.617 ms) : 0, 7617
section iast
BytebuddyAgent [baseline] (786.16 ms) : 0, 786160
BytebuddyAgent [candidate] (780.106 ms) : 0, 780106
GlobalTracer [baseline] (296.134 ms) : 0, 296134
GlobalTracer [candidate] (293.999 ms) : 0, 293999
AppSec [baseline] (47.624 ms) : 0, 47624
AppSec [candidate] (47.323 ms) : 0, 47323
Remote Config [baseline] (603.54 µs) : 0, 604
Remote Config [candidate] (646.395 µs) : 0, 646
Telemetry [baseline] (6.999 ms) : 0, 6999
Telemetry [candidate] (7.814 ms) : 0, 7814
IAST [baseline] (27.363 ms) : 0, 27363
IAST [candidate] (27.436 ms) : 0, 27436
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (786.382 ms) : 0, 786382
BytebuddyAgent [candidate] (777.121 ms) : 0, 777121
GlobalTracer [baseline] (296.291 ms) : 0, 296291
GlobalTracer [candidate] (294.289 ms) : 0, 294289
AppSec [baseline] (47.506 ms) : 0, 47506
AppSec [candidate] (47.446 ms) : 0, 47446
Remote Config [baseline] (603.151 µs) : 0, 603
Remote Config [candidate] (585.556 µs) : 0, 586
Telemetry [baseline] (7.798 ms) : 0, 7798
Telemetry [candidate] (6.983 ms) : 0, 6983
IAST [baseline] (26.531 ms) : 0, 26531
IAST [candidate] (28.174 ms) : 0, 28174
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (777.991 ms) : 0, 777991
BytebuddyAgent [candidate] (776.775 ms) : 0, 776775
GlobalTracer [baseline] (294.914 ms) : 0, 294914
GlobalTracer [candidate] (294.072 ms) : 0, 294072
AppSec [baseline] (47.021 ms) : 0, 47021
AppSec [candidate] (47.228 ms) : 0, 47228
Remote Config [baseline] (587.044 µs) : 0, 587
Remote Config [candidate] (1.363 ms) : 0, 1363
Telemetry [baseline] (9.826 ms) : 0, 9826
Telemetry [candidate] (8.429 ms) : 0, 8429
IAST [baseline] (24.642 ms) : 0, 24642
IAST [candidate] (25.715 ms) : 0, 25715
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.37.0-SNAPSHOT~396e5bd119, baseline=1.37.0-SNAPSHOT~11753cac4d
dateFormat X
axisFormat %s
section baseline
no_agent (368.462 µs) : 349, 388
. : milestone, 368,
iast (479.827 µs) : 459, 501
. : milestone, 480,
iast_FULL (557.057 µs) : 536, 578
. : milestone, 557,
iast_GLOBAL (512.973 µs) : 490, 536
. : milestone, 513,
iast_HARDCODED_SECRET_DISABLED (486.255 µs) : 465, 508
. : milestone, 486,
iast_INACTIVE (455.207 µs) : 434, 477
. : milestone, 455,
iast_TELEMETRY_OFF (468.181 µs) : 447, 489
. : milestone, 468,
tracing (452.753 µs) : 431, 474
. : milestone, 453,
section candidate
no_agent (369.107 µs) : 349, 389
. : milestone, 369,
iast (481.408 µs) : 461, 502
. : milestone, 481,
iast_FULL (559.548 µs) : 538, 581
. : milestone, 560,
iast_GLOBAL (502.34 µs) : 481, 523
. : milestone, 502,
iast_HARDCODED_SECRET_DISABLED (483.515 µs) : 462, 505
. : milestone, 484,
iast_INACTIVE (456.264 µs) : 435, 478
. : milestone, 456,
iast_TELEMETRY_OFF (479.659 µs) : 458, 502
. : milestone, 480,
tracing (441.224 µs) : 421, 462
. : milestone, 441,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.37.0-SNAPSHOT~396e5bd119, baseline=1.37.0-SNAPSHOT~11753cac4d
dateFormat X
axisFormat %s
section baseline
no_agent (1.353 ms) : 1334, 1373
. : milestone, 1353,
appsec (1.711 ms) : 1687, 1735
. : milestone, 1711,
appsec_no_iast (1.73 ms) : 1706, 1753
. : milestone, 1730,
iast (1.482 ms) : 1460, 1505
. : milestone, 1482,
profiling (1.539 ms) : 1514, 1564
. : milestone, 1539,
tracing (1.489 ms) : 1464, 1514
. : milestone, 1489,
section candidate
no_agent (1.344 ms) : 1326, 1363
. : milestone, 1344,
appsec (1.723 ms) : 1699, 1746
. : milestone, 1723,
appsec_no_iast (1.742 ms) : 1718, 1766
. : milestone, 1742,
iast (1.483 ms) : 1460, 1506
. : milestone, 1483,
profiling (1.482 ms) : 1458, 1507
. : milestone, 1482,
tracing (1.47 ms) : 1445, 1494
. : milestone, 1470,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.37.0-SNAPSHOT~396e5bd119, baseline=1.37.0-SNAPSHOT~11753cac4d
dateFormat X
axisFormat %s
section baseline
no_agent (14.862 s) : 14862000, 14862000
. : milestone, 14862000,
appsec (15.051 s) : 15051000, 15051000
. : milestone, 15051000,
iast (18.569 s) : 18569000, 18569000
. : milestone, 18569000,
iast_GLOBAL (17.901 s) : 17901000, 17901000
. : milestone, 17901000,
profiling (15.196 s) : 15196000, 15196000
. : milestone, 15196000,
tracing (14.988 s) : 14988000, 14988000
. : milestone, 14988000,
section candidate
no_agent (14.981 s) : 14981000, 14981000
. : milestone, 14981000,
appsec (15.049 s) : 15049000, 15049000
. : milestone, 15049000,
iast (18.909 s) : 18909000, 18909000
. : milestone, 18909000,
iast_GLOBAL (17.787 s) : 17787000, 17787000
. : milestone, 17787000,
profiling (15.316 s) : 15316000, 15316000
. : milestone, 15316000,
tracing (14.971 s) : 14971000, 14971000
. : milestone, 14971000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.37.0-SNAPSHOT~396e5bd119, baseline=1.37.0-SNAPSHOT~11753cac4d
dateFormat X
axisFormat %s
section baseline
no_agent (1.465 ms) : 1453, 1476
. : milestone, 1465,
appsec (2.213 ms) : 2179, 2248
. : milestone, 2213,
iast (1.957 ms) : 1917, 1998
. : milestone, 1957,
iast_GLOBAL (2.017 ms) : 1975, 2058
. : milestone, 2017,
profiling (1.859 ms) : 1824, 1894
. : milestone, 1859,
tracing (1.834 ms) : 1801, 1867
. : milestone, 1834,
section candidate
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (2.213 ms) : 2179, 2248
. : milestone, 2213,
iast (1.968 ms) : 1927, 2009
. : milestone, 1968,
iast_GLOBAL (2.01 ms) : 1969, 2051
. : milestone, 2010,
profiling (1.846 ms) : 1814, 1879
. : milestone, 1846,
tracing (1.834 ms) : 1801, 1866
. : milestone, 1834,
|
jandro996
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Use the default trace protocol version (v0.4 at the moment) in smoke tests.
Motivation
Support for decoding v0.4 in smoke tests agent was added in 2022, we can now just test the default behavior.
Additional Notes